Files
accounted/components/import/BankFileImportHistory.tsx
T
Jakob Wennberg 1a41119682 perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline (#1942)
* perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline

Two chunks rode along in the first-load JS of almost every dashboard route:
the full BAS 2026 chart (315 KB uncompressed, in 81 route manifests) and
the browser polyfill for Node's crypto/vm/Buffer (327 KB, in 26 routes
incl. login and register). Neither was needed on first paint; both got
there through static imports of helpers that happen to live next to code
that needs the data or the builtin.

Node polyfill (4 pure splits, behaviour unchanged, re-exported from the
original modules for server callers):
- lib/auth/bankid-flags.ts: isBankIdEnabled (login, register, security
  settings imported it from bankid.ts, which imports crypto).
- lib/import/bank-file/formats.ts: the format registry + detection (the
  import history imported getFormat from parser.ts, which hashes).
- lib/salary/personnummer-format.ts: parsing/validation/formatting (the
  employee forms reached the encrypting personnummer.ts via tax-column).
- lib/auth/api-key-scopes.ts: scope catalogue, groups, tool map, helpers
  (the API key panel imported STAGING_SCOPES from the key generator).

BAS chart:
- lib/bookkeeping/bas-lazy.ts + use-bas-reference.ts: the chart becomes a
  dynamic import, fetched once per session after first paint; components
  that show BAS names/descriptions call useBasReference() and re-render
  when it lands. Until then (and on the server) only the hardcoded
  account-descriptions answer, so SSR and hydration agree.
- lib/bookkeeping/bas-labels.ts: class/group labels out of bas-reference.ts
  (account-descriptions needed a label and paid for the whole chart).
- lib/bookkeeping/bas-account-numbers.ts (generated, ~11 KB) +
  scripts/generate-bas-account-numbers.ts (--check) + parity test:
  isStandardBASAccountNumber for AddAccountDialog/ChartOfAccountsManager.
- lib/bookkeeping/account-classifier-{heuristic,client}.ts: the BAS-aligned
  heuristic shared by the server classifier and a client variant that uses
  the lazy chart.
- lib/bookkeeping/invoice-accounts.ts: INVOICE_FX_RATE_MISSING,
  InvoiceFxRateMissingError, getRevenueAccount, getOutputVatAccount out of
  invoice-entries.ts, whose engine import pulled account-backfill and the
  chart into SendInvoiceDialog/PaymentBookingDialog.
- CorrectOpeningBalanceDialog re-seeds names when the chart lands;
  OpeningBalanceRowEditor builds its Fuse indexes lazily; the
  ChartOfAccountsManager BAS-katalog tab awaits the chunk.

Tooling:
- scripts/perf/client-import-closure.mjs: static import closure of every
  'use client' module with the shortest chain to a target (file or bare
  specifier); found every path above without a build.
- scripts/checks/client-node-builtin.mjs wired into check:guards: a client
  module reaching a Node builtin is a hard failure (0 today).

Left as is: invoices/[id], its credit page and SendInvoiceDialog still
reach the chart through lib/invoices/issue-credit-note -> invoice-entries
-> engine -> account-backfill; splitting the engine is out of scope here.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(perf): unambiguous import-edge regex in the closure walker (CodeQL js/redos)

One quantifier per span: a greedy [^'"]* up to the specifier quote, which it
cannot cross, so a run of whitespace has a single parse. Same edges as
before (multi-line named imports, re-exports, side-effect imports; type-only
imports still skipped).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-26 15:07:49 +02:00

253 lines
8.5 KiB
TypeScript

'use client'
import { useCallback, useEffect, useState } from 'react'
import { useTranslations } from 'next-intl'
import { Undo2 } from 'lucide-react'
import { Badge } from '@/components/ui/badge'
import { Button } from '@/components/ui/button'
import { Skeleton } from '@/components/ui/skeleton'
import { useToast } from '@/components/ui/use-toast'
import { DestructiveConfirmDialog } from '@/components/ui/destructive-confirm-dialog'
import { TH_CLASS, TD_CLASS } from '@/components/ui/dry-table'
import { getErrorMessage } from '@/lib/errors/get-error-message'
import { getFormat } from '@/lib/import/bank-file/formats'
import type { BankFileFormatId } from '@/lib/import/bank-file/types'
import { cn, formatDate } from '@/lib/utils'
/**
* Subset of the bank_file_imports row (GET /api/import/bank-file) actually
* rendered here. `status` stays a plain string: unknown values fall back to
* raw muted text instead of crashing on a missing translation key (same
* defensive shape as SIEImportHistory).
*/
interface BankFileImportListRow {
id: string
filename: string
file_format: string
imported_count: number
status: string
created_at: string
}
const STATUS_LABEL_KEY: Record<string, string> = {
completed: 'bankfile_history_status_completed',
undone: 'bankfile_history_status_undone',
failed: 'bankfile_history_status_failed',
pending: 'bankfile_history_status_pending',
processing: 'bankfile_history_status_processing',
}
/**
* Chips mark exceptions (design.md convention 5): the normal 'completed'
* state renders as muted text; only deviating states get a Badge.
*/
const STATUS_BADGE_VARIANT: Record<string, 'secondary' | 'warning' | 'destructive'> = {
undone: 'secondary',
failed: 'destructive',
pending: 'warning',
processing: 'warning',
}
/**
* The undo report returned by DELETE /api/import/bank-file/[id]/undo:
* deleted rows plus what was deliberately left alone (booked rows are
* räkenskapsinformation; rows with payment_match_log history keep their
* append-only log).
*/
interface UndoReport {
deletedTransactions?: number
skippedBooked?: number
skippedMatchHistory?: number
}
/**
* History of past bank file imports with per-row undo for completed ones.
* Rendered fold-open from the 'Tidigare bankfilsimporter' row on the import
* tab; mirrors SIEImportHistory. The undo itself is owner/admin-only,
* enforced server-side by the undo_bank_file_import RPC's actor gate.
*/
export default function BankFileImportHistory() {
const t = useTranslations('import')
const { toast } = useToast()
const [rows, setRows] = useState<BankFileImportListRow[] | null>(null)
const [loadFailed, setLoadFailed] = useState(false)
const [pendingUndo, setPendingUndo] = useState<BankFileImportListRow | null>(null)
const fetchImports = useCallback(async () => {
try {
const res = await fetch('/api/import/bank-file?limit=20')
if (!res.ok) {
setLoadFailed(true)
return
}
const data = await res.json()
setRows(Array.isArray(data.data) ? data.data : [])
setLoadFailed(false)
} catch {
setLoadFailed(true)
}
}, [])
useEffect(() => {
void fetchImports()
}, [fetchImports])
// Deliberately no client-side timeout: undoing a large import can take
// minutes (the route runs with maxDuration 300) and the confirm dialog
// stays open with its spinner until this resolves.
const handleUndoConfirm = useCallback(async () => {
if (!pendingUndo) return
try {
const res = await fetch(`/api/import/bank-file/${pendingUndo.id}/undo`, {
method: 'DELETE',
})
const data = await res.json()
if (!res.ok) {
toast({
title: t('bankfile_history_undo_failed'),
description: getErrorMessage(data),
variant: 'destructive',
})
return
}
// The full report, clearly: X removed, and any rows the undo refused
// to touch (booked / match history) so nothing disappears silently.
const report = data as UndoReport
const skippedBooked = report.skippedBooked ?? 0
const skippedMatchHistory = report.skippedMatchHistory ?? 0
const parts = [
t('bankfile_history_undo_success_deleted', {
count: report.deletedTransactions ?? 0,
}),
]
if (skippedBooked > 0) {
parts.push(t('bankfile_history_undo_skipped_booked', { count: skippedBooked }))
}
if (skippedMatchHistory > 0) {
parts.push(
t('bankfile_history_undo_skipped_match_history', { count: skippedMatchHistory }),
)
}
toast({
title: t('bankfile_history_undo_success_title'),
description: parts.join(' '),
})
await fetchImports()
} catch (err) {
toast({
title: t('bankfile_history_undo_failed'),
description: getErrorMessage(err),
variant: 'destructive',
})
}
}, [pendingUndo, fetchImports, t, toast])
// 'swedbank' → 'Swedbank' via the format registry; unknown ids (a format
// removed from the registry) fall back to the raw stored code.
const formatLabel = (row: BankFileImportListRow): string =>
getFormat(row.file_format as BankFileFormatId)?.name ?? row.file_format
const statusCell = (status: string) => {
const labelKey = STATUS_LABEL_KEY[status]
const label = labelKey ? t(labelKey) : status
const variant = STATUS_BADGE_VARIANT[status]
if (!variant) {
return <span className="text-xs text-muted-foreground">{label}</span>
}
return (
<Badge variant={variant} className="font-normal">
{label}
</Badge>
)
}
if (loadFailed) {
return (
<p className="px-1 text-xs leading-5 text-muted-foreground">
{t('bankfile_history_load_error')}
</p>
)
}
if (rows === null) {
return (
<div className="space-y-2" role="status">
<Skeleton className="h-8 w-full" />
<Skeleton className="h-8 w-full" />
<Skeleton className="h-8 w-full" />
</div>
)
}
if (rows.length === 0) {
return (
<p className="px-1 text-xs leading-5 text-muted-foreground">
{t('bankfile_history_empty')}
</p>
)
}
return (
<div>
<div className="overflow-x-auto">
<table className="w-full border-collapse text-[13px]">
<thead>
<tr>
<th className={TH_CLASS}>{t('bankfile_history_col_file')}</th>
<th className={TH_CLASS}>{t('bankfile_history_col_date')}</th>
<th className={TH_CLASS}>{t('bankfile_history_col_format')}</th>
<th className={cn(TH_CLASS, 'text-right')}>
{t('bankfile_history_col_transactions')}
</th>
<th className={TH_CLASS}>{t('bankfile_history_col_status')}</th>
<th className={TH_CLASS}>
<span className="sr-only">{t('bankfile_history_undo_button')}</span>
</th>
</tr>
</thead>
<tbody className="stagger-enter">
{rows.map((row) => (
<tr key={row.id} className="transition-colors duration-150 hover:bg-secondary/35">
<td className={TD_CLASS}>{row.filename}</td>
<td className={cn(TD_CLASS, 'whitespace-nowrap tabular-nums')}>
{formatDate(row.created_at)}
</td>
<td className={cn(TD_CLASS, 'whitespace-nowrap')}>{formatLabel(row)}</td>
<td className={cn(TD_CLASS, 'text-right tabular-nums')}>{row.imported_count}</td>
<td className={TD_CLASS}>{statusCell(row.status)}</td>
<td className={cn(TD_CLASS, 'text-right')}>
{row.status === 'completed' && (
<Button
variant="outline"
size="sm"
className="text-destructive hover:text-destructive"
onClick={() => setPendingUndo(row)}
>
<Undo2 className="mr-2 h-4 w-4" />
{t('bankfile_history_undo_button')}
</Button>
)}
</td>
</tr>
))}
</tbody>
</table>
</div>
<DestructiveConfirmDialog
open={pendingUndo !== null}
onOpenChange={(open) => {
if (!open) setPendingUndo(null)
}}
title={t('bankfile_history_undo_confirm_title')}
description={t('bankfile_history_undo_confirm_description')}
confirmLabel={t('bankfile_history_undo_confirm_label')}
onConfirm={handleUndoConfirm}
/>
</div>
)
}