Files
accounted/components/bookkeeping/RecordateEntryDialog.tsx
T
Jakob Wennberg 834cc4d0e8 fix(ui): kill horizontal overflow in dialogs and cut the worst modal copy (#1732)
* fix(dialogs): kill horizontal overflow in dialogs and cut the worst modal copy

Overflow hardening:
- DialogTitle/DialogDescription and SheetTitle/SheetDescription get
  break-words at the primitive, so long unbroken interpolated strings
  (emails, product names, org numbers) can no longer widen any dialog.
- AccountCombobox's non-flat dropdown is portaled to document.body with
  viewport-clamped geometry (new pure helper account-combobox-position.ts,
  unit-tested), the same fix info-tooltip.tsx applies to TooltipContent:
  the 34rem panel inside a scrollable DialogContent was the root cause of
  sideways-scrolling dialogs. Outside-click checks the portaled node,
  position tracks scroll/resize (capture phase), wheel/touchmove stop at
  the panel so react-remove-scroll's modal lock cannot block its scrolling,
  and DialogContent/SheetContent treat data-dialog-companion nodes as
  inside interactions so clicking the panel never dismisses the dialog.
  The flat variant is unchanged.
- StrikeLinesDialog/CorrectionEntryDialog line rows switch bare 1fr grid
  tracks to minmax(0,1fr) and wrap the sm:contents-promoted AccountCombobox
  in a min-w-0 cell (SendInvoiceDialog's pattern).
- New dialog-overflow-risk ratchet in no-new-antipatterns.mjs: bare fr
  tracks in dialog hosts, whitespace-nowrap inside DialogContent regions
  outside an allowlist, and unportaled >=20rem overlays; baselined at the
  post-fix 7 files.

Copy reduction (convention 7, MatchVoucherDialog precedent):
- New shared RattelseExplainer (HelpPopover) carries the "a posted
  verifikat cannot be edited directly" framing once; CorrectionEntryDialog,
  StrikeLinesDialog, RecordateEntryDialog and CorrectMetadataDialog drop
  their permanent inline explainer boxes and keep at most one sentence
  inline (hardcoded Swedish: verifikat surface).
- SendInvoiceDialog keeps the actual addresses inline and moves the fixed
  CC/BCC framing plus the extra-address rules behind a HelpPopover
  (recipient_additional_hint replaced by recipient_help_fixed and
  recipient_help_additional in both messages files).
- HelpPopover panels gain pointer-events-auto and the companion marker so
  they are actually interactive inside modal dialogs.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(bookkeeping): mechanism-accurate rattelse copy and calmer dropdown repositioning

The shared RattelseExplainer claimed every rattelse is logged with who/when
in the verifikat's rattelsehistorik, which is only true for the inline
strike-and-replace track (StrikeLinesDialog, CorrectMetadataDialog). The
storno dialogs (CorrectionEntryDialog, RecordateEntryDialog) never write
that log: their BFL 5 kap 5 trail is the storno chain. The shared component
now keeps only the universally true framing sentence, and each dialog's
popover carries the trail sentence matching its own mechanism.

AccountCombobox's capture-phase scroll/resize handler now skips setState
when the recomputed position is shallow-equal to the current one
(isSameDropdownPosition in the pure position helper, unit-tested) and
ignores scroll events originating inside the portaled panel itself, so
scrolling the account list no longer churns re-renders.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-20 10:03:52 +02:00

294 lines
11 KiB
TypeScript

'use client'
import { useState, useEffect } from 'react'
import { useRouter } from 'next/navigation'
import { useTranslations } from 'next-intl'
import {
Dialog,
DialogContent,
DialogHeader,
DialogTitle,
DialogFooter,
} from '@/components/ui/dialog'
import { Button } from '@/components/ui/button'
import { Input } from '@/components/ui/input'
import { Badge } from '@/components/ui/badge'
import RattelseExplainer from '@/components/bookkeeping/RattelseExplainer'
import { useToast } from '@/components/ui/use-toast'
import { getErrorMessage } from '@/lib/errors/get-error-message'
import { AlertTriangle, Lock, ArrowRight } from 'lucide-react'
import { formatDate } from '@/lib/utils'
import { formatVoucher } from '@/lib/bookkeeping/voucher-series-resolver'
import type { JournalEntry } from '@/types'
interface Props {
entry: JournalEntry
open: boolean
onOpenChange: (open: boolean) => void
onMoved: () => void
}
type PeriodStatus = {
status: 'open' | 'locked' | 'closed'
period_id: string | null
lock_date: string | null
period_name: string | null
}
const ISO_DATE = /^\d{4}-\d{2}-\d{2}$/
export default function RecordateEntryDialog({ entry, open, onOpenChange, onMoved }: Props) {
const { toast } = useToast()
const router = useRouter()
const t = useTranslations('journal_detail')
const [newDate, setNewDate] = useState(entry.entry_date)
const [preview, setPreview] = useState<PeriodStatus | null>(null)
const [previewLoading, setPreviewLoading] = useState(false)
const [previewError, setPreviewError] = useState<string | null>(null)
const [isSubmitting, setIsSubmitting] = useState(false)
// Non-null when the server refused with CORRECTION_CHAIN_TOO_DEEP: holds the
// reported chain depth and opens the bypass confirm ("Flytta ändå").
const [deepChainDepth, setDeepChainDepth] = useState<number | null>(null)
// Reset to the original date each time the dialog opens.
useEffect(() => {
if (open) {
setNewDate(entry.entry_date)
setPreview(null)
setPreviewError(null)
}
}, [open, entry.entry_date])
// Resolve the target period status whenever a valid, changed date is entered.
useEffect(() => {
if (!open) return
if (!ISO_DATE.test(newDate) || newDate === entry.entry_date) {
setPreview(null)
setPreviewError(null)
return
}
let cancelled = false
setPreviewLoading(true)
setPreviewError(null)
const handle = setTimeout(async () => {
try {
const res = await fetch(
`/api/bookkeeping/fiscal-periods/period-status?date=${encodeURIComponent(newDate)}`
)
if (!res.ok) throw new Error('period_status_failed')
const { data } = await res.json()
if (!cancelled) {
setPreview((data as PeriodStatus) ?? null)
setPreviewError(null)
}
} catch {
if (!cancelled) {
setPreview(null)
setPreviewError('Kunde inte kontrollera perioden. Försök igen.')
}
} finally {
if (!cancelled) setPreviewLoading(false)
}
}, 250)
return () => {
cancelled = true
clearTimeout(handle)
}
}, [newDate, open, entry.entry_date])
const dateChanged = ISO_DATE.test(newDate) && newDate !== entry.entry_date
const targetOpen = preview?.status === 'open' && !!preview?.period_id
const noCoveringPeriod = preview?.status === 'open' && !preview?.period_id
// Soft, non-blocking advisory when moving into a past date: the moms for
// that period may already have been filed.
const today = new Date().toISOString().slice(0, 10)
const movingIntoPast = dateChanged && newDate < today
const canSubmit = dateChanged && targetOpen && !isSubmitting
async function handleSubmit(allowDeepChain = false) {
if (!canSubmit) return
setIsSubmitting(true)
try {
const res = await fetch(`/api/bookkeeping/journal-entries/${entry.id}/recordate`, {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({
new_entry_date: newDate,
...(allowDeepChain ? { allow_deep_chain: true } : {}),
}),
})
const result = await res.json()
if (!res.ok) {
// Chain-depth guard: open the bypass confirm instead of a dead-end
// toast. "Flytta ändå" resubmits with allow_deep_chain=true.
const structured = (result as { error?: { code?: string; details?: { depth?: number } } })?.error
if (structured?.code === 'CORRECTION_CHAIN_TOO_DEEP') {
setDeepChainDepth(structured.details?.depth ?? 3)
return
}
const error = new Error('Failed to move entry') as Error & { body?: unknown; status?: number }
error.body = result
error.status = res.status
throw error
}
setDeepChainDepth(null)
const correctedId = result.data?.corrected?.id
toast({
title: 'Verifikationen flyttad',
description: 'En storno och en rättelse med rätt datum har bokförts.',
action: correctedId ? (
<Button variant="outline" size="sm" onClick={() => router.push(`/bookkeeping/${correctedId}`)}>
Visa rättelsen
</Button>
) : undefined,
})
onOpenChange(false)
onMoved()
} catch (err) {
const anyErr = err as { body?: unknown; status?: number }
toast({
title: 'Kunde inte flytta verifikationen',
description: getErrorMessage(anyErr.body ?? err, { context: 'journal_entry', statusCode: anyErr.status }),
variant: 'destructive',
})
} finally {
setIsSubmitting(false)
}
}
return (
<Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent className="sm:max-w-lg">
<DialogHeader>
{/* Convention 7: the how-it-works copy lives behind the "?", not in
the dialog flow. */}
<div className="flex items-center gap-2">
<DialogTitle>Rätta datum</DialogTitle>
<RattelseExplainer>
<p>
Raderna behålls oförändrade: en stornoverifikation nollställer
originalet i sin period, och en ny verifikation bokförs med
samma rader det nya datumet.
</p>
<p>
Spårbarheten ligger i stornokedjan: originalet,
stornoverifikationen och den nya verifikationen förblir synliga
i bokföringen och länkade till varandra.
</p>
</RattelseExplainer>
</div>
</DialogHeader>
{/* Original */}
<div className="space-y-1">
<div className="flex items-center gap-2 text-sm text-muted-foreground flex-wrap">
<span className="font-mono">{formatVoucher(entry)}</span>
<span className="tabular-nums">{formatDate(entry.entry_date)}</span>
<Badge variant="outline" className="text-xs">Original</Badge>
</div>
<p className="text-sm">{entry.description}</p>
</div>
{/* New date */}
<div className="space-y-2">
<label htmlFor="recordate-date" className="text-sm font-medium">
Nytt datum
</label>
<Input
id="recordate-date"
type="date"
value={newDate}
onChange={(e) => setNewDate(e.target.value)}
className="tabular-nums"
/>
{/* Target period feedback */}
{dateChanged && (
<div className="text-sm" aria-live="polite">
{previewLoading && <span className="text-muted-foreground">Kontrollerar period</span>}
{!previewLoading && previewError && (
<span className="inline-flex items-center gap-1.5 text-destructive">
<AlertTriangle className="h-4 w-4" />
{previewError}
</span>
)}
{!previewLoading && !previewError && targetOpen && (
<span className="inline-flex items-center gap-1.5 text-muted-foreground">
<ArrowRight className="h-4 w-4" />
Flyttas till {preview?.period_name ?? 'rätt räkenskapsår'}
</span>
)}
{!previewLoading && noCoveringPeriod && (
<span className="text-destructive">
Det finns ingen räkenskapsperiod som täcker datumet. Skapa eller öppna räkenskapsåret först.
</span>
)}
{!previewLoading && preview?.status === 'closed' && (
<span className="text-destructive">
Räkenskapsåret är stängt (bokslut) och kan inte återöppnas. Bokför rättelsen i innevarande period istället.
</span>
)}
{!previewLoading && preview?.status === 'locked' && (
<span className="inline-flex items-center gap-1.5 text-destructive">
<Lock className="h-4 w-4" />
Perioden är låst{preview?.lock_date ? ` t.o.m. ${formatDate(preview.lock_date)}` : ''}. Lås upp perioden för att flytta verifikationen dit.
</span>
)}
</div>
)}
{/* Soft advisory: moving into a past period */}
{targetOpen && movingIntoPast && (
<p className="inline-flex items-start gap-1.5 text-sm text-muted-foreground">
<AlertTriangle className="h-4 w-4 mt-0.5 shrink-0" />
<span>
Om momsen för perioden redan är inlämnad kan du behöva lämna en rättad momsdeklaration.
</span>
</p>
)}
</div>
<DialogFooter>
<Button variant="outline" onClick={() => onOpenChange(false)} disabled={isSubmitting}>
Avbryt
</Button>
<Button onClick={() => handleSubmit()} disabled={!canSubmit}>
{isSubmitting ? 'Flyttar…' : 'Flytta verifikationen'}
</Button>
</DialogFooter>
{/* Chain-depth guard confirm: the server refused because this entry
already sits deep in a rättelse chain. Advisory, never a dead end:
"Flytta ändå" resubmits with allow_deep_chain=true. */}
<Dialog open={deepChainDepth != null} onOpenChange={(next) => { if (!next) setDeepChainDepth(null) }}>
<DialogContent className="sm:max-w-md">
<DialogHeader>
<DialogTitle>{t('deep_chain_title')}</DialogTitle>
</DialogHeader>
<p className="text-sm text-muted-foreground">
{t('deep_chain_body', { depth: deepChainDepth ?? 3 })}
</p>
<DialogFooter>
<Button variant="outline" onClick={() => setDeepChainDepth(null)} disabled={isSubmitting}>
{t('deep_chain_cancel')}
</Button>
<Button
onClick={() => { setDeepChainDepth(null); void handleSubmit(true) }}
disabled={isSubmitting}
>
{t('deep_chain_move_anyway')}
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
</DialogContent>
</Dialog>
)
}