Files
accounted/components/bookkeeping/MatchTransactionInvoicePreview.tsx
T
Jakob Wennberg ec27228a8e style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)
Em dashes (—) and en dashes (–) had spread across comments, docs, tests,
and a few UI strings, reading as AI-generated boilerplate rather than
house style. Replaced each with punctuation matching its context: colon
for explanatory clauses, comma for asides, plain hyphen for numeric/legal
ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for
paired-dash asides. messages/en.json and messages/sv.json were fixed by
hand together to keep sv/en in sync.

Left untouched where the dash is the functional subject rather than
decorative punctuation: date-range-parser.ts's separator regex,
charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE
encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the
agent system-prompt files that already instruct against em dashes, and
a golden iXBRL test fixture compared byte-for-byte.

Also fixes two bugs surfaced along the way: an off-by-one in
ApiKeysPanel's scope-label split (a leftover from an earlier partial
pass), and a charset-repair test that had lost the literal en-dash it
exists to verify.

Regenerated the agent atom seed migration (skills:generate) since 27
SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes,
with an explicit carve-out for the functional-dash cases above.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-04 15:58:06 +02:00

93 lines
3.5 KiB
TypeScript

'use client'
import { ArrowDown } from 'lucide-react'
import { formatCurrency, formatDate } from '@/lib/utils'
interface MatchTransactionInvoicePreviewProps {
data: Record<string, unknown>
}
/**
* Two-card preview for `match_transaction_invoice` operations. Mirrors
* AttachDocumentPreview's layout so reviewers learn one matching idiom.
*/
export function MatchTransactionInvoicePreview({ data }: MatchTransactionInvoicePreviewProps) {
const txDescription = (data.transaction_description as string) || '-'
const txAmount = data.transaction_amount as number | undefined
const txCurrency = (data.transaction_currency as string) || 'SEK'
const txDate = data.transaction_date as string | undefined
const invoiceNumber = (data.invoice_number as string) || '-'
const invoiceTotal = data.invoice_total as number | undefined
const invoiceCurrency = (data.invoice_currency as string) || txCurrency
const invoiceDate = data.invoice_date as string | undefined
const customerName = data.customer_name as string | undefined
// BFL 5 kap 4§ requires bookings to be made "so soon as possible" relative
// to the affärshändelse, so a transaction and invoice that diverge by more
// than a calendar month deserve a second look before the reviewer approves
// the match. The threshold is editorial, not legislated: it just nudges
// the reviewer; it doesn't block.
const showDateDriftHint =
txDate &&
invoiceDate &&
Math.abs(new Date(txDate).getTime() - new Date(invoiceDate).getTime()) > 31 * 24 * 60 * 60 * 1000
return (
<div className="space-y-3 text-sm">
<div className="grid grid-cols-1 md:grid-cols-2 gap-3">
<PreviewCard label="Transaktion">
{txDate && <Row label="Datum" value={formatDate(txDate)} tabular />}
<Row label="Beskrivning" value={txDescription} />
<Row
label="Belopp"
value={typeof txAmount === 'number' ? formatCurrency(txAmount, txCurrency) : '-'}
tabular
/>
</PreviewCard>
<PreviewCard label="Faktura">
<Row label="Nummer" value={invoiceNumber} tabular />
{invoiceDate && <Row label="Fakturadatum" value={formatDate(invoiceDate)} tabular />}
{customerName && <Row label="Kund" value={customerName} />}
{typeof invoiceTotal === 'number' && (
<Row label="Totalt" value={formatCurrency(invoiceTotal, invoiceCurrency)} tabular />
)}
</PreviewCard>
</div>
<div className="flex items-center justify-center text-xs text-muted-foreground">
<ArrowDown className="h-3.5 w-3.5 mr-1" />
matchas mot fakturan
</div>
{showDateDriftHint && (
<p className="text-xs text-muted-foreground">
Transaktionsdatum och fakturadatum skiljer sig med mer än en månad: kontrollera att
matchningen avser rätt affärshändelse.
</p>
)}
</div>
)
}
function PreviewCard({ label, children }: { label: string; children: React.ReactNode }) {
return (
<div className="rounded-lg border border-border p-3 space-y-1.5">
<p className="text-[11px] font-medium uppercase tracking-wider text-muted-foreground">
{label}
</p>
{children}
</div>
)
}
function Row({ label, value, tabular }: { label: string; value: string; tabular?: boolean }) {
return (
<div className="flex justify-between gap-3">
<span className="text-xs text-muted-foreground shrink-0">{label}</span>
<span className={`text-sm ${tabular ? 'tabular-nums' : ''} text-right truncate`}>{value}</span>
</div>
)
}