Files
accounted/components/agent/conversation-mutations.ts
T
Jakob Wennberg a43a8b03cf refactor(assistant): one source of truth for the conversation list (#1214)
* refactor(assistant): one source of truth for the conversation list

PR5 of the assistant UI makeover (dev_docs/assistant_redesign_plan.md section 7):
unified history.

The two surfaces that list conversations had drifted apart in BEHAVIOUR, not
just chrome. The in-sheet list rolled a failed rename back and said so; the
/chat sidebar fired pin, archive and rename blind, with no res.ok check, no
rollback and no message. A failed archive there removed a conversation from the
list while it still existed on the server, and a failed rename displayed a title
the server never saved, both until the next reload, with an unhandled promise
rejection on a network error.

State, search, grouping and all three mutations now live in one hook that both
surfaces consume, so they cannot diverge again: every write is optimistic,
reverts to the value captured before the write on failure, and reports it. The
sheet gains pin and archive, which it never had.

Archive resolves whether the row is really gone, so the sidebar only navigates
away from a conversation that was actually archived.

Chrome deliberately stays per-surface: a 320px sidebar that collapses to a rail
and a sheet panel are different shapes, and merging the markup belongs with the
shell work in PR6, where both containers change anyway.

Verified: 9554 unit tests pass (5 new pinning the rollback semantics, including
reverting to the original pin value rather than toggling and restoring a null
title), lint and tsc clean on the touched files, guards pass.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* fix(assistant): test the real mutation code, and make rollback mutation-aware

Review follow-ups on the unified conversation list. Both findings were right.

The tests duplicated the state transforms and called fetch directly, so they
never executed the hook: deleting the rollback entirely would have left them
green. That is test theater. The transforms and the write coordinator now live
in conversation-mutations.ts, React-free, and the tests exercise those. Checked
by deleting the rollback and confirming three tests fail.

Rollback was not mutation-aware. A failed archive restored a render-time
snapshot of the whole list, discarding any pin, rename or archive made while the
request was in flight; and a failing earlier write could roll back over a newer
value for the same row (a double-click on pin). Writes now claim a per-row
revision and only undo while they are still the latest for that row, and a
failed archive re-inserts the single row into the list AS IT STANDS, at its
server-sort position, rather than replacing the list.

Also drops a ref read during render that the React lint rules reject.

Verified: 9560 unit tests pass (11 covering the real coordinator, including the
overlapping-write case and the concurrent-edit-survives-archive-failure case),
lint clean, tsc clean, guards pass.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* test(assistant): unstub globals so the fetch stub cannot outlive the file

vi.restoreAllMocks does not undo vi.stubGlobal, and the config sets no
unstubGlobals, so the stubbed fetch survived past the suite that set it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
2026-07-26 23:30:01 +02:00

130 lines
3.9 KiB
TypeScript

import type { ConversationRow } from './conversation-display'
/**
* The list transforms and the optimistic-write coordinator behind
* useConversationList. Pure and React-free so they can be tested directly:
* the hook is a thin binding over these, which means a test that deletes the
* rollback here fails, rather than passing against a copy of the logic.
*/
export function setPinned(
list: ConversationRow[],
id: string,
pinned: boolean,
): ConversationRow[] {
return list.map((c) => (c.id === id ? { ...c, pinned } : c))
}
export function setTitle(
list: ConversationRow[],
id: string,
title: string | null,
): ConversationRow[] {
return list.map((c) => (c.id === id ? { ...c, title } : c))
}
export function removeRow(list: ConversationRow[], id: string): ConversationRow[] {
return list.filter((c) => c.id !== id)
}
/**
* Put a row back after a failed archive, into whatever the list looks like NOW.
*
* Restoring a render-time snapshot of the whole list would discard any pin,
* rename or archive the user made while the request was in flight. Position
* follows the server's ordering (pinned first, then most recent first) so the
* row reappears where it belongs rather than at the end.
*/
export function restoreRow(list: ConversationRow[], row: ConversationRow): ConversationRow[] {
if (list.some((c) => c.id === row.id)) return list
const sortKey = (c: ConversationRow) => c.last_message_at ?? c.created_at ?? ''
const idx = list.findIndex((c) => {
if (row.pinned !== c.pinned) return row.pinned && !c.pinned
return sortKey(row) > sortKey(c)
})
if (idx === -1) return [...list, row]
return [...list.slice(0, idx), row, ...list.slice(idx)]
}
/** PATCH one conversation. Resolves false for a non-2xx AND for a thrown fetch. */
export async function patchConversation(
id: string,
body: Record<string, unknown>,
): Promise<boolean> {
try {
const res = await fetch(`/api/agent/conversations/${id}`, {
method: 'PATCH',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify(body),
})
return res.ok
} catch {
return false
}
}
/**
* Per-row revision guard.
*
* Two writes to the same row can overlap (a double-click on pin, a rename
* while an archive is in flight). Without this, a failing FIRST request would
* roll back over the SECOND request's newer value. Each write claims a
* revision; a rollback only applies while its revision is still the latest for
* that row.
*/
export function createRevisionGuard() {
const revisions = new Map<string, number>()
return {
claim(id: string): number {
const next = (revisions.get(id) ?? 0) + 1
revisions.set(id, next)
return next
},
isCurrent(id: string, revision: number): boolean {
return revisions.get(id) === revision
},
}
}
export interface OptimisticPatchArgs {
id: string
body: Record<string, unknown>
/** Optimistic transform, applied immediately. */
apply: (list: ConversationRow[]) => ConversationRow[]
/** Undo, applied to the CURRENT list only if this write is still the latest. */
revert: (list: ConversationRow[]) => ConversationRow[]
setList: (updater: (prev: ConversationRow[]) => ConversationRow[]) => void
guard: ReturnType<typeof createRevisionGuard>
onError: () => void
patch?: typeof patchConversation
}
/**
* Apply a change optimistically, send it, and undo it if the server refuses.
* Returns whether the change stuck.
*/
export async function runOptimisticPatch({
id,
body,
apply,
revert,
setList,
guard,
onError,
patch = patchConversation,
}: OptimisticPatchArgs): Promise<boolean> {
const revision = guard.claim(id)
setList(apply)
const ok = await patch(id, body)
if (ok) return true
// A newer write for this row has since been issued: undoing here would clobber
// it. That write owns the row's state and will report its own failure.
if (!guard.isCurrent(id, revision)) return false
setList(revert)
onError()
return false
}