bjornbergenheimandClaude Opus 5
43a71aec3c
* fix(supabase): stop server clients leaking a 30s refresh ticker per request
`autoRefreshToken` defaults to true in supabase-js, and off-browser
@supabase/auth-js starts the refresh ticker unconditionally:
// in non-browser environments the refresh token ticker runs always
this.startAutoRefresh()
That is a setInterval firing every 30 s. It calls unref(), so the process
still exits, tests pass, and Vercel never notices because the process is
torn down long before the tickers accumulate. But unref() does not make a
timer collectable: it stays registered in the event loop and remains a GC
root for its callback, which closes over the GoTrueClient, the
SupabaseClient, and the whole request scope around it.
A long-running self-hosted instance therefore leaks one timer plus one
entire request graph (socket, IncomingMessage, ServerResponse, headers,
route context: ~100 kB) per client constructed. One died of "JavaScript
heap out of memory" after 42 h, the last 24 of them completely idle. The
heap snapshot showed 445 retained request graphs and ~1050 Timeouts in
the 30 000 ms bucket, retained via `autoRefreshTicker`, and the rate
matched the traffic exactly: the Docker healthcheck polls /api/health
every 30 s and the webhook dispatch cron runs every minute, so
3 clients/min x 148 min = 444.
- new lib/supabase/service-client.ts: createServiceRoleClient() applies
SERVER_AUTH_OPTIONS, spread LAST so a caller passing its own auth block
cannot re-enable the ticker
- 22 call sites migrated; only booking-templates/sync/cron had ever
passed the options itself
- guard 9 in no-new-antipatterns.mjs fails CI on any new value import of
supabase-js's createClient outside the wrapper; type-only imports are
fine. Verified to fail on a deliberate regression and pass once fixed
- browser clients untouched: a signed-in tab genuinely needs the refresh,
and lib/supabase/client.ts is built on createBrowserClient anyway
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* fix(checks): catch namespace imports in the leaky-supabase-client guard
The guard only matched named imports, so
import * as sb from '@supabase/supabase-js'
sb.createClient(url, key)
reached createClient through member access without ever naming it, and
passed. Verified against the real script before and after: the shape is
flagged now, and `import type * as sb` still passes.
Namespace value imports are treated as leaky outright rather than tracking
member access, which keeps the check a regex over source text with no new
dependency.
Review also suggested excluding *.test.tsx alongside *.test.ts. Skipped: the
repo has no .test.tsx files, and all four sibling checks in this file use
`.test.ts`. Diverging in one of them would read as an accident; if such files
appear, all four should change together.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
66 lines
2.6 KiB
TypeScript
66 lines
2.6 KiB
TypeScript
import { createServiceRoleClient } from '@/lib/supabase/service-client'
|
|
import { NextResponse } from 'next/server'
|
|
import { withCronContext } from '@/lib/api/with-cron-context'
|
|
import { errorResponseFromCode } from '@/lib/errors/get-structured-error'
|
|
import { syncSystemPacks } from '@/lib/packs/sync'
|
|
|
|
/**
|
|
* GET /api/settings/booking-templates/sync/cron
|
|
*
|
|
* Reconciles the system booking templates in the database with `packs/*.yaml`
|
|
* (schedule in vercel.json). The packs ship with the deploy; this is what makes
|
|
* the deployed catalogue the one companies actually see, so editing a template
|
|
* is a file change plus a deploy rather than a migration.
|
|
*
|
|
* Idempotent by construction: a database already matching the packs performs
|
|
* zero writes, so running it more often than needed costs one SELECT.
|
|
*
|
|
* Deliberately a cron rather than boot-time work: a sync on every cold start
|
|
* would have every serverless instance racing to write the same rows, and a
|
|
* bad catalogue would be re-applied continuously instead of once a day where
|
|
* it is visible in the logs.
|
|
*
|
|
* Service-role client, no company context: system templates belong to no
|
|
* company and RLS forbids writing them from a user session (btl_insert /
|
|
* btl_update both exclude is_system rows).
|
|
*/
|
|
|
|
// The catalogue is small (tens of rows); this never approaches the budget.
|
|
export const maxDuration = 60
|
|
|
|
export const GET = withCronContext('cron.booking_templates_sync', async (_request, ctx) => {
|
|
const supabaseUrl = process.env.NEXT_PUBLIC_SUPABASE_URL
|
|
const supabaseServiceKey = process.env.SUPABASE_SERVICE_ROLE_KEY
|
|
|
|
if (!supabaseUrl || !supabaseServiceKey) {
|
|
return errorResponseFromCode('INTERNAL_ERROR', ctx.log, {
|
|
requestId: ctx.requestId,
|
|
details: { reason: 'Missing Supabase configuration' },
|
|
})
|
|
}
|
|
|
|
const supabase = createServiceRoleClient(supabaseUrl, supabaseServiceKey)
|
|
|
|
const result = await syncSystemPacks(supabase)
|
|
|
|
if (result.errors.length) {
|
|
// A catalogue that fails to load is a deploy problem, not a data problem:
|
|
// syncSystemPacks writes nothing in that case, so the previous state stands.
|
|
ctx.log.error('pack sync aborted: catalogue invalid', { errors: result.errors })
|
|
return errorResponseFromCode('INTERNAL_ERROR', ctx.log, {
|
|
requestId: ctx.requestId,
|
|
details: { reason: 'Pack catalogue invalid', errors: result.errors },
|
|
})
|
|
}
|
|
|
|
return NextResponse.json({
|
|
data: {
|
|
inserted: result.inserted.length,
|
|
updated: result.updated.length,
|
|
unchanged: result.unchanged.length,
|
|
retired: result.retired.length,
|
|
retired_slugs: result.retired,
|
|
},
|
|
})
|
|
})
|