* feat(reports): custom date ranges on report endpoints in REST v1 and MCP, plus PDF export via API
Requested by a v1/MCP user: the web UI can produce resultat- and
balansrapport for a custom period with PDF export, but REST v1 and the
MCP tools only served whole fiscal years and silently ignored
from_date/to_date.
- v1 income-statement: optional from_date/to_date (validated against the
fiscal period via the same parseReportDateRange the dashboard uses)
- v1 balance-sheet: same, plus as_of as the natural alias for to_date
(mutually exclusive with it)
- Unknown query params on these report routes now return
VALIDATION_ERROR with the unknown and allowed names instead of being
silently dropped (scoped to these routes, not a global v1 change)
- MCP gnubok_get_income_statement: from_date/to_date;
gnubok_get_balance_sheet: as_of_date; both validate format, in-period
and ordering, and reject unknown args (tools/list payload bench held
under the ceiling by trimming the same tools' descriptions)
- New v1 PDF endpoints reports/{income-statement,balance-sheet}/pdf,
byte-equivalent to the dashboard export: the K2/K3 grouping and the
balance gate moved to lib/reports/financial-statement-pdf.ts, shared
by both surfaces
- Both JSON endpoints echo the effective range in data.period
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(reports): range semantics, empty-date validation, and review findings on PR #1909
Consolidated resolution of the skeptic refutations, CI failures, and
CodeRabbit findings:
- Ranged income statement summed closing balances, so from_date after
period start returned year-to-date figures mislabeled as the range
(July revenue reported as Jan-Jul on JSON, PDF, and MCP). The trial
balance rolls pre-range P&L activity into opening columns, so
generateIncomeStatement now builds from period movements whenever
fromDate is set, matching the resultatrapport convention. Full-period
behavior is unchanged; generator-level regression tests added.
- from_date dropped from the v1 balance-sheet routes (JSON + PDF): a
balansraking is a cumulative position, not a flow over a window
(ÅRL 3 kap); matches the MCP tool's as_of_date-only surface.
- Empty date values (from_date=) now fail validation instead of
silently producing a full-period report with an empty period echo
(null-check instead of truthiness in parseReportDateRange).
- dry_run, read by the withApiV1 wrapper on every request, is tolerated
by the strict param check instead of being rejected as unknown.
- Unbalanced balansrakning on the v1 PDF route returns 400 (caller-data
condition), matching the dashboard export, instead of 500.
- skills/accounted-api regenerated (apiskill:check gate).
- Removed the ISO_DATE_RE import that collided with the pre-existing
local declaration in the MCP server (TS2440 on core build).
- CodeRabbit: 401 tests for both PDF endpoints; event bus cleared in
the new MCP test's beforeEach.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
94 lines
3.4 KiB
TypeScript
94 lines
3.4 KiB
TypeScript
import { NextResponse } from 'next/server'
|
|
import { renderToBuffer } from '@react-pdf/renderer'
|
|
import { generateBalanceSheet } from '@/lib/reports/balance-sheet'
|
|
import { FinancialStatementPDF } from '@/lib/reports/financial-statement-pdf-template'
|
|
import { buildBalanceSheetPdfModel, balanceSheetImbalanceKronor } from '@/lib/reports/financial-statement-pdf'
|
|
import { withRouteContext } from '@/lib/api/with-route-context'
|
|
import { parseReportDateRange } from '@/lib/reports/date-range'
|
|
import type { CompanySettings } from '@/types'
|
|
import { getErrorMessage as getUserErrorMessage } from '@/lib/errors/get-error-message'
|
|
|
|
export const GET = withRouteContext('report.balance_sheet.pdf', async (request, { supabase, companyId }) => {
|
|
const { searchParams } = new URL(request.url)
|
|
const periodId = searchParams.get('period_id')
|
|
|
|
if (!periodId) {
|
|
return NextResponse.json({ error: 'period_id is required' }, { status: 400 })
|
|
}
|
|
|
|
const [{ data: period }, { data: companyRow }] = await Promise.all([
|
|
supabase
|
|
.from('fiscal_periods')
|
|
.select('period_start, period_end')
|
|
.eq('id', periodId)
|
|
.eq('company_id', companyId)
|
|
.single(),
|
|
supabase
|
|
.from('company_settings')
|
|
.select('*')
|
|
.eq('company_id', companyId)
|
|
.single(),
|
|
])
|
|
|
|
if (!companyRow) {
|
|
return NextResponse.json({ error: 'Företagsinställningar saknas' }, { status: 404 })
|
|
}
|
|
// An identifiable period is part of räkenskapsinformation (BFL 7 kap). Refuse
|
|
// to render a PDF that can't be archived with the period it refers to.
|
|
if (!period) {
|
|
return NextResponse.json(
|
|
{ error: 'Räkenskapsperioden kunde inte läsas. Välj en befintlig period innan du genererar PDF.' },
|
|
{ status: 400 }
|
|
)
|
|
}
|
|
|
|
const parsedRange = parseReportDateRange(searchParams, period)
|
|
if (!parsedRange.ok) {
|
|
return NextResponse.json({ error: parsedRange.error }, { status: 400 })
|
|
}
|
|
const range = parsedRange.range
|
|
const effectiveStart = range.fromDate ?? period.period_start
|
|
const effectiveEnd = range.toDate ?? period.period_end
|
|
|
|
try {
|
|
const report = await generateBalanceSheet(supabase, companyId, periodId, range)
|
|
report.period = { start: effectiveStart, end: effectiveEnd }
|
|
|
|
if (balanceSheetImbalanceKronor(report) >= 1) {
|
|
return NextResponse.json(
|
|
{
|
|
error:
|
|
'Balansräkningen balanserar inte (tillgångar ≠ eget kapital och skulder). Åtgärda differensen innan du genererar PDF.',
|
|
},
|
|
{ status: 400 }
|
|
)
|
|
}
|
|
|
|
const pdfBuffer = await renderToBuffer(
|
|
FinancialStatementPDF({
|
|
title: 'Balansräkning',
|
|
groups: buildBalanceSheetPdfModel(report).groups,
|
|
period: report.period,
|
|
company: companyRow as CompanySettings,
|
|
generatedAt: new Date().toISOString(),
|
|
})
|
|
)
|
|
|
|
// "-utkast" suffix keeps the draft status visible even after the file
|
|
// leaves the browser: complements the in-document ÅRL 2:7 disclaimer.
|
|
const filename = `balansrakning-${report.period.start}--${report.period.end}-utkast.pdf`
|
|
|
|
return new Response(new Uint8Array(pdfBuffer), {
|
|
headers: {
|
|
'Content-Type': 'application/pdf',
|
|
'Content-Disposition': `attachment; filename="${filename}"`,
|
|
},
|
|
})
|
|
} catch (err) {
|
|
return NextResponse.json(
|
|
{ error: err instanceof Error ? getUserErrorMessage(err) : 'Kunde inte generera balansräkning' },
|
|
{ status: 500 }
|
|
)
|
|
}
|
|
})
|