ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
140 lines
4.6 KiB
TypeScript
140 lines
4.6 KiB
TypeScript
/**
|
|
* Tests for PATCH /api/dimensions/[id] (update dimension).
|
|
*
|
|
* Covers: 401, empty-body validation (400), 404, the is_system name-lock
|
|
* ("Systemdimensioner kan inte döpas om", 400 DIMENSION_SYSTEM_RENAME),
|
|
* archiving a system dimension (allowed), and the happy rename of a custom
|
|
* dimension.
|
|
*/
|
|
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import { NextResponse } from 'next/server'
|
|
import {
|
|
createQueuedMockSupabase,
|
|
createMockRequest,
|
|
createMockRouteParams,
|
|
parseJsonResponse,
|
|
} from '@/tests/helpers'
|
|
|
|
const { supabase, enqueue, reset } = createQueuedMockSupabase()
|
|
|
|
const requireAuthMock = vi.fn()
|
|
vi.mock('@/lib/auth/require-auth', () => ({
|
|
requireAuth: (...args: unknown[]) => requireAuthMock(...args),
|
|
}))
|
|
|
|
vi.mock('@/lib/company/context', () => ({
|
|
getActiveCompanyId: vi.fn().mockResolvedValue('company-1'),
|
|
requireCompanyId: vi.fn().mockResolvedValue('company-1'),
|
|
}))
|
|
|
|
const requireWriteMock = vi.fn()
|
|
vi.mock('@/lib/auth/require-write', () => ({
|
|
requireWritePermission: (...args: unknown[]) => requireWriteMock(...args),
|
|
}))
|
|
|
|
vi.mock('@/lib/init', () => ({ ensureInitialized: vi.fn() }))
|
|
|
|
import { PATCH } from '../[id]/route'
|
|
|
|
const params = () => createMockRouteParams({ id: 'dim-1' })
|
|
|
|
describe('PATCH /api/dimensions/[id]', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
reset()
|
|
requireAuthMock.mockResolvedValue({ user: { id: 'user-1' }, supabase })
|
|
requireWriteMock.mockResolvedValue({ ok: true })
|
|
})
|
|
|
|
it('returns 401 when not authenticated', async () => {
|
|
requireAuthMock.mockResolvedValue({
|
|
error: NextResponse.json({ error: 'Unauthorized' }, { status: 401 }),
|
|
})
|
|
|
|
const request = createMockRequest('/api/dimensions/dim-1', {
|
|
method: 'PATCH',
|
|
body: { name: 'Avdelning' },
|
|
})
|
|
const response = await PATCH(request, params())
|
|
|
|
expect(response.status).toBe(401)
|
|
})
|
|
|
|
it('rejects an empty body with 400', async () => {
|
|
const request = createMockRequest('/api/dimensions/dim-1', { method: 'PATCH', body: {} })
|
|
const response = await PATCH(request, params())
|
|
|
|
expect(response.status).toBe(400)
|
|
})
|
|
|
|
it('returns 404 when the dimension does not belong to the company', async () => {
|
|
enqueue({ data: null }) // maybeSingle fetch
|
|
|
|
const request = createMockRequest('/api/dimensions/dim-1', {
|
|
method: 'PATCH',
|
|
body: { name: 'Avdelning' },
|
|
})
|
|
const response = await PATCH(request, params())
|
|
const { status, body } = await parseJsonResponse<{ error: { code: string } }>(response)
|
|
|
|
expect(status).toBe(404)
|
|
expect(body.error.code).toBe('DIMENSION_NOT_FOUND')
|
|
})
|
|
|
|
it('rejects renaming a system dimension with 400 DIMENSION_SYSTEM_RENAME', async () => {
|
|
enqueue({ data: { id: 'dim-1', name: 'Kostnadsställe', is_system: true } })
|
|
|
|
const request = createMockRequest('/api/dimensions/dim-1', {
|
|
method: 'PATCH',
|
|
body: { name: 'Avdelning' },
|
|
})
|
|
const response = await PATCH(request, params())
|
|
const { status, body } = await parseJsonResponse<{ error: { code: string; message: string } }>(response)
|
|
|
|
expect(status).toBe(400)
|
|
expect(body.error.code).toBe('DIMENSION_SYSTEM_RENAME')
|
|
expect(body.error.message).toBe('Systemdimensioner kan inte döpas om.')
|
|
})
|
|
|
|
it('allows archiving a system dimension (is_active only, no rename)', async () => {
|
|
enqueue({ data: { id: 'dim-1', name: 'Kostnadsställe', is_system: true } })
|
|
enqueue({
|
|
data: {
|
|
id: 'dim-1', sie_dim_no: 1, name: 'Kostnadsställe',
|
|
resets_annually: true, is_system: true, is_active: false, sort_order: 10,
|
|
},
|
|
})
|
|
|
|
const request = createMockRequest('/api/dimensions/dim-1', {
|
|
method: 'PATCH',
|
|
body: { is_active: false },
|
|
})
|
|
const response = await PATCH(request, params())
|
|
const { status, body } = await parseJsonResponse<{ data: { is_active: boolean } }>(response)
|
|
|
|
expect(status).toBe(200)
|
|
expect(body.data.is_active).toBe(false)
|
|
})
|
|
|
|
it('renames a non-system dimension (happy path)', async () => {
|
|
enqueue({ data: { id: 'dim-1', name: 'Dimension 7', is_system: false } })
|
|
enqueue({
|
|
data: {
|
|
id: 'dim-1', sie_dim_no: 7, name: 'Avdelning',
|
|
resets_annually: true, is_system: false, is_active: true, sort_order: 30,
|
|
},
|
|
})
|
|
|
|
const request = createMockRequest('/api/dimensions/dim-1', {
|
|
method: 'PATCH',
|
|
body: { name: 'Avdelning', sort_order: 30 },
|
|
})
|
|
const response = await PATCH(request, params())
|
|
const { status, body } = await parseJsonResponse<{ data: { name: string; sort_order: number } }>(response)
|
|
|
|
expect(status).toBe(200)
|
|
expect(body.data.name).toBe('Avdelning')
|
|
expect(body.data.sort_order).toBe(30)
|
|
})
|
|
})
|