Files
accounted/app/api/clients/signup-access/route.ts
T
MattssonandClaude Fable 5 4f6ecad549 feat(white-label): invite-only signup for brand domains (#1995)
* feat(white-label): invite-only signup for brand domains

A brand domain belongs to the partner's people (founder decision
2026-08-27): only allowlisted or invited users may create an account on
an invite-only brand domain; everyone else is shown an interstitial that
sends them to the canonical Accounted signup.

- brands.signup_mode ('open' default / 'invite_only') +
  brand_signup_allowlist (lowercase emails, team-scoped RLS, owner/admin
  writes) + create_company_for_brand_signup RPC, with pg-real coverage
- server-side gate (lib/auth/brand-signup-gate.ts) enforced on every
  signup path: email signup moved to POST /api/auth/signup (the browser
  used to call GoTrue directly, so a client-side check would be
  bypassable), BankID gated in /bankid/complete, Google covered by the
  dashboard layout's brand-domain bounce
- company invites bypass the allowlist: the invite is the authorization
- register page interstitial on gated brands (no email in the outbound
  URL), sv+en strings
- dashboard layout bounces non-belonging sessions off gated brand hosts
  to the canonical domain (navigation rule like WL-01, not a security
  boundary)
- allowlisted signups' onboarding-created companies attach to the
  brand's byra team via the new RPC, so WL-01 homes them on the brand
  domain; the allowlist entry recorded by an owner/admin stands in for
  the WL-15 admin gate
- byra cockpit page /clients/access + /api/clients/signup-access to
  manage the mode and the allowlist

All existing brands default to 'open': behavior is byte-identical until
a brand is flipped to invite_only.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ByL5dQXG8gGLtNBPj8g2C4

* fix(white-label): rollback brand-signup company with the service client

Skeptic (correctness) found that a brand-signup company created under the
service role rolled back with the cookie-session client: `companies` has
RLS and no FOR DELETE policy, so the delete was a silent 0-row no-op,
stranding a member-less ghost company on the partner's byra team. Pass an
optional rollbackClient to createCompanyCore and hand it the service
client on that path; user_preferences.active_company_id then clears itself
via its ON DELETE SET NULL FK once the company row is actually deleted.

Also map a validateBody 400 (flat envelope, no code) on the register page
to the specific email-invalid field message instead of the generic one,
since the client already pre-gates password strength.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ByL5dQXG8gGLtNBPj8g2C4

* fix(white-label): fail-safe brand lookup, pg-test seed, anonymize fixtures

Second resolve-pr cycle: skeptic + CodeRabbit findings and a green-up.

- Fail safe on a brands-table error (CodeRabbit CWE-285): the gate treated a
  failed resolveBrandByHost as an unbranded host, opening invite-only signup
  during a transient DB blip. resolveBrandResultByHost now distinguishes
  "no brand" from "lookup failed"; the gate returns lookupFailed and the
  email + BankID routes answer 503 (retry), never creating an account.
- pg-real: the RLS delete test seeded its row inside withUserContext, which
  always rolls back, so the owner DELETE saw zero rows. Seed on the superuser
  pool instead.
- Anonymize every test/fixture brand to the repo's existing synthetic
  placeholder (Siffra / app.siffra.se): no real partner names in code.
- SignupAccessManager: functional setData updates so a concurrent mode
  toggle and an add/remove do not clobber each other's snapshot (CodeRabbit).
- Route a transient-error message through i18n instead of the raw envelope
  (raw-user-error guard); new register.error_temporary sv+en.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ByL5dQXG8gGLtNBPj8g2C4

* test(white-label): anonymize new signup-gate fixtures; log oracle residual

Rename the placeholder brand in the four new brand-signup test files to a
clearly-fake, partner-unrelated name (Testbrand / app.testbrand.example);
the previous placeholder echoed a real partner. Scoped to files this PR
creates; the repo-wide legacy placeholder is left for a separate cleanup.

Also record in DECISIONS.md that the feature ships accepting the
low-severity allowlist-enumeration residual (captcha-free 403 vs 200 on
the signup endpoint), with rate-limiting as the follow-up option.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ByL5dQXG8gGLtNBPj8g2C4

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-27 18:32:52 +02:00

221 lines
6.8 KiB
TypeScript

import { NextResponse } from 'next/server'
import { requireAuth } from '@/lib/auth/require-auth'
import { createServiceClientNoCookies } from '@/lib/auth/api-keys'
import { getByraMembership } from '@/lib/clients/fetch-client-overview'
import { clearBrandCache, resolveBrandForTeam, type Brand } from '@/lib/branding/resolve'
import type { SupabaseClient } from '@supabase/supabase-js'
import { validateBody } from '@/lib/api/validate'
import {
BrandAllowlistAddSchema,
BrandAllowlistRemoveSchema,
BrandSignupModeSchema,
} from '@/lib/api/schemas'
/**
* /api/clients/signup-access: the byrå cockpit's management surface for
* invite-only signup on the team's brand domain (2026-08-27).
*
* GET signup mode + allowlist entries (any byrå team member)
* PATCH { signup_mode } flip open/invite_only (owner/admin)
* POST { email, note? } add an allowlist entry (owner/admin)
* DELETE { id } remove an allowlist entry (owner/admin)
*
* Uses requireAuth() directly (the sanctioned withRouteContext opt-out, MFA
* still enforced): byrå staff without a company of their own are the
* cockpit's primary persona, and this surface needs no active company.
*
* Allowlist reads/writes go through the caller's client so RLS enforces the
* same team/role rules a second time. The signup_mode flip uses the service
* client because brands rows are ops-managed (no user write policies); the
* owner/admin check here is the authorization for that single column.
*/
type Access =
| {
ok: true
supabase: SupabaseClient
userId: string
role: 'owner' | 'admin' | 'member'
brand: Brand
}
| { ok: false; response: NextResponse }
async function resolveAccess(opts: { write: boolean }): Promise<Access> {
const auth = await requireAuth()
if (auth.error) return { ok: false, response: auth.error }
const { user, supabase } = auth
const membership = await getByraMembership(supabase, user.id)
if (!membership) {
return {
ok: false,
response: NextResponse.json(
{
error: {
code: 'FORBIDDEN',
message: 'Endast byråteam har åtkomst till registreringsinställningarna.',
message_en: 'Signup access settings are only available to byrå teams.',
},
},
{ status: 403 },
),
}
}
if (opts.write && membership.role !== 'owner' && membership.role !== 'admin') {
return {
ok: false,
response: NextResponse.json(
{
error: {
code: 'FORBIDDEN',
message: 'Endast byråns ägare och administratörer kan ändra registreringsåtkomst.',
message_en: 'Only byrå owners and admins can change signup access.',
},
},
{ status: 403 },
),
}
}
const brand = await resolveBrandForTeam(membership.teamId)
if (!brand) {
return {
ok: false,
response: NextResponse.json(
{
error: {
code: 'NOT_FOUND',
message: 'Byrån har ingen egen domän ännu.',
message_en: 'The byrå has no white-label domain yet.',
},
},
{ status: 404 },
),
}
}
return { ok: true, supabase, userId: user.id, role: membership.role, brand }
}
export async function GET() {
const access = await resolveAccess({ write: false })
if (!access.ok) return access.response
const { data: entries, error } = await access.supabase
.from('brand_signup_allowlist')
.select('id, email, note, created_at')
.eq('brand_id', access.brand.id)
.order('created_at', { ascending: false })
if (error) {
return NextResponse.json(
{ error: { code: 'INTERNAL', message: 'Kunde inte hämta listan.', message_en: 'Could not load the list.' } },
{ status: 500 },
)
}
return NextResponse.json({
data: {
brand: {
domain: access.brand.domain,
appName: access.brand.appName,
signupMode: access.brand.signupMode,
},
role: access.role,
entries: entries ?? [],
},
})
}
export async function PATCH(request: Request) {
const access = await resolveAccess({ write: true })
if (!access.ok) return access.response
const validation = await validateBody(request, BrandSignupModeSchema)
if (!validation.success) return validation.response
const service = createServiceClientNoCookies()
const { error } = await service
.from('brands')
.update({ signup_mode: validation.data.signup_mode })
.eq('id', access.brand.id)
if (error) {
return NextResponse.json(
{ error: { code: 'INTERNAL', message: 'Kunde inte spara.', message_en: 'Could not save.' } },
{ status: 500 },
)
}
// The host-resolution cache holds the old mode for up to ~60s; drop it so
// the gate on this server instance flips immediately. Other instances
// converge within the TTL, same as every other brand edit.
clearBrandCache()
return NextResponse.json({ data: { signupMode: validation.data.signup_mode } })
}
export async function POST(request: Request) {
const access = await resolveAccess({ write: true })
if (!access.ok) return access.response
const validation = await validateBody(request, BrandAllowlistAddSchema)
if (!validation.success) return validation.response
const { data: entry, error } = await access.supabase
.from('brand_signup_allowlist')
.insert({
brand_id: access.brand.id,
email: validation.data.email,
note: validation.data.note ?? null,
created_by: access.userId,
})
.select('id, email, note, created_at')
.single()
if (error) {
if (error.code === '23505') {
return NextResponse.json(
{
error: {
code: 'CONFLICT',
message: 'E-postadressen finns redan i listan.',
message_en: 'That email is already on the list.',
},
},
{ status: 409 },
)
}
return NextResponse.json(
{ error: { code: 'INTERNAL', message: 'Kunde inte lägga till.', message_en: 'Could not add the email.' } },
{ status: 500 },
)
}
return NextResponse.json({ data: entry })
}
export async function DELETE(request: Request) {
const access = await resolveAccess({ write: true })
if (!access.ok) return access.response
const validation = await validateBody(request, BrandAllowlistRemoveSchema)
if (!validation.success) return validation.response
const { error } = await access.supabase
.from('brand_signup_allowlist')
.delete()
.eq('id', validation.data.id)
.eq('brand_id', access.brand.id)
if (error) {
return NextResponse.json(
{ error: { code: 'INTERNAL', message: 'Kunde inte ta bort.', message_en: 'Could not remove the email.' } },
{ status: 500 },
)
}
return NextResponse.json({ data: { removed: validation.data.id } })
}