* fix(invoices): reminders, AR ledger, AR reconciliation and deadlines only read fakturor The overdue-reminder run, the kundreskontra, the 1510 reconciliation and the deadlines page selected invoices by status alone. A sent proforma past its due date was chased with a betalningspaminnelse and flipped to 'overdue', and it appeared as a receivable. All four now filter document_type = 'invoice', which is also the precondition for adding quotes (offert): a quote carries a date but never a receivable. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W45yD8NfQ97JhyYaXpzN56 * feat(invoices): offert (quote) document type with its own OF-series, decisions and conversion Adds document_type 'quote' with valid_until, quote_status (open / accepted / declined; expired is derived from valid_until, never stored) and quote_decided_at. Quotes are numbered OF-nnn at insert from company_settings.next_quote_number via generate_quote_number(), the same pattern as delivery notes, so a declined quote never leaves a hole in the F-series the way a proforma does. The column next_quote_number already existed on prod and staging without a migration; the migration adopts it. Engine: build-invoice-write writes the quote columns and keeps remaining_amount at 0; the draft editor refuses accepted or declined quotes; PATCH refuses changing a quote's or delivery note's document type since the number belongs to the series; mark-paid refuses quotes. New POST /api/invoices/[id]/quote-status records the decision and locks once an invoice exists. Conversion is extracted into lib/invoices/convert-to-invoice.ts (one implementation for the route and the MCP staged commit, which had drifted): a converted quote stays and flips to accepted, the invoice links back via converted_from_id and gets its due date from the customer's payment terms; a declined or already invoiced quote is refused. next-number previews the OF-series for quotes. Migration applied to the staging branch and registered as 20260902140000; the pg test runs in CI (pg-real). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W45yD8NfQ97JhyYaXpzN56 * feat(invoices): quote PDF, email and filename surfaces The customer-facing surfaces get a quote sibling for every proforma branch: PDF title OFFERT / QUOTE with Offertdatum and Giltig till instead of the due date, a notice that the document is not an invoice or a payment request, and no payment box, OCR, bankgiro, Swish, QR or payment link. The email says the quote is attached and valid until the expiry, drops the payment details and pay-online button, and asks about the quote rather than the invoice. Filenames read "Offert nr OF-001". Seller VAT number and payment accounts are skipped for quotes as for proformas: a quote is not a faktura under ML 17 kap. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W45yD8NfQ97JhyYaXpzN56 * feat(invoices): offert in the editor, list and detail pages Editor: "Offert" document type with a required "Giltig till" field (default today + 30 days) in place of the due date; the wire body mirrors it into due_date so the shared schema is satisfied. Payment link, ROT/RUT, periodisering and the bank box are already gated on real invoices. The type cannot be switched on an existing quote (its OF-number belongs to the series). List: an Offerter tab beside Proforma, "Ny offert" in the split button, and a status column that shows the decision or the derived expiry: Utgången and Avböjd are exception chips, Öppen and Accepterad muted text. Detail: Acceptera and Skapa faktura in the header, Avböj in the overflow menu; an expired quote asks before accepting or invoicing (bypassable); once an invoice exists the page links to it as Fakturerad and hides the decision actions. Strings in both sv and en. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W45yD8NfQ97JhyYaXpzN56 * feat(mcp,v1): expose offert on the MCP tools and the v1 REST surface MCP: create_invoice takes document_type quote with a required valid_until and allocates the OF-number at insert; the convert tool keeps its id and accepts quotes with the registry refusal codes; new set_quote_status; list_invoices and get_invoice expose valid_until and the effective quote status, including a derived expired filter. The tools/list payload stays under its ceiling without a ledger change. The MCP staged convert now uses the shared converter. v1: POST /invoices/{id}/quote-status (registered in the endpoint registry, scope map and route loader), valid_until and quote_status in the list, create and detail shapes, and a quote_status list filter. Skill atoms mention offert. Decision log lines for the own number series, derived expiry, accepted-not-cancelled conversion and the header action layout. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W45yD8NfQ97JhyYaXpzN56 * test(invoices): pass route params and period id in the new quote tests Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W45yD8NfQ97JhyYaXpzN56 * refactor(invoices): literal update payloads in the converter so the phantom-column guard can read them Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W45yD8NfQ97JhyYaXpzN56 * fix(invoices): close the quote review findings in one pass Skeptics (correctness, compliance, regression) and CodeRabbit on #2163: - quote_status is no longer a write-builder output, so a v1 PATCH or MCP update_invoice can never reset a recorded accept/decline; new quotes are opened by the invoices_quote_defaults trigger (20260902141000), which also keeps due_date and valid_until equal. v1 PATCH and the MCP update executor now use the shared editable-draft predicate. - One live invoice per converted source, enforced by a partial unique index; the converter maps 23505 to INVOICE_QUOTE_ALREADY_INVOICED and both quote-status routes compare-and-set on the decision they read. - MCP-created quotes carry remaining_amount 0; mark-paid, transaction match and voucher link refuse non-invoices on the MCP staging tools, the executors and the dashboard link route. - Conversion of a foreign-currency source refetches the rate for the conversion day (ML 8 kap 21-23 paragraphs) and fails closed without one; 0-day payment terms mean due on receipt. - bulk-create refuses quotes per item; list_invoices rejects a quote_status filter combined with another document_type; an omitted document_type on PATCH means unchanged. - attention, push notifications, open-AR count, FX revaluation, year-end and accrual auto-detect and bank-match suggestions only read fakturor. - Quote PDF and email print Summa / Total instead of Att betala. - Regenerated skills/accounted-api for the new v1 endpoint. Declined with reasons in DECISIONS.md: NOT VALID + VALIDATE and CONCURRENTLY on the migrations (repo precedent, 13.8k rows, transactional apply); re-validating VAT treatment at conversion (the converted invoice is a draft the user reviews; follow-up). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0111fYAUxKtpxU1BHiBioqzs * fix(invoices): second review round: migration versions, order links, batch allocation, races - Migrations renamed to 20260902220000 / 20260902221000: #2166 shipped its own 20260902141000 to prod while this PR was in review and prod's head moved past both files; below-head versions are skipped by branching, which would have left the quote trigger off prod. Staging rows renamed. - Quote lines never carry sales_order_item_id (an offer must not count as invoiced kundorder quantity); the converter carries a proforma line's order link onto the invoice. - Converter compare-and-sets the source (proforma cancel, quote accept): a concurrent cancel, proforma-to-order conversion or decision removes the orphan invoice with INVOICE_CONVERT_SOURCE_CHANGED instead of a second document for the same sale. - MCP set_quote_status gets the same compare-and-set as the HTTP routes; 0-row updates report INVOICE_QUOTE_CHANGED_CONCURRENTLY everywhere. quote-status (dashboard, v1, MCP) accepts valid_until so an expired sent quote can be reopened, as the docs promised. - MCP mark-paid refuses only quotes, parity with the dashboard route (a sent proforma marked paid is a supported prepayment record). - Batch allocation (dashboard route and MCP tool) refuses non-invoices before the RPC, which gates on status alone. - Customer AR drill-down, v1 customer open invoices and archive guard, and the calendar feed read fakturor only. - Draft quote PDF says "UTKAST" instead of "not a valid invoice"; the editor locks the document type on existing quotes and delivery notes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0111fYAUxKtpxU1BHiBioqzs * chore(invoices): use roundOre in the quote MCP summaries and FX test after main tightened the guard baseline Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0111fYAUxKtpxU1BHiBioqzs * fix(invoices): third review round: atomic decision lock, viewer gate, lookup errors, quote payment terms - 20260902222000: BEFORE UPDATE trigger locks an accepted quote while a live converted invoice exists (the compare-and-set in the three decision writers could still be beaten by a conversion landing in between); the routes and the MCP tool map the raise to 409 INVOICE_QUOTE_ALREADY_INVOICED. generate_quote_number now also requires a non-viewer membership so a viewer's session token cannot burn OF-numbers through PostgREST. - Converter checks quote eligibility before the Riksbanken call and treats a failed company_settings read as a failure instead of a 30-day default. - Re-sending the same decision keeps quote_decided_at (idempotent). - gnubok_find_voucher_candidates_for_invoice refuses non-invoices like its write sibling; the dashboard link route surfaces a failed lookup. - Late-fee and credit-term texts never print on a quote. Applied and registered on staging; pg tests added. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0111fYAUxKtpxU1BHiBioqzs * fix(invoices): review nits: fail-closed batch lookup, dry-run expiry, quote heading, quote-date CHECK - match-batch surfaces a failed document lookup instead of allocating. - v1 quote-status dry-run preview carries the new valid_until. - Quote PDF heading reads Offertinformation / Quote information. - 20260902222000 also pins the date invariants the trigger maintains as a CHECK: a quote always has valid_until = due_date, nothing else has one. Applied on staging. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0111fYAUxKtpxU1BHiBioqzs --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
688 lines
22 KiB
TypeScript
688 lines
22 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
|
|
// ============================================================
|
|
// Mock: sequential result queue
|
|
// ============================================================
|
|
|
|
let resultIdx: number
|
|
let results: Array<{ data?: unknown; error?: unknown }>
|
|
let calls: Array<{ method: string; args: unknown[] }>
|
|
|
|
function makeBuilder() {
|
|
const b: Record<string, unknown> = {}
|
|
for (const m of ['select', 'eq', 'in', 'lte', 'order', 'range']) {
|
|
b[m] = vi.fn().mockImplementation((...args: unknown[]) => {
|
|
calls.push({ method: m, args })
|
|
return b
|
|
})
|
|
}
|
|
b.single = vi.fn().mockImplementation(async () => results[resultIdx++] ?? { data: null, error: null })
|
|
b.then = (resolve: (v: unknown) => void) => resolve(results[resultIdx++] ?? { data: null, error: null })
|
|
return b
|
|
}
|
|
|
|
function makeClient() {
|
|
return {
|
|
from: vi.fn().mockImplementation(() => makeBuilder()),
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
} as any
|
|
}
|
|
|
|
import { generateARLedger } from '../ar-ledger'
|
|
|
|
let supabase: ReturnType<typeof makeClient>
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
resultIdx = 0
|
|
results = []
|
|
calls = []
|
|
supabase = makeClient()
|
|
})
|
|
|
|
describe('generateARLedger', () => {
|
|
it('only reads fakturor: proformas, delivery notes and quotes are not receivables', async () => {
|
|
results = [{ data: [], error: null }]
|
|
|
|
await generateARLedger(supabase, 'company-1')
|
|
|
|
expect(calls).toContainEqual({ method: 'eq', args: ['document_type', 'invoice'] })
|
|
})
|
|
|
|
it('returns empty report when no invoices found', async () => {
|
|
results = [
|
|
{ data: [], error: null },
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1')
|
|
expect(report.entries).toEqual([])
|
|
expect(report.total_outstanding).toBe(0)
|
|
expect(report.unpaid_count).toBe(0)
|
|
})
|
|
|
|
it('returns empty report on query error', async () => {
|
|
results = [
|
|
{ data: null, error: { message: 'DB error' } },
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1')
|
|
expect(report.entries).toEqual([])
|
|
expect(report.total_outstanding).toBe(0)
|
|
})
|
|
|
|
it('groups invoices by customer with correct aging buckets', async () => {
|
|
// Reference date: 2024-06-15
|
|
const asOfDate = '2024-06-15'
|
|
|
|
results = [
|
|
{
|
|
data: [
|
|
// Customer A: one current, one 1-30 days overdue
|
|
{
|
|
id: 'inv-1',
|
|
customer_id: 'cust-a',
|
|
customer: { id: 'cust-a', name: 'Acme AB' },
|
|
invoice_number: 'F001',
|
|
invoice_date: '2024-05-01',
|
|
due_date: '2024-06-20', // not yet due
|
|
total: 5000,
|
|
paid_amount: 0,
|
|
currency: 'SEK',
|
|
status: 'sent',
|
|
},
|
|
{
|
|
id: 'inv-2',
|
|
customer_id: 'cust-a',
|
|
customer: { id: 'cust-a', name: 'Acme AB' },
|
|
invoice_number: 'F002',
|
|
invoice_date: '2024-04-01',
|
|
due_date: '2024-06-01', // 14 days overdue
|
|
total: 3000,
|
|
paid_amount: 1000,
|
|
currency: 'SEK',
|
|
status: 'overdue',
|
|
},
|
|
// Customer B: 90+ days overdue
|
|
{
|
|
id: 'inv-3',
|
|
customer_id: 'cust-b',
|
|
customer: { id: 'cust-b', name: 'Beta Corp' },
|
|
invoice_number: 'F003',
|
|
invoice_date: '2024-01-01',
|
|
due_date: '2024-02-01', // 135 days overdue
|
|
total: 10000,
|
|
paid_amount: 0,
|
|
currency: 'SEK',
|
|
status: 'overdue',
|
|
},
|
|
],
|
|
error: null,
|
|
},
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1', asOfDate)
|
|
|
|
expect(report.unpaid_count).toBe(3)
|
|
expect(report.entries).toHaveLength(2)
|
|
|
|
// Sorted by total outstanding descending: Beta Corp (10000), then Acme (7000)
|
|
expect(report.entries[0].customer_name).toBe('Beta Corp')
|
|
expect(report.entries[0].total_outstanding).toBe(10000)
|
|
expect(report.entries[0].days_90_plus).toBe(10000)
|
|
|
|
expect(report.entries[1].customer_name).toBe('Acme AB')
|
|
expect(report.entries[1].total_outstanding).toBe(7000)
|
|
expect(report.entries[1].current).toBe(5000) // inv-1
|
|
expect(report.entries[1].days_1_30).toBe(2000) // inv-2 (3000 - 1000 paid)
|
|
expect(report.entries[1].invoices).toHaveLength(2)
|
|
|
|
// Totals
|
|
expect(report.total_outstanding).toBe(17000)
|
|
expect(report.total_current).toBe(5000)
|
|
expect(report.total_overdue).toBe(12000)
|
|
})
|
|
|
|
it('computes outstanding as total minus paid_amount', async () => {
|
|
results = [
|
|
{
|
|
data: [
|
|
{
|
|
id: 'inv-1',
|
|
customer_id: 'cust-a',
|
|
customer: { id: 'cust-a', name: 'Test AB' },
|
|
invoice_number: 'F001',
|
|
invoice_date: '2024-06-01',
|
|
due_date: '2024-07-01',
|
|
total: 10000,
|
|
paid_amount: 7500,
|
|
currency: 'SEK',
|
|
status: 'sent',
|
|
},
|
|
],
|
|
error: null,
|
|
},
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1', '2024-06-15')
|
|
|
|
expect(report.entries[0].invoices[0].outstanding).toBe(2500)
|
|
expect(report.total_outstanding).toBe(2500)
|
|
})
|
|
|
|
it('sorts invoices within customer by due_date', async () => {
|
|
results = [
|
|
{
|
|
data: [
|
|
{
|
|
id: 'inv-2',
|
|
customer_id: 'cust-a',
|
|
customer: { id: 'cust-a', name: 'Test AB' },
|
|
invoice_number: 'F002',
|
|
invoice_date: '2024-05-01',
|
|
due_date: '2024-07-01',
|
|
total: 1000,
|
|
paid_amount: 0,
|
|
currency: 'SEK',
|
|
status: 'sent',
|
|
},
|
|
{
|
|
id: 'inv-1',
|
|
customer_id: 'cust-a',
|
|
customer: { id: 'cust-a', name: 'Test AB' },
|
|
invoice_number: 'F001',
|
|
invoice_date: '2024-04-01',
|
|
due_date: '2024-06-01',
|
|
total: 2000,
|
|
paid_amount: 0,
|
|
currency: 'SEK',
|
|
status: 'sent',
|
|
},
|
|
],
|
|
error: null,
|
|
},
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1', '2024-05-15')
|
|
|
|
// Sorted by due_date: F001 (June 1) before F002 (July 1)
|
|
expect(report.entries[0].invoices[0].invoice_number).toBe('F001')
|
|
expect(report.entries[0].invoices[1].invoice_number).toBe('F002')
|
|
})
|
|
|
|
it('aggregates foreign-currency invoices into SEK aging buckets but preserves original currency on detail rows', async () => {
|
|
// The aging totals reconcile against account 1510 (SEK), but the per-invoice
|
|
// detail row keeps `outstanding` in invoice currency for display.
|
|
results = [
|
|
{
|
|
data: [
|
|
// 225 EUR at 11 → 2 475 SEK
|
|
{
|
|
id: 'inv-1',
|
|
customer_id: 'cust-a',
|
|
customer: { id: 'cust-a', name: 'Foreign AB' },
|
|
invoice_number: 'F100',
|
|
invoice_date: '2024-05-01',
|
|
due_date: '2024-06-01', // 14 days overdue at 2024-06-15
|
|
total: 225,
|
|
paid_amount: 0,
|
|
currency: 'EUR',
|
|
exchange_rate: 11,
|
|
status: 'overdue',
|
|
},
|
|
// 1 000 SEK (control)
|
|
{
|
|
id: 'inv-2',
|
|
customer_id: 'cust-a',
|
|
customer: { id: 'cust-a', name: 'Foreign AB' },
|
|
invoice_number: 'F101',
|
|
invoice_date: '2024-05-01',
|
|
due_date: '2024-06-01',
|
|
total: 1000,
|
|
paid_amount: 0,
|
|
currency: 'SEK',
|
|
exchange_rate: null,
|
|
status: 'overdue',
|
|
},
|
|
],
|
|
error: null,
|
|
},
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1', '2024-06-15')
|
|
|
|
const entry = report.entries[0]
|
|
// Aging bucket sums in SEK: 2 475 + 1 000 = 3 475
|
|
expect(entry.days_1_30).toBe(3475)
|
|
expect(entry.total_outstanding).toBe(3475)
|
|
|
|
// Per-invoice detail keeps original currency for display, with the
|
|
// converted SEK value alongside so callers don't accidentally mix.
|
|
const eurInv = entry.invoices.find(i => i.invoice_number === 'F100')!
|
|
expect(eurInv.outstanding).toBe(225)
|
|
expect(eurInv.currency).toBe('EUR')
|
|
expect(eurInv.outstanding_sek).toBe(2475)
|
|
|
|
const sekInv = entry.invoices.find(i => i.invoice_number === 'F101')!
|
|
expect(sekInv.outstanding_sek).toBe(1000)
|
|
|
|
expect(report.total_outstanding).toBe(3475)
|
|
expect(report.unconverted_fx_count).toBe(0)
|
|
})
|
|
|
|
it('lists FX invoices without exchange_rate but excludes them from totals (outstanding_sek = null)', async () => {
|
|
results = [
|
|
{
|
|
data: [
|
|
// 100 EUR with no rate: listed in detail but excluded from buckets
|
|
{
|
|
id: 'inv-1',
|
|
customer_id: 'cust-a',
|
|
customer: { id: 'cust-a', name: 'Foreign AB' },
|
|
invoice_number: 'F200',
|
|
invoice_date: '2024-05-01',
|
|
due_date: '2024-06-01',
|
|
total: 100,
|
|
paid_amount: 0,
|
|
currency: 'EUR',
|
|
exchange_rate: null,
|
|
status: 'overdue',
|
|
},
|
|
// 500 SEK control
|
|
{
|
|
id: 'inv-2',
|
|
customer_id: 'cust-a',
|
|
customer: { id: 'cust-a', name: 'Foreign AB' },
|
|
invoice_number: 'F201',
|
|
invoice_date: '2024-05-01',
|
|
due_date: '2024-06-01',
|
|
total: 500,
|
|
paid_amount: 0,
|
|
currency: 'SEK',
|
|
exchange_rate: null,
|
|
status: 'overdue',
|
|
},
|
|
],
|
|
error: null,
|
|
},
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1', '2024-06-15')
|
|
|
|
expect(report.unconverted_fx_count).toBe(1)
|
|
// EUR row excluded from total: only the 500 SEK invoice contributes
|
|
expect(report.total_outstanding).toBe(500)
|
|
|
|
const entry = report.entries[0]
|
|
expect(entry.total_outstanding).toBe(500)
|
|
// Both detail rows are still visible to the user
|
|
expect(entry.invoices).toHaveLength(2)
|
|
const eurInv = entry.invoices.find(i => i.invoice_number === 'F200')!
|
|
expect(eurInv.outstanding).toBe(100)
|
|
expect(eurInv.outstanding_sek).toBeNull()
|
|
})
|
|
|
|
it('uses Math.round for monetary precision', async () => {
|
|
results = [
|
|
{
|
|
data: [
|
|
{
|
|
id: 'inv-1',
|
|
customer_id: 'cust-a',
|
|
customer: { id: 'cust-a', name: 'Test' },
|
|
invoice_number: 'F001',
|
|
invoice_date: '2024-06-01',
|
|
due_date: '2024-07-01',
|
|
total: 100.1,
|
|
paid_amount: 33.33,
|
|
currency: 'SEK',
|
|
status: 'sent',
|
|
},
|
|
],
|
|
error: null,
|
|
},
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1', '2024-06-15')
|
|
expect(report.entries[0].invoices[0].outstanding).toBe(66.77)
|
|
expect(report.total_outstanding).toBe(66.77)
|
|
})
|
|
|
|
it('nets a credited invoice with its credit note to zero outstanding', async () => {
|
|
// Original was sent (unpaid) and then fully credited.
|
|
// Journal-level AR is 0; the ledger should match.
|
|
results = [
|
|
{
|
|
data: [
|
|
{
|
|
id: 'inv-1',
|
|
customer_id: 'cust-a',
|
|
customer: { id: 'cust-a', name: 'Test AB' },
|
|
invoice_number: '2026001',
|
|
invoice_date: '2026-05-05',
|
|
due_date: '2026-06-05',
|
|
total: 1241.25,
|
|
paid_amount: 0,
|
|
currency: 'SEK',
|
|
status: 'credited',
|
|
},
|
|
{
|
|
id: 'inv-2',
|
|
customer_id: 'cust-a',
|
|
customer: { id: 'cust-a', name: 'Test AB' },
|
|
invoice_number: 'KR-2026001',
|
|
invoice_date: '2026-05-05',
|
|
due_date: '2026-05-05',
|
|
total: -1241.25,
|
|
paid_amount: 0,
|
|
currency: 'SEK',
|
|
status: 'sent',
|
|
credited_invoice_id: 'inv-1',
|
|
},
|
|
],
|
|
error: null,
|
|
},
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1', '2026-05-05')
|
|
|
|
expect(report.entries).toEqual([])
|
|
expect(report.total_outstanding).toBe(0)
|
|
expect(report.total_current).toBe(0)
|
|
expect(report.total_overdue).toBe(0)
|
|
expect(report.unpaid_count).toBe(0)
|
|
})
|
|
|
|
it('keeps a customer whose open invoices are all unconvertible FX', async () => {
|
|
// Every open invoice lacks an exchange_rate, so nothing reached the aging
|
|
// buckets and the customer's SEK total is 0. That 0 means "unknown", not
|
|
// "settled": the rows are counted in unconverted_fx_count, so they have to
|
|
// be reachable somewhere. Dropping the customer made the PDF/XLSX/web view
|
|
// claim N invoices lack a rate while showing none of them.
|
|
results = [
|
|
{
|
|
data: [
|
|
{
|
|
id: 'inv-1',
|
|
customer_id: 'cust-fx',
|
|
customer: { id: 'cust-fx', name: 'Foreign Only AB' },
|
|
invoice_number: 'F300',
|
|
invoice_date: '2024-05-01',
|
|
due_date: '2024-06-01',
|
|
total: 800,
|
|
paid_amount: 0,
|
|
currency: 'EUR',
|
|
exchange_rate: null,
|
|
status: 'overdue',
|
|
},
|
|
],
|
|
error: null,
|
|
},
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1', '2024-06-15')
|
|
|
|
expect(report.unconverted_fx_count).toBe(1)
|
|
expect(report.entries).toHaveLength(1)
|
|
|
|
const entry = report.entries[0]
|
|
expect(entry.customer_name).toBe('Foreign Only AB')
|
|
// Excluded from the SEK totals, but visible.
|
|
expect(entry.total_outstanding).toBe(0)
|
|
expect(entry.invoices).toHaveLength(1)
|
|
expect(entry.invoices[0].outstanding).toBe(800)
|
|
expect(entry.invoices[0].currency).toBe('EUR')
|
|
expect(entry.invoices[0].outstanding_sek).toBeNull()
|
|
|
|
// The unconvertible invoice is still an open item.
|
|
expect(report.total_outstanding).toBe(0)
|
|
expect(report.unpaid_count).toBe(1)
|
|
})
|
|
|
|
it('separates "nets to zero" from "all unconvertible" in the same report', async () => {
|
|
// Two customers both end at total_outstanding 0 for opposite reasons.
|
|
// The settled one must stay suppressed; the unconvertible one must not.
|
|
results = [
|
|
{
|
|
data: [
|
|
// Customer A: invoice + credit note, genuinely settled.
|
|
{
|
|
id: 'inv-1',
|
|
customer_id: 'cust-net',
|
|
customer: { id: 'cust-net', name: 'Netted AB' },
|
|
invoice_number: '2026001',
|
|
invoice_date: '2026-05-05',
|
|
due_date: '2026-06-05',
|
|
total: 2000,
|
|
paid_amount: 0,
|
|
currency: 'SEK',
|
|
status: 'credited',
|
|
},
|
|
{
|
|
id: 'inv-2',
|
|
customer_id: 'cust-net',
|
|
customer: { id: 'cust-net', name: 'Netted AB' },
|
|
invoice_number: 'KR-2026001',
|
|
invoice_date: '2026-05-05',
|
|
due_date: '2026-05-05',
|
|
total: -2000,
|
|
paid_amount: 0,
|
|
currency: 'SEK',
|
|
status: 'sent',
|
|
credited_invoice_id: 'inv-1',
|
|
},
|
|
// Customer B: one open USD invoice, no rate.
|
|
{
|
|
id: 'inv-3',
|
|
customer_id: 'cust-fx',
|
|
customer: { id: 'cust-fx', name: 'Foreign Only AB' },
|
|
invoice_number: 'F400',
|
|
invoice_date: '2026-05-05',
|
|
due_date: '2026-06-05',
|
|
total: 1500,
|
|
paid_amount: 0,
|
|
currency: 'USD',
|
|
exchange_rate: null,
|
|
status: 'sent',
|
|
},
|
|
],
|
|
error: null,
|
|
},
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1', '2026-05-05')
|
|
|
|
expect(report.entries.map((e) => e.customer_name)).toEqual(['Foreign Only AB'])
|
|
expect(report.unconverted_fx_count).toBe(1)
|
|
expect(report.total_outstanding).toBe(0)
|
|
})
|
|
|
|
it('keeps a credit note outstanding when it offsets an already-paid invoice', async () => {
|
|
// Original was paid in full, then credited: we owe the customer the refund.
|
|
results = [
|
|
{
|
|
data: [
|
|
{
|
|
id: 'inv-1',
|
|
customer_id: 'cust-a',
|
|
customer: { id: 'cust-a', name: 'Test AB' },
|
|
invoice_number: '2026001',
|
|
invoice_date: '2026-04-01',
|
|
due_date: '2026-05-01',
|
|
total: 1000,
|
|
paid_amount: 1000,
|
|
currency: 'SEK',
|
|
status: 'credited',
|
|
},
|
|
{
|
|
id: 'inv-2',
|
|
customer_id: 'cust-a',
|
|
customer: { id: 'cust-a', name: 'Test AB' },
|
|
invoice_number: 'KR-2026001',
|
|
invoice_date: '2026-05-05',
|
|
due_date: '2026-05-05',
|
|
total: -1000,
|
|
paid_amount: 0,
|
|
currency: 'SEK',
|
|
status: 'sent',
|
|
credited_invoice_id: 'inv-1',
|
|
},
|
|
],
|
|
error: null,
|
|
},
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1', '2026-05-05')
|
|
|
|
expect(report.entries).toHaveLength(1)
|
|
expect(report.entries[0].total_outstanding).toBe(-1000)
|
|
expect(report.total_outstanding).toBe(-1000)
|
|
expect(report.unpaid_count).toBe(1)
|
|
})
|
|
|
|
it('handles missing customer name gracefully', async () => {
|
|
results = [
|
|
{
|
|
data: [
|
|
{
|
|
id: 'inv-1',
|
|
customer_id: 'cust-a',
|
|
customer: null,
|
|
invoice_number: 'F001',
|
|
invoice_date: '2024-06-01',
|
|
due_date: '2024-07-01',
|
|
total: 1000,
|
|
paid_amount: 0,
|
|
currency: 'SEK',
|
|
status: 'sent',
|
|
},
|
|
],
|
|
error: null,
|
|
},
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1', '2024-06-15')
|
|
expect(report.entries[0].customer_name).toBe('Okänd kund')
|
|
})
|
|
})
|
|
|
|
describe('generateARLedger: historical as-of reconstruction (#1020)', () => {
|
|
const invoiceBase = {
|
|
customer_id: 'cust-a',
|
|
customer: { id: 'cust-a', name: 'Acme AB' },
|
|
invoice_date: '2024-05-01',
|
|
due_date: '2024-06-01',
|
|
currency: 'SEK',
|
|
}
|
|
|
|
it('reopens an invoice whose payment came after the as-of date', async () => {
|
|
results = [
|
|
// Query 1: invoices (historical path also fetches status='paid')
|
|
{
|
|
data: [
|
|
{ ...invoiceBase, id: 'inv-1', invoice_number: 'F001', total: 5000, paid_amount: 5000, paid_at: '2024-07-01T10:00:00Z', status: 'paid' },
|
|
],
|
|
error: null,
|
|
},
|
|
// Query 2: payment rows: the payment is dated after the as-of date
|
|
{
|
|
data: [{ invoice_id: 'inv-1', amount: 5000, payment_date: '2024-07-01' }],
|
|
error: null,
|
|
},
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1', '2024-06-15')
|
|
|
|
expect(report.entries).toHaveLength(1)
|
|
expect(report.entries[0].invoices[0].outstanding).toBe(5000)
|
|
expect(report.entries[0].invoices[0].paid_amount).toBe(0)
|
|
expect(report.total_outstanding).toBe(5000)
|
|
expect(report.unpaid_count).toBe(1)
|
|
})
|
|
|
|
it('reduces outstanding by payments made on or before the as-of date only', async () => {
|
|
results = [
|
|
{
|
|
data: [
|
|
{ ...invoiceBase, id: 'inv-1', invoice_number: 'F001', total: 10000, paid_amount: 10000, paid_at: '2024-07-05T10:00:00Z', status: 'paid' },
|
|
],
|
|
error: null,
|
|
},
|
|
{
|
|
data: [
|
|
{ invoice_id: 'inv-1', amount: 4000, payment_date: '2024-06-10' },
|
|
{ invoice_id: 'inv-1', amount: 6000, payment_date: '2024-07-05' },
|
|
],
|
|
error: null,
|
|
},
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1', '2024-06-15')
|
|
|
|
expect(report.entries[0].invoices[0].paid_amount).toBe(4000)
|
|
expect(report.entries[0].invoices[0].outstanding).toBe(6000)
|
|
expect(report.total_outstanding).toBe(6000)
|
|
})
|
|
|
|
it('skips invoices already settled by the as-of date', async () => {
|
|
results = [
|
|
{
|
|
data: [
|
|
// Settled before the as-of date: must not appear at all.
|
|
{ ...invoiceBase, id: 'inv-1', invoice_number: 'F001', total: 1000, paid_amount: 1000, paid_at: '2024-06-01T10:00:00Z', status: 'paid' },
|
|
// Still open: the only row in the report.
|
|
{ ...invoiceBase, id: 'inv-2', invoice_number: 'F002', total: 2000, paid_amount: 0, status: 'sent' },
|
|
],
|
|
error: null,
|
|
},
|
|
{ data: [], error: null },
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1', '2024-06-15')
|
|
|
|
expect(report.entries).toHaveLength(1)
|
|
expect(report.entries[0].invoices).toHaveLength(1)
|
|
expect(report.entries[0].invoices[0].invoice_number).toBe('F002')
|
|
expect(report.total_outstanding).toBe(2000)
|
|
expect(report.unpaid_count).toBe(1)
|
|
})
|
|
|
|
it('falls back to paid_at for fully paid invoices without payment rows', async () => {
|
|
results = [
|
|
{
|
|
data: [
|
|
// No payment rows, but paid_at says the payment came after the
|
|
// as-of date: the invoice was open on that date.
|
|
{ ...invoiceBase, id: 'inv-1', invoice_number: 'F001', total: 3000, paid_amount: 3000, paid_at: '2024-08-01T10:00:00Z', status: 'paid' },
|
|
],
|
|
error: null,
|
|
},
|
|
{ data: [], error: null },
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1', '2024-06-15')
|
|
|
|
expect(report.entries).toHaveLength(1)
|
|
expect(report.entries[0].invoices[0].outstanding).toBe(3000)
|
|
expect(report.total_outstanding).toBe(3000)
|
|
})
|
|
|
|
it('keeps stored paid_amount for undateable legacy partial payments', async () => {
|
|
results = [
|
|
{
|
|
data: [
|
|
// No payment rows and no paid_at: the stored partial amount cannot
|
|
// be dated, so it is assumed to have stood at the as-of date.
|
|
{ ...invoiceBase, id: 'inv-1', invoice_number: 'F001', total: 3000, paid_amount: 1000, status: 'sent' },
|
|
],
|
|
error: null,
|
|
},
|
|
{ data: [], error: null },
|
|
]
|
|
|
|
const report = await generateARLedger(supabase, 'company-1', '2024-06-15')
|
|
|
|
expect(report.entries[0].invoices[0].outstanding).toBe(2000)
|
|
expect(report.total_outstanding).toBe(2000)
|
|
})
|
|
})
|