Files
accounted/components/import/BankFileImportHistory.tsx
T
Mattsson 47c039453c feat(import): undo a bank file import including ignored transactions (#1764)
* feat(import): undo a bank file import including ignored transactions (#1672)

A mis-parsed bank CSV could not be cleaned up: re-importing dedup-skips
the bad rows, the single-row DELETE refuses imported rows by design
(TRANSACTION_DELETE_IMPORTED), and there was no bulk action. Transactions
also never recorded which import batch inserted them, so a strictly
scoped undo was impossible.

- transactions.bank_file_import_id: batch link stamped at ingest by both
  bank-file import paths (dashboard execute route, v1 REST route). PSD2/
  manual/MCP rows stay NULL. No retroactive backfill: fuzzy attribution
  could delete rows belonging to a different import.
- undo_bank_file_import RPC: owner/admin-only bulk delete of the batch's
  unbooked rows, ignored INCLUDED. Booked rows (journal link, payment
  rows, voucher links) and rows with append-only payment_match_log
  history are skipped and reported, mirroring the single-row route's
  guards. Marks the import 'undone' (re-import reuses the row via the
  company_id+file_hash upsert), writes one audit_log summary row, and
  hardens the actor gate like undo_sie_import: p_user_id honored only
  for service_role callers, 42501 otherwise, no anon EXECUTE.
- DELETE /api/import/bank-file/[id]/undo returns the deletion report;
  RPC 42501 maps to BANK_FILE_UNDO_FORBIDDEN (403).

Closes #1672

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Emil <emilmattsson14@gmail.com>

* fix(import): return 404 when the bank-file undo target does not exist

An unknown or out-of-company import id answered 400 BANK_FILE_UNDO_FAILED,
hiding the not-found semantics the SIE import routes already expose
('Import not found', 404). Flag the case in undoBankFileImport (notFound)
and map it to a new BANK_FILE_UNDO_NOT_FOUND structured error (404);
status-refusals and RPC failures keep the 400 envelope.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Emil <emilmattsson14@gmail.com>

* feat(import): show bank file import history with undo on the import tab

The undo shipped for issue #1672 was API-only: no surface listed a
company's bank_file_imports, so neither users nor founders could reach
DELETE /api/import/bank-file/[id]/undo, and the deletion report existed
only in JSON. Mirror the SIE pattern (SIEImportHistory, #1574):

- GET /api/import/bank-file: list the company's imports newest-first,
  same { data, count, limit, offset } shape as GET /api/import/sie.
- BankFileImportHistory: fold-open 'Tidigare bankfilsimporter' row on
  the Importera tab with filename, date, format, imported count and
  status per import, plus an undo action on completed rows behind a
  DestructiveConfirmDialog. The undo stays owner/admin-only via the
  undo_bank_file_import RPC's actor gate, like the SIE one.
- After undo the toast shows the full report: transactions removed,
  booked rows skipped, rows with match history skipped, so nothing
  disappears silently from the ledger's surroundings.
- i18n strings in messages/sv.json and messages/en.json following the
  sie_history_* key style; list-route test mirroring the SIE list test.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Emil <emilmattsson14@gmail.com>

* chore(migrations): move undo_bank_file_import after main's 2026-08-19 migrations

Signed-off-by: Emil <emilmattsson14@gmail.com>

* fix(import): validate bank-file list params, fail closed on undo lookup, log lost batch attribution

Review findings on #1764 (CodeRabbit):
- GET /api/import/bank-file rejects non-integer/negative/oversized limit
  and offset and unknown status with a mapped 400
  (BANK_FILE_LIST_INVALID_QUERY), limit capped at 100; boundary and
  invalid-input tests added.
- undoBankFileImport distinguishes PGRST116 (zero rows -> notFound/404)
  from other lookup failures, which now return an error instead of
  masquerading as a permanent 404.
- The v1 import route no longer discards the bank_file_imports upsert
  error: kept non-fatal by design (an unattributed batch imports fine and
  never appears in undo history), but the failure is now logged loudly.
- Route test beforeEach clears the event bus (repo convention).

Signed-off-by: Emil <emilmattsson14@gmail.com>

---------

Signed-off-by: Emil <emilmattsson14@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-20 21:25:18 +02:00

253 lines
8.5 KiB
TypeScript

'use client'
import { useCallback, useEffect, useState } from 'react'
import { useTranslations } from 'next-intl'
import { Undo2 } from 'lucide-react'
import { Badge } from '@/components/ui/badge'
import { Button } from '@/components/ui/button'
import { Skeleton } from '@/components/ui/skeleton'
import { useToast } from '@/components/ui/use-toast'
import { DestructiveConfirmDialog } from '@/components/ui/destructive-confirm-dialog'
import { TH_CLASS, TD_CLASS } from '@/components/ui/dry-table'
import { getErrorMessage } from '@/lib/errors/get-error-message'
import { getFormat } from '@/lib/import/bank-file/parser'
import type { BankFileFormatId } from '@/lib/import/bank-file/types'
import { cn, formatDate } from '@/lib/utils'
/**
* Subset of the bank_file_imports row (GET /api/import/bank-file) actually
* rendered here. `status` stays a plain string: unknown values fall back to
* raw muted text instead of crashing on a missing translation key (same
* defensive shape as SIEImportHistory).
*/
interface BankFileImportListRow {
id: string
filename: string
file_format: string
imported_count: number
status: string
created_at: string
}
const STATUS_LABEL_KEY: Record<string, string> = {
completed: 'bankfile_history_status_completed',
undone: 'bankfile_history_status_undone',
failed: 'bankfile_history_status_failed',
pending: 'bankfile_history_status_pending',
processing: 'bankfile_history_status_processing',
}
/**
* Chips mark exceptions (design.md convention 5): the normal 'completed'
* state renders as muted text; only deviating states get a Badge.
*/
const STATUS_BADGE_VARIANT: Record<string, 'secondary' | 'warning' | 'destructive'> = {
undone: 'secondary',
failed: 'destructive',
pending: 'warning',
processing: 'warning',
}
/**
* The undo report returned by DELETE /api/import/bank-file/[id]/undo:
* deleted rows plus what was deliberately left alone (booked rows are
* räkenskapsinformation; rows with payment_match_log history keep their
* append-only log).
*/
interface UndoReport {
deletedTransactions?: number
skippedBooked?: number
skippedMatchHistory?: number
}
/**
* History of past bank file imports with per-row undo for completed ones.
* Rendered fold-open from the 'Tidigare bankfilsimporter' row on the import
* tab; mirrors SIEImportHistory. The undo itself is owner/admin-only,
* enforced server-side by the undo_bank_file_import RPC's actor gate.
*/
export default function BankFileImportHistory() {
const t = useTranslations('import')
const { toast } = useToast()
const [rows, setRows] = useState<BankFileImportListRow[] | null>(null)
const [loadFailed, setLoadFailed] = useState(false)
const [pendingUndo, setPendingUndo] = useState<BankFileImportListRow | null>(null)
const fetchImports = useCallback(async () => {
try {
const res = await fetch('/api/import/bank-file?limit=20')
if (!res.ok) {
setLoadFailed(true)
return
}
const data = await res.json()
setRows(Array.isArray(data.data) ? data.data : [])
setLoadFailed(false)
} catch {
setLoadFailed(true)
}
}, [])
useEffect(() => {
void fetchImports()
}, [fetchImports])
// Deliberately no client-side timeout: undoing a large import can take
// minutes (the route runs with maxDuration 300) and the confirm dialog
// stays open with its spinner until this resolves.
const handleUndoConfirm = useCallback(async () => {
if (!pendingUndo) return
try {
const res = await fetch(`/api/import/bank-file/${pendingUndo.id}/undo`, {
method: 'DELETE',
})
const data = await res.json()
if (!res.ok) {
toast({
title: t('bankfile_history_undo_failed'),
description: getErrorMessage(data),
variant: 'destructive',
})
return
}
// The full report, clearly: X removed, and any rows the undo refused
// to touch (booked / match history) so nothing disappears silently.
const report = data as UndoReport
const skippedBooked = report.skippedBooked ?? 0
const skippedMatchHistory = report.skippedMatchHistory ?? 0
const parts = [
t('bankfile_history_undo_success_deleted', {
count: report.deletedTransactions ?? 0,
}),
]
if (skippedBooked > 0) {
parts.push(t('bankfile_history_undo_skipped_booked', { count: skippedBooked }))
}
if (skippedMatchHistory > 0) {
parts.push(
t('bankfile_history_undo_skipped_match_history', { count: skippedMatchHistory }),
)
}
toast({
title: t('bankfile_history_undo_success_title'),
description: parts.join(' '),
})
await fetchImports()
} catch (err) {
toast({
title: t('bankfile_history_undo_failed'),
description: getErrorMessage(err),
variant: 'destructive',
})
}
}, [pendingUndo, fetchImports, t, toast])
// 'swedbank' → 'Swedbank' via the format registry; unknown ids (a format
// removed from the registry) fall back to the raw stored code.
const formatLabel = (row: BankFileImportListRow): string =>
getFormat(row.file_format as BankFileFormatId)?.name ?? row.file_format
const statusCell = (status: string) => {
const labelKey = STATUS_LABEL_KEY[status]
const label = labelKey ? t(labelKey) : status
const variant = STATUS_BADGE_VARIANT[status]
if (!variant) {
return <span className="text-xs text-muted-foreground">{label}</span>
}
return (
<Badge variant={variant} className="font-normal">
{label}
</Badge>
)
}
if (loadFailed) {
return (
<p className="px-1 text-xs leading-5 text-muted-foreground">
{t('bankfile_history_load_error')}
</p>
)
}
if (rows === null) {
return (
<div className="space-y-2" role="status">
<Skeleton className="h-8 w-full" />
<Skeleton className="h-8 w-full" />
<Skeleton className="h-8 w-full" />
</div>
)
}
if (rows.length === 0) {
return (
<p className="px-1 text-xs leading-5 text-muted-foreground">
{t('bankfile_history_empty')}
</p>
)
}
return (
<div>
<div className="overflow-x-auto">
<table className="w-full border-collapse text-[13px]">
<thead>
<tr>
<th className={TH_CLASS}>{t('bankfile_history_col_file')}</th>
<th className={TH_CLASS}>{t('bankfile_history_col_date')}</th>
<th className={TH_CLASS}>{t('bankfile_history_col_format')}</th>
<th className={cn(TH_CLASS, 'text-right')}>
{t('bankfile_history_col_transactions')}
</th>
<th className={TH_CLASS}>{t('bankfile_history_col_status')}</th>
<th className={TH_CLASS}>
<span className="sr-only">{t('bankfile_history_undo_button')}</span>
</th>
</tr>
</thead>
<tbody className="stagger-enter">
{rows.map((row) => (
<tr key={row.id} className="transition-colors duration-150 hover:bg-secondary/35">
<td className={TD_CLASS}>{row.filename}</td>
<td className={cn(TD_CLASS, 'whitespace-nowrap tabular-nums')}>
{formatDate(row.created_at)}
</td>
<td className={cn(TD_CLASS, 'whitespace-nowrap')}>{formatLabel(row)}</td>
<td className={cn(TD_CLASS, 'text-right tabular-nums')}>{row.imported_count}</td>
<td className={TD_CLASS}>{statusCell(row.status)}</td>
<td className={cn(TD_CLASS, 'text-right')}>
{row.status === 'completed' && (
<Button
variant="outline"
size="sm"
className="text-destructive hover:text-destructive"
onClick={() => setPendingUndo(row)}
>
<Undo2 className="mr-2 h-4 w-4" />
{t('bankfile_history_undo_button')}
</Button>
)}
</td>
</tr>
))}
</tbody>
</table>
</div>
<DestructiveConfirmDialog
open={pendingUndo !== null}
onOpenChange={(open) => {
if (!open) setPendingUndo(null)
}}
title={t('bankfile_history_undo_confirm_title')}
description={t('bankfile_history_undo_confirm_description')}
confirmLabel={t('bankfile_history_undo_confirm_label')}
onConfirm={handleUndoConfirm}
/>
</div>
)
}