Files
accounted/app/api/auth/heartbeat/route.ts
T
MattssonandClaude Fable 5 11995b1b0c feat(auth): make automatic logout an opt-in per-user setting (#1536)
* feat(auth): make automatic logout an opt-in per-user setting

Session timeouts (30 min idle / 12 h absolute on hosted) now apply only
to users who enable "Automatic logout" in Settings > Security. Default
is off: sessions live for the full Supabase refresh-token lifetime, the
behavior from before the 2026-07 session hardening.

- user_preferences.auto_logout (migration, default false), toggled via
  the extended /api/user/preferences route
- The opt-in is snapshotted into the signed timeout cookie at mint, so
  enforcement stays DB-read-free per request; the preferences route
  clears the cookie on change so a toggle takes effect immediately
- Pre-toggle cookies are authentic-but-stale: re-minted preserving
  their timers, never routed down the tamper path, so the rollout does
  not log anyone out
- NEXT_PUBLIC_SESSION_TIMEOUT_FORCE_ALL=true enforces timeouts for
  every user regardless of preference (emergency lever, also plumbed
  through the Docker image); self-hosted stays disabled by default

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(auth): resolve PR #1536 review findings

- Replace the spread upsert in /api/user/preferences with one literal
  payload per field: the phantom-column schema guard cannot resolve
  spread payloads (Unit tests 3/4 ceiling failure)
- Map the preferences 500 through getErrorMessage so the user-facing
  text is Swedish (CodeRabbit)
- fetchAutoLogoutPreference now returns null on a FAILED read instead
  of a fail-open false: callers skip minting so an unknown preference
  is never persisted into the year-long signed cookie, and the next
  request retries; failures log at error level, distinct from the
  normal opt-out path (compliance swarm GDPR Art.32(1)(b) / ISO A.8.5)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(auth): write multi-field preference updates as one atomic upsert

A request carrying both hide_assistant_fab and auto_logout previously
issued two sequential writes, so a failure of the second returned 500
after half the request had persisted (CodeRabbit, PR #1536). One
literal upsert per accepted field combination keeps the write atomic
and stays resolvable for the phantom-column schema guard.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-12 16:45:41 +02:00

146 lines
4.3 KiB
TypeScript

import { cookies } from 'next/headers'
import { NextResponse } from 'next/server'
import type { SupabaseClient } from '@supabase/supabase-js'
import { requireAuth } from '@/lib/auth/require-auth'
import {
createSessionTimeoutState,
evaluateSessionTimeout,
fetchAutoLogoutPreference,
getSessionTimeoutConfig,
sessionStateMatchesUser,
sessionStateNeedsRemint,
sessionTimeoutCookieOptions,
signSessionTimeoutState,
toSessionTimeoutClientState,
verifySessionTimeoutState,
} from '@/lib/auth/session-timeout'
import {
SESSION_AUTH_METHOD_HINT_COOKIE,
SESSION_TIMEOUT_COOKIE,
isSessionAuthMethod,
type SessionTimeoutReason,
} from '@/lib/auth/session-timeout-shared'
export const dynamic = 'force-dynamic'
async function getSessionId(supabase: SupabaseClient): Promise<string | null> {
if (typeof supabase.auth.getClaims !== 'function') return null
try {
const { data } = await supabase.auth.getClaims()
return typeof data?.claims?.session_id === 'string'
? data.claims.session_id
: null
} catch {
return null
}
}
function expiredResponse(reason: SessionTimeoutReason): NextResponse {
const response = NextResponse.json(
{ error: { code: 'SESSION_EXPIRED', reason } },
{ status: 401 },
)
response.headers.set('X-Session-Timeout-Reason', reason)
response.headers.set('Cache-Control', 'no-store')
return response
}
async function heartbeat(updateActivity: boolean): Promise<NextResponse> {
const auth = await requireAuth()
if (auth.error) return auth.error
const config = getSessionTimeoutConfig()
const now = Date.now()
if (!config.enabled) {
return NextResponse.json({
data: {
enabled: false,
idleTimeoutMs: 0,
absoluteTimeoutMs: 0,
warningMs: 0,
serverNow: now,
startedAt: now,
lastActivityAt: now,
method: 'password',
},
})
}
const cookieStore = await cookies()
const encodedState = cookieStore.get(SESSION_TIMEOUT_COOKIE)?.value
const state = await verifySessionTimeoutState(encodedState)
const sessionId = await getSessionId(auth.supabase)
const stateMatches =
state !== null && sessionStateMatchesUser(state, auth.user.id, sessionId)
if (!state || !stateMatches || sessionStateNeedsRemint(state)) {
// Mirror middleware initialization: a missing, session-mismatched, or
// pre-toggle cookie means the timeout state has not been established
// for this session yet, not that the session expired.
const hintedMethod = cookieStore.get(SESSION_AUTH_METHOD_HINT_COOKIE)?.value
const autoLogout = await fetchAutoLogoutPreference(auth.supabase, auth.user.id)
const freshState = state && stateMatches
? { ...state, autoLogout: autoLogout ?? false }
: createSessionTimeoutState({
userId: auth.user.id,
sessionId,
method: isSessionAuthMethod(hintedMethod) ? hintedMethod : 'password',
autoLogout: autoLogout ?? false,
now,
})
const response = NextResponse.json({
data: toSessionTimeoutClientState(freshState, config, now),
})
response.headers.set('Cache-Control', 'no-store')
// Unknown preference (failed read): answer this poll without persisting
// a fail-open snapshot; the next resync retries the read (mirrors the
// middleware).
if (autoLogout !== null) {
const signedFresh = await signSessionTimeoutState(freshState)
if (signedFresh) {
response.cookies.set(
SESSION_TIMEOUT_COOKIE,
signedFresh,
sessionTimeoutCookieOptions(),
)
}
}
return response
}
const reason = evaluateSessionTimeout(state, config, now)
if (reason) return expiredResponse(reason)
const nextState = updateActivity
? { ...state, lastActivityAt: now }
: state
const response = NextResponse.json({
data: toSessionTimeoutClientState(nextState, config, now),
})
response.headers.set('Cache-Control', 'no-store')
if (updateActivity) {
const signedNext = await signSessionTimeoutState(nextState)
if (signedNext) {
response.cookies.set(
SESSION_TIMEOUT_COOKIE,
signedNext,
sessionTimeoutCookieOptions(),
)
}
}
return response
}
export async function GET(): Promise<NextResponse> {
return heartbeat(false)
}
export async function POST(): Promise<NextResponse> {
return heartbeat(true)
}