* fix(reports): stabilize fetchAllRows paging to stop doubled/dropped balances (#790, #791) PostgREST `.range()` paging is only correct when the underlying query has a stable TOTAL order. Several aggregating report queries (general ledger, trial balance, grundbok, supplier/AR ledgers, etc.) paginated without `.order()`, so on datasets larger than one 1000-row page Postgres could return rows in a different order between requests — silently DUPLICATING or SKIPPING rows on a page boundary and doubling or dropping financial totals. - fetch-all.ts: document the ordering invariant and add an optional `dedupeBy` defense-in-depth that drops cross-page duplicates and warns when it fires (surfaces a missing `.order()` in logs instead of corrupting money). - Add a stable `.order()` (line PK or account_number) to every paginated query in lib/reports/ and the account-balances route; pass `dedupeBy` on the money-aggregating line queries. - Add fetch-all unit tests and update report test fixtures to carry row ids. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(api): declare the real { data, meta } envelope on v1 single/write/204 endpoints (#794) The OpenAPI generator derives each endpoint's documented body purely from its registered `response.success` Zod schema, and that schema is never validated at runtime — so a route could advertise a shape its handler never sends. #802 fixed this for list endpoints; the same drift was latent on single-resource and write endpoints, which declared the bare resource schema instead of the `{ data, meta }` envelope the handlers actually return. - registry.ts: extend `ResponseMetaSchema` with the optional `audit` block and `partial_expansions` list that writes/expansions emit; add the `NoBodyResponse` sentinel so 204 DELETE handlers document a bare 204 instead of a phantom 200. - Wrap every single/write endpoint's `response.success` in `dataEnvelope(...)` (or `NoBodyResponse` for 204s) across the v1 routes. - Add a response-envelope contract test that fails CI if any JSON endpoint forgets to wrap its schema, with binary downloads and 204s as the only exemptions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(reports): extend paging dedupeBy to rc-basis-gaps and opening-balances Address PR review: these two money-aggregating line queries already had the stable `.order('id')` (so paging was correct) but didn't carry `id` in the select, so they couldn't use the `dedupeBy` defense-in-depth that general-ledger and trial-balance got. Select `id` and pass `dedupeBy: r => r.id` so the whole report layer applies the ordering invariant consistently. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
139 lines
4.3 KiB
TypeScript
139 lines
4.3 KiB
TypeScript
import type { SupabaseClient } from '@supabase/supabase-js'
|
|
import { fetchAllRows } from '@/lib/supabase/fetch-all'
|
|
import { resolveSekAmount } from '@/lib/bookkeeping/currency-utils'
|
|
|
|
export interface SupplierLedgerEntry {
|
|
supplier_id: string
|
|
supplier_name: string
|
|
current: number
|
|
days_1_30: number
|
|
days_31_60: number
|
|
days_61_90: number
|
|
days_90_plus: number
|
|
total_outstanding: number
|
|
}
|
|
|
|
export interface SupplierLedgerReport {
|
|
entries: SupplierLedgerEntry[]
|
|
total_outstanding: number
|
|
total_current: number
|
|
total_overdue: number
|
|
unpaid_count: number
|
|
/**
|
|
* Number of foreign-currency invoices excluded from the SEK totals because
|
|
* they had no exchange_rate. Adding them would mix currencies; surfacing
|
|
* the count lets the UI tell the user a row could not be converted.
|
|
*/
|
|
unconverted_fx_count: number
|
|
}
|
|
|
|
/**
|
|
* Generate supplier ledger (leverantörsreskontra) with aging analysis
|
|
*/
|
|
export async function generateSupplierLedger(
|
|
supabase: SupabaseClient,
|
|
companyId: string,
|
|
asOfDate?: string
|
|
): Promise<SupplierLedgerReport> {
|
|
const refDate = asOfDate ? new Date(asOfDate) : new Date()
|
|
|
|
// Fetch all unpaid/partially_paid supplier invoices
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
let invoices: any[]
|
|
try {
|
|
invoices = await fetchAllRows(({ from, to }) =>
|
|
supabase
|
|
.from('supplier_invoices')
|
|
.select('*, supplier:suppliers(id, name)')
|
|
.eq('company_id', companyId)
|
|
.in('status', ['registered', 'approved', 'partially_paid', 'overdue'])
|
|
// Stable total order for correct paging (see fetch-all.ts).
|
|
.order('id', { ascending: true })
|
|
.range(from, to)
|
|
)
|
|
} catch {
|
|
return {
|
|
entries: [],
|
|
total_outstanding: 0,
|
|
total_current: 0,
|
|
total_overdue: 0,
|
|
unpaid_count: 0,
|
|
unconverted_fx_count: 0,
|
|
}
|
|
}
|
|
|
|
// Group by supplier and calculate aging
|
|
const bySupplier = new Map<string, SupplierLedgerEntry>()
|
|
let unconvertedFxCount = 0
|
|
|
|
for (const inv of invoices) {
|
|
const supplierId = inv.supplier_id
|
|
const supplierName = inv.supplier?.name || 'Okänd leverantör'
|
|
|
|
// Foreign-currency invoice with no exchange_rate cannot be converted to
|
|
// SEK; adding the raw foreign amount to a SEK total would be unsound, so
|
|
// the row is excluded from sums and only counted.
|
|
const isFx = inv.currency && inv.currency !== 'SEK'
|
|
const hasRate = inv.exchange_rate != null && Number(inv.exchange_rate) > 0
|
|
if (isFx && !hasRate) {
|
|
unconvertedFxCount += 1
|
|
continue
|
|
}
|
|
|
|
if (!bySupplier.has(supplierId)) {
|
|
bySupplier.set(supplierId, {
|
|
supplier_id: supplierId,
|
|
supplier_name: supplierName,
|
|
current: 0,
|
|
days_1_30: 0,
|
|
days_31_60: 0,
|
|
days_61_90: 0,
|
|
days_90_plus: 0,
|
|
total_outstanding: 0,
|
|
})
|
|
}
|
|
|
|
const entry = bySupplier.get(supplierId)!
|
|
const dueDate = new Date(inv.due_date)
|
|
const daysOverdue = Math.floor((refDate.getTime() - dueDate.getTime()) / (1000 * 60 * 60 * 24))
|
|
// remaining_amount is stored in invoice currency. The 2440 GL line was posted
|
|
// in SEK at the invoice-date rate, so we convert here for the reconciliation.
|
|
const amount = resolveSekAmount(
|
|
Number(inv.remaining_amount) || 0,
|
|
null,
|
|
inv.currency,
|
|
inv.exchange_rate
|
|
)
|
|
|
|
if (daysOverdue <= 0) {
|
|
entry.current += amount
|
|
} else if (daysOverdue <= 30) {
|
|
entry.days_1_30 += amount
|
|
} else if (daysOverdue <= 60) {
|
|
entry.days_31_60 += amount
|
|
} else if (daysOverdue <= 90) {
|
|
entry.days_61_90 += amount
|
|
} else {
|
|
entry.days_90_plus += amount
|
|
}
|
|
|
|
entry.total_outstanding += amount
|
|
}
|
|
|
|
const entries = Array.from(bySupplier.values())
|
|
.sort((a, b) => b.total_outstanding - a.total_outstanding)
|
|
|
|
const total_outstanding = entries.reduce((sum, e) => sum + e.total_outstanding, 0)
|
|
const total_current = entries.reduce((sum, e) => sum + e.current, 0)
|
|
const total_overdue = total_outstanding - total_current
|
|
|
|
return {
|
|
entries,
|
|
total_outstanding: Math.round(total_outstanding * 100) / 100,
|
|
total_current: Math.round(total_current * 100) / 100,
|
|
total_overdue: Math.round(total_overdue * 100) / 100,
|
|
unpaid_count: invoices.length,
|
|
unconverted_fx_count: unconvertedFxCount,
|
|
}
|
|
}
|