Jakob Wennberg
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
63 lines
1.8 KiB
TypeScript
63 lines
1.8 KiB
TypeScript
/**
|
|
* Currency conversion helpers for journal entry generators.
|
|
*
|
|
* All journal entry line amounts (debit_amount / credit_amount) must be in SEK.
|
|
* These helpers resolve the correct SEK amount from the various currency fields
|
|
* available on invoices, transactions, and supplier invoices.
|
|
*/
|
|
|
|
/**
|
|
* Resolve the SEK amount for a journal entry line.
|
|
*
|
|
* Priority:
|
|
* 1. If currency is SEK → return amount as-is
|
|
* 2. If amountSek is populated → return it (pre-computed SEK value)
|
|
* 3. If exchangeRate is available → compute amount * exchangeRate
|
|
* 4. Fallback → return amount (legacy data safety: assumes SEK)
|
|
*/
|
|
export function resolveSekAmount(
|
|
amount: number,
|
|
amountSek: number | null | undefined,
|
|
currency: string | null | undefined,
|
|
exchangeRate: number | null | undefined
|
|
): number {
|
|
if (!currency || currency === 'SEK') {
|
|
return amount
|
|
}
|
|
|
|
if (amountSek != null) {
|
|
return Math.round(amountSek * 100) / 100
|
|
}
|
|
|
|
if (exchangeRate != null && exchangeRate > 0) {
|
|
return Math.round(amount * exchangeRate * 100) / 100
|
|
}
|
|
|
|
// Fallback: legacy data without conversion info: return original amount
|
|
return amount
|
|
}
|
|
|
|
/**
|
|
* Build currency metadata fields for a journal entry line.
|
|
* Returns an empty object for SEK transactions (no metadata needed).
|
|
*/
|
|
export function buildCurrencyMetadata(
|
|
currency: string | null | undefined,
|
|
amountInCurrency: number | null | undefined,
|
|
exchangeRate: number | null | undefined
|
|
): {
|
|
currency?: string
|
|
amount_in_currency?: number
|
|
exchange_rate?: number
|
|
} {
|
|
if (!currency || currency === 'SEK') {
|
|
return {}
|
|
}
|
|
|
|
return {
|
|
...(currency ? { currency } : {}),
|
|
...(amountInCurrency != null ? { amount_in_currency: amountInCurrency } : {}),
|
|
...(exchangeRate != null && exchangeRate > 0 ? { exchange_rate: exchangeRate } : {}),
|
|
}
|
|
}
|