Files
accounted/lib/bookkeeping/__tests__/cancel-orphaned-entry.test.ts
T
Jakob WennbergandClaude Sonnet 5 ec27228a8e style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)
Em dashes (—) and en dashes (–) had spread across comments, docs, tests,
and a few UI strings, reading as AI-generated boilerplate rather than
house style. Replaced each with punctuation matching its context: colon
for explanatory clauses, comma for asides, plain hyphen for numeric/legal
ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for
paired-dash asides. messages/en.json and messages/sv.json were fixed by
hand together to keep sv/en in sync.

Left untouched where the dash is the functional subject rather than
decorative punctuation: date-range-parser.ts's separator regex,
charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE
encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the
agent system-prompt files that already instruct against em dashes, and
a golden iXBRL test fixture compared byte-for-byte.

Also fixes two bugs surfaced along the way: an off-by-one in
ApiKeysPanel's scope-label split (a leftover from an earlier partial
pass), and a charset-repair test that had lost the literal en-dash it
exists to verify.

Regenerated the agent atom seed migration (skills:generate) since 27
SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes,
with an explicit carve-out for the functional-dash cases above.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-04 15:58:06 +02:00

113 lines
3.8 KiB
TypeScript

import { describe, it, expect, vi } from 'vitest'
import { cancelOrphanedPaymentEntry } from '../cancel-orphaned-entry'
function createMockSupabase(opts: {
orphan?: { fiscal_period_id: string; voucher_series: string | null; voucher_number: number } | null
cancelError?: { message: string } | null
}) {
const updates: unknown[] = []
const inserts: Record<string, unknown[]> = {}
const supabase = {
from: vi.fn().mockImplementation((table: string) => ({
select: vi.fn().mockReturnValue({
eq: vi.fn().mockReturnValue({
eq: vi.fn().mockReturnValue({
single: vi.fn().mockResolvedValue({
data: opts.orphan ?? null,
error: opts.orphan ? null : { message: 'not found' },
}),
}),
}),
}),
update: vi.fn().mockImplementation((payload: unknown) => {
updates.push(payload)
return {
eq: vi.fn().mockReturnValue({
eq: vi.fn().mockResolvedValue({ error: opts.cancelError ?? null }),
}),
}
}),
insert: vi.fn().mockImplementation((payload: unknown) => {
;(inserts[table] ??= []).push(payload)
return Promise.resolve({ error: null })
}),
})),
}
return { supabase, updates, inserts }
}
describe('cancelOrphanedPaymentEntry', () => {
it('cancels the voucher and records a gap explanation', async () => {
const { supabase, updates, inserts } = createMockSupabase({
orphan: { fiscal_period_id: 'fp-1', voucher_series: 'A', voucher_number: 66 },
})
await cancelOrphanedPaymentEntry(
supabase as never, 'company-1', 'user-1', 'je-1', 'Automatiskt makulerad: test',
)
expect(updates).toEqual([{ status: 'cancelled' }])
const gaps = inserts['voucher_gap_explanations'] as Record<string, unknown>[]
expect(gaps).toHaveLength(1)
expect(gaps[0]).toMatchObject({
company_id: 'company-1',
fiscal_period_id: 'fp-1',
voucher_series: 'A',
gap_number: 66,
explanation: 'Automatiskt makulerad: test',
created_by: 'user-1',
})
})
it('defaults the gap series to A when the voucher has none', async () => {
const { supabase, inserts } = createMockSupabase({
orphan: { fiscal_period_id: 'fp-1', voucher_series: null, voucher_number: 12 },
})
await cancelOrphanedPaymentEntry(
supabase as never, 'company-1', 'user-1', 'je-1', 'x',
)
const gaps = inserts['voucher_gap_explanations'] as Record<string, unknown>[]
expect(gaps[0]).toMatchObject({ voucher_series: 'A' })
})
it('still cancels when the orphan lookup fails, but records no gap', async () => {
const { supabase, updates, inserts } = createMockSupabase({ orphan: null })
await cancelOrphanedPaymentEntry(
supabase as never, 'company-1', 'user-1', 'je-1', 'x',
)
expect(updates).toEqual([{ status: 'cancelled' }])
expect(inserts['voucher_gap_explanations']).toBeUndefined()
})
it('never throws, even when the client rejects unexpectedly', async () => {
const supabase = {
from: vi.fn().mockImplementation(() => {
throw new Error('network blip')
}),
}
await expect(
cancelOrphanedPaymentEntry(supabase as never, 'company-1', 'user-1', 'je-1', 'x'),
).resolves.toBeUndefined()
})
it('does not record a gap when the cancel itself fails', async () => {
const { supabase, inserts } = createMockSupabase({
orphan: { fiscal_period_id: 'fp-1', voucher_series: 'A', voucher_number: 9 },
cancelError: { message: 'period locked' },
})
await cancelOrphanedPaymentEntry(
supabase as never, 'company-1', 'user-1', 'je-1', 'x',
)
// The voucher is still live: a gap explanation would be a lie.
expect(inserts['voucher_gap_explanations']).toBeUndefined()
})
})