Files
accounted/app/api/agent/ask/route.ts
T
6aecbdc9b7 fix(agent): surface empty assistant answers instead of silent stops (#1830)
The support chat showed 'Tänker' and then went quiet with no answer and
no error. Root cause: the 2026-08-21 RIP-3 cutover moved general.help to
the single-call POST /api/agent/ask, whose 1500-token default cap made
stop_reason max_tokens routine on tool-loop turns. The empty answer then
passed unlogged through the service, the route answered 200 with an
empty string, and the console appended an invisible empty bubble.

Fixes, single-call path:
- ask-service: default maxTokens 1500 -> 5400 (the streaming chat's
  reply ceiling); an empty final answer now logs model + usage and
  throws the typed EmptyModelAnswerError instead of passing through.
- /api/agent/ask: maxDuration 300, logger, empty answer maps to 502
  with 'Assistenten gav inget svar. Försök igen.'; an empty assistant
  turn is never persisted (the question stays, so retry works).
- AskConsole: a 200 with an empty answer shows the error box instead of
  appending an invisible bubble.
- anthropic-family: serialized tool results are bounded at 40000 chars
  (mirrors run-turn) so one big read cannot eat the output budget; the
  step-exhausted fallback keeps tools declared with tool_choice none,
  because replaying tool_use/tool_result without tools is an API 400.

Fixes, streaming path (same silent class):
- /api/agent/invoke: maxDuration 300 so deep thinking turns are not
  killed mid-stream at the platform default cap.
- run-turn: stop_reason max_tokens with no visible text emits an error
  event, not a bare turn_complete.
- AgentChat: an NDJSON stream that ends without turn_complete or error
  (and was not aborted) shows 'Anslutningen bröts innan svaret blev
  klart. Försök igen.'

The lib/ai request-shape tests were updated deliberately for the
fallback change; general.help stays on the single-call runtime
(founder decision, not reverted).


Claude-Session: https://claude.ai/code/session_01SyDuePXxUFowaPBKpAv8SF

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-24 13:19:15 +02:00

185 lines
7.4 KiB
TypeScript

import { NextResponse } from 'next/server'
import { z } from 'zod'
import { ensureInitialized } from '@/lib/init'
import { requireAuth } from '@/lib/auth/require-auth'
import { getActiveCompanyId } from '@/lib/company/context'
import { checkAgentRateLimit, agentRateLimitResponseBody } from '@/lib/rate-limits/agent'
import { guardSandbox } from '@/lib/sandbox/guard'
import { requireCapability } from '@/lib/entitlements/has-capability'
import { CAPABILITY } from '@/lib/entitlements/keys'
import { getAiStatus } from '@/lib/ai'
import { createLogger } from '@/lib/logger'
import { answerAssistantQuestion } from '@/lib/agent/ask/ask-service'
import { EmptyModelAnswerError } from '@/lib/agent/ask/errors'
import {
resolveChatConversation,
persistUserTurn,
persistAssistantTurn,
} from '@/lib/agent/ask/persist'
import { getErrorMessage as getUserErrorMessage } from '@/lib/errors/get-error-message'
// The assistant answers over the read-only MCP tools, which are registered
// into the agent tool registry by the mcp-server extension at load. Without
// this the registry is empty and the assistant falls back to snapshot-only,
// so a hosted deploy would silently lose its ledger tools.
ensureInitialized()
const log = createLogger('api.agent.ask')
// A tool-loop answer can take minutes (several model turns, each preceded by
// real report reads). The plan default cap would kill the function mid-answer
// and the client would see a silent empty stop; 300 s matches the other
// long-running model surfaces (app/api/receipt-hunt/run).
export const maxDuration = 300
// The Swedish body AskConsole's !res.ok branch renders verbatim.
const EMPTY_ANSWER_MESSAGE = 'Assistenten gav inget svar. Försök igen.'
/**
* POST /api/agent/ask: a single-call, provider-agnostic assistant answer over a
* bounded read-only tool loop.
*
* Unlike POST /api/agent/invoke (the streaming Anthropic chat runtime, which
* is gated on `assistantAvailable` and only runs on the Anthropic family),
* this endpoint answers through getAiService().generateText, so it runs on ANY
* configured backend, including an OpenAI-compatible local model. It is
* therefore gated on `configured`, not `assistantAvailable`. The service
* attaches the read-only MCP tools so it can fetch real figures (audit Option
* A / rip): a page posts its context and a question, gets one answer back.
*/
const Schema = z.object({
question: z.string().min(1).max(4000),
context: z.string().max(24_000).optional(),
tier: z.enum(['assistant', 'heavy']).optional(),
company_id: z.string().uuid().optional(),
// Chat-console persistence (opt-in). When `persist` is true, the turn is
// written to agent_conversations/agent_messages so the /chat sidebar keeps
// working. Page-scoped one-off actions (a report page asking a question)
// omit it and stay stateless. `conversation_id` resumes an existing
// general.help thread; omitted means "create one". `context_ref` binds a
// fresh thread to a page ("report:vat:2026-07") for the context chip.
persist: z.boolean().optional(),
conversation_id: z.string().uuid().nullable().optional(),
context_ref: z.string().max(200).nullable().optional(),
})
export async function POST(request: Request): Promise<Response> {
const { user, supabase, error } = await requireAuth()
if (error) return error
const rate = await checkAgentRateLimit(supabase, user.id)
if (!rate.ok) return NextResponse.json(agentRateLimitResponseBody(rate), { status: 429 })
let body: unknown
try {
body = await request.json()
} catch {
return NextResponse.json({ error: 'Invalid JSON' }, { status: 400 })
}
const parsed = Schema.safeParse(body)
if (!parsed.success) {
return NextResponse.json({ error: 'Ogiltig fråga.', type: 'validation_error' }, { status: 400 })
}
const companyId = parsed.data.company_id ?? (await getActiveCompanyId(supabase, user.id))
if (!companyId) return NextResponse.json({ error: 'No active company' }, { status: 400 })
const { data: membership } = await supabase
.from('company_members')
.select('user_id')
.eq('company_id', companyId)
.eq('user_id', user.id)
.maybeSingle()
if (!membership) return NextResponse.json({ error: 'Forbidden' }, { status: 403 })
const blocked = await guardSandbox(supabase, companyId)
if (blocked) return blocked
const capBlocked = await requireCapability(supabase, companyId, CAPABILITY.ai)
if (capBlocked) return capBlocked
// Distinct from the paywall: no AI backend configured at all. Unlike the
// chat loop, ANY provider works here, so we gate on `configured`.
if (!getAiStatus().configured) {
return NextResponse.json(
{ error: 'Assistenten är inte konfigurerad på den här installationen.', code: 'ai_unconfigured' },
{ status: 503 },
)
}
// Stateless page-scoped ask: one answer, nothing written.
if (parsed.data.persist !== true) {
try {
const result = await answerAssistantQuestion({
supabase,
companyId,
userId: user.id,
question: parsed.data.question,
pageContext: parsed.data.context,
tier: parsed.data.tier,
})
return NextResponse.json({ data: result })
} catch (err) {
if (err instanceof EmptyModelAnswerError) {
// Already logged with model + usage by ask-service.
return NextResponse.json(
{ error: EMPTY_ANSWER_MESSAGE, code: 'empty_model_answer' },
{ status: 502 },
)
}
log.error('assistant ask failed', err, { companyId, persist: false })
return NextResponse.json({ error: getUserErrorMessage(err) }, { status: 500 })
}
}
// Persisted chat-console turn: resolve/create the thread, write the question,
// answer once, write the answer. Resolve BEFORE the model call so a bad
// conversation id 404s without spending a request; the user turn is written
// before the answer so a mid-call failure still leaves the question in the
// thread (the user can retry), matching the streaming runtime's semantics.
try {
const resolved = await resolveChatConversation(
supabase,
user.id,
companyId,
parsed.data.conversation_id,
parsed.data.question,
parsed.data.context_ref,
)
if (!resolved.ok) {
return NextResponse.json({ error: 'Konversationen hittades inte.' }, { status: 404 })
}
const { conversationId } = resolved
await persistUserTurn(supabase, conversationId, parsed.data.question)
const result = await answerAssistantQuestion({
supabase,
companyId,
userId: user.id,
conversationId,
question: parsed.data.question,
pageContext: parsed.data.context,
tier: parsed.data.tier,
})
// answerAssistantQuestion throws EmptyModelAnswerError on an empty answer,
// so an empty assistant turn is never persisted: the thread keeps the
// question (retryable) but records no blank reply.
await persistAssistantTurn(supabase, conversationId, result.answer)
return NextResponse.json({ data: { ...result, conversation_id: conversationId } })
} catch (err) {
if (err instanceof EmptyModelAnswerError) {
// Already logged with model + usage by ask-service.
return NextResponse.json(
{ error: EMPTY_ANSWER_MESSAGE, code: 'empty_model_answer' },
{ status: 502 },
)
}
log.error('assistant ask failed', err, { companyId, persist: true })
return NextResponse.json({ error: getUserErrorMessage(err) }, { status: 500 })
}
}