* feat(mcp): unify missing-document surfaces on one predicate (P1-3)
The two MCP surfaces told different truths: the transactions tool keyed
'has underlag' on transactions.document_id while the verifikat tool
keyed on document_attachments — and neither respected the source-type
semantics, version chains, or journal_entry_no_doc_required waivers
that lib/worklist's canonical count applies. Measured on prod: 22,046
waived verifikat still listed to agents, 2,370 doc-exempt source types
listed, ~87 docs attached to transactions but never propagated to the
verifikat, 1,100 transactions flagged missing-receipt although their
verifikat HAS the underlag.
One predicate now lives in SQL — posted, needs-doc source type
(mirrors NEEDS_DOC_SOURCE_TYPES), no current-version doc, no waiver:
- verifikat_without_documents RPC v2 adopts the canonical predicate.
- New transactions_without_documents RPC: the bank-driven subset of the
same predicate, joined through transactions.journal_entry_id — a
strict subset of the verifikat surface by construction. Rows expose
qualified transaction_id (P1-2 forward-compat); bare id deprecated.
- Both tools become thin RPC wrappers; descriptions state the actual
set relationship.
- lib/worklist countVerifikatMissingDocument delegates to the RPC
(previously three full-table pulls set-differenced client-side) —
badge count and agent surfaces can no longer drift.
- Backfill: propagate transaction-attached docs to their verifikat
where the attachment was never linked (open periods only; never
steals a doc linked to another verifikat).
pg-real: fixture matrix (no-doc/with-doc/waived/stale-version/
doc-exempt-source/import), strict-subset assertion, per-source-type pin
of the SQL list against the TS constant, tenant guard.
Part of dev_docs/mcp_optimization_plan.md (P1-3).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* docs(mcp): explicit grants restated + count-call comment (#876 review)
- Restate REVOKE/GRANT on verifikat_without_documents so the migration
is self-contained (CREATE OR REPLACE preserves the 20260703130000
grants — verified on prod: authenticated + service_role only).
- Comment on the p_limit:1 count call: total_count is computed over the
full filtered set, independent of page size.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Jakob Wennberg
21512db81a