764348e99c
* feat(dimensions): PR10 advanced — custom dimensions, hierarchy, account rules, commit enforcement The final rung of the dimensions ladder (dev_docs/dimensions_implementation_plan.md §7 row 10): - custom dimensions: POST /api/dimensions creates registry dims (next free SIE number >= 20 when omitted; explicit numbers allowed — SIE import already mints reserved ones); register gets a 'Ny dimension' dialog with a quiet Avancerat disclosure for the #UNDERDIM parent; GET now carries parent_sie_dim_no (the column + SIE round-trip existed since PR1/PR5 — this exposes it) - account_dimension_rules (migration 20260703120000): one rule per (account, dimension) — required / default / fixed, per-rule is_active, company-scoped RLS, composite FK to the registry, value-presence CHECK - enforcement, opt-in BY CONSTRUCTION (zero rules = engine byte-identical; deliberately NO settings toggle — a rule that exists but is ignored is worse than either extreme): default/fixed apply onto line bags at draft creation (fixed overwrites, default fills); required asserts at commitEntry with a Swedish MANDATORY_DIMENSION_MISSING naming every account + dimension; the bulk-book route runs the same policy before its RPC; storno/correction paths never pass through commitEntry so history always reverses regardless of policy; rule fetches fail open incl. thrown exceptions - chart of accounts: per-account Dimensionsregler section in EditAccountDialog (Krävs/Förval/Låst, value picker, pause switch), gated on the existing dimensions toggle, quiet when empty - pickers: LineDimensionFields is registry-driven (one combobox per active dimension, cached fetch, hardcoded 1/6 fallback) — every existing mount lights up custom dims with zero changes - agent briefing: per-dimension required_on_accounts/default_on_accounts so agents self-correct instead of bouncing off the policy error - rules CRUD API with existence/active/company validation and qualified DTO ids; firm_id FK deferred until the firms table lands (per plan) 39 new tests (pure-fn rules, engine enforcement, both new API surfaces, pg-real RLS/CHECK/cascade suite); full suite 6,791 green; migration replayed on a fresh container. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix: renumber migration to 20260703200000 — version collision with prod The concurrent session shipped pending_operations_add_link_document_to_voucher as 20260703120000 today; the Supabase preview branch (cloned from prod) rejected the duplicate version key. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix: review round — auto-pick retry on collision, fail-open warnings, query schema - POST /api/dimensions retries once past a concurrent number claim when the number was auto-picked (explicit choices still 409) - every fail-open skip of the dimension-rules policy now logs a structured warning (engine draft/commit paths + bulk-book) — deliberate fail-open, but observable - GET /api/dimensions/rules validates its query through ListDimensionRulesQuerySchema instead of an inline regex Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
141 lines
6.0 KiB
TypeScript
141 lines
6.0 KiB
TypeScript
/**
|
|
* DimensionValidationError — the typed rejection of validateEntryDimensions()
|
|
* (lib/bookkeeping/dimension-resolver.ts).
|
|
*
|
|
* Lives in its own module instead of ./errors.ts for one reason only:
|
|
* dimension-resolver.ts is reachable from client bundles (lib/api/schemas.ts
|
|
* imports DimensionsBagSchema and is itself imported by "use client"
|
|
* components such as InvoiceEditor), while ./errors.ts imports next/server —
|
|
* a server-only module graph (AsyncLocalStorage internals) that must never
|
|
* enter a client bundle. This module stays dependency-free.
|
|
*
|
|
* ./errors.ts re-exports everything here, wires the class into
|
|
* isBookkeepingError() and bookkeepingErrorResponse(), and remains the single
|
|
* import surface for server code:
|
|
*
|
|
* import { DimensionValidationError } from '@/lib/bookkeeping/errors'
|
|
*
|
|
* The class follows the ./errors.ts conventions: stable `code` const, `name`
|
|
* set to the class name, structured data on public readonly fields so the
|
|
* HTTP layer can attach machine-readable details. The message is user-facing
|
|
* Swedish (stays-Swedish bookkeeping surface, mirroring
|
|
* accountsNotInChartResponse) and names every offending code so a user or
|
|
* agent can self-correct in one pass.
|
|
*/
|
|
|
|
export const DIMENSION_VALIDATION_FAILED = 'DIMENSION_VALIDATION_FAILED' as const
|
|
|
|
export type DimensionValidationReason =
|
|
/** The line references a SIE dimension number with no registry row. */
|
|
| 'unknown_dimension'
|
|
/** The dimension exists but the code has no dimension_values row. */
|
|
| 'unknown_value'
|
|
/** The value exists but is archived (is_active = false). */
|
|
| 'archived_value'
|
|
|
|
export interface DimensionValidationIssue {
|
|
/** SIE dimension number as keyed in the line bag, e.g. '1' or '6'. */
|
|
sie_dim_no: string
|
|
/** Offending object code; null when the dimension number itself is unknown. */
|
|
code: string | null
|
|
reason: DimensionValidationReason
|
|
}
|
|
|
|
/** Swedish user-facing sentence for a single validation issue. */
|
|
export function formatDimensionValidationIssue(issue: DimensionValidationIssue): string {
|
|
switch (issue.reason) {
|
|
case 'unknown_dimension':
|
|
return `Okänd dimension ${issue.sie_dim_no}. Skapa dimensionen i registret först.`
|
|
case 'archived_value':
|
|
return `"${issue.code}" är arkiverat — återaktivera värdet för att använda det.`
|
|
case 'unknown_value':
|
|
return `Okänt kostnadsställe/projekt: "${issue.code}" (dimension ${issue.sie_dim_no}). Skapa värdet i registret först.`
|
|
}
|
|
}
|
|
|
|
function isDimensionValidationIssue(value: unknown): value is DimensionValidationIssue {
|
|
if (typeof value !== 'object' || value === null) return false
|
|
const v = value as Record<string, unknown>
|
|
if (typeof v.sie_dim_no !== 'string') return false
|
|
if (v.reason === 'unknown_dimension') return true
|
|
return (
|
|
(v.reason === 'unknown_value' || v.reason === 'archived_value') && typeof v.code === 'string'
|
|
)
|
|
}
|
|
|
|
/**
|
|
* Format an untyped issues array (e.g. `details.issues` from a serialized API
|
|
* error envelope) into the Swedish message. Returns null unless `raw` is a
|
|
* non-empty array of well-formed issues — callers fall back to their generic
|
|
* message. Used by lib/errors/get-error-message.ts so the toast reconstructs
|
|
* the exact per-code sentences instead of the static registry fallback.
|
|
*/
|
|
export function formatDimensionValidationIssues(raw: unknown): string | null {
|
|
if (!Array.isArray(raw) || raw.length === 0) return null
|
|
const issues = raw.filter(isDimensionValidationIssue)
|
|
if (issues.length === 0) return null
|
|
return issues.map(formatDimensionValidationIssue).join(' ')
|
|
}
|
|
|
|
/**
|
|
* Raised by validateEntryDimensions() when a company with
|
|
* company_settings.dimensions_enabled = true tags a line with a dimension
|
|
* number that has no registry row, a code with no dimension_values row, or an
|
|
* archived value. Companies without the toggle keep free-text passthrough
|
|
* (backward compatible with every existing API/MCP writer), and untagged
|
|
* entries never reach this validation at all.
|
|
*/
|
|
export class DimensionValidationError extends Error {
|
|
readonly code = DIMENSION_VALIDATION_FAILED
|
|
|
|
constructor(public readonly issues: DimensionValidationIssue[]) {
|
|
super(issues.map(formatDimensionValidationIssue).join(' '))
|
|
this.name = 'DimensionValidationError'
|
|
}
|
|
}
|
|
|
|
export function isDimensionValidationError(err: unknown): err is DimensionValidationError {
|
|
return err instanceof DimensionValidationError
|
|
}
|
|
|
|
// ============================================================================
|
|
// Mandatory dimension enforcement (dimensions PR10)
|
|
// ============================================================================
|
|
|
|
export const MANDATORY_DIMENSION_MISSING = 'MANDATORY_DIMENSION_MISSING' as const
|
|
|
|
export interface MandatoryDimensionViolation {
|
|
account_number: string
|
|
/** SIE dimension number the rule requires, e.g. '6'. */
|
|
sie_dim_no: string
|
|
/** Registry display name for the dimension, e.g. 'Projekt'. */
|
|
dimension_name: string
|
|
}
|
|
|
|
/** Swedish user-facing sentence for a single missing-dimension violation. */
|
|
export function formatMandatoryDimensionViolation(v: MandatoryDimensionViolation): string {
|
|
return `Konto ${v.account_number} kräver ${v.dimension_name} — välj ett värde innan bokföring.`
|
|
}
|
|
|
|
/**
|
|
* Raised at COMMIT time (commitEntry / the bulk-book pre-check) when an
|
|
* active 'required' rule in account_dimension_rules is unsatisfied by a
|
|
* line's dimensions bag. Drafts may be incomplete by design — the rule bites
|
|
* when the verifikat is about to become immutable. Companies without rules
|
|
* (every company by default) never reach this error.
|
|
*/
|
|
export class MandatoryDimensionMissingError extends Error {
|
|
readonly code = MANDATORY_DIMENSION_MISSING
|
|
|
|
constructor(public readonly violations: MandatoryDimensionViolation[]) {
|
|
super(violations.map(formatMandatoryDimensionViolation).join(' '))
|
|
this.name = 'MandatoryDimensionMissingError'
|
|
}
|
|
}
|
|
|
|
export function isMandatoryDimensionMissingError(
|
|
err: unknown,
|
|
): err is MandatoryDimensionMissingError {
|
|
return err instanceof MandatoryDimensionMissingError
|
|
}
|