Files
accounted/lib/bookkeeping/__tests__/bas-reference.test.ts
T
Jakob Wennberg 98cd253bce feat: enable banking hardening, arcim inference, SIE fixes, onboarding (#32)
* feat: import system improvements, INK2 fix, and Swedish text corrections

- SIE parser: Windows-1252 and CP437 encoding detection and decoding
- Bank file parser: add Nordea Business (Företag) CSV format
- Bank file parser: improve format detection for SEB, Länsförsäkringar, generic CSV
- INK2 engine: calculate årets resultat (7222) from income statement for open fiscal years
- Dashboard: parallel Supabase queries, simplified dashboard page
- Fix Swedish characters (å, ä, ö) in BAS data descriptions, validation messages, AI consent disclosures
- Import wizard UI improvements across all steps
- Migration: add 'bas_range' match type to sie_account_mappings constraint
- Extensive new tests for SIE parser encoding and bank file parser

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat: arcim migration wizard UX fixes, Sentry setup, and extension scaffolding

Arcim migration wizard improvements:
- Progress bar now excludes non-interactive steps (migrating/result)
- Fix OAuth text to match target="_blank" behavior (new tab, not redirect)
- Display month names instead of "Månad X" in preview
- Fix Swedish typo "förifylla" in no-company-info message
- Replace native checkboxes with shadcn Switch in options step
- Add ConfirmationDialog before starting migration
- Show progress percentage during migration
- Add "Nästa steg" guidance and navigation links in result step
- Add "Försök igen" button in error state (returns to options)
- Add Bokio company ID help text (GUID from URL)
- Add Fortnox integration add-on hint on connection failure

Also includes: SIE import system improvements, INK2 fixes, Swedish text
corrections, Sentry error tracking setup, and arcim-migration extension
scaffolding.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: address PR review feedback

- Fix OAuth error recovery blank page (restore provider from URL params)
- Pass real userId to MigrationWizard instead of empty string
- Remove ~50 debug console.log statements from sie-import.ts
- Fix comment referencing account 3740 → 3741

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat: comprehensive UI design audit and normalization

Dashboard audit:
- Fix muted-foreground contrast (4.31:1 → 5.08:1) for WCAG AA
- Add prefers-reduced-motion media query for all animations
- Replace border-l-2 accent anti-pattern with subtle full-border colors
- Add aria-expanded to toggle buttons, role="status" to live counters
- Fix touch targets on deadline buttons (28px → 36px)
- Vary section spacing for rhythm (mb-12/mb-10/mb-8)
- Remove unused imports and dead code

Transactions audit + hardening:
- Add pagination (200 per page) with "Ladda fler" button
- Replace height animation with transform-only exit animation
- Show batch progress in floating action bar during processing
- Fix batch bar mobile overlap (bottom-20 on mobile)
- Replace clickable badges with proper button elements
- Add safe area padding to fullscreen swipe view
- Add response.ok check to suggestion fetch
- Add truncation to invoice number buttons

Invoicing audit:
- Remove border-l-4 accent pattern from invoice cards
- Replace string concatenation with cn() utility

Systemic sweep (34 files):
- All page headings: font-bold → font-display font-medium (Fraunces)
- All stat numbers: font-bold → font-display font-medium tabular-nums
- All hard-coded blue/amber/emerald colors → design tokens
- Remove all dark mode overrides (tokens handle automatically)
- Tint pure white card background to 99%

Design context added to CLAUDE.md with brand personality,
aesthetic direction, and 5 design principles.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: bookkeeping flow audit — design system, accessibility, UX

- Replace raw <select> with shadcn Select component (JournalEntryForm)
- Add confirmation dialog for account deletion (ChartOfAccountsManager)
- Remove console.error from production code (JournalEntryList, JournalEntryForm)
- Fix contradictory h-7/min-h-[44px] button sizing → h-10 (ChartOfAccountsManager)
- Increase BAS catalog "Lägg till" touch target h-7 → h-9
- Improve loading state with spinner (JournalEntryList)
- Improve empty state with icon, description, and guidance (JournalEntryList)
- Add response.ok check on journal entry fetch
- Add aria-expanded to entry expand buttons
- Add tabular-nums to desktop debit/credit columns

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: onboarding and empty state improvements

Onboarding:
- Replace font-serif with font-display (Fraunces) for brand consistency
- Remove console.error calls from production code

Empty states:
- Fix broken /transactions/new link in EmptyTransactions (route doesn't exist)
- Add actionHref fallback to EmptyCustomers when no onAction prop provided
- Improve EmptyTransactions description copy

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: clarify Swedish UX copy — terminology, errors, descriptions

Terminology consistency:
- "Försenad" → "Förfallen" for overdue invoices (customers/[id])
- "bokföringsorder" → actionable description in bookkeeping page
- "verifikation har bifogats" → "underlag har bifogats" in doc warning
- "Fortsätt ändå" → "Bokför utan underlag" (specific action)

Error messages — replace generic "Fel" + "Något gick fel" with specific:
- "Något gick fel vid bokföring" → "Transaktionen kunde inte bokföras"
- "Något gick fel vid matchning" → "Transaktionen kunde inte matchas"
- "Kunde inte hämta X" → "Kunde inte ladda X" + recovery hint
- Add "Försök igen" guidance to all error toasts

Page descriptions — replace redundant with actionable:
- Invoices: "Skapa och hantera" → "Skicka, följ betalningar, skapa kreditnotor"
- Bookkeeping: list of features → actionable description

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: design critique — dashboard affordance, reports description

Dashboard:
- Add ChevronRight indicator to clickable summary cards
  (Att få betalt, Koppla bank) to distinguish from static cards
- Add cursor-pointer to linked cards

Reports:
- Replace feature list description with actionable guidance
  "Huvudbok, grundbok..." → "Generera skattedeklarationer..."

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: replace generic "Fel" error toasts with specific messages

Deadlines: 5 generic "Fel" → specific per-action titles
  (create, toggle, edit, delete, load)
Expenses detail: 5 generic "Fel" → specific per-action titles
  (load, approve, pay, credit, delete)
Expenses new: 3 generic "Fel" → instructional validation messages
  (supplier name, supplier selection, invoice number)
Customers: 1 generic "Fel" → specific load error with recovery hint

All error toasts now follow pattern:
  title = what failed, description = how to recover

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: replace all remaining generic "Fel" error toasts (37 instances)

Systematic sweep across 12 dashboard pages replacing generic
title: 'Fel' with context-specific error titles:

- Load errors: "Kunde inte ladda [resurs]"
- Action errors: "[Åtgärd] misslyckades"
- Validation: "[Fält] saknas"

Every error toast now tells the user what failed without needing
to read the description. Recovery hints added where missing.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: import flow — normalize stat typography, remove console.warn

- Replace font-bold with font-display font-medium on 13 stat numbers
  across SIEPreviewStep, BankFilePreviewStep, BankFileConfirmStep,
  ImportResultStep (missed by systemic sweep since these are in
  components/import/, not app/(dashboard)/)
- Add tabular-nums to stat numbers displaying counts/currency
- Remove console.warn in ArcimMigrationWorkspace

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: final cleanup — console statements, remaining font-bold stats

Remove production console statements:
- Step1EntityType: remove debug console.warn (dead code after onNext)
- TransactionBookingDialog: remove console.error on doc link failure
- JournalEntryAttachments: remove 3 console.error calls

Normalize remaining font-bold stat displays:
- SwipeCategorizationView: 3 instances (completion, amount displays)
- NEDeclarationView: yearly result heading + value

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: address Greptile review feedback

loadMoreTransactions: add inbox item enrichment matching fetchTransactions
- Paginated transactions now fetch invoice_inbox_items in parallel
- Fixes missing document indicator, template suggestions, and inbox
  match card for transactions loaded via "Ladda fler"

fetchAllPages: add maxPages guard (default 500) to prevent infinite loop
- If Arcim gateway returns hasMore:true indefinitely, the loop now
  exits after 500 pages instead of running forever

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* docs: minimize CLAUDE.md — remove derivable content, fix stale data

Remove ~230 lines (51% reduction) of content that duplicates what's
already in the source code (directory tree, function tables, type
definitions, migration lists). Update migration count (63→65), add
missing test helpers, fix cron job list. Keep all high-value sections:
accounting guard rails, BAS accounts, VAT rutor, design context.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: enable banking hardening, arcim entity inference, SIE import fixes, and onboarding improvements

- Enable Banking: OAuth CSRF state tokens, JWT caching, retry with timeouts, raw PSD2 response archival (BFL 7 kap), expired/error connection UI, consent expiry notifications, pagination safety limits
- Arcim migration: Smarter entity type inference from org numbers, VAT prefixes, company name suffixes (GmbH, Ltd, etc.), and country codes
- SIE import: Parser and import fixes with new migration
- BAS accounts: Added vehicle accounts (1241, 1242, 1249, 1259)
- Dashboard: New SIE import and stale uncategorized transaction queries
- Onboarding: Enhanced NewUserChecklist
- Period service: Improvements with updated tests
- Transaction ingest: Updated logic and tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: address Greptile review — credit note type, EU country codes, notification thresholds, migration timestamps

- Fix dead ternary: credit notes now correctly stored as 'credit_note' instead of 'invoice'
- Add 'GR' (Greece ISO 3166-1) to EU_COUNTRIES alongside 'EL' (VAT prefix)
- Fix consent notification condition: fire at exactly 7 days or ≤3 days, not every day in 7-day window
- Deduplicate migration timestamps: rename SIE migration to 20260316120100

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-16 14:21:32 +01:00

270 lines
8.4 KiB
TypeScript

import { describe, it, expect } from 'vitest'
import {
BAS_REFERENCE,
ACCOUNT_CLASS_LABELS,
ACCOUNT_GROUP_LABELS,
getBASReference,
getBASReferenceByClass,
isStandardBASAccount,
} from '../bas-reference'
describe('BAS_REFERENCE data integrity', () => {
it('contains the expected number of accounts (~1,276)', () => {
expect(BAS_REFERENCE.length).toBeGreaterThanOrEqual(1250)
expect(BAS_REFERENCE.length).toBeLessThanOrEqual(1300)
})
it('has no duplicate account numbers', () => {
const numbers = BAS_REFERENCE.map((a) => a.account_number)
const uniqueNumbers = new Set(numbers)
expect(uniqueNumbers.size).toBe(numbers.length)
})
it('account_class matches the first digit of account_number', () => {
for (const account of BAS_REFERENCE) {
const firstDigit = parseInt(account.account_number[0], 10)
expect(account.account_class).toBe(firstDigit)
}
})
it('account_group matches the first two digits of account_number', () => {
for (const account of BAS_REFERENCE) {
const firstTwo = account.account_number.substring(0, 2)
expect(account.account_group).toBe(firstTwo)
}
})
it('every account has a non-null sru_code', () => {
const withoutSru = BAS_REFERENCE.filter((a) => a.sru_code === null)
expect(withoutSru).toEqual([])
})
it('every account has a non-empty description', () => {
const withoutDesc = BAS_REFERENCE.filter((a) => !a.description || a.description.trim() === '')
expect(withoutDesc).toEqual([])
})
it('every account has a valid account_type', () => {
const validTypes = ['asset', 'liability', 'equity', 'revenue', 'expense', 'untaxed_reserves']
for (const account of BAS_REFERENCE) {
expect(validTypes).toContain(account.account_type)
}
})
it('every account has a valid normal_balance', () => {
for (const account of BAS_REFERENCE) {
expect(['debit', 'credit']).toContain(account.normal_balance)
}
})
it('all account numbers are 4 digits', () => {
for (const account of BAS_REFERENCE) {
expect(account.account_number).toMatch(/^\d{4}$/)
}
})
})
describe('Non-standard accounts removed', () => {
const nonStandard = ['1400', '1580', '3109', '4100', '4990', '7834', '7835', '7910', '8710']
for (const num of nonStandard) {
it(`${num} is not in the catalog`, () => {
expect(isStandardBASAccount(num)).toBe(false)
})
}
})
describe('Class 2 account_type correctness', () => {
it('20xx accounts are equity', () => {
const group20 = BAS_REFERENCE.filter((a) => a.account_group === '20')
expect(group20.length).toBeGreaterThan(0)
for (const a of group20) {
expect(a.account_type).toBe('equity')
}
})
it('21xx accounts are untaxed_reserves', () => {
const group21 = BAS_REFERENCE.filter((a) => a.account_group === '21')
expect(group21.length).toBeGreaterThan(0)
for (const a of group21) {
expect(a.account_type).toBe('untaxed_reserves')
}
})
it('22xx-29xx accounts are liability', () => {
const liabilityGroups = BAS_REFERENCE.filter(
(a) => a.account_class === 2 && parseInt(a.account_group) >= 22
)
expect(liabilityGroups.length).toBeGreaterThan(0)
for (const a of liabilityGroups) {
expect(a.account_type).toBe('liability')
}
})
})
describe('Class 8 normal_balance correctness', () => {
it('8310 (Ränteintäkter) has credit normal_balance', () => {
const account = getBASReference('8310')
expect(account).toBeDefined()
expect(account!.normal_balance).toBe('credit')
})
it('8410 (Räntekostnader) has debit normal_balance', () => {
const account = getBASReference('8410')
expect(account).toBeDefined()
expect(account!.normal_balance).toBe('debit')
})
it('8910 (Skatt) has debit normal_balance', () => {
const account = getBASReference('8910')
expect(account).toBeDefined()
expect(account!.normal_balance).toBe('debit')
})
it('8810 (Bokslutsdispositioner) has credit normal_balance', () => {
const account = getBASReference('8810')
expect(account).toBeDefined()
expect(account!.normal_balance).toBe('credit')
})
})
describe('Contra accounts have opposite normal_balance', () => {
it('1119 (Ack. avskrivningar byggnader) has credit balance', () => {
const account = getBASReference('1119')
expect(account).toBeDefined()
expect(account!.normal_balance).toBe('credit')
})
it('1229 (Ack. avskrivningar inventarier) has credit balance', () => {
const account = getBASReference('1229')
expect(account).toBeDefined()
expect(account!.normal_balance).toBe('credit')
})
it('2011 (Egna varuuttag) has debit balance', () => {
const account = getBASReference('2011')
expect(account).toBeDefined()
expect(account!.normal_balance).toBe('debit')
})
it('3740 (Öres- och kronutjämning) has debit balance', () => {
const account = getBASReference('3740')
expect(account).toBeDefined()
expect(account!.normal_balance).toBe('debit')
})
})
describe('K2-excluded accounts', () => {
const k2Excluded = [
'1010', '1011', '1012', '1018', '1019',
'1370', '1518',
'2092', '2096', '2240', '2448',
'3940', '7940',
'8290', '8291', '8295',
'8320', '8321', '8325',
'8450', '8451', '8455',
'8480', '8940',
]
it('known K2-excluded accounts are marked correctly', () => {
for (const num of k2Excluded) {
const account = getBASReference(num)
expect(account).toBeDefined()
expect(account!.k2_excluded).toBe(true)
}
})
it('common non-K2-excluded accounts are not marked', () => {
const normalAccounts = ['1510', '1930', '2440', '3001', '4010', '5010', '7010', '8310']
for (const num of normalAccounts) {
const account = getBASReference(num)
expect(account).toBeDefined()
expect(account!.k2_excluded).toBe(false)
}
})
it('total K2-excluded count matches expected (24)', () => {
const k2Count = BAS_REFERENCE.filter((a) => a.k2_excluded).length
expect(k2Count).toBe(24)
})
})
describe('ACCOUNT_GROUP_LABELS coverage', () => {
it('all groups present in BAS_REFERENCE have labels', () => {
const groups = new Set(BAS_REFERENCE.map((a) => a.account_group))
for (const group of groups) {
expect(ACCOUNT_GROUP_LABELS[group]).toBeDefined()
}
})
it('covers at least 70 groups', () => {
expect(Object.keys(ACCOUNT_GROUP_LABELS).length).toBeGreaterThanOrEqual(70)
})
})
describe('ACCOUNT_CLASS_LABELS', () => {
it('has labels for all 8 classes', () => {
for (let i = 1; i <= 8; i++) {
expect(ACCOUNT_CLASS_LABELS[i]).toBeDefined()
}
})
})
describe('Helper functions', () => {
it('getBASReference returns correct account', () => {
const account = getBASReference('1930')
expect(account).toBeDefined()
expect(account!.account_name).toBe('Företagskonto')
expect(account!.account_type).toBe('asset')
})
it('getBASReference returns undefined for non-existent account', () => {
expect(getBASReference('9999')).toBeUndefined()
})
it('getBASReferenceByClass returns accounts for each class', () => {
for (let cls = 1; cls <= 8; cls++) {
const accounts = getBASReferenceByClass(cls)
expect(accounts.length).toBeGreaterThan(0)
for (const a of accounts) {
expect(a.account_class).toBe(cls)
}
}
})
it('getBASReferenceByClass returns empty array for non-existent class', () => {
expect(getBASReferenceByClass(9)).toEqual([])
})
it('isStandardBASAccount returns true for standard accounts', () => {
expect(isStandardBASAccount('1510')).toBe(true)
expect(isStandardBASAccount('3001')).toBe(true)
expect(isStandardBASAccount('8999')).toBe(true)
})
it('isStandardBASAccount returns false for non-standard accounts', () => {
expect(isStandardBASAccount('9999')).toBe(false)
expect(isStandardBASAccount('0000')).toBe(false)
})
})
describe('Account class distribution', () => {
it('class 1 (assets) has ~230 accounts', () => {
const cls = getBASReferenceByClass(1)
expect(cls.length).toBeGreaterThanOrEqual(220)
expect(cls.length).toBeLessThanOrEqual(240)
})
it('class 2 (equity & liabilities) has ~265 accounts', () => {
const cls = getBASReferenceByClass(2)
expect(cls.length).toBeGreaterThanOrEqual(255)
expect(cls.length).toBeLessThanOrEqual(275)
})
it('class 3 (revenue) has ~100 accounts', () => {
const cls = getBASReferenceByClass(3)
expect(cls.length).toBeGreaterThanOrEqual(90)
expect(cls.length).toBeLessThanOrEqual(110)
})
})