Files
accounted/lib/documents/inbox-field-visibility.ts
T
d7320a6c87 feat(invoice-inbox): show receipt fields on receipts, invoice fields on invoices (#1426)
* feat(invoice-inbox): show receipt fields on receipts, invoice fields on invoices

A kassakvitto has no due date, no OCR reference, no invoice number and no
bankgiro: it is already paid. The rail rendered all four as empty boxes
anyway, so a perfectly extracted receipt looked like a failed extraction.
The date was mislabelled too: on a receipt the document date is the
purchase date, not a "Fakturadatum".

When extracted_data.documentKind is 'receipt' the rail now labels the date
"Inköpsdatum" and folds the five invoice-only fields behind a quiet "Visa
fakturafält (N)" link.

Two rules keep it safe when the classification is wrong: a field holding a
value is never hidden (a hybrid restaurangnota with an invoice number
still shows it), and the fold is one click from being undone.

Logic lives in lib/documents/inbox-field-visibility.ts rather than the
component: this repo has no jsdom or testing-library, so display rules are
only testable as a React-free module.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(invoice-inbox): reset the invoice-field fold when switching documents

Review catch (PR Agent on #1426): showAllFields was component state with no
per-item reset, and EditableFieldsList stays mounted across selections in
the rail. Expanding "Visa fakturafält" on one receipt therefore left the
invoice-only fields open on the next document, which reads as if that one
carried them too.

Reset alongside drafts and edit provenance in the existing itemId effect,
and moved the declaration up next to the other state so it is defined
above its first use rather than relying on hoisting.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-05 20:26:16 +02:00

62 lines
2.2 KiB
TypeScript

/**
* Which extracted fields the Underlag rail should show for a document.
*
* A kassakvitto has no due date, no OCR reference, no invoice number and no
* bankgiro: it is already paid. Rendering those as four empty boxes made the
* rail read as "extraction failed" when in truth the concepts do not exist
* on the document. The date is mislabelled too: on a receipt the document
* date is the purchase date, not a "Fakturadatum".
*
* Two rules keep this safe when the AI classification is wrong:
* 1. A field that HAS a value is never hidden.
* 2. Hiding is reversible in one click (the caller renders a toggle), so
* a receipt that really does carry an invoice number stays reachable.
*
* React-free on purpose: this repo has no jsdom or testing-library, so
* display logic is tested here rather than through the component.
*/
/** Concepts that exist on an invoice but not on a paid receipt. */
export const INVOICE_ONLY_FIELD_KEYS: ReadonlySet<string> = new Set([
'invoice.dueDate',
'invoice.invoiceNumber',
'invoice.paymentReference',
'supplier.bankgiro',
'supplier.plusgiro',
])
/** Labels that read wrong on a receipt. */
export const RECEIPT_FIELD_LABELS: Readonly<Record<string, string>> = {
'invoice.invoiceDate': 'Inköpsdatum',
}
export interface VisibleField {
key: string
label: string
}
export function selectInboxFields<T extends VisibleField>(opts: {
/** extracted_data.documentKind; anything but 'receipt' keeps today's list. */
documentKind: string | null | undefined
fields: readonly T[]
/** True when the field currently holds a value (draft or extracted). */
hasValue: (key: string) => boolean
/** User clicked "show invoice fields". */
showAll: boolean
}): { shown: T[]; hiddenCount: number } {
const { documentKind, fields, hasValue, showAll } = opts
if (documentKind !== 'receipt') return { shown: [...fields], hiddenCount: 0 }
const shown: T[] = []
let hiddenCount = 0
for (const field of fields) {
if (!showAll && INVOICE_ONLY_FIELD_KEYS.has(field.key) && !hasValue(field.key)) {
hiddenCount += 1
continue
}
const label = RECEIPT_FIELD_LABELS[field.key]
shown.push(label ? { ...field, label } : field)
}
return { shown, hiddenCount }
}