Jakob Wennberg
0bb0b89353
* feat(auth): inline, specific error states on login and signup Auth failures now render inline next to the form instead of as a top-right toast: a persistent alert with role=alert, aria-invalid field highlighting, and focus returned to the offending field. Login maps GoTrue error codes (invalid_credentials, email_not_confirmed, rate limits, user_banned) to specific Swedish/English messages, with a reset-password link embedded in the credentials error. The credentials message stays 'wrong email or password' by design: GoTrue returns one code for both cases to prevent account enumeration. Signup gets a live password-requirements checklist, field-level errors for weak/mismatched passwords, and inline handling of email-exists, invalid-email and rate-limit responses with a sign-in link where that is the recovery path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(auth): treat email_provider_disabled as signup-disabled with specific copy Review follow-up: GoTrue signals disabled email/password signups with email_provider_disabled as well as signup_disabled; classify both (plus the message-string fallback for older GoTrue) and give the register form a specific inline message instead of the generic fallback. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
62 lines
3.4 KiB
TypeScript
62 lines
3.4 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import { classifyAuthError } from '../classify-auth-error'
|
|
|
|
describe('classifyAuthError', () => {
|
|
it('maps GoTrue error codes', () => {
|
|
expect(classifyAuthError({ code: 'invalid_credentials', message: 'Invalid login credentials', status: 400 }))
|
|
.toBe('invalid_credentials')
|
|
expect(classifyAuthError({ code: 'email_not_confirmed', message: 'Email not confirmed', status: 400 }))
|
|
.toBe('email_not_confirmed')
|
|
expect(classifyAuthError({ code: 'over_request_rate_limit', message: 'Request rate limit reached', status: 429 }))
|
|
.toBe('rate_limited')
|
|
expect(classifyAuthError({ code: 'over_email_send_rate_limit', message: '...', status: 429 }))
|
|
.toBe('rate_limited')
|
|
expect(classifyAuthError({ code: 'user_banned', message: 'User is banned', status: 403 }))
|
|
.toBe('user_banned')
|
|
expect(classifyAuthError({ code: 'user_already_exists', message: 'User already registered', status: 422 }))
|
|
.toBe('email_exists')
|
|
expect(classifyAuthError({ code: 'weak_password', message: 'Password is too weak', status: 422 }))
|
|
.toBe('weak_password')
|
|
expect(classifyAuthError({ code: 'email_address_invalid', message: 'Email address is invalid', status: 400 }))
|
|
.toBe('email_invalid')
|
|
expect(classifyAuthError({ code: 'signup_disabled', message: 'Signups not allowed', status: 400 }))
|
|
.toBe('signup_disabled')
|
|
expect(classifyAuthError({ code: 'email_provider_disabled', message: 'Email signups are disabled', status: 400 }))
|
|
.toBe('signup_disabled')
|
|
})
|
|
|
|
it('falls back on message strings when code is missing (older self-hosted GoTrue)', () => {
|
|
expect(classifyAuthError({ message: 'Invalid login credentials', status: 400 }))
|
|
.toBe('invalid_credentials')
|
|
expect(classifyAuthError({ message: 'Email not confirmed', status: 400 }))
|
|
.toBe('email_not_confirmed')
|
|
expect(classifyAuthError({ message: 'User already registered', status: 422 }))
|
|
.toBe('email_exists')
|
|
expect(classifyAuthError({ message: 'Signups not allowed for this instance', status: 400 }))
|
|
.toBe('signup_disabled')
|
|
expect(classifyAuthError({ message: 'Email signups are disabled', status: 400 }))
|
|
.toBe('signup_disabled')
|
|
expect(classifyAuthError({ message: 'Email rate limit exceeded', status: 429 }))
|
|
.toBe('rate_limited')
|
|
})
|
|
|
|
it('falls back on HTTP 429 when neither code nor message identifies the error', () => {
|
|
expect(classifyAuthError({ message: 'something opaque', status: 429 })).toBe('rate_limited')
|
|
})
|
|
|
|
it('returns unknown for unrecognized or malformed input', () => {
|
|
expect(classifyAuthError({ code: 'mfa_totp_verify_not_enabled', message: 'x', status: 400 })).toBe('unknown')
|
|
expect(classifyAuthError({ message: 'fetch failed' })).toBe('unknown')
|
|
expect(classifyAuthError(new Error('network down'))).toBe('unknown')
|
|
expect(classifyAuthError('a string')).toBe('unknown')
|
|
expect(classifyAuthError(null)).toBe('unknown')
|
|
expect(classifyAuthError(undefined)).toBe('unknown')
|
|
})
|
|
|
|
it('never leaks which credential part failed: unknown email and wrong password share a kind', () => {
|
|
const unknownEmail = { code: 'invalid_credentials', message: 'Invalid login credentials', status: 400 }
|
|
const wrongPassword = { code: 'invalid_credentials', message: 'Invalid login credentials', status: 400 }
|
|
expect(classifyAuthError(unknownEmail)).toBe(classifyAuthError(wrongPassword))
|
|
})
|
|
})
|