* fix(mcp): supplier-invoice-from-inbox resolves FX through the shared resolver, with the cache and an override
MCP feedback seq 299742: eight USD supplier invoices staged from the inbox
in one batch, three got a Riksbanken rate and five came back
exchange_rate: null / exchange_rate_source "lookup_failed", reproducibly,
for ordinary weekdays in April-August. None of the five could be approved
(the executor refuses with SI_FX_RATE_MISSING; it never books 0 SEK), and
the tool offered no way to supply the rate.
Cause: the tool called fetchExchangeRate without the supabase client, so
neither the shared exchange_rates read-through cache nor the
last-cached-observation fallback was reachable. Riksbanken's IP limiter
answers 429 after about five requests in a burst (a weekend date costs
two: exact-date 204, then the 7-day range), sends no Retry-After header,
and asks for ~54 s, which the 5 s retry cap cannot honour. The pass/fail
split was request ordering, nothing about the dates.
- Resolve through resolveSupplierInvoiceExchangeRate with the client, the
same resolver the commit executor and the v1/web write paths use, so the
staging preview and the commit agree and the cache is consulted and
warmed.
- New input exchange_rate_override (SEK per 1 unit of invoice currency),
trusted verbatim like the web form and v1; validated positive and finite,
refused as implausible past the resolver's bound, rejected on a SEK
invoice. Source is echoed as "supplied".
- When the lookup still fails, the preview carries exchange_rate_hint
saying approval will refuse and naming the override that unblocks it.
tools/list: +1 property (~25 tokens), ledger line added in
payload-size.bench.test.ts; ceiling unchanged. The retry cap is left as is:
waiting a minute inside a tool call or the sync cron's fan-out is a design
call, and the cached fallback now covers the common case.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013yw62FMXGSzo6icFDiBwP3
* docs(decisions): FX override and retry cap on the inbox supplier-invoice tool
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013yw62FMXGSzo6icFDiBwP3
---------
Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Jakob Wennberg
7240bfe7f3