98d0c7f2d0
* fix(salary): align pain.001 salary file with the Swedish domestic bank dialect Verified against the Swedish Common Interpretation of ISO 20022 (Bankforeningen, Common Payment Types in Sweden, Appendix 1 Example 4: Salaries) and Nordea Corporate Access pain.001 examples v2.6 (2026-06-22), and XSD-validated against the official pain.001.001.03 schema: - drop SvcLvl SEPA (SEPA credit transfers are EUR-only; omitting SvcLvl gets the domestic NURG default) - drop RmtInf (not allowed for SALA salary payments; the beneficiary statement text comes from the Dataclearing LON code) - address employees domestically: clearing as CdtrAgt ClrSysMmbId SESBA, account WITHOUT clearing as CdtrAcct Othr with SchmeNm BBAN - share the clearing/account split (Swedbank 5-digit shift, Nordea personkonto prefix dedup) between the LB and pain.001 generators via splitDomesticBankAccount, fixing pain.001 duplicating the personkonto clearing - clamp MsgId/PmtInfId/InstrId/EndToEndId to Max35Text with the per-tx counter surviving truncation; carry the org number on Dbtr - return 400 from the pain001 route on an invalid clearing instead of emitting a broken file Also includes two unrelated decision-log lines from the parallel revisor-review session (DECISIONS.md is a shared append-only log). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(nav): surface the year-end chain in the sidebar Add Periodiseringar, Arsredovisning (aktiebolag only) and Inkomstdeklaration (INK2 for AB, NE-bilaga for EF) to the Skatt & bokslut group, in workflow order. Entity gating via a new entityOnly flag on NavItem; isActive carve-outs extended so exactly one row lights up for the new routes. Driven by an external revisor review that concluded these features did not exist because none of them were reachable from the nav. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(stripe): Stripe Connect integration behind config gate Connect OAuth per company (only the acct_ id is stored), automatic single-use Payment Links on invoice send, deterministic payment settlement against 1686 (BAS moved acquirer receivables 1580 -> 1686), payout booking with reverse-charge fees (6570 + 4535/4598 + 2645/2614), and a 15-minute sync cron. Non-deterministic events land as needs_review, never guessed at. Fully dark without STRIPE_CONNECT_CLIENT_ID: connect returns 503, the send hook and cron no-op, and the settings page shows 'Kommer snart' (hosted) until the Connect platform is verified. Self-hosted keeps the honest not-configured message. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(deadlines): add shared completeTaxDeadline and fix dead AGI deadline auto-complete generate-declaration.ts has updated non-existent columns (type/period/ status) since inception, so the arbetsgivardeklaration deadline was never auto-completed. Replace with a shared helper targeting the real schema (tax_deadline_type/tax_period/is_completed), also used by the kvittens crons and moms handlers in the follow-up commit. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(rot-rut): import Skatteverket beslutsfil and record decisions on payout requests Parse the beslutsfil JSON from Skatteverkets rot/rut e-tjanst and record godkant belopp on the matching begaran: matched by stored skv_referensnummer first, then exact name among active undecided requests; arenden by fakturanummer then personnummer, exactly-one or the beslut errors (all-or-nothing). Never auto-settles: recording the beslut and booking the payout are separate acts. Exposed as an API route and the gnubok_import_rot_rut_beslut MCP tool. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(skatteverket): system auth for background reads, one-click VAT submit, kvittens notifications Hybrid auth program: system CCG (org certificate) for background reads while personal BankID stays for interactive submissions, since SKV per-flow refresh tokens live 65 min and crons structurally cannot run on them. All system-auth code sits behind SKATTEVERKET_SYSTEM_AUTH_MODE (default off) with a stub transport until the Expisoft cert and CCG avtal land; auth resolution is centralized in resolve-auth.ts. Also in this change: - One-click VAT submit chaining kontrollera -> utkast -> las server-side with a stage discriminator; step-by-step buttons demoted to the overflow menu. - Kvittens crons (AGI + new VAT schedule) with email-only notifications, deduped in notification_log under the new skv_kvittens type. - Ombud grant probe + verification UI in the connect panel, and a dashboard promo card for unconnected companies. - skatteverket_company_connections table with pg-real coverage. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(salary): auto-settle AGI tax payment from skattekonto and surface SKV reconnect on the tax card The "Skatt att betala" card only cleared via the manual mark-paid button on the run detail page; the promised automatic flip from the Skattekonto sync was never implemented, so paid periods stayed red. - settleAgiTaxPayments: during every skattekonto sync, a booked "Arbetsgivardeklaration YYYYMM" debit row settles the matching agi_declarations.tax_paid_at, but only when the amount equals the declared total to the ore and the account is not in deficit (deterministic; drift or deficit falls back to manual). - Salary overview card: reconnect hint when the SKV token needs re-consent (link to /settings/tax, silent when the extension is off), plus an inline "Markera som betald" button reusing the existing endpoint and salary_payments strings. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Add cloud backup scheduling and alerting features - Implement unit tests for scheduling logic in `schedule.test.ts`, covering various scenarios for determining if a backup schedule is due. - Create a new module `backup-alert.ts` to handle failure alerts for cloud backup auto-sync, including email notifications for reauthentication and repeated failures. - Introduce `schedule.ts` to manage scheduling logic, including handling local time zones and converting between local and UTC hours. - Add CSV report generation functions in `archive-csv.ts` for trial balance, income statement, balance sheet, and general ledger, ensuring compatibility with Swedish Excel formats. - Create a README generator for the archive structure in `archive-readme.ts`, providing clear documentation for users accessing backup files. - Implement tests for CSV report generation in `archive-csv.test.ts`, ensuring correct formatting and content. - Establish a full-archive coverage contract test in `full-archive-coverage.pg.test.ts` to ensure all company-scoped tables are properly classified for backup. * fix(stripe): correct invoice clearing reference and improve type safety in sync logic * fix(invoices): narrow accountingMethod before resolveInvoicePaymentSourceType settleInvoicePayment takes accountingMethod as a raw settings string, but resolveInvoicePaymentSourceType requires the 'accrual' | 'cash' union. Normalize at the call site (anything but 'cash' books as accrual), matching the existing useCashEntry semantics. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix: address CodeRabbit review findings and nitpicks on PR #1004 Review findings: - backup settings redirect: always force view=export over incoming params - AGI/VAT kvittens crons: isolate best-effort post-submit calls, check the signed-state persist error, guard recovery calls in catch blocks so one company cannot abort the rest; surface grant_revoked in the run summary - kvittens notifications: atomic claim-first dedup with a partial unique index; map non-uuid reference keys to deterministic uuids - grant probe: record the actual 2xx status; mTLS transport: handle response-stream errors - stripe: amount-aware idempotency keys for payment links; emit stripe.disconnected on upstream revocations - ROT/RUT beslut import: mutate in-memory request state after apply, move item + header writes into an atomic apply_rot_rut_beslut RPC, add rot_rut_payout to JournalEntrySourceTypeSchema - migrations: use NOT VALID + VALIDATE CONSTRAINT for CHECK constraints on journal_entries, notification_log and rot_rut_payout_requests - cloud backup: hour_utc-only schedule updates clear stale hour_local Nitpicks: - stripe sync: enforce the cron time budget inside per-connection event processing with idempotent cursor progress; maybeSingle for settings; honest partial-customer DTO shared with the settlement boundary - shared applyPaymentLinkToInvoice helper for both invoice send routes, v1 docblock documents step 6b and PAYMENT_LINK_FAILED - settings panel: drop redundant decodeURIComponent - cloud backup: document worst-case archive memory headroom Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
153 lines
5.5 KiB
TypeScript
153 lines
5.5 KiB
TypeScript
import { describe, it, expect, beforeAll } from 'vitest'
|
|
import { getPool } from '@/tests/pg/setup'
|
|
import {
|
|
MASTER_DATA_DUMP_TABLES,
|
|
ARCHIVE_COVERED_ELSEWHERE_TABLES,
|
|
ARCHIVE_EXCLUDED_TABLES,
|
|
} from '@/lib/reports/full-archive-export'
|
|
|
|
/**
|
|
* Anti-rot guard for the full-archive backup (BFL 7-year retention).
|
|
*
|
|
* The säkerhetsbackup dumps company data table-by-table from an explicit list.
|
|
* That list rotted once already: salary, assets, dimensions, articles and
|
|
* rot/rut shipped without ever joining the dump, and three child tables were
|
|
* queried by a company_id column they do not have (silent error stubs in every
|
|
* backup). This test makes the schema and the dump contract converge:
|
|
*
|
|
* every public base table with a company_id column must be classified as
|
|
* DUMPED, COVERED ELSEWHERE in the archive, or EXCLUDED with a reason.
|
|
*
|
|
* A migration adding a company-scoped table fails here until the author makes
|
|
* an explicit call about its place in the backup.
|
|
*/
|
|
|
|
interface ColumnRow {
|
|
table_name: string
|
|
column_name: string
|
|
}
|
|
|
|
let columnsByTable: Map<string, Set<string>>
|
|
|
|
beforeAll(async () => {
|
|
const { rows } = await getPool().query<ColumnRow>(`
|
|
SELECT c.table_name, c.column_name
|
|
FROM information_schema.columns c
|
|
JOIN information_schema.tables t
|
|
ON t.table_schema = c.table_schema AND t.table_name = c.table_name
|
|
WHERE c.table_schema = 'public'
|
|
AND t.table_type = 'BASE TABLE'
|
|
`)
|
|
columnsByTable = new Map()
|
|
for (const row of rows) {
|
|
let set = columnsByTable.get(row.table_name)
|
|
if (!set) {
|
|
set = new Set()
|
|
columnsByTable.set(row.table_name, set)
|
|
}
|
|
set.add(row.column_name)
|
|
}
|
|
})
|
|
|
|
function companyScopedTables(): string[] {
|
|
return [...columnsByTable.entries()]
|
|
.filter(([, cols]) => cols.has('company_id'))
|
|
.map(([name]) => name)
|
|
.sort()
|
|
}
|
|
|
|
describe('full-archive coverage contract', () => {
|
|
it('classifies every company-scoped table (new tables must be triaged)', () => {
|
|
const dumped = new Set(MASTER_DATA_DUMP_TABLES.map((t) => t.name))
|
|
const covered = new Set(Object.keys(ARCHIVE_COVERED_ELSEWHERE_TABLES))
|
|
const excluded = new Set(Object.keys(ARCHIVE_EXCLUDED_TABLES))
|
|
|
|
const unclassified = companyScopedTables().filter(
|
|
(t) => !dumped.has(t) && !covered.has(t) && !excluded.has(t)
|
|
)
|
|
|
|
expect(
|
|
unclassified,
|
|
`Company-scoped tables missing from the backup contract: ${unclassified.join(', ')}. ` +
|
|
'Add each to MASTER_DATA_DUMP_TABLES, ARCHIVE_COVERED_ELSEWHERE_TABLES or ' +
|
|
'ARCHIVE_EXCLUDED_TABLES in lib/reports/full-archive-export.ts (with a reason).'
|
|
).toEqual([])
|
|
})
|
|
|
|
it('classifies only tables that actually exist (catches renames and drops)', () => {
|
|
const allClassified = [
|
|
...MASTER_DATA_DUMP_TABLES.map((t) => t.name),
|
|
...Object.keys(ARCHIVE_COVERED_ELSEWHERE_TABLES),
|
|
...Object.keys(ARCHIVE_EXCLUDED_TABLES),
|
|
]
|
|
const missing = allClassified.filter((t) => !columnsByTable.has(t))
|
|
expect(
|
|
missing,
|
|
`Classified tables that no longer exist in the schema: ${missing.join(', ')}`
|
|
).toEqual([])
|
|
})
|
|
|
|
it('keeps the three classification buckets disjoint', () => {
|
|
const dumped = MASTER_DATA_DUMP_TABLES.map((t) => t.name)
|
|
const covered = Object.keys(ARCHIVE_COVERED_ELSEWHERE_TABLES)
|
|
const excluded = Object.keys(ARCHIVE_EXCLUDED_TABLES)
|
|
const seen = new Set<string>()
|
|
const duplicates: string[] = []
|
|
for (const name of [...dumped, ...covered, ...excluded]) {
|
|
if (seen.has(name)) duplicates.push(name)
|
|
seen.add(name)
|
|
}
|
|
expect(duplicates).toEqual([])
|
|
})
|
|
|
|
it('dumps direct tables by an existing company_id column', () => {
|
|
const broken = MASTER_DATA_DUMP_TABLES.filter(
|
|
(t) => !t.via && !columnsByTable.get(t.name)?.has('company_id')
|
|
).map((t) => t.name)
|
|
expect(
|
|
broken,
|
|
`Direct dump tables without a company_id column (the query would error and ` +
|
|
`the backup would contain an error stub): ${broken.join(', ')}`
|
|
).toEqual([])
|
|
})
|
|
|
|
it('pages every dump table by an existing unique key', () => {
|
|
const broken = MASTER_DATA_DUMP_TABLES.filter(
|
|
(t) => !columnsByTable.get(t.name)?.has(t.pageKey ?? 'id')
|
|
).map((t) => `${t.name}.${t.pageKey ?? 'id'}`)
|
|
expect(broken, `page keys missing from schema: ${broken.join(', ')}`).toEqual([])
|
|
})
|
|
|
|
it('fetches via-tables through a real parent/fk relationship', () => {
|
|
for (const t of MASTER_DATA_DUMP_TABLES) {
|
|
if (!t.via) continue
|
|
const childCols = columnsByTable.get(t.name)
|
|
expect(childCols, `via-table ${t.name} does not exist`).toBeDefined()
|
|
expect(
|
|
childCols!.has(t.via.fk),
|
|
`via-table ${t.name} has no column ${t.via.fk}`
|
|
).toBe(true)
|
|
expect(
|
|
childCols!.has('company_id'),
|
|
`via-table ${t.name} HAS a company_id column: dump it directly instead`
|
|
).toBe(false)
|
|
expect(
|
|
columnsByTable.get(t.via.parent)?.has('company_id'),
|
|
`via-parent ${t.via.parent} of ${t.name} has no company_id column`
|
|
).toBe(true)
|
|
}
|
|
})
|
|
|
|
it('orders every dump query by columns that exist', () => {
|
|
const broken = MASTER_DATA_DUMP_TABLES.filter(
|
|
(t) => t.orderBy && !columnsByTable.get(t.name)?.has(t.orderBy)
|
|
).map((t) => `${t.name}.${t.orderBy}`)
|
|
expect(broken, `orderBy columns missing from schema: ${broken.join(', ')}`).toEqual([])
|
|
})
|
|
|
|
it('writes each table to a unique file', () => {
|
|
const files = MASTER_DATA_DUMP_TABLES.map((t) => t.file)
|
|
expect(new Set(files).size).toBe(files.length)
|
|
})
|
|
})
|