Files
accounted/lib/deadlines/status-engine.ts
T
Jakob Wennberg f8504f3bd0 fix: audit batch — pagination truncation, MFA/dead-code cleanup, mark-paid fail-closed (#841)
* fix(reports): paginate 8 more report/ledger queries (1000-row truncation)

Raw .select() without fetchAllRows() silently caps at PostgREST's 1000-row
limit, producing wrong statutory output for high-volume companies. Following
#806 (trial-balance/VAT), wrap the remaining offenders in
fetchAllRows + a stable .order('id') + dedupeBy:

- ink2-engine / ne-engine: INK2 & NE-bilaga tax declarations under-counted
- ar-reconciliation (1510/1513), supplier-reconciliation (2440): phantom
  "Ej avstämd" gaps
- full-archive-export: 7-year DR archive (added a unique total order so rows
  are not silently skipped/duplicated across pages)
- avgifter-basis, currency-revaluation, vat-declaration

Adds a regression guard test asserting >1000 ledger lines are summed, not
truncated at 1000.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(api): close extension-dispatcher MFA gap, scope /api/events to API key, sweep dead code

Security/correctness:
- ext/[...path] dispatcher now uses requireAuth() instead of inline
  supabase.auth.getUser(), enforcing MFA (AAL2) on hosted across the whole
  enabled-extension surface (banking sync, document upload/booking, supplier
  invoices, migration). Ratchets antipatterns-baseline raw-route-auth 168->165.
- /api/events now filters by the API key's bound company_id instead of the
  user's active company (was a cross-company read with a scoped key).
- enable-banking OAuth callback calls ensureInitialized() at module load so
  the PSD2 consent audit event (ASVS V16 / GDPR Art.30) isn't dropped on a
  cold-start instance.

Dead-code sweep (all confirmed zero importers):
- delete lib/tax/calculator.ts, lib/salary/engangsskatt.ts (+test),
  lib/email/resend.ts, lib/salary/salary-transaction-matcher.ts,
  lib/webhooks/diff.ts, lib/salary/effective-values.ts,
  lib/bookkeeping/template-prompt.ts
- trim unused lib/vat/eu-countries.ts helpers (keep EU_COUNTRIES)
- remove dead getAutomaticStatus() and the abandoned Activepieces CSP entry

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(invoices): fail closed when a payment journal entry doesn't post

Three mark-paid paths (legacy route, v1 API, agent commit) diverged on the
"mark paid but the JE failed" case — two would flip the invoice to paid (or
leave an orphaned posted voucher) with no booking, silently diverging the GL
from the AR/AP sub-ledger. Unify on fail-closed:

- legacy + v1 + agent commitMarkInvoicePaid: never mark paid without a posted
  voucher; on a null/failed JE return INVOICE_PAID_BOOK_FAILED before any
  state mutation (v1 mirrors the match-invoice strict mode).
- agent path: add the .in('status',[...]).select('id') CAS guard and cancel
  the orphaned voucher (cancelOrphanedPaymentEntry) on a lost race or update
  error, matching the web route.
- legacy route: cancel the orphan on a non-race update error too (was only
  handled on the race branch).
- supplier mark-paid: stop swallowing a failed supplier_invoice_payments
  insert — that row drives the reversal amount in payment-sync; roll back the
  status flip and cancel the voucher instead.
- pending-ops orchestrator: error-check the terminal 'committed' write so an
  op stranded in 'committing' (the expire sweep only targets 'pending') is at
  least logged loudly.

Adds a guard test for the legacy fail-closed path. Full unit suite green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(ci): unblock core build + address compliance-review findings

- avgifter-basis.ts: fix the core-build TypeScript error — PostgREST's
  type-level select parser models the salary_run embed as an array, which
  wasn't assignable to the object-typed generic. Type it `unknown` (rows are
  read via an explicit cast), making it robust across postgrest-js versions.
- /api/events: add a non-null companyId guard before the event_log query
  (defense-in-depth for the API-key-bound scope) — addresses ASVS V8.2.1 /
  ISO A.5.15.
- supplier mark-paid: add a CAS guard (.eq('status', newStatus)) to the
  payment-insert-failure rollback so a concurrent settlement can't be
  clobbered — addresses ASVS V2.3.
- dispatcher: add an AAL2 regression test asserting a non-MFA session is
  rejected (403) and the extension handler never runs — addresses the
  GDPR Art.32 review ask for the single extension chokepoint.

Verified deletions are safe: effective-values.ts was a dead duplicate — the
live AGI/payslip path inlines the same `?? override` coalescing
(generate-declaration.ts), so AGI correctness is unaffected.

next build: exit 0. Full unit suite: 6147 passing. ESLint clean.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-30 14:34:23 +02:00

202 lines
5.9 KiB
TypeScript

/**
* Status engine for deadline status transitions
*
* Status flow:
* upcoming ──(14d före)──> action_needed ──(manuell)──> in_progress
* │ │
* │ ──(manuell)──> submitted ──> confirmed
* │
* (passerad)
* │
* v
* overdue
*/
import { SupabaseClient } from '@supabase/supabase-js'
import { createLogger } from '@/lib/logger'
import type { DeadlineStatus } from '@/types'
const log = createLogger('deadline-status')
/**
* Number of days before deadline when status changes to action_needed
*/
export const ACTION_NEEDED_THRESHOLD_DAYS = 14
/**
* Valid manual status transitions
*/
export const MANUAL_TRANSITIONS: Record<DeadlineStatus, DeadlineStatus[]> = {
upcoming: ['action_needed', 'in_progress'],
action_needed: ['in_progress', 'submitted'],
in_progress: ['submitted', 'action_needed'],
submitted: ['confirmed', 'in_progress'],
confirmed: [], // Terminal state
overdue: ['in_progress', 'submitted'], // Can recover from overdue
}
/**
* Check if a manual status transition is valid
*/
export function isValidTransition(
currentStatus: DeadlineStatus,
newStatus: DeadlineStatus
): boolean {
return MANUAL_TRANSITIONS[currentStatus].includes(newStatus)
}
/**
* Calculate days until a deadline
*/
export function daysUntilDeadline(dueDate: string): number {
const today = new Date()
today.setHours(0, 0, 0, 0)
const deadline = new Date(dueDate)
deadline.setHours(0, 0, 0, 0)
return Math.ceil((deadline.getTime() - today.getTime()) / (1000 * 60 * 60 * 24))
}
/**
* Update deadline statuses automatically (called by daily cron)
*/
export async function updateDeadlineStatuses(
supabase: SupabaseClient
): Promise<{ updated: number; newlyOverdue: number; newlyActionNeeded: number }> {
const today = new Date()
today.setHours(0, 0, 0, 0)
const todayStr = today.toISOString().split('T')[0]
// Calculate the action_needed threshold date
const thresholdDate = new Date(today)
thresholdDate.setDate(thresholdDate.getDate() + ACTION_NEEDED_THRESHOLD_DAYS)
const thresholdStr = thresholdDate.toISOString().split('T')[0]
let updated = 0
let newlyOverdue = 0
let newlyActionNeeded = 0
// 1. Mark overdue: past deadline, not completed, not submitted/confirmed
const { data: overdueDeadlines, error: overdueError } = await supabase
.from('deadlines')
.update({
status: 'overdue',
status_changed_at: new Date().toISOString(),
})
.lt('due_date', todayStr)
.eq('is_completed', false)
.in('status', ['upcoming', 'action_needed'])
.select('id')
if (overdueError) {
log.error('Error updating overdue deadlines:', overdueError)
} else {
newlyOverdue = overdueDeadlines?.length || 0
updated += newlyOverdue
}
// 2. Mark action_needed: within threshold, currently upcoming
const { data: actionNeededDeadlines, error: actionNeededError } = await supabase
.from('deadlines')
.update({
status: 'action_needed',
status_changed_at: new Date().toISOString(),
})
.gte('due_date', todayStr)
.lte('due_date', thresholdStr)
.eq('status', 'upcoming')
.eq('is_completed', false)
.select('id')
if (actionNeededError) {
log.error('Error updating action_needed deadlines:', actionNeededError)
} else {
newlyActionNeeded = actionNeededDeadlines?.length || 0
updated += newlyActionNeeded
}
return { updated, newlyOverdue, newlyActionNeeded }
}
/**
* Manually update a deadline's status
*/
export async function updateDeadlineStatus(
supabase: SupabaseClient,
deadlineId: string,
companyId: string,
newStatus: DeadlineStatus
): Promise<{ success: boolean; error?: string }> {
// Fetch current deadline
const { data: deadline, error: fetchError } = await supabase
.from('deadlines')
.select('status, is_completed')
.eq('id', deadlineId)
.eq('company_id', companyId)
.single()
if (fetchError || !deadline) {
return { success: false, error: 'Deadline not found' }
}
// Check if transition is valid
if (!isValidTransition(deadline.status, newStatus)) {
return {
success: false,
error: `Invalid transition from ${deadline.status} to ${newStatus}`,
}
}
// Update the status
const updates: Record<string, unknown> = {
status: newStatus,
status_changed_at: new Date().toISOString(),
}
// If marking as confirmed, also mark as completed
if (newStatus === 'confirmed') {
updates.is_completed = true
updates.completed_at = new Date().toISOString()
}
const { error: updateError } = await supabase
.from('deadlines')
.update(updates)
.eq('id', deadlineId)
.eq('company_id', companyId)
if (updateError) {
return { success: false, error: updateError.message }
}
return { success: true }
}
/**
* Get deadlines that need attention (action_needed or overdue)
*/
export async function getDeadlinesNeedingAttention(
supabase: SupabaseClient,
companyId: string
): Promise<{
actionNeeded: Array<{ id: string; title: string; due_date: string; tax_deadline_type: string | null }>
overdue: Array<{ id: string; title: string; due_date: string; tax_deadline_type: string | null }>
}> {
const { data: deadlines, error } = await supabase
.from('deadlines')
.select('id, title, due_date, tax_deadline_type, status')
.eq('company_id', companyId)
.eq('is_completed', false)
.in('status', ['action_needed', 'overdue'])
.order('due_date', { ascending: true })
if (error) {
log.error('Error fetching deadlines needing attention:', error)
return { actionNeeded: [], overdue: [] }
}
const actionNeeded = deadlines?.filter((d) => d.status === 'action_needed') || []
const overdue = deadlines?.filter((d) => d.status === 'overdue') || []
return { actionNeeded, overdue }
}