Jakob Wennberg
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
56 lines
2.2 KiB
TypeScript
56 lines
2.2 KiB
TypeScript
import type { CreateJournalEntryLineInput } from '@/types'
|
|
|
|
export type DispositionKind =
|
|
| 'bolagsskatt'
|
|
| 'periodiseringsfond_avsattning'
|
|
| 'periodiseringsfond_ateforing'
|
|
| 'overavskrivningar'
|
|
| 'sarskild_loneskatt'
|
|
| 'uppskjuten_skatt'
|
|
|
|
/**
|
|
* Common shape every bokslut-disposition calculator returns. The wizard renders
|
|
* one card per proposal; the API endpoint accepts a list of `{ kind, accept,
|
|
* overrideAmount? }` from the user and posts the matching entries.
|
|
*/
|
|
export interface ProposedDisposition {
|
|
kind: DispositionKind
|
|
/** Short Swedish label for UI cards (e.g. "Bolagsskatt 20,6 %"). */
|
|
label: string
|
|
/** One-sentence Swedish explanation of what the entry does. */
|
|
description: string
|
|
/** SEK amount displayed in the card header. Always a positive number. */
|
|
amount: number
|
|
/** Final voucher lines if the user accepts. Already balanced. */
|
|
lines: CreateJournalEntryLineInput[]
|
|
/** Soft warnings the UI surfaces beside the card (e.g. forced p-fond reversal,
|
|
* rate cap reached). Not blockers. */
|
|
warnings: string[]
|
|
/** Calculator-specific breakdown the UI can render in an "Visa beräkning"
|
|
* panel. Free-form so each calculator can show its own details. */
|
|
computation?: Record<string, unknown>
|
|
/** True if this proposal cannot be skipped: e.g. periodiseringsfond from
|
|
* tax year N-6 that must be reversed. UI disables the skip control. */
|
|
required?: boolean
|
|
}
|
|
|
|
/**
|
|
* Snapshot of all proposed dispositions for a fiscal period, returned by the
|
|
* dispositions API. Order is the suggested user-flow order: p-fond återföring
|
|
* (mandatory) → överavskrivningar → p-fond avsättning → SLP → bolagsskatt.
|
|
* The wizard renders them in that order so each step's effect is visible to
|
|
* the next one (bolagsskatt comes last because it depends on everything else).
|
|
*/
|
|
export interface DispositionsProposal {
|
|
entityType: 'aktiebolag' | 'enskild_firma' | 'handelsbolag' | 'kommanditbolag' | 'ekonomisk_forening'
|
|
fiscalPeriod: {
|
|
id: string
|
|
name: string
|
|
period_start: string
|
|
period_end: string
|
|
}
|
|
/** Result before any new dispositions, from the income statement (positive = profit). */
|
|
netResultBefore: number
|
|
proposals: ProposedDisposition[]
|
|
}
|