ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
116 lines
3.3 KiB
TypeScript
116 lines
3.3 KiB
TypeScript
import { NextResponse } from 'next/server'
|
|
import type { SupabaseClient } from '@supabase/supabase-js'
|
|
import { getActiveCompanyId } from '@/lib/company/context'
|
|
import type { CompanyRole } from '@/types'
|
|
|
|
/**
|
|
* Write-permission guard for API routes.
|
|
*
|
|
* Looks up the caller's role in the currently active company. Returns a
|
|
* 403 JSON response if the role is 'viewer' (or if the user has no role
|
|
* in any resolvable company). Any other role (owner / admin / member)
|
|
* passes.
|
|
*
|
|
* Meant to be called AFTER `requireAuth()` in every API route that
|
|
* mutates tenant data (POST / PATCH / PUT / DELETE). Read-only POSTs
|
|
* that only generate PDFs or run utility lookups (e.g. VAT validation)
|
|
* should skip this check.
|
|
*
|
|
* This is the application-layer half of the defense-in-depth story; the
|
|
* RLS helper `public.current_user_can_write()` is the database half.
|
|
* Having both means a viewer who bypasses the JS UI and calls the API
|
|
* directly still gets a clean 403, and even if someone forgets to add
|
|
* this guard to a new route, the RLS policy blocks the write at the
|
|
* database layer.
|
|
*/
|
|
type WritePermissionResult =
|
|
| { ok: true }
|
|
| { ok: false; response: NextResponse }
|
|
|
|
export async function requireWritePermission(
|
|
supabase: SupabaseClient,
|
|
userId: string,
|
|
): Promise<WritePermissionResult> {
|
|
const companyId = await getActiveCompanyId(supabase, userId)
|
|
|
|
if (!companyId) {
|
|
return {
|
|
ok: false,
|
|
response: NextResponse.json(
|
|
{ error: 'Inget aktivt företag.' },
|
|
{ status: 403 },
|
|
),
|
|
}
|
|
}
|
|
|
|
const { data: membership } = await supabase
|
|
.from('company_members')
|
|
.select('role')
|
|
.eq('company_id', companyId)
|
|
.eq('user_id', userId)
|
|
.maybeSingle()
|
|
|
|
if (!membership || membership.role === 'viewer') {
|
|
return {
|
|
ok: false,
|
|
response: NextResponse.json(
|
|
{ error: 'Du har endast läsbehörighet i detta företag.' },
|
|
{ status: 403 },
|
|
),
|
|
}
|
|
}
|
|
|
|
return { ok: true }
|
|
}
|
|
|
|
/**
|
|
* Resolves the caller's role in the active company without blocking viewers.
|
|
*
|
|
* Unlike `requireWritePermission()` (which returns 403 for viewers), this
|
|
* returns the actual role so the caller can make conditional decisions:
|
|
* e.g. allowing viewers to import raw bank transactions but nothing else.
|
|
*
|
|
* Use `requireWritePermission()` for routes that are fully off-limits to
|
|
* viewers. Use `getCompanyRole()` only when the route needs viewer-
|
|
* conditional behavior.
|
|
*/
|
|
export type CompanyRoleResult =
|
|
| { ok: true; role: CompanyRole; companyId: string }
|
|
| { ok: false; response: NextResponse }
|
|
|
|
export async function getCompanyRole(
|
|
supabase: SupabaseClient,
|
|
userId: string,
|
|
): Promise<CompanyRoleResult> {
|
|
const companyId = await getActiveCompanyId(supabase, userId)
|
|
|
|
if (!companyId) {
|
|
return {
|
|
ok: false,
|
|
response: NextResponse.json(
|
|
{ error: 'Inget aktivt företag.' },
|
|
{ status: 403 },
|
|
),
|
|
}
|
|
}
|
|
|
|
const { data: membership } = await supabase
|
|
.from('company_members')
|
|
.select('role')
|
|
.eq('company_id', companyId)
|
|
.eq('user_id', userId)
|
|
.maybeSingle()
|
|
|
|
if (!membership) {
|
|
return {
|
|
ok: false,
|
|
response: NextResponse.json(
|
|
{ error: 'Du har ingen roll i detta företag.' },
|
|
{ status: 403 },
|
|
),
|
|
}
|
|
}
|
|
|
|
return { ok: true, role: membership.role as CompanyRole, companyId }
|
|
}
|