Jakob WennbergandClaude Sonnet 5
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
57 lines
2.1 KiB
TypeScript
57 lines
2.1 KiB
TypeScript
import { NextResponse } from 'next/server'
|
|
import { generateDimensionPnl } from '@/lib/reports/dimension-pnl'
|
|
import { withRouteContext } from '@/lib/api/with-route-context'
|
|
import { errorResponseFromCode } from '@/lib/errors/get-structured-error'
|
|
import { parseReportDateRange } from '@/lib/reports/date-range'
|
|
|
|
// Resultat per projekt/kostnadsställe: value-as-column P&L matrix over one
|
|
// SIE dimension. ?dim_no picks the dimension (default 6, projekt).
|
|
export const GET = withRouteContext(
|
|
'report.dimension_pnl',
|
|
async (request, ctx) => {
|
|
const { supabase, companyId, log, requestId } = ctx
|
|
|
|
const { searchParams } = new URL(request.url)
|
|
const periodId = searchParams.get('period_id')
|
|
const dimNo = searchParams.get('dim_no') ?? '6'
|
|
|
|
if (!periodId) {
|
|
return errorResponseFromCode('REPORT_PERIOD_REQUIRED', log, { requestId })
|
|
}
|
|
if (!/^[1-9]\d{0,3}$/.test(dimNo)) {
|
|
return NextResponse.json({ error: 'dim_no must be an SIE dimension number' }, { status: 400 })
|
|
}
|
|
|
|
const { data: period } = await supabase
|
|
.from('fiscal_periods')
|
|
.select('period_start, period_end')
|
|
.eq('id', periodId)
|
|
.eq('company_id', companyId)
|
|
.single()
|
|
|
|
if (!period) {
|
|
return NextResponse.json({ error: 'Fiscal period not found' }, { status: 404 })
|
|
}
|
|
|
|
const parsed = parseReportDateRange(searchParams, period)
|
|
if (!parsed.ok) {
|
|
return NextResponse.json({ error: parsed.error }, { status: 400 })
|
|
}
|
|
|
|
try {
|
|
// Only toDate: the matrix is cumulative from period_start by design
|
|
// (closing-balance semantics; see lib/reports/dimension-pnl.ts).
|
|
const data = await generateDimensionPnl(supabase, companyId!, periodId, dimNo, {
|
|
toDate: parsed.range.toDate,
|
|
})
|
|
return NextResponse.json({ data })
|
|
} catch (err) {
|
|
log.error('dimension pnl generation failed', err as Error, { periodId, dimNo })
|
|
return errorResponseFromCode('REPORT_GENERATION_FAILED', log, {
|
|
requestId,
|
|
details: { reason: err instanceof Error ? err.message : 'unknown' },
|
|
})
|
|
}
|
|
},
|
|
)
|