Files
accounted/app/api/deadlines/route.ts
T
Jakob WennbergandClaude Fable 5 3c0bf3f584 feat(deadlines): gate F-skatt reminders on debited preliminary tax + durable dismissal (#1057)
* feat(deadlines): gate F-skatt reminders on debited preliminary tax, add durable dismissal

The f_skatt deadline was gated on the F-skatt approval flag (DB default
true), giving nearly every company 12 monthly payment reminders for a tax
Skatteverket may not have debited at all (64% of all system deadline rows,
one lifetime completion). Approval carries no recurring obligation; the
monthly duty is payment of debiterad preliminarskatt and exists only while
the debited amount is > 0 (SFL 62 kap. 4-5 par., 55 kap. 2 par.).

- Gate the f_skatt deadline on preliminary_tax_monthly > 0 (field already
  collected at onboarding, previously unread) and retitle it as a payment.
- Storforetag keep the 12th in August (January-only 17th, 62 kap. 3 par.).
- Declare the prod-only preliminary_tax_monthly column in a migration so
  installs built purely from migrations stop failing tax-settings saves.
- Add deadlines.dismissed_at: DELETE on a system deadline now soft-dismisses
  it durably (hard deletes were resurrected by the nightly backfill within
  24h); generator, backfill, and every read surface respect it.
- Prune upcoming f_skatt rows for companies with no debited amount.

Closes part of #1028.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(deadlines): include dismissed_at in DeadlineForm payload

The Deadline type gained the required dismissed_at field; the form's
submit payload literal must carry it for the Omit<Deadline, ...> shape.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(deadlines): make system-deadline dismissal atomic

Constrain the dismiss update to source='system' and verify a row was
actually updated: a concurrent regeneration can delete the row between
lookup and update, and the route must not report a phantom success.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-17 15:48:25 +02:00

99 lines
2.6 KiB
TypeScript

import { NextResponse } from 'next/server'
import { withRouteContext } from '@/lib/api/with-route-context'
import { validateBody } from '@/lib/api/validate'
import { CreateDeadlineSchema } from '@/lib/api/schemas'
/**
* GET /api/deadlines
* List deadlines for the authenticated user
* Query params:
* - status: 'all' | 'pending' | 'completed' (default: 'all')
* - type: DeadlineType (optional)
* - from: ISO date string (optional)
* - to: ISO date string (optional)
*/
export const GET = withRouteContext('deadline.list', async (request, ctx) => {
const { supabase, companyId } = ctx
// Parse query params
const { searchParams } = new URL(request.url)
const status = searchParams.get('status') || 'all'
const type = searchParams.get('type')
const from = searchParams.get('from')
const to = searchParams.get('to')
// Build query. Dismissed system deadlines are an explicit opt-out and
// never listed.
let query = supabase
.from('deadlines')
.select('*, customer:customers(id, name)')
.eq('company_id', companyId)
.is('dismissed_at', null)
// Apply filters
if (status === 'pending') {
query = query.eq('is_completed', false)
} else if (status === 'completed') {
query = query.eq('is_completed', true)
}
if (type) {
query = query.eq('deadline_type', type)
}
if (from) {
query = query.gte('due_date', from)
}
if (to) {
query = query.lte('due_date', to)
}
const { data, error } = await query.order('due_date', { ascending: true })
if (error) {
return NextResponse.json({ error: error.message }, { status: 500 })
}
return NextResponse.json({ data })
})
/**
* POST /api/deadlines
* Create a new deadline
*/
export const POST = withRouteContext(
'deadline.create',
async (request, ctx) => {
const { supabase, companyId, user } = ctx
const validation = await validateBody(request, CreateDeadlineSchema)
if (!validation.success) return validation.response
const body = validation.data
// Insert the deadline
const { data, error } = await supabase
.from('deadlines')
.insert({
user_id: user.id,
company_id: companyId,
title: body.title,
due_date: body.due_date,
due_time: body.due_time || null,
deadline_type: body.deadline_type,
priority: body.priority || 'normal',
customer_id: body.customer_id || null,
notes: body.notes || null,
})
.select('*, customer:customers(id, name)')
.single()
if (error) {
return NextResponse.json({ error: error.message }, { status: 500 })
}
return NextResponse.json({ data })
},
{ requireWrite: true },
)