Jakob WennbergandClaude Fable 5
fb3f0a9cee
The dual-write window ends (dev_docs/dimensions_implementation_plan.md PR9): journal_entry_lines.cost_center/project are now GENERATED ALWAYS AS (NULLIF(dimensions->>'1'/'6','')) STORED — divergence from the bag is impossible by construction instead of by convention. - migration 20260702230000: drift pre-flight (refuses cutover on inconsistent data; prod verified 0 drift across 593k rows), column swap (DROP metadata-only + one-rewrite ADD pair), and atomic redefinition of the two SQL writers — retag_line_dimensions (SET dimensions only) and bulk_book_transactions (INSERT names the bag only) - TS writers stripped of the mirror spread: engine buildLineInserts (covers create/update/reversal), storno-service (reversal + correction), SIE import bulk insert, sandbox seed - lineDimensionColumns() removed from dimension-resolver — nothing derives mirrors in TypeScript anymore; normalizeLineDimensions + the deprecated cost_center/project INPUT aliases stay (API contract, they normalize into the bag); JournalEntryLine ROW type keeps the fields (generated columns still SELECT) - immutability carve-out unchanged BY DESIGN: its whole-row diff already subtracts dimensions/cost_center/project on both sides, which is exactly what makes it correct with generated columns (BEFORE-trigger NEW carries not-yet-recomputed mirror values) - audited every reader (v1 journal-entries, MCP query_journal filters + group_by, rc-basis-gaps) — reads are untouched; no index, view, or constraint referenced the TEXT columns, so DROP COLUMN cascades nothing - new pg suite: generated derivation, explicit-mirror-write rejection, draft-update recompute; existing retag/substrate/bulk-book suites updated to bag-only writes (their mirror assertions now exercise the generation expression) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
100 lines
3.8 KiB
TypeScript
100 lines
3.8 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import {
|
|
insertAuthUser,
|
|
insertCompany,
|
|
insertCompanyMember,
|
|
insertFiscalPeriod,
|
|
insertDraftJournalEntry,
|
|
} from '@/tests/pg/fixtures'
|
|
import { getPool } from '@/tests/pg/setup'
|
|
|
|
/**
|
|
* Covers 20260702230000_dimensions_generated_column_cutover (dimensions PR9):
|
|
*
|
|
* - cost_center/project are GENERATED ALWAYS AS (NULLIF(dimensions->>'1'/'6',''))
|
|
* STORED — inserting only the bag produces the same mirror values the
|
|
* dual-write produced.
|
|
* - An INSERT that names either mirror column errors (the reason every
|
|
* writer was stripped in this PR).
|
|
* - The retag RPC (redefined here to SET only the bag) still updates a
|
|
* posted line under its carve-out, and the mirrors recompute.
|
|
*/
|
|
|
|
async function seedTenant() {
|
|
const userId = await insertAuthUser()
|
|
const companyId = await insertCompany({ createdBy: userId })
|
|
await insertCompanyMember({ companyId, userId, role: 'owner' })
|
|
const fiscalPeriodId = await insertFiscalPeriod({
|
|
userId,
|
|
companyId,
|
|
periodStart: '2026-01-01',
|
|
periodEnd: '2026-12-31',
|
|
})
|
|
return { userId, companyId, fiscalPeriodId }
|
|
}
|
|
|
|
describe('journal_entry_lines generated mirrors (PR9 cutover)', () => {
|
|
it('derives cost_center/project from the bag on insert; empty bag yields NULLs', async () => {
|
|
const { userId, companyId, fiscalPeriodId } = await seedTenant()
|
|
const entryId = await insertDraftJournalEntry({ userId, companyId, fiscalPeriodId })
|
|
|
|
const { rows } = await getPool().query<{
|
|
dimensions: Record<string, string>
|
|
cost_center: string | null
|
|
project: string | null
|
|
}>(
|
|
`INSERT INTO public.journal_entry_lines
|
|
(journal_entry_id, account_number, debit_amount, credit_amount, dimensions)
|
|
VALUES ($1, '4010', 1000, 0, '{"1":"KS01","6":"P001"}'::jsonb),
|
|
($1, '1930', 0, 1000, '{}'::jsonb)
|
|
RETURNING dimensions, cost_center, project`,
|
|
[entryId],
|
|
)
|
|
|
|
const tagged = rows.find((r) => r.dimensions['1'])!
|
|
expect(tagged.cost_center).toBe('KS01')
|
|
expect(tagged.project).toBe('P001')
|
|
|
|
const untagged = rows.find((r) => !r.dimensions['1'])!
|
|
expect(untagged.cost_center).toBeNull()
|
|
expect(untagged.project).toBeNull()
|
|
})
|
|
|
|
it('rejects an INSERT that names a mirror column explicitly', async () => {
|
|
const { userId, companyId, fiscalPeriodId } = await seedTenant()
|
|
const entryId = await insertDraftJournalEntry({ userId, companyId, fiscalPeriodId })
|
|
|
|
await expect(
|
|
getPool().query(
|
|
`INSERT INTO public.journal_entry_lines
|
|
(journal_entry_id, account_number, debit_amount, credit_amount, dimensions, cost_center)
|
|
VALUES ($1, '4010', 1000, 0, '{"1":"KS01"}'::jsonb, 'KS01')`,
|
|
[entryId],
|
|
),
|
|
).rejects.toThrow(/non-DEFAULT value into column/i)
|
|
})
|
|
|
|
it('mirrors recompute when a draft bag is updated (bag-only write)', async () => {
|
|
const { userId, companyId, fiscalPeriodId } = await seedTenant()
|
|
const entryId = await insertDraftJournalEntry({ userId, companyId, fiscalPeriodId })
|
|
const { rows } = await getPool().query<{ id: string }>(
|
|
`INSERT INTO public.journal_entry_lines
|
|
(journal_entry_id, account_number, debit_amount, credit_amount, dimensions)
|
|
VALUES ($1, '4010', 500, 0, '{"6":"P001"}'::jsonb)
|
|
RETURNING id`,
|
|
[entryId],
|
|
)
|
|
|
|
await getPool().query(
|
|
`UPDATE public.journal_entry_lines SET dimensions = '{"1":"KS02"}'::jsonb WHERE id = $1`,
|
|
[rows[0].id],
|
|
)
|
|
const after = await getPool().query<{ cost_center: string | null; project: string | null }>(
|
|
`SELECT cost_center, project FROM public.journal_entry_lines WHERE id = $1`,
|
|
[rows[0].id],
|
|
)
|
|
expect(after.rows[0].cost_center).toBe('KS02')
|
|
expect(after.rows[0].project).toBeNull()
|
|
})
|
|
})
|