Files
accounted/lib/reports/__tests__/continuity-check.test.ts
T
Jakob WennbergandClaude Opus 4.8 fce6faff2c fix(api): stabilize report pagination + declare real { data, meta } envelope on v1 single/write endpoints (#811)
* fix(reports): stabilize fetchAllRows paging to stop doubled/dropped balances (#790, #791)

PostgREST `.range()` paging is only correct when the underlying query has a
stable TOTAL order. Several aggregating report queries (general ledger, trial
balance, grundbok, supplier/AR ledgers, etc.) paginated without `.order()`, so
on datasets larger than one 1000-row page Postgres could return rows in a
different order between requests — silently DUPLICATING or SKIPPING rows on a
page boundary and doubling or dropping financial totals.

- fetch-all.ts: document the ordering invariant and add an optional
  `dedupeBy` defense-in-depth that drops cross-page duplicates and warns when
  it fires (surfaces a missing `.order()` in logs instead of corrupting money).
- Add a stable `.order()` (line PK or account_number) to every paginated query
  in lib/reports/ and the account-balances route; pass `dedupeBy` on the
  money-aggregating line queries.
- Add fetch-all unit tests and update report test fixtures to carry row ids.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(api): declare the real { data, meta } envelope on v1 single/write/204 endpoints (#794)

The OpenAPI generator derives each endpoint's documented body purely from its
registered `response.success` Zod schema, and that schema is never validated at
runtime — so a route could advertise a shape its handler never sends. #802
fixed this for list endpoints; the same drift was latent on single-resource and
write endpoints, which declared the bare resource schema instead of the
`{ data, meta }` envelope the handlers actually return.

- registry.ts: extend `ResponseMetaSchema` with the optional `audit` block and
  `partial_expansions` list that writes/expansions emit; add the `NoBodyResponse`
  sentinel so 204 DELETE handlers document a bare 204 instead of a phantom 200.
- Wrap every single/write endpoint's `response.success` in `dataEnvelope(...)`
  (or `NoBodyResponse` for 204s) across the v1 routes.
- Add a response-envelope contract test that fails CI if any JSON endpoint
  forgets to wrap its schema, with binary downloads and 204s as the only
  exemptions.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(reports): extend paging dedupeBy to rc-basis-gaps and opening-balances

Address PR review: these two money-aggregating line queries already had the
stable `.order('id')` (so paging was correct) but didn't carry `id` in the
select, so they couldn't use the `dedupeBy` defense-in-depth that general-ledger
and trial-balance got. Select `id` and pass `dedupeBy: r => r.id` so the whole
report layer applies the ordering invariant consistently.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-28 13:42:50 +02:00

295 lines
10 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from 'vitest'
// ============================================================
// Mock Supabase — table-keyed result queues
// ============================================================
type MockResult = { data?: unknown; error?: unknown; count?: number }
let mockResults: Record<string, MockResult[]>
function makeBuilder(tableName: string) {
const b: Record<string, unknown> = {}
for (const m of ['select', 'eq', 'in', 'lt', 'neq', 'order', 'range', 'update']) {
b[m] = vi.fn().mockReturnValue(b)
}
const consume = (): MockResult => {
const queue = mockResults[tableName]
if (!queue || queue.length === 0) return { data: null, error: null }
return queue.shift()!
}
b.single = vi.fn().mockImplementation(async () => consume())
b.then = (resolve: (v: unknown) => void) => resolve(consume())
return b
}
function makeClient() {
const rpc = vi.fn().mockImplementation(async (fn: string) => {
const queue = mockResults[`rpc:${fn}`]
if (!queue || queue.length === 0) return { data: [], error: null }
return queue.shift()!
})
return {
from: vi.fn().mockImplementation((table: string) => makeBuilder(table)),
rpc,
// eslint-disable-next-line @typescript-eslint/no-explicit-any
} as any
}
import { validateBalanceContinuity } from '../continuity-check'
let supabase: ReturnType<typeof makeClient>
beforeEach(() => {
vi.clearAllMocks()
mockResults = {}
supabase = makeClient()
})
describe('validateBalanceContinuity', () => {
it('returns valid for first period (no previous_period_id)', async () => {
mockResults = {
fiscal_periods: [
{ data: { id: 'p1', name: 'FY2024', period_start: '2024-01-01', previous_period_id: null, opening_balance_entry_id: null } },
],
}
const result = await validateBalanceContinuity(supabase, 'company-1', 'p1')
expect(result.valid).toBe(true)
expect(result.discrepancies).toEqual([])
expect(result.checked_accounts).toBe(0)
expect(result.previous_period_name).toBeNull()
})
it('returns valid when IB matches UB', async () => {
mockResults = {
fiscal_periods: [
// Target period
{ data: { id: 'p2', name: 'FY2025', period_start: '2025-01-01', previous_period_id: 'p1', opening_balance_entry_id: 'ob-1' } },
// Previous period (for name)
{ data: { id: 'p1', name: 'FY2024' } },
// Previous period (for generateTrialBalance)
{ data: { period_start: '2024-01-01', opening_balance_entry_id: null } },
],
journal_entry_lines: [
// Previous period lines (trial balance — prior OB comes from RPC, defaults empty)
{
data: [
{ account_number: '1930', debit_amount: 50000, credit_amount: 0 },
{ account_number: '2099', debit_amount: 0, credit_amount: 30000 },
{ account_number: '1510', debit_amount: 10000, credit_amount: 0 },
],
},
// Current period OB entry lines (getOpeningBalances)
{
data: [
{ account_number: '1930', debit_amount: 50000, credit_amount: 0 },
{ account_number: '2099', debit_amount: 0, credit_amount: 30000 },
{ account_number: '1510', debit_amount: 10000, credit_amount: 0 },
],
},
],
chart_of_accounts: [
{
data: [
{ account_number: '1510', account_name: 'Kundfordringar', account_class: 1 },
{ account_number: '1930', account_name: 'Företagskonto', account_class: 1 },
{ account_number: '2099', account_name: 'Årets resultat', account_class: 2 },
],
},
],
}
const result = await validateBalanceContinuity(supabase, 'company-1', 'p2')
expect(result.valid).toBe(true)
expect(result.discrepancies).toEqual([])
expect(result.checked_accounts).toBe(3)
expect(result.period_name).toBe('FY2025')
expect(result.previous_period_name).toBe('FY2024')
})
it('detects discrepancy in one account', async () => {
mockResults = {
fiscal_periods: [
{ data: { id: 'p2', name: 'FY2025', period_start: '2025-01-01', previous_period_id: 'p1', opening_balance_entry_id: 'ob-1' } },
{ data: { id: 'p1', name: 'FY2024' } },
{ data: { period_start: '2024-01-01', opening_balance_entry_id: null } },
],
journal_entry_lines: [
// Previous UB: 1930 = 50000 debit
{
data: [
{ account_number: '1930', debit_amount: 50000, credit_amount: 0 },
{ account_number: '2099', debit_amount: 0, credit_amount: 50000 },
],
},
// Current IB: 1930 = 49000 debit (mismatch!)
{
data: [
{ account_number: '1930', debit_amount: 49000, credit_amount: 0 },
{ account_number: '2099', debit_amount: 0, credit_amount: 50000 },
],
},
],
chart_of_accounts: [
{
data: [
{ account_number: '1930', account_name: 'Företagskonto', account_class: 1 },
{ account_number: '2099', account_name: 'Årets resultat', account_class: 2 },
],
},
],
}
const result = await validateBalanceContinuity(supabase, 'company-1', 'p2')
expect(result.valid).toBe(false)
expect(result.discrepancies).toHaveLength(1)
expect(result.discrepancies[0].account_number).toBe('1930')
expect(result.discrepancies[0].previous_ub_net).toBe(50000)
expect(result.discrepancies[0].current_ib_net).toBe(49000)
expect(result.discrepancies[0].difference).toBe(1000)
})
it('detects account present in UB but not IB', async () => {
mockResults = {
fiscal_periods: [
{ data: { id: 'p2', name: 'FY2025', period_start: '2025-01-01', previous_period_id: 'p1', opening_balance_entry_id: 'ob-1' } },
{ data: { id: 'p1', name: 'FY2024' } },
{ data: { period_start: '2024-01-01', opening_balance_entry_id: null } },
],
journal_entry_lines: [
// Previous UB has 1510 and 2440
{
data: [
{ account_number: '1510', debit_amount: 10000, credit_amount: 0 },
{ account_number: '2440', debit_amount: 0, credit_amount: 10000 },
],
},
// Current IB only has 1510 (2440 missing)
{
data: [
{ account_number: '1510', debit_amount: 10000, credit_amount: 0 },
],
},
],
chart_of_accounts: [
{
data: [
{ account_number: '1510', account_name: 'Kundfordringar', account_class: 1 },
{ account_number: '2440', account_name: 'Leverantörsskulder', account_class: 2 },
],
},
],
}
const result = await validateBalanceContinuity(supabase, 'company-1', 'p2')
expect(result.valid).toBe(false)
expect(result.discrepancies).toHaveLength(1)
expect(result.discrepancies[0].account_number).toBe('2440')
expect(result.discrepancies[0].previous_ub_net).toBe(-10000)
expect(result.discrepancies[0].current_ib_net).toBe(0)
})
it('detects account present in IB but not UB', async () => {
mockResults = {
fiscal_periods: [
{ data: { id: 'p2', name: 'FY2025', period_start: '2025-01-01', previous_period_id: 'p1', opening_balance_entry_id: 'ob-1' } },
{ data: { id: 'p1', name: 'FY2024' } },
{ data: { period_start: '2024-01-01', opening_balance_entry_id: null } },
],
journal_entry_lines: [
// Previous UB: only 1930
{
data: [
{ account_number: '1930', debit_amount: 50000, credit_amount: 0 },
],
},
// Current IB: 1930 + 1510 (1510 shouldn't be here)
{
data: [
{ account_number: '1930', debit_amount: 50000, credit_amount: 0 },
{ account_number: '1510', debit_amount: 5000, credit_amount: 0 },
],
},
],
chart_of_accounts: [
{
data: [
{ account_number: '1930', account_name: 'Företagskonto', account_class: 1 },
],
},
],
}
const result = await validateBalanceContinuity(supabase, 'company-1', 'p2')
expect(result.valid).toBe(false)
expect(result.discrepancies).toHaveLength(1)
expect(result.discrepancies[0].account_number).toBe('1510')
expect(result.discrepancies[0].previous_ub_net).toBe(0)
expect(result.discrepancies[0].current_ib_net).toBe(5000)
})
it('treats sub-öre float drift as valid (ORE_TOLERANCE = 0.005 SEK)', async () => {
mockResults = {
fiscal_periods: [
{ data: { id: 'p2', name: 'FY2025', period_start: '2025-01-01', previous_period_id: 'p1', opening_balance_entry_id: 'ob-1' } },
{ data: { id: 'p1', name: 'FY2024' } },
{ data: { period_start: '2024-01-01', opening_balance_entry_id: null } },
],
journal_entry_lines: [
{
data: [
{ account_number: '1930', debit_amount: 50000.001, credit_amount: 0 },
],
},
{
data: [
{ account_number: '1930', debit_amount: 50000, credit_amount: 0 },
],
},
],
chart_of_accounts: [
{
data: [
{ account_number: '1930', account_name: 'Företagskonto', account_class: 1 },
],
},
],
}
const result = await validateBalanceContinuity(supabase, 'company-1', 'p2')
expect(result.valid).toBe(true)
expect(result.discrepancies).toEqual([])
})
it('throws when period not found', async () => {
mockResults = {
fiscal_periods: [
{ data: null, error: { message: 'not found' } },
],
}
await expect(
validateBalanceContinuity(supabase, 'company-1', 'nonexistent')
).rejects.toThrow('Fiscal period not found')
})
it('throws when previous period not found', async () => {
mockResults = {
fiscal_periods: [
{ data: { id: 'p2', name: 'FY2025', period_start: '2025-01-01', previous_period_id: 'p1', opening_balance_entry_id: null } },
{ data: null, error: { message: 'not found' } },
],
}
await expect(
validateBalanceContinuity(supabase, 'company-1', 'p2')
).rejects.toThrow('Previous fiscal period not found')
})
})