ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
129 lines
4.1 KiB
TypeScript
129 lines
4.1 KiB
TypeScript
import type { SupabaseClient } from '@supabase/supabase-js'
|
|
import type { ContinuityCheckResult, ContinuityDiscrepancy } from '@/types'
|
|
import { generateTrialBalance } from './trial-balance'
|
|
import { getOpeningBalances } from './opening-balances'
|
|
import { roundOre, ORE_TOLERANCE } from '@/lib/bokslut/rounding'
|
|
|
|
/**
|
|
* Validate that a fiscal period's opening balances (IB) match the previous
|
|
* period's closing balances (UB) for all balance sheet accounts (class 1-2).
|
|
*
|
|
* Uses the same data paths as the actual reports: generateTrialBalance() for
|
|
* UB and getOpeningBalances() for IB, so a passing check proves the reports
|
|
* are consistent.
|
|
*
|
|
* Tolerance: ORE_TOLERANCE (0.005 SEK) per account. All monetary values
|
|
* funnel through roundOre() first, so a half-öre threshold is sufficient
|
|
* to absorb float drift and any larger difference is a real discrepancy.
|
|
* (Swedish öresavrundning was abolished 2010: this is purely IEEE 754
|
|
* hygiene, not a regulatory rounding.)
|
|
*/
|
|
export async function validateBalanceContinuity(
|
|
supabase: SupabaseClient,
|
|
companyId: string,
|
|
fiscalPeriodId: string
|
|
): Promise<ContinuityCheckResult> {
|
|
// Fetch target period
|
|
const { data: period, error: periodError } = await supabase
|
|
.from('fiscal_periods')
|
|
.select('id, name, period_start, previous_period_id, opening_balance_entry_id')
|
|
.eq('id', fiscalPeriodId)
|
|
.eq('company_id', companyId)
|
|
.single()
|
|
|
|
if (periodError || !period) {
|
|
throw new Error('Fiscal period not found')
|
|
}
|
|
|
|
// First period: nothing to compare against
|
|
if (!period.previous_period_id) {
|
|
return {
|
|
valid: true,
|
|
period_name: period.name,
|
|
previous_period_name: null,
|
|
discrepancies: [],
|
|
checked_accounts: 0,
|
|
}
|
|
}
|
|
|
|
// Fetch previous period name
|
|
const { data: prevPeriod } = await supabase
|
|
.from('fiscal_periods')
|
|
.select('id, name')
|
|
.eq('id', period.previous_period_id)
|
|
.eq('company_id', companyId)
|
|
.single()
|
|
|
|
if (!prevPeriod) {
|
|
throw new Error('Previous fiscal period not found')
|
|
}
|
|
|
|
// Previous period UB: trial balance filtered to class 1-2
|
|
const { rows: trialRows } = await generateTrialBalance(
|
|
supabase,
|
|
companyId,
|
|
prevPeriod.id
|
|
)
|
|
|
|
const previousUB = new Map<string, { net: number; name: string }>()
|
|
for (const row of trialRows) {
|
|
if (row.account_class >= 1 && row.account_class <= 2) {
|
|
const net = roundOre(row.closing_debit - row.closing_credit)
|
|
if (Math.abs(net) >= ORE_TOLERANCE) {
|
|
previousUB.set(row.account_number, { net, name: row.account_name })
|
|
}
|
|
}
|
|
}
|
|
|
|
// Current period IB
|
|
const { balances: ibBalances } = await getOpeningBalances(supabase, companyId, period)
|
|
|
|
const currentIB = new Map<string, number>()
|
|
for (const [accountNumber, bal] of ibBalances) {
|
|
// Only check balance sheet accounts
|
|
const accountClass = parseInt(accountNumber[0]) || 0
|
|
if (accountClass >= 1 && accountClass <= 2) {
|
|
const net = roundOre(bal.debit - bal.credit)
|
|
if (Math.abs(net) >= ORE_TOLERANCE) {
|
|
currentIB.set(accountNumber, net)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Compare all accounts from both sides
|
|
const allAccounts = new Set([...previousUB.keys(), ...currentIB.keys()])
|
|
const discrepancies: ContinuityDiscrepancy[] = []
|
|
|
|
// Get account names for IB-only accounts
|
|
const accountNames = new Map<string, string>()
|
|
for (const [num, data] of previousUB) {
|
|
accountNames.set(num, data.name)
|
|
}
|
|
|
|
for (const accountNumber of allAccounts) {
|
|
const ubNet = previousUB.get(accountNumber)?.net ?? 0
|
|
const ibNet = currentIB.get(accountNumber) ?? 0
|
|
const difference = roundOre(ubNet - ibNet)
|
|
|
|
if (Math.abs(difference) > ORE_TOLERANCE) {
|
|
discrepancies.push({
|
|
account_number: accountNumber,
|
|
account_name: accountNames.get(accountNumber) ?? `Konto ${accountNumber}`,
|
|
previous_ub_net: ubNet,
|
|
current_ib_net: ibNet,
|
|
difference,
|
|
})
|
|
}
|
|
}
|
|
|
|
discrepancies.sort((a, b) => a.account_number.localeCompare(b.account_number))
|
|
|
|
return {
|
|
valid: discrepancies.length === 0,
|
|
period_name: period.name,
|
|
previous_period_name: prevPeriod.name,
|
|
discrepancies,
|
|
checked_accounts: allAccounts.size,
|
|
}
|
|
}
|