Files
accounted/components/bookkeeping/AttachDocumentPreview.tsx
T
Jakob Wennberg ec27228a8e style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)
Em dashes (—) and en dashes (–) had spread across comments, docs, tests,
and a few UI strings, reading as AI-generated boilerplate rather than
house style. Replaced each with punctuation matching its context: colon
for explanatory clauses, comma for asides, plain hyphen for numeric/legal
ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for
paired-dash asides. messages/en.json and messages/sv.json were fixed by
hand together to keep sv/en in sync.

Left untouched where the dash is the functional subject rather than
decorative punctuation: date-range-parser.ts's separator regex,
charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE
encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the
agent system-prompt files that already instruct against em dashes, and
a golden iXBRL test fixture compared byte-for-byte.

Also fixes two bugs surfaced along the way: an off-by-one in
ApiKeysPanel's scope-label split (a leftover from an earlier partial
pass), and a charset-repair test that had lost the literal en-dash it
exists to verify.

Regenerated the agent atom seed migration (skills:generate) since 27
SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes,
with an explicit carve-out for the functional-dash cases above.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-04 15:58:06 +02:00

115 lines
4.7 KiB
TypeScript

'use client'
import { ArrowDown, AlertTriangle } from 'lucide-react'
import { formatCurrency, formatDate } from '@/lib/utils'
import { DocumentViewButton } from './DocumentViewButton'
interface AttachDocumentPreviewProps {
data: Record<string, unknown>
params: Record<string, unknown>
}
/**
* Two-card preview for `attach_document_to_transaction` operations. Renders
* the transaction and the document side by side so the reviewer can confirm
* the pairing without cross-referencing IDs.
*/
export function AttachDocumentPreview({ data, params }: AttachDocumentPreviewProps) {
const txDescription = (data.transaction_description as string) || '-'
const txAmount = data.transaction_amount as number | undefined
const txCurrency = (data.transaction_currency as string) || 'SEK'
const txDate = data.transaction_date as string | undefined
const docFileName = (data.document_file_name as string) || '-'
const docVendor = data.document_vendor_name as string | undefined
const docAmount = data.document_amount as number | undefined
const docCurrency = (data.document_currency as string) || txCurrency
const docInvoiceDate = data.document_invoice_date as string | undefined
const willOverwrite = data.will_overwrite_existing === true
const existingDocName = data.existing_document_file_name as string | undefined
// Fail safe: if the staging tool didn't explicitly assert the existing doc
// is NOT räkenskapsinformation (i.e. `=== false`), treat overwrite as a
// BFL 7 kap event. A missing/undefined flag must not silently downgrade
// the destructive warning.
const existingIsAccounting =
willOverwrite && data.existing_document_is_rakenskapsinformation !== false
const documentId = params.document_id as string | undefined
return (
<div className="space-y-3 text-sm">
<div className="grid grid-cols-1 md:grid-cols-2 gap-3">
<PreviewCard label="Transaktion">
<Row label="Datum" value={txDate ? formatDate(txDate) : '-'} tabular />
<Row label="Beskrivning" value={txDescription} />
<Row
label="Belopp"
value={typeof txAmount === 'number' ? formatCurrency(txAmount, txCurrency) : '-'}
tabular
/>
</PreviewCard>
<PreviewCard label="Dokument">
<Row label="Fil" value={docFileName} />
{docVendor && <Row label="Leverantör" value={docVendor} />}
{docInvoiceDate && <Row label="Fakturadatum" value={formatDate(docInvoiceDate)} tabular />}
{typeof docAmount === 'number' && (
<Row label="Belopp" value={formatCurrency(docAmount, docCurrency)} tabular />
)}
{documentId && (
<div className="pt-1">
<DocumentViewButton documentId={documentId} />
</div>
)}
</PreviewCard>
</div>
<div className="flex items-center justify-center text-xs text-muted-foreground">
<ArrowDown className="h-3.5 w-3.5 mr-1" />
kopplas till transaktionen
</div>
{willOverwrite && existingIsAccounting && (
<div className="flex items-start gap-2 rounded-md border border-destructive/40 bg-destructive/10 p-3 text-sm text-destructive">
<AlertTriangle className="mt-0.5 h-4 w-4 shrink-0" />
<div>
<p className="font-medium">Ersätter räkenskapsinformation</p>
<p className="mt-1 text-xs">
Befintligt dokument{existingDocName ? ` (${existingDocName})` : ''} är markerat som
räkenskapsinformation enligt BFL 7 kap. Att ersätta det här gör det tidigare
verifikationsunderlaget otillgängligt: bekräfta att du har originalet sparat innan
du godkänner.
</p>
</div>
</div>
)}
{willOverwrite && !existingIsAccounting && (
<div className="rounded-md border border-border bg-muted/30 p-2 text-xs text-muted-foreground">
Ersätter befintligt dokument{existingDocName ? `: ${existingDocName}` : ''}.
</div>
)}
</div>
)
}
function PreviewCard({ label, children }: { label: string; children: React.ReactNode }) {
return (
<div className="rounded-lg border border-border p-3 space-y-1.5">
<p className="text-[11px] font-medium uppercase tracking-wider text-muted-foreground">
{label}
</p>
{children}
</div>
)
}
function Row({ label, value, tabular }: { label: string; value: string; tabular?: boolean }) {
return (
<div className="flex justify-between gap-3">
<span className="text-xs text-muted-foreground shrink-0">{label}</span>
<span className={`text-sm ${tabular ? 'tabular-nums' : ''} text-right truncate`}>{value}</span>
</div>
)
}