MattssonandClaude Fable 5
c187fabf92
* feat(shopify): Shopify order/refund feed into the transactions inbox
New extensions/general/shopify feed extension, modeled on the WooCommerce
feed: connect a Shopify store with Dev Dashboard custom-app client
credentials (client credentials grant, ~24h tokens, never stored), then a
nightly cron + manual sync imports paid orders and refunds via the GraphQL
Admin API (pinned 2026-07) into the transactions inbox on clearing account
1584. Feed-only: nothing auto-books. Zero PII fields are queried, keeping
the app outside Shopify's protected customer data program.
- shopify_connections migration (RLS, revoke-never-delete, encrypted
client id/secret) + shopify_sync capability and bank_sync-mirrored
backfill
- frozen external_id scheme shopify_{shop_domain}_order|refund_{id},
scoped on the shop domain so reconnects never re-import
- cursor sync on updated_at windows with 24h overlap, lock-date drop at
map time, ingest-failure cursor floor, deadline stop-and-resume,
revoked-credential flip
- /import card + settings panel, sv/en i18n, cron 03:15 in vercel.json +
regenerated Docker crontabs, logo, events, panel registry
- 65 unit tests + pg-real RLS test; extensions.schema.json enum also
gains the missing stripe entry (pre-existing drift)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(shopify): review findings from PR 1474
- token exchange: a 429 that survives every retry is throttling, not a
credential failure; stop remapping retryable 4xx to 401 so sustained
throttling can no longer flip the connection to revoked and delete the
stored credentials (CodeRabbit critical)
- order sync: advance a scanned-through watermark (run start, capped by
the failure floor) after a fully-listed window, so empty first runs and
quiet stores rotate to the back of the cron's oldest-first selection
instead of permanently occupying the 50-connection batch (CodeRabbit
major, starvation)
- add handler-level tests for the orders cron route (auth 401, disabled
503, unconfigured no-op, query failure, capability skip, happy path,
per-connection failure isolation, revoked marking)
- add 401 tests for /sync, /transaction-sync and /disconnect; pin the
cursor floor rule with a two-order page; stub the encryption key via
vi.stubEnv
- note in the panel description (sv/en) that orders can mix VAT rates and
must be split at booking (Swedish review advisory)
- DECISIONS.md: wrap underscore identifiers in backticks (MD037)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
65 lines
2.0 KiB
TypeScript
65 lines
2.0 KiB
TypeScript
import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
|
|
import {
|
|
encryptCredential,
|
|
decryptCredential,
|
|
credentialsOf,
|
|
isShopifyConfigured,
|
|
} from '../lib/credentials'
|
|
|
|
describe('shopify credentials encryption', () => {
|
|
beforeEach(() => {
|
|
vi.stubEnv('SHOPIFY_CREDENTIALS_ENCRYPTION_KEY', 'test-key')
|
|
})
|
|
|
|
afterEach(() => {
|
|
vi.unstubAllEnvs()
|
|
})
|
|
|
|
it('round-trips a credential', () => {
|
|
const ciphertext = encryptCredential('shpca_client_secret_123')
|
|
expect(ciphertext).not.toContain('shpca')
|
|
expect(decryptCredential(ciphertext)).toBe('shpca_client_secret_123')
|
|
})
|
|
|
|
it('uses a fresh IV per encryption', () => {
|
|
const a = encryptCredential('same-input')
|
|
const b = encryptCredential('same-input')
|
|
expect(a).not.toBe(b)
|
|
expect(decryptCredential(a)).toBe('same-input')
|
|
expect(decryptCredential(b)).toBe('same-input')
|
|
})
|
|
|
|
it('rejects tampered ciphertext', () => {
|
|
const ciphertext = encryptCredential('secret')
|
|
const buf = Buffer.from(ciphertext, 'base64url')
|
|
buf[buf.length - 1] ^= 0xff
|
|
expect(() => decryptCredential(buf.toString('base64url'))).toThrow()
|
|
})
|
|
|
|
it('throws without the env key', () => {
|
|
vi.stubEnv('SHOPIFY_CREDENTIALS_ENCRYPTION_KEY', '')
|
|
expect(isShopifyConfigured()).toBe(false)
|
|
expect(() => encryptCredential('x')).toThrow(/SHOPIFY_CREDENTIALS_ENCRYPTION_KEY/)
|
|
})
|
|
|
|
it('credentialsOf decrypts a connection and refuses missing credentials', () => {
|
|
const creds = credentialsOf({
|
|
shop_domain: 'minbutik.myshopify.com',
|
|
client_id_encrypted: encryptCredential('client-id'),
|
|
client_secret_encrypted: encryptCredential('client-secret'),
|
|
})
|
|
expect(creds).toEqual({
|
|
shopDomain: 'minbutik.myshopify.com',
|
|
clientId: 'client-id',
|
|
clientSecret: 'client-secret',
|
|
})
|
|
expect(() =>
|
|
credentialsOf({
|
|
shop_domain: 'minbutik.myshopify.com',
|
|
client_id_encrypted: null,
|
|
client_secret_encrypted: null,
|
|
}),
|
|
).toThrow(/no stored credentials/)
|
|
})
|
|
})
|