* feat(dimensions): PR2 registry — CRUD API, register UI, settings toggle, SIE export on the new registry
Phase 2 of dev_docs/dimensions_implementation_plan.md. Companies with
dimensions_enabled=false (default) see zero change.
API:
- Dashboard CRUD: GET /api/dimensions (lazy-seeds system dims 1/6 via the
ensure_company_dimensions RPC), PATCH /api/dimensions/[id] (is_system
rename blocked), POST/PATCH/DELETE values (code immutable after creation;
strict Fortnox code format ^[A-Za-z0-9ÅÄÖåäö_+\-]{1,20}$ at the API layer;
retention-trigger deletes surface the Swedish "arkivera istället" message
as 409 DIMENSION_VALUE_REFERENCED).
- POST /api/dimensions/import-existing — scans journal_entry_lines.dimensions
for unregistered codes and mints inactive placeholder registry rows.
- v1 public API: GET dimensions + POST values (Idempotency-Key, dry-run),
registered in the OpenAPI spec (102→104 endpoints).
- dimensions_enabled boolean on company_settings (new migration,
UI-visibility only, never correctness-bearing) exposed through the
existing settings read/update path.
SIE export (lib/reports/sie-export.ts):
- Reads the new dimensions/dimension_values registry; legacy
cost_centers/projects tables now have zero readers (drop migration next).
- Fixes the latent Visma-rejection bug: #OBJEKT now declared for INACTIVE
values referenced by lines.
- Generic-N: #DIM/#UNDERDIM loop sorted by sie_dim_no; #TRANS object lists
serialize from the line JSONB map (sorted, '01'→'1' collapse); orphan
codes/dims synthesize declarations from the SIE reserved-number seed —
every referenced (dim, code) pair is guaranteed declared.
UI:
- /dimensions register (Register-recipe): tabs per dimension, search,
sortable table, value dialog (code immutable on edit, projekt dates on
dim 6), archive-not-delete affordances.
- DimensionCombobox shipped (mounts in the tagging PR).
- Settings toggle "Aktivera kostnadsställen & projekt" — toggle-on runs the
import-existing scan and links to the register.
- Nav row in redovisning, rendered only when dimensions_enabled (same
mechanism as pays_salaries).
- dimensions.* i18n namespace (51 keys, sv/en parity).
- Sandbox seed: demo dims + values, revenue line tagged {"1":"BUTIK","6":"P001"}.
Verified: 6328/6328 unit tests, guard + coverage gate green, tsc parity with
main (210=210), production build passes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(dimensions): PR2 review round — atomic archived-create, UNDERDIM ordering, import robustness, date semantics
- POST values accepts is_active so "create as archived" is atomic; the UI's
fragile create-then-PATCH fallback is deleted (PR Agent finding 1).
- DimensionCombobox blur revert reads the committed value/values through refs
so a selection landing inside the 150ms window always wins (finding 2).
- import-existing sanitizes candidate codes like the PR1 backfill and upserts
with ignoreDuplicates — one bad/duplicate code can no longer abort the
batch; created counted from returned rows (finding 3).
- SIE export emits all root #DIM before any #UNDERDIM so a parent always
precedes a lower-numbered child (SIE4 declaration order — Swedish review);
synthesized placeholder declarations now log one structured warning
(BFNAR 2013:2 behandlingshistorik) + defence-in-depth comment.
- Value dates rejected (400 DIMENSION_VALUE_DATES_NOT_ALLOWED) when the
parent dimension is flow-period (resets_annually=true); explicit null
still clears (Swedish review).
- Sandbox seed logs seeded dimension codes; GET /api/dimensions documents
the deliberate absence of dimensions_enabled gating (UI-visibility flag,
not a security boundary — compliance-swarm V8.2.1 rejected by design).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
104 lines
3.5 KiB
TypeScript
104 lines
3.5 KiB
TypeScript
/**
|
|
* GET /api/dimensions — the dimension registry (kostnadsställe/projekt + custom
|
|
* dims) with nested values, for the register page and pickers.
|
|
*
|
|
* Calls ensure_company_dimensions first so the system dims (1 = Kostnadsställe,
|
|
* 6 = Projekt) always exist — lazy seeding keeps core zero-config for companies
|
|
* that never touch dimensions (dev_docs/dimensions_implementation_plan.md §6).
|
|
*
|
|
* Response contract (PR2 — the register UI builds against this exactly):
|
|
* 200 { dimensions: [{ id, sie_dim_no, name, resets_annually, is_system,
|
|
* is_active, sort_order, values: [{ id, code, name, is_active,
|
|
* start_date, end_date }] }] }
|
|
* Dimensions sorted by sort_order, values by code.
|
|
*/
|
|
import { NextResponse } from 'next/server'
|
|
import { ensureInitialized } from '@/lib/init'
|
|
import { withRouteContext } from '@/lib/api/with-route-context'
|
|
import { errorResponse } from '@/lib/errors/get-structured-error'
|
|
|
|
ensureInitialized()
|
|
|
|
interface DimensionValueRow {
|
|
id: string
|
|
dimension_id: string
|
|
code: string
|
|
name: string
|
|
is_active: boolean
|
|
start_date: string | null
|
|
end_date: string | null
|
|
}
|
|
|
|
interface DimensionRow {
|
|
id: string
|
|
sie_dim_no: number
|
|
name: string
|
|
resets_annually: boolean
|
|
is_system: boolean
|
|
is_active: boolean
|
|
sort_order: number
|
|
}
|
|
|
|
export const GET = withRouteContext(
|
|
'dimension.list',
|
|
async (_request, ctx) => {
|
|
// dimensions_enabled is deliberately NOT enforced here — it is a
|
|
// UI-visibility flag only (dev_docs/dimensions_implementation_plan.md §2).
|
|
// Agents/MCP and SIE import must operate on the registry regardless of the
|
|
// toggle; the security boundary is company scoping (withRouteContext + RLS).
|
|
const { supabase, companyId, log, requestId } = ctx
|
|
|
|
const { error: ensureError } = await supabase.rpc('ensure_company_dimensions', {
|
|
p_company_id: companyId,
|
|
})
|
|
if (ensureError) {
|
|
log.error('ensure_company_dimensions failed', ensureError)
|
|
return errorResponse(ensureError, log, { requestId })
|
|
}
|
|
|
|
const { data: dims, error: dimsError } = await supabase
|
|
.from('dimensions')
|
|
.select('id, sie_dim_no, name, resets_annually, is_system, is_active, sort_order')
|
|
.eq('company_id', companyId)
|
|
.order('sort_order', { ascending: true })
|
|
.order('sie_dim_no', { ascending: true })
|
|
|
|
if (dimsError) {
|
|
log.error('dimension list failed', dimsError)
|
|
return errorResponse(dimsError, log, { requestId })
|
|
}
|
|
|
|
const { data: values, error: valuesError } = await supabase
|
|
.from('dimension_values')
|
|
.select('id, dimension_id, code, name, is_active, start_date, end_date')
|
|
.eq('company_id', companyId)
|
|
.order('code', { ascending: true })
|
|
|
|
if (valuesError) {
|
|
log.error('dimension value list failed', valuesError)
|
|
return errorResponse(valuesError, log, { requestId })
|
|
}
|
|
|
|
const valuesByDimension = new Map<string, Omit<DimensionValueRow, 'dimension_id'>[]>()
|
|
for (const v of (values ?? []) as DimensionValueRow[]) {
|
|
const bucket = valuesByDimension.get(v.dimension_id) ?? []
|
|
bucket.push({
|
|
id: v.id,
|
|
code: v.code,
|
|
name: v.name,
|
|
is_active: v.is_active,
|
|
start_date: v.start_date,
|
|
end_date: v.end_date,
|
|
})
|
|
valuesByDimension.set(v.dimension_id, bucket)
|
|
}
|
|
|
|
const dimensions = ((dims ?? []) as DimensionRow[]).map((d) => ({
|
|
...d,
|
|
values: valuesByDimension.get(d.id) ?? [],
|
|
}))
|
|
|
|
return NextResponse.json({ dimensions })
|
|
},
|
|
)
|