* fix: article number ordering, free-text rows, invoice back-nav, onboarding resilience (#1053) Four fixes from Discord feedback in issue #1053: - Articles now order by article number with numeric-aware comparison ('2' before '10', unnumbered last, name tiebreak) in the invoice editor's article picker and as the register's default sort, via a shared lib/articles/sort.ts. Name order put article "1" last. - Invoice rows with no amounts (quantity 0, unit price 0) render as pure text rows on the PDF, the invoice detail page, and the review step via shared isTextLikeLine(), instead of printing "0 / 0,00 SEK / 0,00 SEK". Display-only; booking untouched. - The invoice editor navigates with router.replace after saving, so the detail page's back arrow returns to the list instead of reopening a fresh editor from history. - A transient query failure no longer reads as "no companies" / "onboarding not done": getActiveCompanyId throws CompanyContextError('resolution_failed') instead of returning null, the Edge middleware fails open on a degraded resolution (no onboarding redirect, no cookie clearing, no locale overwrite), and the dashboard page only redirects to /onboarding on a positively read incomplete/missing settings row. This is the likely cause of the completed onboarding wizard reappearing. Fixes #1053 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: CLAUDE.md tenancy line matches actual resolution order (prefs-first, cookie not read) The middleware stopped reading the gnubok-company-id cookie when user_preferences became authoritative (RLS parity); the stale doc line still described cookie-first order and misled review tooling. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
11 KiB
CLAUDE.md: Accounted
Swedish accounting SaaS: double-entry bookkeeping under Swedish accounting law (Bokföringslagen) for sole traders (enskild firma) and limited companies (aktiebolag). Multi-tenant: users belong to companies via company_members; teams group companies for consultants.
Stack: Next.js 16 (App Router), React 19, TypeScript 5 strict, Zod 4, Supabase (Postgres + RLS + auth), Tailwind 4 + shadcn/ui. Vercel-hosted is the primary target; Docker self-hosted must keep working but never at hosted's expense. Path alias @/* = repo root. All code, comments, and commits in English.
Hard Rules
The accounting rules are Swedish law, enforced by DB triggers. Code that violates them fails at runtime; code that works around the triggers breaks legal compliance. Never do either.
- Never edit or delete a posted journal entry. Committed vouchers are immutable. Cancel with
reverseEntry(); correct withcorrectEntry()(lib/core/bookkeeping/storno-service.ts). Storno, never edit. - All journal writes go through
lib/bookkeeping/engine.ts. Never insert into journal tables directly: voucher numbers are assigned atomically by thecommit_journal_entryRPC and must stay sequential, and gaps require documented explanations (BFNAR 2013:2,voucher_gap_explanations). - Every entry balances:
sum(debits) === sum(credits), both> 0. - Respect period locks. DB triggers block writes to closed/locked periods and behind the company lock date. Don't work around them: fix the flow that tried to write there.
- Never delete documents linked to posted entries: 7-year retention is a legal requirement.
- Money math is
Math.round(x * 100) / 100. NevertoFixed(): it returns strings and rounds incorrectly, causing öre-level drift that breaks entry balance. - Account numbers are strings (
'1930', never1930). They are identifiers, not quantities; arithmetic on them is always a bug.
General prohibitions:
- Never modify an existing migration: schemas already shipped; create a new migration. Never touch the enforcement triggers (migration 017); they are legally required.
- Never leave a remote DB ahead of the repo. If you
apply_migration(or run any DDL) against prod, staging, or a preview branch, write the byte-identical SQL intosupabase/migrations/under the exact applied version in the same change. An applied version with no committed file is an orphan: Supabase branching aborts the next merge tomainwith "Remote migration versions not found in local migrations directory" and blocks every pending migration behind it. The PR preview passes anyway (preview branches fork from prod's history, which already has the orphan), so this only surfaces at merge. - Core code must never import from
@/extensions/. CI builds core with zero extensions enabled; a direct import breaks that build. Extensions cannot use dynamic imports (the registry generates static imports viasetup:extensions). - Don't add dependencies without asking. This is an AGPL-3.0 project; license compatibility matters, and the dependency surface is audited.
- Don't "finish" the gnubok → Accounted rename. Wire-format identifiers keep the old name on purpose:
gnubok-company-idcookie,gnubok_sk_/gnubok_inv_prefixes,gnubok-mcpnpm package. Renaming them breaks live sessions, API keys, and invites. - Treat
.env.localas pointing at the production database. Never run seed/cleanup/repair scripts against it without explicit confirmation. - Keep the diff scoped to the request. No drive-by refactors of untouched code.
- Never use em dashes (—) or en dashes (–) in code, comments, commit messages, or docs. Use a colon, comma, semicolon, or plain hyphen instead, whichever fits the sentence. Exception: a dash character that is the literal subject being parsed, matched, or documented (e.g. mojibake byte-mapping tables, a date-range separator regex) stays as-is; don't launder those into a colon.
- Never create a NUL/nul file:
\Accounted\NUL.
When Uncertain
- Stop and ask; do not guess. Especially for anything touching posted entries, the production database, money math, or Swedish tax law.
- Swedish domain questions are never answered from training data. Load the matching
swedish-*skill (vat, accounting-compliance, invoice-compliance, payroll, year-end-closing, sie-import-export, sru-filing, financial-reporting, asset-accounting, project-accounting, tax-planning, e-invoicing). - Scaffolding has skills; use them instead of improvising:
/erp-api-route(API routes),/supabase-migration(migrations),/create-extension(extensions),/frontend-design(new UI),vercel:deploy(deployment).
Definition of Done
A change is done when all of these hold; iterate until they do:
npm run lintis clean andnpm testpasses (npx vitest run <dir>while iterating).- New or changed logic in
lib/orapp/api/has tests: auth 401, validation 400, 404, happy path; mock@/lib/supabase/server. - Any change to a trigger, RPC, RLS policy, or DEFERRABLE constraint ships with a
*.pg.test.ts(npm run test:pg). - New UI strings exist in both
messages/sv.jsonandmessages/en.json. - If you edited an atom
SKILL.md,npm run skills:generatewas run (CI'sskills:checkfails otherwise). npm run check:guardspasses if you touched API routes.- Commit is conventional (
feat:/fix:/refactor:/test:/docs:), atomic, branched frommain. - If the change touches migrations, local and prod are reconciled: every version in prod's
schema_migrationshas a matching file insupabase/migrations/, and vice versa. Check before opening the PR (e.g.list_migrations/select version from supabase_migrations.schema_migrations); a remote-only version means an uncommitted orphan that will fail the merge. - The last mile is verified in-session, not assumed. Whatever was built is confirmed switched on before the session ends: merged PR's migration applied to prod, scheduled loop/routine observed firing, script actually executed, feature reachable. If switch-on must wait, the session's final output states exactly what is NOT live yet and who flips it. History shows the expensive failure mode is built-but-never-initiated, not built-wrong.
Commands
npm run dev # Dev server (runs setup:extensions first)
npm run build # Production build (runs setup:extensions first)
npm run lint # ESLint
npm test # All Vitest tests
npx vitest run <dir> # Tests in one directory
npm run test:pg # pg-real tests against real Postgres
npm run check:guards # Ratchet guard (e.g. no hand-rolled route auth)
npm run setup:extensions # Regenerate extension registry from extensions.config.json
npm run skills:generate # Regenerate agent_atom_registry seed after editing an atom SKILL.md
Architecture
- Journal entry lifecycle:
createDraftEntry()→commitEntry()(atomic voucher viacommit_journal_entryRPC);createJournalEntry()does both. Everything accounting-shaped routes through this engine. - Tenancy: every business table has
company_id. Active company resolves inlib/supabase/middleware.tsfromuser_preferences.active_company_id(authoritative: RLS reads the same value viacurrent_active_company_id()), falling back to first non-archived membership. Thegnubok-company-idcookie is written as a hint for legacy read paths but deliberately no longer read: letting it override the DB would desync Next.js from RLS. RLS usesuser_company_ids(); queries still filter bycompany_idexplicitly (defense in depth: service-role paths have no RLS). - Auth: Supabase email+password + TOTP MFA, enforced application-side, not in RLS.
NEXT_PUBLIC_REQUIRE_MFA=trueon hosted;NEXT_PUBLIC_SELF_HOSTED=truedisables MFA. API routes wrapwithRouteContext: it is the only path that enforces MFA, so never hand-rollsupabase.auth.getUser()in a route. - Events:
lib/events/bus.tsis a module-level singleton. Any route that emits events must callensureInitialized()(lib/init.ts) at module level: otherwise extension handlers are never wired and events silently go nowhere. - Supabase clients: browser
client.ts, servercreateClient(), service rolecreateServiceClient(), cookieless service rolecreateServiceClientNoCookies()(lives inlib/auth/api-keys.ts; for API-key/MCP paths). Paginate withfetchAllRows(): PostgREST silently caps at 1000 rows. - Extensions: opt-in plugins in
extensions/general/<name>/;extensions.config.jsonis the source of truth for what's enabled. Core must run with zero extensions. - MCP server: the bookkeeping engine is exposed as 100+ MCP tools (
extensions/general/mcp-server/), authenticated bygnubok_sk_API keys (SHA-256, scoped, default 100 RPM per key). - Types: import from
@/types(types/index.ts); event types inlib/events/types.ts. - User-facing errors are Swedish: map through
lib/errors/get-error-message.ts. - Cron: hosted cron jobs live in
vercel.json, authenticated viaverifyCronSecret()(lib/auth/cron.ts).
Repository Map
lib/bookkeeping/: engine, entry generators, mapping, templates, BAS 2026 data (bas-data/)lib/core/: period, year-end, storno, tax codes, audit, documentslib/events/,lib/auth/,lib/supabase/,lib/api/(ZodvalidateBody/validateQuery)lib/reports/: balance sheet, income statement, trial balance, GL, ledgers, VAT, SIE, INK2, NE-bilaga, salary, …lib/invoices/,lib/transactions/,lib/import/,lib/documents/,lib/salary/,lib/reconciliation/,lib/tax/,lib/vat/,lib/providers/(Fortnox/Bokio/Briox/BL/Visma),lib/skatteverket/,lib/currency/,lib/bankgiro/,lib/deadlines/,lib/calendar/lib/utils.ts:cn(),formatCurrency(),formatDate(),formatOrgNumber();lib/logger.tsapp/(dashboard)/*pages;app/api/*routes;supabase/migrations/schema;extensions/general/*plugins
Testing
Vitest 4, node env, tests in __tests__/, scope lib/ + app/api/ (no component/E2E tests). Helpers in tests/helpers.ts: createMockSupabase(), createQueuedMockSupabase(), createMockRequest(), parseJsonResponse(), plus fixture factories (makeTransaction, makeJournalEntry, makeInvoice, …). vi.clearAllMocks() + eventBus.clear() in beforeEach. Trigger/RPC/RLS behavior is tested in *.pg.test.ts against real Postgres, not with mocks.
Detail Loads On Demand
Don't duplicate these here; they auto-load when you touch matching paths:
.claude/rules/design.md: design system, locked tokens (app/**,components/**).claude/rules/i18n.md: sv/en conventions, "stays Swedish" surfaces.claude/rules/api-routes.md:withRouteContextroute pattern, endpoint map (app/api/**).claude/rules/database.md: migration rules, key tables/RPCs/triggers, pg-real (supabase/migrations/**).claude/rules/mcp-server.md: MCP tool authoring, staged-operation pattern.claude/rules/bookkeeping.md: BAS accounts, VAT treatments/rutor,lib/core/services
Decision Log
When you make a non-obvious choice (picked approach A over B, declined a dependency, stopped because a rule here forbade something), append one line to DECISIONS.md (repo root): [YYYY-MM-DD] <decision>: <why>. Check that file before re-litigating a past decision.