Jakob Wennberg
c74b19df1b
* feat(reconciliation): close the bank-feed loop on voucher links and re-tag mis-typed opening balances
Two related fixes to bank reconciliation correctness:
1. Auto-reconcile on voucher link. Linking an invoice or supplier invoice to
an existing voucher previously advanced only the invoice — the bank
transaction that paid it kept sitting in the Transactions inbox with a null
journal_entry_id. linkInvoiceToVoucher / linkSupplierInvoiceToVoucher now
call autoReconcileTransactionForLinkedVoucher (lib/reconciliation), which
links the bank transaction to the same verifikat when exactly one unbooked
line matches it. Best-effort and post-commit: a failure here never fails the
link. The result surfaces reconciledTransactionId; the inbox row leaves the
list and the UI shows link_success_tx_reconciled.
2. Re-tag mis-typed opening balances. getReconciliationStatus and the GL-line
matching RPCs identify a cash account's ingående balans solely by
journal_entries.source_type='opening_balance'. Companies migrated from other
systems often booked the bank IB as an ordinary voucher (source_type
'import' or 'manual'), so it was never excluded and surfaced as a phantom
reconciliation difference equal to the opening balance. Adds:
- migration mark_entry_as_opening_balance: a GUC-gated carve-out in the
immutability trigger plus a SECURITY DEFINER RPC that validates the entry
(balance-sheet lines only, dated on a fiscal-period boundary), flips the
source_type, and writes an audit row — no blanket data sweep.
- POST /api/reconciliation/bank/mark-opening-balance + MarkOpeningBalanceSchema.
- BankReconciliationView action to trigger it from the IB diff.
The gnubok_create_voucher executor now accepts a typed is_opening_balance flag
and derives source_type='opening_balance' only after validating class 1/2 lines
on the period start, so new IBs land correctly typed.
Covered by lib/reconciliation auto-reconcile tests, voucher-executors tests,
and a mark-entry-as-opening-balance pg-real test.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore: rebrand gnubok → Accounted and prune swarm agent skills
Product rebrand and skills housekeeping. No runtime behaviour change.
Rebrand: replace user-visible "gnubok" with "Accounted" across docs, READMEs,
in-code comments, doc-site content, MCP skill/resource prose, and the
gnubok-mcp package description. The MCP resource URI scheme is moved gnubok://
→ Accounted:// consistently across resource registrations, the event-type
comment, and the resource/skill tests. Deliberately preserved as stable
identifiers (NOT rebranded): the gnubok-company-id cookie, gnubok_sk_ / gnubok_inv_
token prefixes, the gnubok-mcp npm bridge name, and the AGI <gem:Programnamn>
value (kept 'gnubok' per its source comment — it is the software identifier sent
to Skatteverket and must not churn across visual rebrands).
Skills: remove the 27 swarm-* agent SKILL.md atoms (no longer used; already
absent from the agent_atom_registry in prod), refresh the remaining skill docs,
add the .claude/rules/ path-scoped rule set, and regenerate the
seed_agent_atom_bodies migration + .skill-body-manifest.json via
`npm run skills:generate` so the DB-backed skill bodies match the trimmed set.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
67 lines
2.2 KiB
TypeScript
67 lines
2.2 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import { dataResources, findResource, parseResourceQuery } from '../resources'
|
|
|
|
describe('mcp resource registry', () => {
|
|
it('exposes all data resources with required fields', () => {
|
|
expect(dataResources).toHaveLength(7)
|
|
const uris = dataResources.map((r) => r.uri).sort()
|
|
expect(uris).toEqual([
|
|
'Accounted://attention',
|
|
'Accounted://capabilities',
|
|
'Accounted://chart-of-accounts',
|
|
'Accounted://company/current',
|
|
'Accounted://period/active',
|
|
'Accounted://recent-activity',
|
|
'Accounted://settings/vat-treatments',
|
|
])
|
|
|
|
for (const r of dataResources) {
|
|
expect(r.name).toBeTruthy()
|
|
expect(r.description.length).toBeGreaterThan(20)
|
|
expect(r.mimeType).toBe('application/json')
|
|
expect(typeof r.read).toBe('function')
|
|
}
|
|
})
|
|
|
|
it('matches base URI ignoring query string', () => {
|
|
const r = findResource('Accounted://recent-activity?limit=5')
|
|
expect(r?.uri).toBe('Accounted://recent-activity')
|
|
})
|
|
|
|
it('returns null for unknown URI', () => {
|
|
expect(findResource('Accounted://does-not-exist')).toBeNull()
|
|
})
|
|
|
|
it('parses query params from URI', () => {
|
|
const q = parseResourceQuery('Accounted://recent-activity?limit=5&offset=10')
|
|
expect(q?.get('limit')).toBe('5')
|
|
expect(q?.get('offset')).toBe('10')
|
|
})
|
|
|
|
it('returns undefined when no query', () => {
|
|
expect(parseResourceQuery('Accounted://capabilities')).toBeUndefined()
|
|
})
|
|
})
|
|
|
|
describe('vat-treatments resource', () => {
|
|
it('returns matrix for all customer types without DB access', async () => {
|
|
const r = findResource('Accounted://settings/vat-treatments')!
|
|
const result = (await r.read({
|
|
// Pure-function resource: no DB calls
|
|
supabase: undefined as never,
|
|
companyId: 'irrelevant',
|
|
userId: 'irrelevant',
|
|
scopes: [],
|
|
})) as { treatments: string[]; by_customer_type: Record<string, unknown> }
|
|
|
|
expect(result.treatments).toContain('standard_25')
|
|
expect(result.treatments).toContain('reverse_charge')
|
|
expect(Object.keys(result.by_customer_type)).toEqual([
|
|
'individual',
|
|
'swedish_business',
|
|
'eu_business',
|
|
'non_eu_business',
|
|
])
|
|
})
|
|
})
|