* feat(reconciliation): close the bank-feed loop on voucher links and re-tag mis-typed opening balances
Two related fixes to bank reconciliation correctness:
1. Auto-reconcile on voucher link. Linking an invoice or supplier invoice to
an existing voucher previously advanced only the invoice — the bank
transaction that paid it kept sitting in the Transactions inbox with a null
journal_entry_id. linkInvoiceToVoucher / linkSupplierInvoiceToVoucher now
call autoReconcileTransactionForLinkedVoucher (lib/reconciliation), which
links the bank transaction to the same verifikat when exactly one unbooked
line matches it. Best-effort and post-commit: a failure here never fails the
link. The result surfaces reconciledTransactionId; the inbox row leaves the
list and the UI shows link_success_tx_reconciled.
2. Re-tag mis-typed opening balances. getReconciliationStatus and the GL-line
matching RPCs identify a cash account's ingående balans solely by
journal_entries.source_type='opening_balance'. Companies migrated from other
systems often booked the bank IB as an ordinary voucher (source_type
'import' or 'manual'), so it was never excluded and surfaced as a phantom
reconciliation difference equal to the opening balance. Adds:
- migration mark_entry_as_opening_balance: a GUC-gated carve-out in the
immutability trigger plus a SECURITY DEFINER RPC that validates the entry
(balance-sheet lines only, dated on a fiscal-period boundary), flips the
source_type, and writes an audit row — no blanket data sweep.
- POST /api/reconciliation/bank/mark-opening-balance + MarkOpeningBalanceSchema.
- BankReconciliationView action to trigger it from the IB diff.
The gnubok_create_voucher executor now accepts a typed is_opening_balance flag
and derives source_type='opening_balance' only after validating class 1/2 lines
on the period start, so new IBs land correctly typed.
Covered by lib/reconciliation auto-reconcile tests, voucher-executors tests,
and a mark-entry-as-opening-balance pg-real test.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore: rebrand gnubok → Accounted and prune swarm agent skills
Product rebrand and skills housekeeping. No runtime behaviour change.
Rebrand: replace user-visible "gnubok" with "Accounted" across docs, READMEs,
in-code comments, doc-site content, MCP skill/resource prose, and the
gnubok-mcp package description. The MCP resource URI scheme is moved gnubok://
→ Accounted:// consistently across resource registrations, the event-type
comment, and the resource/skill tests. Deliberately preserved as stable
identifiers (NOT rebranded): the gnubok-company-id cookie, gnubok_sk_ / gnubok_inv_
token prefixes, the gnubok-mcp npm bridge name, and the AGI <gem:Programnamn>
value (kept 'gnubok' per its source comment — it is the software identifier sent
to Skatteverket and must not churn across visual rebrands).
Skills: remove the 27 swarm-* agent SKILL.md atoms (no longer used; already
absent from the agent_atom_registry in prod), refresh the remaining skill docs,
add the .claude/rules/ path-scoped rule set, and regenerate the
seed_agent_atom_bodies migration + .skill-body-manifest.json via
`npm run skills:generate` so the DB-backed skill bodies match the trimmed set.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
264 lines
9.4 KiB
TypeScript
264 lines
9.4 KiB
TypeScript
import type {
|
||
TICCompanyResponse,
|
||
TICCompanyDocument,
|
||
TICBankgirot,
|
||
TICIndustryCode,
|
||
TICEmail,
|
||
TICPhone,
|
||
TICCompanyPurpose,
|
||
TICDocument,
|
||
TICFiscalYear,
|
||
TICAccountingPeriod,
|
||
TICPayrollSummary,
|
||
TICSignatory,
|
||
TICRepresentatives,
|
||
TICCompanyStatusEntry,
|
||
TICBeneficialOwnerResponse,
|
||
} from './tic-types'
|
||
import { TICAPIError } from './tic-types'
|
||
|
||
const TIC_API_TIMEOUT = 15_000
|
||
|
||
// In-process TTL cache for proxy responses. Onboarding currently fires the
|
||
// same org-number lookup 2–3 times in <2 s (server prefetch + client
|
||
// useEffect + duplicate-check) and the agent build re-fetches /profile data
|
||
// minutes later. The TIC budget (3000/mo Lens calls) can't absorb the
|
||
// duplication. 5 min is long enough to collapse a full onboarding flow into
|
||
// one upstream hit and short enough that stale data never matters (TIC
|
||
// data changes on Bolagsverket filing cycles measured in days).
|
||
const CACHE_TTL_MS = 5 * 60_000
|
||
const CACHE_MAX_ENTRIES = 500
|
||
interface CacheEntry {
|
||
expiresAt: number
|
||
value: unknown
|
||
}
|
||
const proxyCache = new Map<string, CacheEntry>()
|
||
|
||
function cacheGet<T>(key: string): T | undefined {
|
||
const entry = proxyCache.get(key)
|
||
if (!entry) return undefined
|
||
if (entry.expiresAt < Date.now()) {
|
||
proxyCache.delete(key)
|
||
return undefined
|
||
}
|
||
return entry.value as T
|
||
}
|
||
|
||
function cacheSet(key: string, value: unknown): void {
|
||
if (proxyCache.size >= CACHE_MAX_ENTRIES) {
|
||
// LRU-ish eviction: drop the oldest 10% so we never grow unbounded.
|
||
const drop = Math.max(1, Math.floor(CACHE_MAX_ENTRIES / 10))
|
||
const keys = Array.from(proxyCache.keys()).slice(0, drop)
|
||
for (const k of keys) proxyCache.delete(k)
|
||
}
|
||
proxyCache.set(key, { expiresAt: Date.now() + CACHE_TTL_MS, value })
|
||
}
|
||
|
||
// Test-only: flush the in-process cache so per-test fixtures don't bleed
|
||
// across cases. Not used by production code.
|
||
export function __resetTicCacheForTest(): void {
|
||
proxyCache.clear()
|
||
}
|
||
|
||
/**
|
||
* Generic TIC API fetch helper.
|
||
*
|
||
* Routes through the proxy at TIC_API_PROXY_URL (no API key needed in this
|
||
* codebase). The proxy targets `lens-api.tic.io` (v2 "Lens API") and adds
|
||
* `x-api-key` server-side. v1 (`api.tic.io`) is retired — all paths below
|
||
* are Lens paths (no `/datasets/` prefix, `id` instead of `companyId`).
|
||
*/
|
||
export async function ticApiFetch<T>(endpoint: string): Promise<T | null> {
|
||
const proxyUrl = process.env.TIC_API_PROXY_URL
|
||
if (!proxyUrl) {
|
||
throw new TICAPIError('TIC_API_PROXY_URL is not configured', undefined, 'NOT_CONFIGURED')
|
||
}
|
||
|
||
// Check the in-process cache first. The cache key is the endpoint (which
|
||
// includes the org-number / company-id) so each unique upstream call is
|
||
// memoized; 404 responses are cached as `null` deliberately so a typo'd
|
||
// org-number doesn't re-spend a call on every keystroke.
|
||
const cached = cacheGet<T | null>(endpoint)
|
||
if (cached !== undefined) {
|
||
return cached
|
||
}
|
||
|
||
const url = `${proxyUrl}?endpoint=${encodeURIComponent(endpoint)}`
|
||
|
||
try {
|
||
const response = await fetch(url, {
|
||
headers: { Accept: 'application/json' },
|
||
signal: AbortSignal.timeout(TIC_API_TIMEOUT),
|
||
})
|
||
|
||
if (response.status === 404) {
|
||
cacheSet(endpoint, null)
|
||
return null
|
||
}
|
||
|
||
if (response.status === 429) {
|
||
// Do NOT cache rate-limit responses — the next call after the window
|
||
// resets should be allowed through.
|
||
throw new TICAPIError('Rate limit exceeded', 429, 'RATE_LIMIT_EXCEEDED')
|
||
}
|
||
|
||
if (!response.ok) {
|
||
throw new TICAPIError(`TIC API error: ${response.statusText}`, response.status)
|
||
}
|
||
|
||
const body = await response.json()
|
||
cacheSet(endpoint, body)
|
||
return body
|
||
} catch (error: unknown) {
|
||
if (error instanceof Error && (error.name === 'TimeoutError' || error.name === 'AbortError')) {
|
||
throw new TICAPIError('Request timeout', undefined, 'TIMEOUT')
|
||
}
|
||
if (error instanceof TICAPIError) {
|
||
throw error
|
||
}
|
||
const message = error instanceof Error ? error.message : String(error)
|
||
throw new TICAPIError(`Failed to fetch from TIC: ${message}`)
|
||
}
|
||
}
|
||
|
||
/** Search for a company by org number. Returns the first matching document or null. */
|
||
export async function searchCompanyByOrgNumber(
|
||
orgNumber: string
|
||
): Promise<TICCompanyDocument | null> {
|
||
const cleaned = orgNumber.replace(/[\s-]/g, '')
|
||
const data = await ticApiFetch<TICCompanyResponse>(
|
||
`/search-public/companies?q=${cleaned}&query_by=registrationNumber`
|
||
)
|
||
|
||
if (!data || data.found === 0 || !data.hits?.[0]) {
|
||
return null
|
||
}
|
||
|
||
return data.hits[0].document
|
||
}
|
||
|
||
/**
|
||
* Get bank accounts for a company. v2 narrows this endpoint to Bankgirot
|
||
* numbers only (returns `Bankgironumber_Dto[]`); v1's IBAN / plusgiro
|
||
* coverage is no longer available from this path.
|
||
*/
|
||
export async function getBankAccounts(companyId: number): Promise<TICBankgirot[] | null> {
|
||
return ticApiFetch<TICBankgirot[]>(`/companies/${companyId}/bank-accounts`)
|
||
}
|
||
|
||
/**
|
||
* Get industry codes for a company. v2 returns a discriminated array
|
||
* (`CompanyIndustryCode_Dto[]`) covering both SNI 2007 and SNI 2025;
|
||
* callers filter by `companyIndustryCodeType` for the version they want.
|
||
*/
|
||
export async function getIndustryCodes(companyId: number): Promise<TICIndustryCode[] | null> {
|
||
return ticApiFetch<TICIndustryCode[]>(`/companies/${companyId}/industries`)
|
||
}
|
||
|
||
/** Get email addresses for a company. */
|
||
export async function getEmails(companyId: number): Promise<TICEmail[] | null> {
|
||
return ticApiFetch<TICEmail[]>(`/companies/${companyId}/email-addresses`)
|
||
}
|
||
|
||
/** Get phone numbers for a company. */
|
||
export async function getPhones(companyId: number): Promise<TICPhone[] | null> {
|
||
return ticApiFetch<TICPhone[]>(`/companies/${companyId}/phone-numbers`)
|
||
}
|
||
|
||
/** Get company purpose / verksamhetsbeskrivning. */
|
||
export async function getCompanyPurpose(companyId: number): Promise<TICCompanyPurpose[] | null> {
|
||
return ticApiFetch<TICCompanyPurpose[]>(`/companies/${companyId}/purposes`)
|
||
}
|
||
|
||
/**
|
||
* List all documents filed by the company (annual reports, audit reports,
|
||
* articles of association, minutes, etc.). v2 replaces v1's
|
||
* `/financial-report-summaries` with this broader endpoint. Filter the
|
||
* result by `type === 'annualReport'` to recover the financial-report
|
||
* subset.
|
||
*/
|
||
export async function getCompanyDocuments(companyId: number): Promise<TICDocument[] | null> {
|
||
return ticApiFetch<TICDocument[]>(`/companies/${companyId}/documents`)
|
||
}
|
||
|
||
/**
|
||
* Get fiscal-year configurations for a company. v2 endpoint with no v1
|
||
* equivalent — used to auto-fill fiscal-year selection during Accounted
|
||
* onboarding so the user doesn't have to enter MM-DD manually.
|
||
*/
|
||
export async function getFiscalYears(companyId: number): Promise<TICFiscalYear[] | null> {
|
||
return ticApiFetch<TICFiscalYear[]>(`/companies/${companyId}/fiscal-years`)
|
||
}
|
||
|
||
/**
|
||
* Get accounting-period change history for a company. v2 endpoint with
|
||
* no v1 equivalent — surfaces "this company has shifted its year-end"
|
||
* during onboarding/customer-setup.
|
||
*/
|
||
export async function getAccountingPeriods(
|
||
companyId: number
|
||
): Promise<TICAccountingPeriod[] | null> {
|
||
return ticApiFetch<TICAccountingPeriod[]>(`/companies/${companyId}/accounting-periods`)
|
||
}
|
||
|
||
/**
|
||
* Get payroll summary for a company. v2 endpoint — restructured from
|
||
* v1's `/se/payroll`, returns `{ payroll2, payrolls }` where `payroll2`
|
||
* is the modern per-period breakdown and `payrolls` is the legacy
|
||
* Skatteverket MOMS/AG totals.
|
||
*/
|
||
export async function getPayrolls(companyId: number): Promise<TICPayrollSummary | null> {
|
||
return ticApiFetch<TICPayrollSummary>(`/companies/${companyId}/payrolls`)
|
||
}
|
||
|
||
/**
|
||
* Get firmateckning (signatory) rules for a company. v2 endpoint
|
||
* (renamed from v1 `/signatories`). Free-form Swedish descriptions of
|
||
* who can sign for the company; consumed by the AB invoice/årsredovisning
|
||
* signer-pick flows.
|
||
*/
|
||
export async function getSignatory(companyId: number): Promise<TICSignatory[] | null> {
|
||
return ticApiFetch<TICSignatory[]>(`/companies/${companyId}/signatory`)
|
||
}
|
||
|
||
/**
|
||
* Get representatives (board / CEO / auditor) for a company. v2 splits
|
||
* what v1 called `/parties` into `/representatives` (this endpoint) and
|
||
* `/beneficial-owners` (separate). Returns a wrapper with board-summary
|
||
* counts plus the per-person list.
|
||
*/
|
||
export async function getRepresentatives(
|
||
companyId: number
|
||
): Promise<TICRepresentatives | null> {
|
||
return ticApiFetch<TICRepresentatives>(`/companies/${companyId}/representatives`)
|
||
}
|
||
|
||
/**
|
||
* Get current and historical status entries for a company (active, in
|
||
* liquidation, struck off, bankruptcy, etc.). v2 endpoint. Each entry
|
||
* carries a traffic-light `statusColor` (red/yellow/green/neutral) and
|
||
* an `isCeased` flag inside `companyStatusDescription`.
|
||
*/
|
||
export async function getCompanyStatus(
|
||
companyId: number
|
||
): Promise<TICCompanyStatusEntry[] | null> {
|
||
return ticApiFetch<TICCompanyStatusEntry[]>(`/companies/${companyId}/status`)
|
||
}
|
||
|
||
/**
|
||
* Get current + historic beneficial owner records from Bolagsverket
|
||
* (verklig huvudman per Lag 2017:631). Returns notifications and any
|
||
* exempt-from-registration flags. Used to answer ownership questions
|
||
* authoritatively rather than asking the user to confirm.
|
||
*
|
||
* v2 endpoint — split out from what v1 grouped under `/parties`.
|
||
* Representatives (board/CEO/auditor) live at `/representatives` instead.
|
||
*/
|
||
export async function getBeneficialOwners(
|
||
companyId: number,
|
||
): Promise<TICBeneficialOwnerResponse | null> {
|
||
return ticApiFetch<TICBeneficialOwnerResponse>(
|
||
`/companies/${companyId}/beneficial-owners`,
|
||
)
|
||
}
|