6ea92f3152
Community PR #2416 by @olofpinzke, adopted and finished by maintainers (rebased so every commit is signed). Why the problem occurred: no Zettle integration; POS sales only reached the books as bank descriptors while Woo/Shopify already had order underlag via webshop_orders. The contributor's version also failed at the database (platform CHECKs listed only woocommerce/shopify), which the mocked unit tests never saw. What was simplified: reused the Orders/book/invoice path instead of a new inbox; Finance API payouts/fees deferred. Sales the one-account, revenue-per-rate model cannot book (split tender, gift cards, tips) import unbookable with a "bokför manuellt" title instead of guessing accounts. Reset parity uses the rename-and-wrap pattern instead of re-issuing the reset body. Why this solution: per-purchase rows give the radunderlag BFL verifikat need and the bulk-book path exists; daily kassarapport aggregation and Finance API fees/payouts are the follow-up (DECISIONS.md). Skeptic-refuted paths fixed before merge: concurrent refresh-token rotation (sync claim), cron offset paging (candidate snapshot), platform CHECKs, writer-role gate, migration-reset parity, white-label return origin re-validated at callback, VAT net from product rows. Not live until ZETTLE_CLIENT_ID / ZETTLE_CLIENT_SECRET / ZETTLE_CREDENTIALS_ENCRYPTION_KEY are set on Vercel and a Zettle developer app is registered with the callback redirect URI. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WtYqzKPoTSRHskYYdf7MwB
162 lines
6.0 KiB
TypeScript
162 lines
6.0 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import { getPool, withUserContext } from './setup'
|
|
import { randomUUID } from 'crypto'
|
|
import { insertAuthUser, insertCompanyMember, seedCompany } from './fixtures'
|
|
|
|
const uniqueOrg = (label: string) => label + '-' + randomUUID()
|
|
|
|
/**
|
|
* Covers migration 20260909100000_zettle_connections:
|
|
* 1. RLS: members insert and read their own company's connection.
|
|
* 2. One ACTIVE connection per company.
|
|
* 3. One organization actively connected to at most one company.
|
|
* 4. No DELETE policy.
|
|
*/
|
|
|
|
describe('zettle_connections RLS', () => {
|
|
it('a member can insert and read their company connection', async () => {
|
|
const { userId, companyId } = await seedCompany()
|
|
const org = uniqueOrg('member')
|
|
await withUserContext(userId, async (client) => {
|
|
const inserted = await client.query(
|
|
`INSERT INTO public.zettle_connections
|
|
(company_id, user_id, organization_uuid, status)
|
|
VALUES ($1, $2, $3, 'active')
|
|
RETURNING id`,
|
|
[companyId, userId, org],
|
|
)
|
|
expect(inserted.rows).toHaveLength(1)
|
|
|
|
const read = await client.query(
|
|
`SELECT status, organization_uuid FROM public.zettle_connections WHERE company_id = $1`,
|
|
[companyId],
|
|
)
|
|
expect(read.rows).toEqual([{ status: 'active', organization_uuid: org }])
|
|
})
|
|
})
|
|
|
|
it('a non-member sees nothing and cannot insert for a foreign company', async () => {
|
|
const { userId: ownerId, companyId } = await seedCompany()
|
|
await getPool().query(
|
|
`INSERT INTO public.zettle_connections (company_id, user_id, organization_uuid, status)
|
|
VALUES ($1, $2, $3, 'active')`,
|
|
[companyId, ownerId, uniqueOrg('foreign')],
|
|
)
|
|
const { userId: outsiderId } = await seedCompany()
|
|
|
|
await withUserContext(outsiderId, async (client) => {
|
|
const read = await client.query(
|
|
`SELECT id FROM public.zettle_connections WHERE company_id = $1`,
|
|
[companyId],
|
|
)
|
|
expect(read.rows).toHaveLength(0)
|
|
|
|
await expect(
|
|
client.query(
|
|
`INSERT INTO public.zettle_connections (company_id, user_id, organization_uuid, status)
|
|
VALUES ($1, $2, $3, 'pending')`,
|
|
[companyId, outsiderId, uniqueOrg('intruder')],
|
|
),
|
|
).rejects.toThrow(/row-level security/i)
|
|
})
|
|
})
|
|
|
|
it('only one ACTIVE connection per company is allowed', async () => {
|
|
const { userId, companyId } = await seedCompany()
|
|
await getPool().query(
|
|
`INSERT INTO public.zettle_connections (company_id, user_id, organization_uuid, status)
|
|
VALUES ($1, $2, $3, 'active')`,
|
|
[companyId, userId, uniqueOrg('org-one')],
|
|
)
|
|
await expect(
|
|
getPool().query(
|
|
`INSERT INTO public.zettle_connections (company_id, user_id, organization_uuid, status)
|
|
VALUES ($1, $2, $3, 'active')`,
|
|
[companyId, userId, uniqueOrg('org-two')],
|
|
),
|
|
).rejects.toMatchObject({ code: '23505' })
|
|
})
|
|
|
|
it('an organization may be actively connected to at most one company', async () => {
|
|
const { userId: userA, companyId: companyA } = await seedCompany()
|
|
const { userId: userB, companyId: companyB } = await seedCompany()
|
|
const sharedOrg = uniqueOrg('shared')
|
|
await getPool().query(
|
|
`INSERT INTO public.zettle_connections (company_id, user_id, organization_uuid, status)
|
|
VALUES ($1, $2, $3, 'active')`,
|
|
[companyA, userA, sharedOrg],
|
|
)
|
|
await expect(
|
|
getPool().query(
|
|
`INSERT INTO public.zettle_connections (company_id, user_id, organization_uuid, status)
|
|
VALUES ($1, $2, $3, 'active')`,
|
|
[companyB, userB, sharedOrg],
|
|
),
|
|
).rejects.toMatchObject({ code: '23505' })
|
|
})
|
|
|
|
it('members cannot DELETE a connection (revoke-only)', async () => {
|
|
const { userId, companyId } = await seedCompany()
|
|
const inserted = await getPool().query(
|
|
`INSERT INTO public.zettle_connections (company_id, user_id, organization_uuid, status)
|
|
VALUES ($1, $2, $3, 'active') RETURNING id`,
|
|
[companyId, userId, uniqueOrg('nodelete')],
|
|
)
|
|
const id = inserted.rows[0].id as string
|
|
await withUserContext(userId, async (client) => {
|
|
const deleted = await client.query(
|
|
`DELETE FROM public.zettle_connections WHERE id = $1`,
|
|
[id],
|
|
)
|
|
expect(deleted.rowCount).toBe(0)
|
|
})
|
|
const still = await getPool().query(
|
|
`SELECT status FROM public.zettle_connections WHERE id = $1`,
|
|
[id],
|
|
)
|
|
expect(still.rows[0].status).toBe('active')
|
|
})
|
|
})
|
|
|
|
/**
|
|
* Covers migration 20260909100400_zettle_platform_parity:
|
|
* 1. webshop_orders / webshop_store_settings accept platform = 'zettle'.
|
|
* 2. The writer-role gate (20260902093000) is attached: a viewer cannot
|
|
* connect a Zettle account even though RLS membership would let them.
|
|
*/
|
|
describe('zettle platform parity', () => {
|
|
it('lets webshop rows carry platform = zettle', async () => {
|
|
const { rows } = await getPool().query<{ conname: string; def: string }>(
|
|
`SELECT conname, pg_get_constraintdef(oid) AS def
|
|
FROM pg_constraint
|
|
WHERE conname IN ('webshop_orders_platform_check', 'webshop_store_settings_platform_check')
|
|
ORDER BY conname`,
|
|
)
|
|
expect(rows.map((r) => r.conname)).toEqual([
|
|
'webshop_orders_platform_check',
|
|
'webshop_store_settings_platform_check',
|
|
])
|
|
for (const row of rows) {
|
|
expect(row.def).toContain("'zettle'")
|
|
expect(row.def).toContain("'shopify'")
|
|
expect(row.def).toContain("'woocommerce'")
|
|
}
|
|
})
|
|
|
|
it('refuses a viewer who tries to connect', async () => {
|
|
const { companyId } = await seedCompany()
|
|
const viewerId = await insertAuthUser()
|
|
await insertCompanyMember({ companyId, userId: viewerId, role: 'viewer' })
|
|
|
|
await withUserContext(viewerId, async (client) => {
|
|
await expect(
|
|
client.query(
|
|
`INSERT INTO public.zettle_connections (company_id, user_id, organization_uuid, status)
|
|
VALUES ($1, $2, $3, 'pending')`,
|
|
[companyId, viewerId, uniqueOrg('viewer')],
|
|
),
|
|
).rejects.toThrow(/no write access to company/i)
|
|
})
|
|
})
|
|
})
|