Files
accounted/supabase/migrations/20260819190000_notice_dismissals.sql
Jakob Wennberg 9fc05c383f feat(notices): one aggregated notice line instead of stacked degraded-state banners (#1733)
* feat(notices): lib/notices aggregator + single notice line on Hem

Degraded-state surfaces (broken/expiring bank connections, Skatteverket
reconnect, failing cloud backups, wrong-account hint) each hand-rolled
their own detection and stacked independently on the dashboard. This adds
lib/notices, mirroring lib/worklist, as the single owner of every health
predicate, and de-clutters the surfaces:

- lib/notices/{types,predicates,categories,aggregate}: five documented
  categories with a fixed priority order; every predicate soft-fails to
  null; pure decision helpers live in predicates.ts so 'use client' pages
  can import them without pulling server-only modules. Broken supersedes
  expiring for the same bank connection by construction (status filter).
- GET /api/notices + POST /api/notices/dismiss (withRouteContext), and a
  notice_dismissals table (per company+user+notice_id, RLS user-scoped).
  Notice ids embed a state discriminator, so a dismissal hides exactly
  the state the user saw and a NEW failure surfaces again.
- Hem renders only the highest-priority notice as ONE AttnLine where the
  boxed BackupHealthBanner card sat (banner deleted; its multi-provider
  sentence logic moved into the backup_failing predicate), with a quiet
  "+N till" inline expander. otherAccountHint joins the same list as the
  lowest-priority category instead of an unconditional extra line.
- transactions and skattekonto keep their own AttnLine copy/CTA but source
  the reconnect decision from the shared skvStatusNeedsReconnect /
  skvAuthErrorNeedsReconnect predicates; Hem's Bevaka row imports the
  expiring-consent day-math instead of duplicating it.
- design.md convention 6 addendum: max one global notice line + max one
  page-domain attn line (locked convention: needs founder sign-off).
- i18n: new notices namespace in sv+en; moved banner/hint keys deleted.
- notice_dismissals classified as archive-excluded (UI state, not
  räkenskapsinformation) to satisfy the full-archive contract.

SkatteverketPromoCard keeps its localStorage dismiss for now; migrating it
to notice_dismissals is a follow-up.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(notices): stable dismissals with reaping, bounded ids, unnamed-bank copy

Review fixes on the notice aggregator:

- Migration renamed 20260819080000 -> 20260819190000_notice_dismissals.sql
  (version collision with another in-flight PR; content unchanged).
- backup_failing dismissal stability: the id no longer embeds
  last_auto_sync_at / needs_reauth_at, which the cron re-stamps while the
  SAME incident persists and so resurrected a dismissed notice daily. The
  id is now stable per (provider, reason), and the opposite direction is
  kept correct by stale-dismissal reaping in getCompanyNotices: when a
  category is currently healthy, the caller's stored dismissals for that
  category (matched on the 'category:' id prefix) are best-effort deleted,
  so error -> dismiss -> healthy (reaped) -> new error resurfaces. Audit of
  the other ids: bank ids embed connection id + status/expiry and skv
  embeds the incident's first-error/expiry timestamp (markNeedsReconsent
  only fires post-connect), all stable per incident; they get the same
  reaping as hygiene. Contract documented on Notice.id in types.ts.
- NULL bank_name no longer interpolates the Swedish fallback 'banken' into
  the English message: a bank_broken_one_unnamed message variant (sv + en)
  is selected instead of a name param.
- Bounded notice ids: folding several connections into one discriminator
  now collapses to count + first 8 hex of a sha256 over the sorted parts
  (node:crypto, server-only) instead of concatenating uuids; single
  connection ids stay human-readable. Dismiss schema cap tightened to 200
  with an updated rationale.
- Tests: persisting failure stays dismissed across two aggregations,
  healthy state reaps, new failure after reap resurfaces, hint never
  reaped, failed reap swallowed, 30-connection id under 200 chars and
  stable across orderings, unnamed-bank variant, sorted backup id stable
  across cron re-stamps.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(notices): pg-real coverage for the notice_dismissals policies

The coverage gate is right to flag the migration: every policy on this table
binds company membership AND auth.uid(), and nothing exercised it. The suite
pins the property that makes the table different from the rest of the schema:
a dismissal is personal, so a colleague in the same company keeps seeing a
notice the other member hid. It also covers the upsert re-stamp (which needs
the UPDATE policy), cross-tenant refusal, dismissing on behalf of another
user, the caller-scoped DELETE that reaping relies on, and the composite key.

Falsification-verified against a real Postgres: weakening the SELECT policy
to company-only scoping fails the colleague-isolation test.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-20 10:27:52 +02:00

67 lines
2.7 KiB
SQL

-- Per-user dismissals for degraded-state notices (lib/notices).
--
-- lib/notices aggregates system/integration health (broken bank connections,
-- Skatteverket reconnect, failing cloud backups, expiring PSD2 consents,
-- wrong-account hint) into priority-ordered notices. A user can dismiss one;
-- the dismissal must be server-side and per (company, user) so it works
-- cross-device, unlike the localStorage patterns it replaces.
--
-- notice_id is an opaque text id that embeds a state discriminator
-- (connection id + status, consent expiry, error timestamp): a dismissal
-- hides exactly the state the user saw, and a NEW failure after a fix mints
-- a new id and surfaces again. Rows are therefore never updated in place
-- beyond re-stamping dismissed_at on a repeat dismissal (upsert), and stale
-- rows for states that no longer occur are harmless.
CREATE TABLE IF NOT EXISTS public.notice_dismissals (
company_id UUID NOT NULL REFERENCES public.companies ON DELETE CASCADE,
user_id UUID NOT NULL REFERENCES auth.users ON DELETE CASCADE,
notice_id TEXT NOT NULL,
dismissed_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
PRIMARY KEY (company_id, user_id, notice_id)
);
ALTER TABLE public.notice_dismissals ENABLE ROW LEVEL SECURITY;
-- All access is scoped to the user's own rows within their companies:
-- dismissals are personal (a colleague still sees the notice), so even
-- SELECT is bound to auth.uid(), not just company membership.
DROP POLICY IF EXISTS "Users see their own notice dismissals" ON public.notice_dismissals;
CREATE POLICY "Users see their own notice dismissals"
ON public.notice_dismissals FOR SELECT
USING (
company_id IN (SELECT public.user_company_ids())
AND user_id = auth.uid()
);
DROP POLICY IF EXISTS "Users insert their own notice dismissals" ON public.notice_dismissals;
CREATE POLICY "Users insert their own notice dismissals"
ON public.notice_dismissals FOR INSERT
WITH CHECK (
company_id IN (SELECT public.user_company_ids())
AND user_id = auth.uid()
);
-- Upserts re-stamp dismissed_at on conflict, which needs UPDATE.
DROP POLICY IF EXISTS "Users update their own notice dismissals" ON public.notice_dismissals;
CREATE POLICY "Users update their own notice dismissals"
ON public.notice_dismissals FOR UPDATE
USING (
company_id IN (SELECT public.user_company_ids())
AND user_id = auth.uid()
)
WITH CHECK (
company_id IN (SELECT public.user_company_ids())
AND user_id = auth.uid()
);
DROP POLICY IF EXISTS "Users delete their own notice dismissals" ON public.notice_dismissals;
CREATE POLICY "Users delete their own notice dismissals"
ON public.notice_dismissals FOR DELETE
USING (
company_id IN (SELECT public.user_company_ids())
AND user_id = auth.uid()
);
NOTIFY pgrst, 'reload schema';