Jakob Wennberg
31fba5e8f9
* fix(accruals): carry origin dimensions onto dissolution entries
A project-tagged deferred invoice line lost its dimensions bag on every
monthly dissolution: the schedule never stored the bag, so dissolution
lines booked untagged and the per-project P&L drifted from the origin.
Persist the merged bag (invoice default_dimensions with the item bag on
top, same merge the origin generators use) on accrual_schedules and
attach it to BOTH dissolution lines: both origin generators tag the
interim 17xx/29xx line too, so per-dimension views of the interim
account keep netting to zero. Pre-existing schedules stay at '{}' and
keep today's untagged behavior; backfill is a separate follow-up.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(accruals): let dissolutions post when the tagged dimension value is archived
Carrying the origin's dimensions bag onto dissolution lines pulled every
monthly periodisering into validateEntryDimensions. With dimensions_enabled,
a project archived after the origin invoice was booked made the validator
reject the dissolution: the accrual service caught the rejection, wrote
last_error and left the installment pending forever. The remaining months of
prepaid cost would never reach 5xxx/6xxx, the interim 17xx/29xx account would
stay overstated, and the trial balance still balances, so no year-end check
fires and the arsredovisning is filed with understated cost.
Add a second, narrow exempt set (DIMENSION_VALIDATION_EXEMPT_SOURCE_TYPES =
{'accrual'}) with an isDimensionValidationExemptSource() helper, and skip the
soft registry validation for it in createDraftEntry. A dissolution is the
mechanical continuation of an already-approved, already-posted decision: the
same category as a storno, which the engine already bypasses.
The tag is kept, never stripped: an archived value still exists in the
registry and the cost genuinely belongs to that project. The rules set
(required/default/fixed) stays untouched, and the other two
validateEntryDimensions call sites keep validating: updateDraftEntry is a
user edit of an editable draft, and replaceOpeningBalanceEntry rejects any
source_type other than opening_balance.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
15 lines
811 B
SQL
15 lines
811 B
SQL
-- Accrual schedules carry the origin line's dimensions bag so dissolution
|
|
-- entries can tag their lines the way the origin entry tagged its interim
|
|
-- (17xx/29xx) line. Without this, every monthly dissolution books untagged
|
|
-- and a project-tagged deferred invoice line silently disappears from the
|
|
-- per-project P&L while the tagged interim balance never nets to zero.
|
|
--
|
|
-- Shape: {sie_dim_no: object_code}, same as journal_entry_lines.dimensions;
|
|
-- the CHECK mirrors dimension_values.attributes (20260702084500). Existing
|
|
-- rows get '{}' (untagged): pre-existing schedules keep today's behavior; a
|
|
-- backfill from the origin entry is a separate follow-up.
|
|
|
|
ALTER TABLE public.accrual_schedules
|
|
ADD COLUMN dimensions jsonb NOT NULL DEFAULT '{}'::jsonb
|
|
CHECK (jsonb_typeof(dimensions) = 'object');
|