Files
accounted/supabase/migrations/20260703090000_rot_rut_payout_requests.sql
Mattsson 237b77a366 feat: custom inbound mail domains, rot/rut payout file, invoice email texts, security hardening (#878)
* fix(security): guard MCP test keys, RLS role gate + voucher RPC guards, /api MFA gate, deps

- MCP: force dry-run / block writes for test-mode API keys in tools/call (extensions/general/mcp-server)
- DB: current_user_can_write role gate on write policies (40 tables) + tenant guards, SET search_path, REVOKE anon on commit_journal_entry / next_voucher_number / detect_voucher_gaps (migration 20260702093000)
- Middleware: MFA (AAL2) gate on cookie-authenticated /api routes via apiPathSkipsMfaGate
- Deps: npm audit fix clears mailparser/linkify-it/nodemailer/svix/uuid highs; xlsx -> SheetJS 0.20.3

Adds unit + pg-real tests. Does not touch in-progress ROT/RUT or invoice-email-texts work.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(invoices): rot/rut begäran om utbetalning — HUS XML (V6), payout tracking + settlement, MCP tool

Generates Skatteverkets begäran-om-utbetalning file (schema V6) from paid
ROT/RUT invoices — no submission API exists, the file is uploaded manually
at skatteverket.se. Headless by design for now: API routes + MCP tool
(gnubok_generate_rot_rut_file), no UI surfaces.

- lib/invoices/rot-rut-file.ts: pure XML generator with deterministic
  per-invoice blockers (hours, work type, personnummer, property info,
  mixed rot+rut, XSD limits) + 31 January deadline warnings
- rot_rut_payout_requests(+items) tables: one active begäran per invoice
  (DB triggers incl. reactivation guard), RLS, audit, pg-real tests
- Settlement: POST /settle books debit 1930 / credit 1513 via the engine
  (source_type rot_rut_payout); partial payouts → partially_paid
- Work-type lists corrected against Begaran.xsd: IT-tjänster is rut-only,
  snöskottning/tillsyn/tvätt added (schablontjänster utfört-only)
- Fix: invoice-level fastighetsbeteckning was validated but never
  persisted — now stamped onto rot lines in build-invoice-write; API
  accepts bostadsrätt pair (lägenhetsnr + BRF orgnr, editor UI deferred)
- invoice_items.brf_org_number migration + MCP scope invoices:write

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(invoices): per-company editable invoice email texts

Add an "E-posttexter" section under Settings -> Fakturering where the
subject, greeting, body and sign-off of the standard invoice email can
be customized per company in Swedish and English. Fields pre-fill with
the standard texts and only diffs from the standard are stored
(company_settings.invoice_email_texts JSONB), so future improvements to
the stock wording still reach companies that have not customized. Each
field has a reset-to-standard button; cleared fields snap back.

Texts support a fixed placeholder set (invoice number, customer name,
first name, company, due date, amount) substituted at send time in a
single pass; unknown placeholders stay literal. Custom texts are
HTML-escaped after substitution, newlines become <br> in the HTML
variant, and subject lines are flattened to a single header line.
Overrides apply to standard invoices only - credit notes, proforma and
delivery notes keep the stock texts. All send paths (UI, v1 API, MCP
approval, recurring) pick the texts up via the existing settings row.

The Zod schema half of this change (InvoiceEmailTextsSchema in
lib/api/schemas.ts) was inadvertently included in 8291f745.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(documents): accept PDFs with preamble before %PDF- header, surface content rejections as 400

detectFileMagic required the %PDF- signature at byte 0 (BOM aside),
rejecting genuine PDFs that carry a leading newline or junk bytes —
files every ISO 32000 reader opens fine. Now scan the first 1024 bytes
for the signature, matching real-reader behavior. Image types stay
strict at offset 0 to keep the anti-placeholder defense tight.

Magic-byte rejections were also mislabeled as DOC_UPLOAD_STORAGE_FAILED
(500 'Filen kunde inte sparas'), blaming storage for a client-side file
problem. Both upload routes now map them to a new
DOC_UPLOAD_INVALID_CONTENT (400) with an accurate message.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(bookkeeping): full keyboard flow for manual journal entry

Enter now drives the whole verifikat flow: verifikationstext drops into
the first row missing an account, konto commits advance to debet, Enter
on an empty debet hops to kredit, and an entered amount jumps to the
next row. Once the voucher balances, Enter opens the review (unchanged
gate) and the auto-focused confirm posts it — including through the
no-underlag warning dialog. Escape in the inline review goes back to
the form.

Also fixes an Enter footgun in AccountCombobox: a bare Enter on a
freshly focused field no longer selects the first account in the list —
selection now requires typing or arrow navigation; otherwise Enter
re-commits the current value or bubbles to the form-level handler.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat: add custom inbound domains management for companies

- Implemented functionality to allow companies to claim and manage their own inbound email domains via Resend's API.
- Created a new table `company_inbound_domains` to store domain information, including status and DNS records.
- Added necessary RLS policies to restrict access based on user roles (owner/admin).
- Developed functions for domain normalization, validation, claiming, verification, and removal.
- Implemented webhook handling for domain status updates from Resend.
- Added comprehensive tests for RLS, constraints, and triggers related to the new domain management feature.

* fix: address PR #878 review findings and CI failures

- migrations: drop the ai_usage_tracking policy block from the role-gate
  migration — the table was removed by 20260504120000_remove_ai_subsystem
  and only lingers on staging as drift; a from-scratch chain (pg-real,
  Supabase preview) failed on it
- invoice-inbox: never flip a custom domain to verified off a domain.updated
  webhook alone — confirm the receiving capability with Resend first
  (fail-closed); normalize both sides of the orphan-adoption domain match
- rot/rut: block files where begärt belopp exceeds what the buyer paid
  (DEDUCTION_EXCEEDS_PAYMENT); tighten brf_org_number validation to real
  orgnr shapes; parameterize the settlement bank account (19xx, default 1930)
- rot/rut routes: log acting user on financial mutations, stop swallowing
  item mirror errors, narrow response projections (no customer ids through
  the invoice join); document the deliberate inline-XML decision
- documents: stop echoing raw storage-layer error messages to clients

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: round-2 CI + compliance findings on PR #878

- migrations: the role-gate migration targeted automation_webhooks, which
  20260515170000_webhooks_v2 renamed to webhooks on the canonical chain
  (staging kept the old name — drift); gate public.webhooks instead,
  dropping legacy schema-sync policy names defensively. Restore the
  20260623130000 owner fallback in next_voucher_number that the stale
  copied-verbatim body silently reverted (caught by engine.pg locally).
  Full migration chain verified from scratch against supabase/postgres:15.
- mcp: bump the tools/list payload ceiling 44K -> 45K — main's #877
  qualified-identifier schemas plus this branch's rot/rut tool crossed the
  ceiling only in combination; documented in the test's history log.
- rot/rut: refuse partial settlement before Skatteverkets beslut is
  recorded (would bypass the PATCH lifecycle and strand the request);
  block zero-kronor ärenden (ZERO_DEDUCTION); require sekelsiffra 16 on
  12-digit brf orgnr in both schema validation and normalizeBrfOrgNr

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: rename branch migrations off main's colliding versions

After the merge with main, two versions were shared by two files each
(20260702100000: rot_rut_payout_requests vs company_settings_dimensions_
enabled; 20260702130000: invoice_email_texts vs pending_operations_add_
create_dimension_value). psql-based CI applies by filename and doesn't
care, but Supabase branching records migrations by version (PK) — the
second file with the same version breaks the preview with a
schema_migrations_pkey duplicate. Neither branch migration is version-
recorded on staging or prod, so renaming to fresh 20260703 versions is
safe; nothing between the old and new positions depends on these objects.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(security): scope the /api MFA-gate bypass to real Bearer-auth surfaces

Any Authorization header — attacker-controlled — used to skip the AAL2
gate for every /api route, so a stolen-password AAL1 cookie session could
reach cookie-authenticated routes (which ignore the header) by attaching
`Authorization: x`. The skip is now scoped to the surfaces whose auth
contract IS the header (/api/v1 API keys, the MCP endpoint's OAuth
tokens); pure Bearer callers elsewhere (cron secret, signed webhooks)
carry no cookie session and were never touched by the gate, which only
fires for cookie users. Superagent P2 on PR #878.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test: normalize path separators in dimension statutory guard scan

The route scan compared walked file paths against a POSIX-path allowlist,
so the suite failed on Windows (backslash separators) while passing on
Linux CI. Normalize the scanned paths to forward slashes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-03 13:57:59 +02:00

270 lines
12 KiB
PL/PgSQL
Raw Permalink Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
-- Rot & rut: begäran om utbetalning (Skatteverkets husavdragstjänst)
--
-- Tracks generated payout-request files (HUS XML, schema V6 — see
-- dev_docs/skatteverket/husavdrag/) so an invoice can never end up in two
-- active begäran, and so the Skatteverket outcome (utbetalt/avslag) can be
-- recorded and settled against BAS 1513.
--
-- Also adds invoice_items.brf_org_number: ROT i bostadsrätt is reported with
-- bostadsrättsföreningens orgnr + lägenhetsnummer instead of
-- fastighetsbeteckning (BegaranCOMPONENT.xsd: BrfOrgNr, max 12 chars).
-- =============================================================================
-- 1. invoice_items.brf_org_number
-- =============================================================================
ALTER TABLE public.invoice_items
ADD COLUMN IF NOT EXISTS brf_org_number TEXT NULL;
-- Format (digits/dash, XSD BrfOrgNrTYPE) is validated at the API layer via
-- Zod, same approach as the other ROT/RUT columns (20260526121700). The DB
-- only guards the hard XSD length cap.
ALTER TABLE public.invoice_items DROP CONSTRAINT IF EXISTS invoice_items_brf_org_number_check;
ALTER TABLE public.invoice_items ADD CONSTRAINT invoice_items_brf_org_number_check
CHECK (brf_org_number IS NULL OR char_length(brf_org_number) <= 12);
-- =============================================================================
-- 2. rot_rut_payout_requests — one row per generated begäran-fil
-- =============================================================================
CREATE TABLE public.rot_rut_payout_requests (
id uuid DEFAULT gen_random_uuid() PRIMARY KEY,
company_id uuid NOT NULL REFERENCES public.companies(id) ON DELETE CASCADE,
user_id uuid NOT NULL REFERENCES auth.users(id) ON DELETE CASCADE,
deduction_type TEXT NOT NULL CHECK (deduction_type IN ('rot', 'rut')),
-- NamnPaBegaranTYPE: 116 chars, shown in Skatteverkets e-tjänst.
name TEXT NOT NULL CHECK (char_length(name) BETWEEN 1 AND 16),
-- Lifecycle: generated → submitted → paid | partially_paid | rejected.
-- cancelled is allowed from generated/submitted (file never uploaded, or
-- withdrawn before beslut). Transitions are enforced at the API layer;
-- the DB constrains the value set.
status TEXT NOT NULL DEFAULT 'generated' CHECK (status IN (
'generated', 'submitted', 'paid', 'partially_paid', 'rejected', 'cancelled'
)),
-- Sum of item requested_amount (kr). Denormalized for list views.
requested_total NUMERIC(12,2) NOT NULL CHECK (requested_total >= 0),
-- Filled in when Skatteverkets beslut is recorded.
decided_total NUMERIC(12,2) NULL CHECK (decided_total >= 0),
-- The archived XML file (räkenskapsinformation, 7-year retention via the
-- document_attachments WORM chain).
file_name TEXT NOT NULL,
file_document_id uuid NULL REFERENCES public.document_attachments(id) ON DELETE SET NULL,
-- Settlement voucher (debit 1930 / credit 1513) once utbetalningen booked.
settlement_journal_entry_id uuid NULL REFERENCES public.journal_entries(id) ON DELETE SET NULL,
submitted_at timestamptz NULL,
decided_at timestamptz NULL,
created_at timestamptz NOT NULL DEFAULT now(),
updated_at timestamptz NOT NULL DEFAULT now()
);
ALTER TABLE public.rot_rut_payout_requests ENABLE ROW LEVEL SECURITY;
CREATE POLICY "view own-company rot_rut_payout_requests"
ON public.rot_rut_payout_requests FOR SELECT
USING (company_id IN (SELECT user_company_ids()));
CREATE POLICY "insert own-company rot_rut_payout_requests"
ON public.rot_rut_payout_requests FOR INSERT
WITH CHECK (company_id IN (SELECT user_company_ids()));
CREATE POLICY "update own-company rot_rut_payout_requests"
ON public.rot_rut_payout_requests FOR UPDATE
USING (company_id IN (SELECT user_company_ids()));
CREATE POLICY "delete own-company rot_rut_payout_requests"
ON public.rot_rut_payout_requests FOR DELETE
USING (company_id IN (SELECT user_company_ids()));
CREATE INDEX idx_rot_rut_payout_requests_company_id
ON public.rot_rut_payout_requests (company_id);
CREATE INDEX idx_rot_rut_payout_requests_company_status
ON public.rot_rut_payout_requests (company_id, status);
CREATE TRIGGER set_updated_at_rot_rut_payout_requests
BEFORE UPDATE ON public.rot_rut_payout_requests
FOR EACH ROW EXECUTE FUNCTION public.update_updated_at_column();
CREATE TRIGGER audit_rot_rut_payout_requests
AFTER INSERT OR UPDATE OR DELETE ON public.rot_rut_payout_requests
FOR EACH ROW EXECUTE FUNCTION public.write_audit_log();
-- =============================================================================
-- 3. rot_rut_payout_request_items — one row per (request, invoice)
-- =============================================================================
CREATE TABLE public.rot_rut_payout_request_items (
id uuid DEFAULT gen_random_uuid() PRIMARY KEY,
request_id uuid NOT NULL REFERENCES public.rot_rut_payout_requests(id) ON DELETE CASCADE,
-- RESTRICT: an invoice referenced by a begäran is bokföringsunderlag and
-- must not disappear from under the request.
invoice_id uuid NOT NULL REFERENCES public.invoices(id) ON DELETE RESTRICT,
-- BegartBelopp for this invoice (kr, whole kronor in the file; stored with
-- öre precision because it mirrors invoices.deduction_total).
requested_amount NUMERIC(12,2) NOT NULL CHECK (requested_amount > 0),
-- Godkänt belopp from Skatteverkets beslut (null until decided).
decided_amount NUMERIC(12,2) NULL CHECK (decided_amount >= 0),
created_at timestamptz NOT NULL DEFAULT now(),
updated_at timestamptz NOT NULL DEFAULT now(),
UNIQUE (request_id, invoice_id)
);
ALTER TABLE public.rot_rut_payout_request_items ENABLE ROW LEVEL SECURITY;
CREATE POLICY "view own-company rot_rut_payout_request_items"
ON public.rot_rut_payout_request_items FOR SELECT
USING (EXISTS (
SELECT 1 FROM public.rot_rut_payout_requests r
WHERE r.id = rot_rut_payout_request_items.request_id
AND r.company_id IN (SELECT user_company_ids())
));
CREATE POLICY "insert own-company rot_rut_payout_request_items"
ON public.rot_rut_payout_request_items FOR INSERT
WITH CHECK (EXISTS (
SELECT 1 FROM public.rot_rut_payout_requests r
WHERE r.id = rot_rut_payout_request_items.request_id
AND r.company_id IN (SELECT user_company_ids())
));
CREATE POLICY "update own-company rot_rut_payout_request_items"
ON public.rot_rut_payout_request_items FOR UPDATE
USING (EXISTS (
SELECT 1 FROM public.rot_rut_payout_requests r
WHERE r.id = rot_rut_payout_request_items.request_id
AND r.company_id IN (SELECT user_company_ids())
));
CREATE POLICY "delete own-company rot_rut_payout_request_items"
ON public.rot_rut_payout_request_items FOR DELETE
USING (EXISTS (
SELECT 1 FROM public.rot_rut_payout_requests r
WHERE r.id = rot_rut_payout_request_items.request_id
AND r.company_id IN (SELECT user_company_ids())
));
CREATE INDEX idx_rot_rut_payout_request_items_request_id
ON public.rot_rut_payout_request_items (request_id);
CREATE INDEX idx_rot_rut_payout_request_items_invoice_id
ON public.rot_rut_payout_request_items (invoice_id);
CREATE TRIGGER set_updated_at_rot_rut_payout_request_items
BEFORE UPDATE ON public.rot_rut_payout_request_items
FOR EACH ROW EXECUTE FUNCTION public.update_updated_at_column();
CREATE TRIGGER audit_rot_rut_payout_request_items
AFTER INSERT OR UPDATE OR DELETE ON public.rot_rut_payout_request_items
FOR EACH ROW EXECUTE FUNCTION public.write_audit_log();
-- =============================================================================
-- 4. Integrity guard: one active begäran per invoice + same-company check
--
-- An invoice may appear in any number of cancelled/rejected requests (retry
-- after avslag) but in at most ONE active (generated/submitted/paid/
-- partially_paid) request — otherwise the same deduction could be requested
-- twice. Cross-table invariants can't be expressed as a UNIQUE index across
-- a JOIN, hence the trigger.
-- =============================================================================
CREATE OR REPLACE FUNCTION public.enforce_single_active_rot_rut_request()
RETURNS trigger
LANGUAGE plpgsql
AS $$
DECLARE
v_request_company uuid;
v_invoice_company uuid;
BEGIN
SELECT company_id INTO v_request_company
FROM public.rot_rut_payout_requests
WHERE id = NEW.request_id;
SELECT company_id INTO v_invoice_company
FROM public.invoices
WHERE id = NEW.invoice_id;
IF v_invoice_company IS NULL OR v_invoice_company != v_request_company THEN
RAISE EXCEPTION 'Invoice % does not belong to the same company as payout request %',
NEW.invoice_id, NEW.request_id;
END IF;
IF EXISTS (
SELECT 1
FROM public.rot_rut_payout_request_items i
JOIN public.rot_rut_payout_requests r ON r.id = i.request_id
WHERE i.invoice_id = NEW.invoice_id
AND i.id != NEW.id
AND r.status NOT IN ('cancelled', 'rejected')
) THEN
RAISE EXCEPTION 'Invoice % is already included in an active rot/rut payout request',
NEW.invoice_id
USING ERRCODE = '23505';
END IF;
RETURN NEW;
END;
$$;
CREATE TRIGGER enforce_single_active_rot_rut_request
BEFORE INSERT OR UPDATE OF invoice_id, request_id ON public.rot_rut_payout_request_items
FOR EACH ROW EXECUTE FUNCTION public.enforce_single_active_rot_rut_request();
-- The item-level trigger can be bypassed by flipping a cancelled/rejected
-- request back to an active status while its invoices have meanwhile been
-- included in another active request. Guard the reactivation path too.
CREATE OR REPLACE FUNCTION public.enforce_rot_rut_request_reactivation()
RETURNS trigger
LANGUAGE plpgsql
AS $$
BEGIN
IF OLD.status IN ('cancelled', 'rejected')
AND NEW.status NOT IN ('cancelled', 'rejected')
AND EXISTS (
SELECT 1
FROM public.rot_rut_payout_request_items mine
JOIN public.rot_rut_payout_request_items other
ON other.invoice_id = mine.invoice_id AND other.request_id != mine.request_id
JOIN public.rot_rut_payout_requests r ON r.id = other.request_id
WHERE mine.request_id = NEW.id
AND r.status NOT IN ('cancelled', 'rejected')
) THEN
RAISE EXCEPTION 'Cannot reactivate payout request %: an invoice is already included in another active request',
NEW.id
USING ERRCODE = '23505';
END IF;
RETURN NEW;
END;
$$;
CREATE TRIGGER enforce_rot_rut_request_reactivation
BEFORE UPDATE OF status ON public.rot_rut_payout_requests
FOR EACH ROW EXECUTE FUNCTION public.enforce_rot_rut_request_reactivation();
-- =============================================================================
-- 5. journal_entries.source_type: add 'rot_rut_payout' for the settlement
-- voucher (debit 1930 / credit 1513) booked when Skatteverket pays out.
-- =============================================================================
ALTER TABLE public.journal_entries
DROP CONSTRAINT IF EXISTS journal_entries_source_type_check;
ALTER TABLE public.journal_entries
ADD CONSTRAINT journal_entries_source_type_check
CHECK (source_type IN (
'manual', 'bank_transaction', 'invoice_created',
'invoice_paid', 'invoice_cash_payment', 'credit_note', 'salary_payment',
'opening_balance', 'year_end',
'storno', 'correction', 'import', 'system',
'inbox_item',
'supplier_invoice_registered', 'supplier_invoice_paid',
'supplier_invoice_cash_payment', 'supplier_credit_note',
'currency_revaluation',
'supplier_invoice_privately_paid',
'reminder_fee',
'accrual',
'result_appropriation',
'rot_rut_payout'
));
-- Reload PostgREST schema cache
NOTIFY pgrst, 'reload schema';