Jakob Wennberg
47fe193c48
* feat(perf): session-cached reference data layer, server-seeded, with a raw-fetch ratchet
Customer report (2026-08-26): "it takes time before all fields load when
clicking around". The cause is on the client: fiscal periods, settings,
accounts, cash accounts, dimensions and templates are fetched raw from 47 /
27 / 14 / 8 / 12 / 5 independent call sites, uncached, on every mount and
every dialog open, each request paying the auth proxy and route wrapper
before its own query. SWR was adopted for exactly this on 2026-07-13 but
reached only three files.
This PR adds the layer; consumers migrate in the follow-ups.
- lib/reference-data/keys.ts: one key builder per data set, company id in
position 1, null without a company; company_settings keeps the shape
useCompanySettings already uses so that hook is seeded without a change.
- lib/reference-data/fetchers.ts: browser Supabase for fiscal periods and
cash accounts (mirroring period.list and listForCompany ordering, pinned
by tests), /api for the lists whose routes do real work (accounts RPC,
dimensions ensure, template scoping, customer masking).
- lib/reference-data/hooks.ts: useFiscalPeriods, useCashAccounts,
useAccounts, useDimensions, useBookingTemplates, useCustomers,
useSuppliers, useArticles (+ re-exported useCompanySettings); one-minute
dedupe, keepPreviousData, background revalidation kept on so writes from
MCP/agents/other tabs surface.
- lib/reference-data/invalidate.ts: invalidateReferenceData(kind) for the
success path of every client write.
- lib/reference-data/seed.ts + components/providers/ReferenceDataSeed.tsx:
the dashboard layout fetches fiscal periods and cash accounts in its
existing batch and hands them, with the settings row it already had, to
SWR as fallback, so the first form of a session renders its period, bank
account and settings-driven fields on first paint. getDashboardSettings
now selects the full row for that (its other consumers read a subset).
The chart of accounts is not seeded (hundreds of KB for large charts).
- scripts/checks/raw-reference-fetch.mjs, wired into check:guards as a
per-file ratchet: GET-shaped fetch('/api/<reference path>') anywhere in
client-facing code and .from('<reference table>').select( in 'use client'
files. Baselined at 55 files; new sites fail CI; at 0 the entry goes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(checks): anchor every optional whitespace run in the raw-reference-fetch regex
CodeQL js/redos flagged the `\s*,?\s*\)` tail: two adjacent optional
whitespace runs around an optional comma backtrack polynomially on a long
near-miss. The URL and init-object pieces are now named fragments and
every whitespace run is followed by a literal, so there is one way to
match. Behaviour unchanged (same 7 fixtures + baseline count of 55);
a worst-case timing test pins the linear scan.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(checks): make the use-client directive regex unambiguous (CodeQL js/redos)
An unclosed /* let the lazy comment body be re-split at every later /*.
The body is now (?:[^*]|\*(?!\/))* which cannot cross a */, so the outer
repetition has one parse. Pinned with a 3000-comment worst-case test.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* ci: re-trigger checks for the rebased head
No workflow ran for dd560a7af (nor after close/reopen); an empty commit
gives the pull_request event a fresh head. No code change.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(checks): single-character whitespace alternative in the use-client detector (CodeQL js/redos)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
67 lines
2.8 KiB
TypeScript
67 lines
2.8 KiB
TypeScript
/**
|
|
* SWR cache keys for company-scoped reference data.
|
|
*
|
|
* One builder per data set is the single source of truth for the hooks
|
|
* (lib/reference-data/hooks.ts), the server seed (seed.ts) and the
|
|
* invalidation helper (invalidate.ts): a key spelled out anywhere else can
|
|
* drift from the seed and silently reintroduce the refetch this layer exists
|
|
* to remove. Every key carries the company id in position 1 so a company
|
|
* switch can never serve another company's list, and resolves to `null`
|
|
* (SWR: do not fetch) when there is no active company.
|
|
*
|
|
* `company_settings` keeps the shape components/settings/useSettings.ts has
|
|
* used since 2026-07-13 so that hook needs no change to be seeded.
|
|
*/
|
|
|
|
export const REFERENCE_KINDS = [
|
|
'company_settings',
|
|
'ref:fiscal-periods',
|
|
'ref:cash-accounts',
|
|
'ref:accounts',
|
|
'ref:dimensions',
|
|
'ref:booking-templates',
|
|
'ref:customers',
|
|
'ref:suppliers',
|
|
'ref:articles',
|
|
] as const
|
|
|
|
export type ReferenceKind = (typeof REFERENCE_KINDS)[number]
|
|
|
|
type Key<K extends ReferenceKind, Rest extends readonly unknown[] = []> =
|
|
| readonly [K, string, ...Rest]
|
|
| null
|
|
|
|
export const refKeys = {
|
|
companySettings: (companyId: string | null): Key<'company_settings'> =>
|
|
companyId ? (['company_settings', companyId] as const) : null,
|
|
fiscalPeriods: (companyId: string | null): Key<'ref:fiscal-periods'> =>
|
|
companyId ? (['ref:fiscal-periods', companyId] as const) : null,
|
|
cashAccounts: (companyId: string | null): Key<'ref:cash-accounts'> =>
|
|
companyId ? (['ref:cash-accounts', companyId] as const) : null,
|
|
accounts: (
|
|
companyId: string | null,
|
|
activeOnly = true,
|
|
): Key<'ref:accounts', [boolean]> =>
|
|
companyId ? (['ref:accounts', companyId, activeOnly] as const) : null,
|
|
dimensions: (companyId: string | null): Key<'ref:dimensions'> =>
|
|
companyId ? (['ref:dimensions', companyId] as const) : null,
|
|
bookingTemplates: (companyId: string | null): Key<'ref:booking-templates'> =>
|
|
companyId ? (['ref:booking-templates', companyId] as const) : null,
|
|
customers: (companyId: string | null): Key<'ref:customers'> =>
|
|
companyId ? (['ref:customers', companyId] as const) : null,
|
|
suppliers: (companyId: string | null): Key<'ref:suppliers'> =>
|
|
companyId ? (['ref:suppliers', companyId] as const) : null,
|
|
articles: (
|
|
companyId: string | null,
|
|
includeInactive = false,
|
|
): Key<'ref:articles', [boolean]> =>
|
|
companyId ? (['ref:articles', companyId, includeInactive] as const) : null,
|
|
}
|
|
|
|
const KIND_SET: ReadonlySet<string> = new Set(REFERENCE_KINDS)
|
|
|
|
/** True for any key produced by `refKeys` (used by the invalidation filter). */
|
|
export function isReferenceKey(key: unknown): key is readonly [ReferenceKind, string, ...unknown[]] {
|
|
return Array.isArray(key) && typeof key[0] === 'string' && KIND_SET.has(key[0])
|
|
}
|