Files
Jakob Wennberg 18cbc4c30a fix(security): audit remediation 2026-09-01: api_keys identity, viewer gates, OAuth binding, XSS, MFA gate (#2155)
* fix(security): bind api_keys to the caller, lock hash-as-bearer RPCs and provider token tables

Security audit 2026-09-01, critical items.

- api_keys INSERT requires user_id = auth.uid() again (an admin could
  forge a key for any co-member and act as them in every company they
  belong to); SELECT is own-keys-or-admin; a BEFORE trigger freezes the
  identity and credential columns against user-session UPDATEs.
- rotate_mcp_refresh_token and validate_and_increment_api_key become
  service_role only: they match rows by a presented SHA-256, so a hash
  readable by co-members was a bearer credential.
- validate_and_increment_api_key fails closed when the key's user is no
  longer a member of the key's company.
- provider_consent_tokens and provider_otc: the DELETE policies collapsed
  to "caller has any team row" (correlated subquery on a non-existent
  team_members.company_id). All member policies dropped; service_role
  only, matching every existing code path.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): role gates, ownership guards and posting integrity in the database

Security audit 2026-09-01, high items at the database layer.

- One table-level guard, enforce_company_writer_role(), blocks the
  read-only viewer role on 55 company-scoped tables including through
  the 15 membership-only SECURITY DEFINER writers. Keyed on the JWT role
  claim so it fires inside definer bodies; no-op for service_role and
  trigger cascades.
- company_members user_id/company_id immutable from user sessions;
  invitations can never grant owner; team_members gains a transition
  guard (admins keep non-owner role moves); companies team_id and
  archiving are owner-only and team attachment needs team membership.
- Direct statements (current_user = authenticated) can no longer insert
  posted headers, add lines under posted verifikat, or post a draft with
  a voucher number the sequence never issued. Sanctioned RPCs run as the
  definer and are untouched; the engine's own draft-then-post shapes
  still pass.
- create_document_version refuses viewers and foreign storage paths;
  validate_version_chain needs membership and loses anon EXECUTE;
  match_documents / match_booking_templates lose anon; cron maintenance
  RPCs become service_role only; the production-only
  seed_asset_categories is dropped.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* build: pin tsx as an exact devDependency instead of fetching it with npx at build time

prebuild ran "npx tsx" with no lockfile entry, so every Vercel, Docker
and CI build downloaded tsx@latest and its transitive tree from the
registry with no integrity check, inside the build environment.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): refuse the viewer role on API-key and MCP write paths

The v1 wrapper and the MCP company routing checked company membership
but never role, and both run as service role, so a read-only viewer
holding an API key could post vouchers and change settings through the
API. Mutating methods and non-read scopes now return 403 ROLE_READ_ONLY
for viewers on v1; MCP write tools refuse viewers the same way.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): stop serving uploaded SVG, XML and HTML as executable content on the app origin

Uploads persisted the browser-declared mime type and the inline proxy
served it verbatim, sandboxing only text/html; the storage proxy
forwarded the uploader's Content-Type. Any writer, or any Peppol sender,
could plant a scripted SVG or XHTML that executed on app.gnubok.se.

- inline route: allow-list of natively safe types (PDF, raster images)
  served as before; everything else gets the opaque sandbox CSP.
- storage proxy: octet-stream + attachment + sandbox unless the DB
  mime for the key is on the allow-list.
- document-service: the stored mime is the magic-byte validated type.
- logo upload: magic-byte validation, SVG refused.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): byrå brand logo upload decides the type by magic bytes and drops SVG

Same pattern as the company logo route: the logos bucket is public, so a
scripted SVG (or anything declared as an image) must never land there.
The upload pickers stop advertising SVG.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): bind Enable Banking, Stripe and WooCommerce callbacks to the initiating user

The callbacks resolved the pending row by oauth_state alone, so a
victim who completed an attacker-initiated consent had their bank
account, merchant account or store attached to the attacker's company.
requireFlowInitiator() now requires the cookie session of the user who
started the flow: no session redirects to login with the callback URL
preserved, a different user is refused and nothing is exchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): guard tenant-controlled outbound fetches and surface the disabled rate limiter

WooCommerce and Shopify syncs fetched a member-editable store URL with
plain fetch() and redirect following under the service role, and the
invoice PDF renderer fetched company_settings.logo_url unguarded. All
three go through a new safeFetch() (public-IP validation via url-guard,
https only, redirect: 'manual', body size cap) and re-normalise the
stored host at use time. checkRateLimit() keeps failing open on hosted
but logs one error per process when Upstash is not configured and
exports isRateLimiterConfigured().

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): decide the API MFA gate from server-authenticated factors, not the session cookie

getAuthenticatorAssuranceLevel() without arguments derives nextLevel
from session.user.factors, which comes from the unsigned sb-*-auth-token
cookie. Deleting factors from the cookie made an enrolled account look
like it had nothing to step up to, on every /api route and in
requireAuth. Both gates now read factors from the getUser() result or
listFactors() and the level from the verified JWT claim, and fail closed
on errors. Page-branch gate hardened the same way.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): bind Fortnox/Visma, Gmail and Skatteverket callbacks to the initiating user

The arcim-migration callback exchanged the provider code onto whatever
consent the one-time state named, with no check of who completed the
flow and no org-number comparison, so a phished Fortnox admin handed
their ledger to the attacker's company. provider_otc now records the
initiating user (migration 20260902100000); the callback requires that
session and, after the exchange, refuses a provider company whose org
number differs from the consent's company. The Gmail and Skatteverket
callbacks enforce the same initiator check.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): BankID signup confirms the email before linking the identity

Signup created an email-confirmed, MFA-exempt account for any address
the caller typed and returned a magic link, so an attacker could
pre-register a victim's email and keep a permanent BankID login into the
account the victim later adopted. The user is now created unconfirmed,
the identity carries email_verified_at NULL (migration 20260902101000),
bankid_linked is not set until the mailed confirmation is clicked, and
BankID login of a pending identity is refused with the confirmation
re-sent.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): bind MCP OAuth redirect URIs to the consenting user and cap scopes

A user-registered redirect URI was allowlisted globally, the consent page
named no client, and all scopes were pre-checked, so one phishing link
handed an attacker a full-scope key for the victim's company. Registered
URIs now resolve only for the registrant or a colleague sharing a
company; the consent page shows the client identity and redirect host;
non-built-in clients default to read-only pre-checks; scopes are capped
by the user's role (viewer: read only) at consent and at /token.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(auth): client follow-ups for BankID confirmation, callback mismatch copy and decision log

- register client handles the new confirmation_sent response from BankID
  signup with the existing inbox screen instead of calling verifyOtp.
- BankID login surfaces the email_unconfirmed explanation.
- WooCommerce settings map woocommerce_error=wrong_user to its own copy.
- Logo help text no longer advertises SVG.
- DECISIONS.md records the audit remediation choices.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(mcp-oauth): literal SoD columns in the api_keys insert so the phantom-column scanner resolves them

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* test(logo): type the upload fixtures as Uint8Array<ArrayBuffer> so they are valid BlobParts

Fixes the typecheck ratchet on PR #2155 and ratchets the baseline down
by the one legacy error the change removed.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-02 11:38:30 +02:00

225 lines
8.0 KiB
TypeScript

/**
* Guarded outbound `fetch` for URLs a tenant controls.
*
* Several server-side paths fetch a URL that a company member can write
* straight into the database through PostgREST (RLS lets members update
* their own rows, so app-side normalisation at create time is not a
* boundary): `woocommerce_connections.store_url`, `shopify_connections.
* shop_domain`, `company_settings.logo_url`. Fetching those with a bare
* `fetch()` from the Vercel function's network position is a textbook SSRF:
* cloud metadata (169.254.169.254), loopback, RFC 1918 ranges, and any 3xx
* that bounces the request there AFTER a hostname check passed.
*
* This helper is the one place such fetches go through:
*
* 1. The URL must be http(s). Anything else is refused up front.
* 2. Unless the URL's origin is explicitly trusted by the caller (e.g. the
* deployment's own Supabase storage origin, which may legitimately be a
* private address on a self-hosted install), EVERY A/AAAA record of the
* hostname must be publicly routable and the scheme must be https. That
* check is `validateWebhookUrl` from the webhook dispatcher, reused
* verbatim so there is a single definition of "safe address" in the
* codebase. IP-literal hostnames are classified directly, without DNS.
* 3. Redirects are never followed: `redirect: 'manual'` is forced and any
* 3xx (or an opaque-redirect response) is a refusal, not a response.
*
* Compared to `lib/webhooks/pinned-fetch.ts` this keeps the `fetch` /
* `Response` surface that the callers (and their tests) are written against,
* at the cost of the DNS-rebinding window between validation and connect that
* the pinned transport closes. That window is the same one url-guard.ts
* documents for its own callers and is acceptable for these read-only feeds;
* a caller that needs pinning should use pinnedHttpsFetch instead.
*
* Timeouts stay the caller's responsibility (`signal: AbortSignal.timeout()`),
* and body size is bounded with `readBodyWithCap` so a hostile host cannot
* balloon memory before a size check runs.
*/
import { isIP } from 'node:net'
import {
validateWebhookUrl as validateWebhookUrlDefault,
type WebhookUrlValidationReason,
} from '@/lib/webhooks/url-guard'
export type SafeFetchRefusalReason =
| WebhookUrlValidationReason
| 'unsupported_scheme'
| 'redirect_blocked'
/**
* Thrown when the guard refuses to open (or to keep) a connection. Callers
* must treat this as terminal for the URL: retrying does not help, and the
* stored URL should be surfaced to the user as invalid rather than fetched.
*/
export class UnsafeUrlError extends Error {
readonly name = 'UnsafeUrlError'
constructor(
readonly reason: SafeFetchRefusalReason,
readonly detail: string,
) {
super(`Refused to fetch URL (${reason}): ${detail}`)
}
}
/** Name-based so it survives duplicate module instances (vitest isolation). */
export function isUnsafeUrlError(error: unknown): error is UnsafeUrlError {
return error instanceof Error && error.name === 'UnsafeUrlError'
}
export interface SafeFetchOptions {
/**
* Origins (`scheme://host[:port]`) that skip the public-address check.
* Reserved for infrastructure the app already talks to (the deployment's
* own Supabase storage). Redirect refusal still applies to these.
*/
trustedOrigins?: readonly string[]
}
export interface SafeFetchDeps {
/** DNS validation seam. Defaults to url-guard's validateWebhookUrl. */
validateUrl?: typeof validateWebhookUrlDefault
/** Transport seam. Defaults to the global fetch (resolved at call time). */
fetchImpl?: typeof fetch
}
type ValidateUrlOptions = NonNullable<Parameters<typeof validateWebhookUrlDefault>[1]>
/**
* `dns.resolve4('10.0.0.1')` is not a lookup, it is an error (or worse, a
* provider-dependent echo). For IP-literal hostnames, feed the literal to the
* validator as if it were the single DNS answer so the address classifier
* runs on it directly and the result is deterministic.
*/
function literalResolvers(hostname: string): ValidateUrlOptions | undefined {
const bare =
hostname.startsWith('[') && hostname.endsWith(']') ? hostname.slice(1, -1) : hostname
const family = isIP(bare)
if (family === 0) return undefined
const literal = (async () => [bare]) as unknown as ValidateUrlOptions['resolve4']
const noRecords = (async () => {
const err = new Error(`No records for ${bare}`) as NodeJS.ErrnoException
err.code = 'ENODATA'
throw err
}) as unknown as ValidateUrlOptions['resolve4']
return family === 4
? { resolve4: literal, resolve6: noRecords }
: { resolve4: noRecords, resolve6: literal }
}
function originOf(value: string): string | null {
try {
return new URL(value).origin
} catch {
return null
}
}
function isTrustedOrigin(parsed: URL, trustedOrigins: readonly string[] | undefined): boolean {
if (!trustedOrigins || trustedOrigins.length === 0) return false
const target = parsed.origin
return trustedOrigins.some((entry) => originOf(entry) === target)
}
function isRedirectResponse(res: Response): boolean {
if (res.type === 'opaqueredirect') return true
return res.status >= 300 && res.status < 400
}
async function discardBody(res: Response): Promise<void> {
try {
await res.body?.cancel()
} catch {
// Best-effort socket cleanup; the response is being refused anyway.
}
}
/**
* Fetch `rawUrl` only if it is safe to connect to, never following redirects.
* Throws `UnsafeUrlError` on refusal; transport errors propagate unchanged so
* callers keep their existing retry semantics for the network-blip case.
*/
export async function safeFetch(
rawUrl: string,
init: RequestInit = {},
options: SafeFetchOptions = {},
deps: SafeFetchDeps = {},
): Promise<Response> {
const validateUrl = deps.validateUrl ?? validateWebhookUrlDefault
const fetchImpl = deps.fetchImpl ?? globalThis.fetch
let parsed: URL
try {
parsed = new URL(rawUrl)
} catch {
throw new UnsafeUrlError('invalid_url', 'URL did not parse.')
}
if (parsed.protocol !== 'https:' && parsed.protocol !== 'http:') {
throw new UnsafeUrlError(
'unsupported_scheme',
`Only http(s) URLs can be fetched (got ${parsed.protocol}).`,
)
}
if (!isTrustedOrigin(parsed, options.trustedOrigins)) {
const validation = await validateUrl(rawUrl, literalResolvers(parsed.hostname))
if (!validation.ok) {
throw new UnsafeUrlError(validation.reason, validation.detail)
}
}
const response = await fetchImpl(rawUrl, { ...init, redirect: 'manual' })
if (isRedirectResponse(response)) {
await discardBody(response)
throw new UnsafeUrlError(
'redirect_blocked',
`${parsed.hostname} answered ${response.status || 'with a redirect'}; redirects are never followed.`,
)
}
return response
}
/**
* Read a response body into a Buffer, refusing anything over `maxBytes`.
*
* Checks the declared Content-Length first (cheap, no bytes read), then
* streams with a running total so a host that lies about (or omits) the
* length is cut off at the cap instead of being buffered whole. Returns null
* when the cap is exceeded; the body is cancelled in that case.
*/
export async function readBodyWithCap(res: Response, maxBytes: number): Promise<Buffer | null> {
const declared = Number(res.headers.get('content-length') ?? '')
if (Number.isFinite(declared) && declared > maxBytes) {
await discardBody(res)
return null
}
const body = res.body
if (!body || typeof body.getReader !== 'function') {
// Bodyless or non-streaming Response (test doubles, some polyfills):
// fall back to a whole read with a post-hoc check.
const buf = Buffer.from(await res.arrayBuffer())
return buf.byteLength > maxBytes ? null : buf
}
const reader = body.getReader()
const chunks: Buffer[] = []
let total = 0
for (;;) {
const { done, value } = await reader.read()
if (done) break
total += value.byteLength
if (total > maxBytes) {
await reader.cancel().catch(() => undefined)
return null
}
chunks.push(Buffer.from(value))
}
return Buffer.concat(chunks)
}