2d49a81508
* fix(bookkeeping): negative item rows book on the opposite side, never as negative amounts A supplier-invoice item with a negative line_total (an öresavrundning row on 3740, a rabatt row) was copied straight into debit_amount, producing a line like "3740 debit -0.25". The entry balances arithmetically, so no trigger fired, but the verifikat page renders only positive amounts: the row showed empty and the visible debits (20 056,25) disagreed with the summa (20 056,00). Prod holds 14 such lines: 12 supplier registrations in 3 companies, 1 customer invoice (3004 credit -0.50), 1 storno mirroring a bad original. Why it occurred: the "one non-negative side per line" invariant lived nowhere. Zod allows negative items (they are legitimate), the engine only checked balance, and journal_entry_lines had no CHECK. Any producer that aggregates user rows could repeat it. What was removed or simplified: no new state. The privately-paid supplier path already flipped negative buckets to credit; that rule is now one helper (lib/bookkeeping/line-side.ts) shared by the supplier registration, cash-method and privately-paid generators and by the customer-invoice per-rate generator. The credit-note generator stops swapping sides and takes |net|, since its inputs now arrive on the correct side. Why this and not the proposed fix: patching only the supplier generator leaves MCP, templates and future producers free to repeat the class, and rejecting negative items at input would break real rabatt/avrundning rows. So the sign is fixed at three levels: producers flip the side, the engine refuses negative amounts before any write (JOURNAL_LINE_NEGATIVE_AMOUNT, Swedish message), and a NOT VALID CHECK on journal_entry_lines rejects new rows regardless of the writer. reverseEntry swaps on the net so a legacy negative line stornos into a well-formed line before the data repair runs. The 14 existing prod lines are repaired by a separate founder-approved SQL (flip to the opposite column, net unchanged); VALIDATE CONSTRAINT follows in a later migration once prod reports zero offending rows. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YMJvTFitzKQYuv7ABUVFj9 * fix(bookkeeping): anchor foreign-currency 1510/1930 on the net of the revenue lines; flip salary buckets by side Skeptic findings on ab119d6ed: 1. A non-SEK customer invoice with a negative row (rabatt, avrundning on a separate revenue account) now lands that row on the debit side, but the 1510 (accrual) and 1930 (kontantmetod) anchors summed only credit_amount, so the entry was overstated by the row and threw "Verifikationen balanserar inte". Both anchors now use credit - debit. EUR test added for both paths. 2. Salary: arbetsgivaravgifter, semesteravsättning, pension and SLP buckets copied bucket.amount into debit_amount and the aggregated liability into credit_amount. A negative month (unpaid leave beyond gross) produced 7510 D -628,40, which the engine now refuses. Buckets and liabilities go through debitNatural/creditNatural so a negative month books 7510 K / 2731 D. Test added. 3. replaceOpeningBalanceEntry, the third engine write path, now runs the same non-negative guard as createDraftEntry and updateDraftEntry. 4. The credit-note comment claimed |net| is side-correct for every original; it is not for originals with a negative row (pre-existing, callers negate items with -Math.abs). Comment now states the actual behaviour and the known gap. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(bookkeeping): map JOURNAL_LINE_NEGATIVE_AMOUNT to a structured 400; supplier anchors flip side when the invoice nets below zero CodeRabbit on #2439: - JournalLineNegativeAmountError was not registered in isBookkeepingError / bookkeepingErrorResponse, so the journal-entry routes would have returned a generic 500 instead of the structured 400 with code and details. Added, with a test. - The three supplier balance anchors (2440 on registration, the payment account under kontantmetoden, the liability account for privately paid invoices) were fixed-credit lines. An invoice whose rows net below zero (a leverantörskreditfaktura keyed in as an invoice) produced a negative credit there, which the engine now refuses. The anchors go through creditNatural so such an invoice books 2440 D, as a supplier credit note would. Tests for all three paths. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
804 lines
36 KiB
TypeScript
804 lines
36 KiB
TypeScript
/**
|
|
* Maps raw errors to user-friendly localized messages.
|
|
*
|
|
* Priority chain:
|
|
* 1. Zod validation field errors
|
|
* 2. Postgres error code map
|
|
* 3. HTTP status code map
|
|
* 4. Context-specific fallback
|
|
* 5. Generic fallback
|
|
*
|
|
* Callers can pass an explicit `locale` ('sv' | 'en'). Default 'sv' so existing
|
|
* server-side callers (cron, background jobs, logs) keep their current Swedish
|
|
* output. UI callers should pass the active locale from useLocale() / getLocale().
|
|
*
|
|
* Specific domain phrases (locked period, unbalanced voucher, etc.) remain
|
|
* Swedish for now: those refer to statutory accounting concepts and English
|
|
* users will still see them on Skatteverket-bound surfaces.
|
|
*/
|
|
|
|
import { formatCurrency } from '@/lib/utils'
|
|
// Pure module (no next/server): safe for the client bundles this file lives in.
|
|
import { formatDimensionValidationIssues } from '@/lib/bookkeeping/dimension-errors'
|
|
import {
|
|
describeMissingInvoicePaymentAccount,
|
|
isInvoicePaymentAccountCurrency,
|
|
} from '@/lib/invoices/payment-accounts'
|
|
import { getErrorEntry, hasErrorEntry } from './structured-errors'
|
|
|
|
type ErrorContext =
|
|
| 'invoice'
|
|
| 'supplier_invoice'
|
|
| 'customer'
|
|
| 'article'
|
|
| 'supplier'
|
|
| 'transaction'
|
|
| 'journal_entry'
|
|
| 'settings'
|
|
| 'auth'
|
|
| 'salary'
|
|
|
|
export type ErrorLocale = 'sv' | 'en'
|
|
|
|
interface GetErrorMessageOptions {
|
|
context?: ErrorContext
|
|
statusCode?: number
|
|
locale?: ErrorLocale
|
|
}
|
|
|
|
type Bilingual = { sv: string; en: string }
|
|
|
|
function pick(b: Bilingual, locale: ErrorLocale): string {
|
|
return b[locale] ?? b.sv
|
|
}
|
|
|
|
// Postgres error codes -> localized messages
|
|
const POSTGRES_ERROR_MAP: Record<string, Bilingual> = {
|
|
'23505': { sv: 'En post med samma uppgifter finns redan.', en: 'A record with the same details already exists.' },
|
|
'23503': { sv: 'Posten kan inte ändras eftersom den refereras av annan data.', en: 'This record cannot be changed because other data refers to it.' },
|
|
'23502': { sv: 'Ett obligatoriskt fält saknas.', en: 'A required field is missing.' },
|
|
'42501': { sv: 'Du har inte behörighet att utföra denna åtgärd.', en: 'You do not have permission to perform this action.' },
|
|
'42P01': { sv: 'Resursen kunde inte hittas.', en: 'The resource could not be found.' },
|
|
'23514': { sv: 'Värdet uppfyller inte de tillåtna kraven.', en: 'The value does not meet the allowed constraints.' },
|
|
'40001': { sv: 'En annan ändring pågick samtidigt. Försök igen.', en: 'A concurrent change was in progress. Please try again.' },
|
|
'40P01': { sv: 'En konflikt uppstod. Försök igen.', en: 'A conflict occurred. Please try again.' },
|
|
'22P02': { sv: 'Ogiltigt värde angavs.', en: 'Invalid value supplied.' },
|
|
'22003': { sv: 'Värdet är utanför tillåtet intervall.', en: 'Value is out of allowed range.' },
|
|
}
|
|
|
|
// HTTP status codes -> localized messages
|
|
const HTTP_STATUS_MAP: Record<number, Bilingual> = {
|
|
400: { sv: 'Förfrågan innehåller ogiltiga uppgifter.', en: 'The request contains invalid data.' },
|
|
401: { sv: 'Din session har gått ut. Logga in igen.', en: 'Your session has expired. Please sign in again.' },
|
|
403: { sv: 'Du har inte behörighet att utföra denna åtgärd.', en: 'You do not have permission to perform this action.' },
|
|
404: { sv: 'Resursen kunde inte hittas.', en: 'The resource could not be found.' },
|
|
409: { sv: 'En konflikt uppstod. Ladda om sidan och försök igen.', en: 'A conflict occurred. Reload the page and try again.' },
|
|
// 413 is answered by the hosting platform, before any route runs, with a
|
|
// plain-text body: the status is the only thing a caller has to go on.
|
|
413: { sv: 'Filen är för stor för att skickas. Försök igen med en mindre fil.', en: 'The file is too large to send. Try again with a smaller file.' },
|
|
415: { sv: 'Filtypen stöds inte.', en: 'That file type is not supported.' },
|
|
422: { sv: 'Uppgifterna kunde inte bearbetas. Kontrollera fälten och försök igen.', en: 'The data could not be processed. Check the fields and try again.' },
|
|
429: { sv: 'För många förfrågningar. Vänta en stund och försök igen.', en: 'Too many requests. Wait a moment and try again.' },
|
|
500: { sv: 'Ett oväntat serverfel uppstod. Försök igen senare.', en: 'An unexpected server error occurred. Please try again later.' },
|
|
502: { sv: 'Servern är tillfälligt otillgänglig. Försök igen om en stund.', en: 'The server is temporarily unavailable. Please try again shortly.' },
|
|
503: { sv: 'Tjänsten är tillfälligt otillgänglig. Försök igen om en stund.', en: 'The service is temporarily unavailable. Please try again shortly.' },
|
|
}
|
|
|
|
// Context-specific fallbacks
|
|
const CONTEXT_FALLBACKS: Record<ErrorContext, Bilingual> = {
|
|
invoice: { sv: 'Kunde inte hantera fakturan. Försök igen.', en: 'Could not process the invoice. Please try again.' },
|
|
supplier_invoice: { sv: 'Kunde inte hantera leverantörsfakturan. Försök igen.', en: 'Could not process the supplier invoice. Please try again.' },
|
|
customer: { sv: 'Kunde inte hantera kunden. Försök igen.', en: 'Could not process the customer. Please try again.' },
|
|
article: { sv: 'Kunde inte hantera artikeln. Försök igen.', en: 'Could not process the article. Please try again.' },
|
|
supplier: { sv: 'Kunde inte hantera leverantören. Försök igen.', en: 'Could not process the supplier. Please try again.' },
|
|
transaction: { sv: 'Kunde inte hantera transaktionen. Försök igen.', en: 'Could not process the transaction. Please try again.' },
|
|
journal_entry: { sv: 'Kunde inte hantera verifikationen. Försök igen.', en: 'Could not process the journal entry. Please try again.' },
|
|
settings: { sv: 'Kunde inte spara inställningarna. Försök igen.', en: 'Could not save settings. Please try again.' },
|
|
auth: { sv: 'Ett fel uppstod vid inloggningen. Försök igen.', en: 'An error occurred while signing in. Please try again.' },
|
|
salary: { sv: 'Kunde inte hantera löneuppgifterna. Försök igen.', en: 'Could not process the payroll data. Please try again.' },
|
|
}
|
|
|
|
const GENERIC_FALLBACK: Bilingual = { sv: 'Något gick fel. Försök igen.', en: 'Something went wrong. Please try again.' }
|
|
|
|
// Known error patterns → user-friendly Swedish messages
|
|
const ERROR_PATTERN_MAP: [RegExp, string | null][] = [
|
|
[
|
|
/reason must be 500 characters or fewer/i,
|
|
'Motiveringen får vara högst 500 tecken.',
|
|
],
|
|
[
|
|
/locked\/closed fiscal period/i,
|
|
'Perioden är låst. Verifikationen kan inte skapas i en stängd eller låst period.',
|
|
],
|
|
[
|
|
/Bokföringen är låst t\.o\.m\./,
|
|
null, // null = extract the Swedish message directly from the raw error text
|
|
],
|
|
[
|
|
/Cannot attach documents to entries in a locked/i,
|
|
'Kan inte bifoga dokument till verifikationer i en låst period.',
|
|
],
|
|
[
|
|
/Entry date .+ is outside fiscal period/i,
|
|
'Datumet ligger utanför det valda räkenskapsåret.',
|
|
],
|
|
[
|
|
/Only company owners and admins can delete vouchers/i,
|
|
'Endast ägare och administratörer kan radera verifikationer.',
|
|
],
|
|
[
|
|
/Journal entry not found/i,
|
|
'Verifikationen kunde inte hittas.',
|
|
],
|
|
[
|
|
/Only posted entries can be deleted/i,
|
|
'Endast bokförda verifikationer kan raderas.',
|
|
],
|
|
[
|
|
/Cannot delete voucher in a closed fiscal period/i,
|
|
'Verifikationen kan inte raderas: räkenskapsåret är stängt.',
|
|
],
|
|
[
|
|
/Cannot delete voucher in a locked fiscal period/i,
|
|
'Verifikationen kan inte raderas: perioden är låst.',
|
|
],
|
|
[
|
|
/Cannot delete: other entries reference this voucher/i,
|
|
'Verifikationen kan inte raderas eftersom andra verifikationer (t.ex. storno eller rättelse) refererar till den.',
|
|
],
|
|
[
|
|
/timed out after \d+m?s/i,
|
|
'Anslutningen mot tjänsten tog för lång tid. Försök igen.',
|
|
],
|
|
[
|
|
/already has a journal entry/i,
|
|
'Transaktionen är redan bokförd. Ångra kategoriseringen om du vill ändra den.',
|
|
],
|
|
[
|
|
// GoTrue rejects supabase.auth.signUp with this when the installation
|
|
// runs with disable_signup (closed self-hosted instances). The invitee
|
|
// cannot fix it themselves: point them to whoever runs the installation.
|
|
/signups? not allowed/i,
|
|
'Kontoregistrering är avstängd på den här installationen. Kontakta den som bjöd in dig eller din administratör för att få ett konto.',
|
|
],
|
|
[
|
|
// GoTrue could not send its own mail (admin invite, confirmation,
|
|
// recovery): almost always missing SMTP configuration on self-hosted.
|
|
/error sending (invite|confirmation|recovery|magic link|email change) email/i,
|
|
'E-postmeddelandet kunde inte skickas av autentiseringstjänsten. Kontrollera installationens SMTP-inställningar och försök igen.',
|
|
],
|
|
]
|
|
|
|
/**
|
|
* Check if a message matches a known error pattern and return the Swedish translation.
|
|
* Returns null if no pattern matches.
|
|
*/
|
|
function tryMatchKnownError(message: string): string | null {
|
|
for (const [pattern, translation] of ERROR_PATTERN_MAP) {
|
|
if (pattern.test(message)) {
|
|
if (translation !== null) return translation
|
|
// Extract the Swedish part from the message
|
|
const match = message.match(/Bokföringen är låst t\.o\.m\. [^.]+\./)
|
|
return match ? match[0] : 'Bokföringen är låst för denna period.'
|
|
}
|
|
}
|
|
return null
|
|
}
|
|
|
|
/**
|
|
* Swedish tokens that mark a sentence as Swedish. STRONG ones are
|
|
* unambiguous (never English, rare in technical output) and count 2 on their
|
|
* own; WEAK ones are common function words that also exist in English or are
|
|
* too short to be decisive ("till", "den", "det") and count 1 each. Words
|
|
* that are plainly English as well ("under", "men", "om", "en", "vi") are
|
|
* left out on purpose, so an English framework message cannot score on them.
|
|
*/
|
|
const SWEDISH_STRONG_WORDS = [
|
|
'och', 'att', 'inte', 'är', 'ska', 'finns', 'ingen', 'inget', 'inga', 'redan',
|
|
'bara', 'hos', 'från', 'eller', 'utan', 'också', 'endast', 'ännu', 'igen',
|
|
'kunde', 'gick', 'går', 'måste', 'får', 'saknas', 'lyckades', 'misslyckades',
|
|
'bifogad', 'svarade',
|
|
]
|
|
const SWEDISH_WEAK_WORDS = [
|
|
'för', 'med', 'till', 'det', 'den', 'ett', 'av', 'på', 'som', 'har', 'kan',
|
|
'när', 'över', 'mot', 'vid', 'efter', 'innan', 'alla', 'sedan', 'här', 'där',
|
|
'din', 'ditt', 'dina', 'denna', 'detta', 'dessa', 'minst', 'högst',
|
|
]
|
|
// The strong list is probed with .test(), so it must NOT be global: a global
|
|
// regex keeps lastIndex between calls and silently fails the next message.
|
|
// The weak list is iterated with matchAll(), which requires the g flag and
|
|
// clones the regex per call.
|
|
const wordListRe = (words: string[], flags: string) =>
|
|
new RegExp(`(^|[^\\p{L}])(${words.join('|')})(?=$|[^\\p{L}])`, flags)
|
|
const SWEDISH_STRONG_RE = wordListRe(SWEDISH_STRONG_WORDS, 'iu')
|
|
const SWEDISH_WEAK_RE = wordListRe(SWEDISH_WEAK_WORDS, 'giu')
|
|
|
|
/**
|
|
* Signs that a string is a technical leak rather than a sentence written for
|
|
* the user: stack frames, file:line references, JS/Node error vocabulary,
|
|
* Postgres/PostgREST/SQL fragments, JSON, URLs. A message carrying any of
|
|
* these is never shown raw, whatever language it is in.
|
|
*/
|
|
const TECHNICAL_LEAK_PATTERNS: RegExp[] = [
|
|
/\bat \S+ \(/, // stack frame: "at fn (file:1:2)"
|
|
/\.(?:ts|tsx|js|mjs|cjs):\d+/, // file:line
|
|
/\b(?:TypeError|ReferenceError|SyntaxError|RangeError|EvalError)\b/,
|
|
/cannot read propert/i,
|
|
/is not a function\b/i,
|
|
/is not defined\b/i,
|
|
/\bundefined\b/,
|
|
/\bNaN\b/,
|
|
/\bPGRST\d+/,
|
|
/\bSQLSTATE\b/,
|
|
/violates .*constraint/i,
|
|
/duplicate key value/i,
|
|
/relation "/i,
|
|
/column "/i,
|
|
/syntax error at/i,
|
|
/\bE(?:CONN\w+|TIMEDOUT|NOTFOUND|PIPE|HOSTUNREACH)\b/,
|
|
/fetch failed/i,
|
|
/unexpected token/i,
|
|
/\{\s*"/, // JSON object start
|
|
/https?:\/\//,
|
|
]
|
|
|
|
/**
|
|
* Whether a free-text string reads as a Swedish sentence written for the user
|
|
* (issue #2086): it carries å/ä/ö or Swedish words, and shows no sign of
|
|
* being a technical leak (see TECHNICAL_LEAK_PATTERNS). Scoring: å/ä/ö or
|
|
* any STRONG word counts 2, each distinct WEAK word 1, pass at 2. So "Inget
|
|
* skattekonto är registrerat hos Skatteverket." and "Kopplingen misslyckades."
|
|
* pass; "Failed to fetch customer", "Redirect till /login" and
|
|
* "TypeError: x is not a function" do not.
|
|
*/
|
|
export function looksLikeUserFacingSwedish(message: string): boolean {
|
|
const text = message.trim()
|
|
if (!text) return false
|
|
if (TECHNICAL_LEAK_PATTERNS.some((p) => p.test(text))) return false
|
|
if (/[åäöÅÄÖ]/.test(text)) return true
|
|
if (SWEDISH_STRONG_RE.test(text)) return true
|
|
const weak = new Set<string>()
|
|
for (const m of text.matchAll(SWEDISH_WEAK_RE)) weak.add(m[2].toLowerCase())
|
|
return weak.size >= 2
|
|
}
|
|
|
|
/**
|
|
* Whether a route's free-text `error` / `message` string is a user-facing
|
|
* Swedish message that should be shown as-is.
|
|
*
|
|
* Two ways in. The keyword list below is the original test; it stays because
|
|
* callers rely on the odd tokens it lets through (e.g. "session"). It was also
|
|
* the ONLY test until issue #2086: a correct sentence without one of the ~30
|
|
* keywords ("Inget skattekonto är registrerat hos Skatteverket.") was dropped
|
|
* and replaced with the generic HTTP-500 text, whose "försök igen senare"
|
|
* advice was wrong for the case. 155 of the 631 message_sv strings in
|
|
* structured-errors.ts failed the keyword test. looksLikeUserFacingSwedish is
|
|
* the second way in, and a registry-wide test pins that every message_sv
|
|
* passes one of the two.
|
|
*/
|
|
export function isSwedishUserMessage(message: string): boolean {
|
|
const swedishPatterns = [
|
|
/kunde inte/i,
|
|
/kan inte/i,
|
|
/hittades/i,
|
|
/redan/i,
|
|
/låst/i,
|
|
/försök igen/i,
|
|
/ogiltigt?/i,
|
|
/saknas/i,
|
|
/saknar/i,
|
|
/krävs/i,
|
|
/måste/i,
|
|
/redan finns/i,
|
|
/gick fel/i,
|
|
/valideringsfel/i,
|
|
/korrigera/i,
|
|
/bankuppgifter/i,
|
|
/behörighet/i,
|
|
/session/i,
|
|
/förfrågan/i,
|
|
/obligatorisk/i,
|
|
/är låst/i,
|
|
/fält/i,
|
|
/värde/i,
|
|
/felaktig/i,
|
|
/för (lång|kort|stor|liten|många|få)/i,
|
|
/bankgiro/i,
|
|
/personnummer/i,
|
|
/kontonummer/i,
|
|
/clearingnummer/i,
|
|
/nummer är/i,
|
|
/tillgängligt/i,
|
|
/verifikation/i,
|
|
/importera|importen/i,
|
|
]
|
|
return swedishPatterns.some((p) => p.test(message)) || looksLikeUserFacingSwedish(message)
|
|
}
|
|
|
|
/**
|
|
* Extract a user-friendly message from a Zod validation error shape.
|
|
* Returns null if the error is not a Zod error.
|
|
*/
|
|
function tryParseZodErrors(error: unknown): string | null {
|
|
if (typeof error !== 'object' || error === null) return null
|
|
|
|
const obj = error as Record<string, unknown>
|
|
|
|
// Check for Zod-style field errors: { fieldName: ["message"] } or { issues: [...] }
|
|
if (Array.isArray(obj.issues)) {
|
|
const issues = obj.issues as Array<{ message?: string; path?: string[] }>
|
|
const messages = issues
|
|
.slice(0, 3)
|
|
.map((issue) => {
|
|
const field = issue.path?.join('.') || ''
|
|
const msg = issue.message || 'ogiltigt värde'
|
|
return field ? `${field}: ${msg}` : msg
|
|
})
|
|
if (messages.length > 0) return messages.join('. ')
|
|
}
|
|
|
|
// Check for { errors: [{ field, message, code }] } shape from validateBody
|
|
if (Array.isArray(obj.errors)) {
|
|
const items = obj.errors as Array<{ field?: string; message?: string }>
|
|
const messages = items
|
|
.slice(0, 3)
|
|
.map((it) => {
|
|
const field = it.field || ''
|
|
const msg = it.message || 'ogiltigt värde'
|
|
return field ? `${field}: ${msg}` : msg
|
|
})
|
|
.filter(Boolean)
|
|
if (messages.length > 0) return messages.join('. ')
|
|
}
|
|
|
|
// Check for { errors: { field: ["msg"] } } shape (legacy)
|
|
if (typeof obj.errors === 'object' && obj.errors !== null) {
|
|
const fieldErrors = obj.errors as Record<string, string[]>
|
|
const messages: string[] = []
|
|
for (const [field, msgs] of Object.entries(fieldErrors)) {
|
|
if (Array.isArray(msgs) && msgs.length > 0) {
|
|
messages.push(`${field}: ${msgs[0]}`)
|
|
}
|
|
if (messages.length >= 3) break
|
|
}
|
|
if (messages.length > 0) return messages.join('. ')
|
|
}
|
|
|
|
return null
|
|
}
|
|
|
|
/**
|
|
* Get a user-friendly Swedish error message from a raw error.
|
|
*
|
|
* @param error - The raw error. Can be an API response body (object), Error instance, string, or unknown.
|
|
* @param options - Optional context and HTTP status code.
|
|
*/
|
|
export function getErrorMessage(
|
|
error: unknown,
|
|
options: GetErrorMessageOptions = {}
|
|
): string {
|
|
const { context, statusCode, locale = 'sv' } = options
|
|
|
|
// 1. If it's a string, check if it's already Swedish or matches a known pattern
|
|
if (typeof error === 'string' && error.trim()) {
|
|
if (isSwedishUserMessage(error)) return error
|
|
const knownError = tryMatchKnownError(error)
|
|
if (knownError) return knownError
|
|
}
|
|
|
|
// 2. If it's an object, try various parsing strategies
|
|
if (typeof error === 'object' && error !== null) {
|
|
const obj = error as Record<string, unknown>
|
|
|
|
// Bare envelope inner-error shape: { code, message, message_en?, ... }.
|
|
// Happens when a caller forwards `result.error` (the inner object) instead
|
|
// of the whole `result`. Pick the English variant when the UI locale is
|
|
// English; otherwise fall back to the Swedish `message`.
|
|
if (typeof obj.code === 'string' && typeof obj.message === 'string' && obj.message.trim()) {
|
|
// Typed domain exceptions (lib/bookkeeping/errors.ts classes) also match
|
|
// this shape, but their `message` is raw English (often a DB constraint
|
|
// string) and must never reach the user verbatim. Normalize the instance
|
|
// into the structured envelope so the per-code branches below own the
|
|
// translation. Class fields are enumerable own props, so { ...obj }
|
|
// carries exactly the details those branches expect (totalDebit,
|
|
// lockDate, reason, issues, ...), while the non-enumerable Error.message
|
|
// stays out of details. Plain objects (forwarded inner envelopes,
|
|
// PostgrestError-shaped literals) keep the passthrough behavior.
|
|
if (error instanceof Error) {
|
|
// Only recurse when the registry knows the code: the structured
|
|
// branches then own the translation. An unknown code (a Node system
|
|
// error like ECONNREFUSED, a Postgres SQLSTATE on a wrapped Error, a
|
|
// stray third-party code) would fall out of the structured path with
|
|
// its raw English message, so instead fall through to the plain
|
|
// handling below: Postgres map, known patterns, Swedish check, and
|
|
// finally the status/context/generic fallbacks.
|
|
if (hasErrorEntry(obj.code)) {
|
|
return getErrorMessage(
|
|
{
|
|
error: {
|
|
code: obj.code,
|
|
message: obj.message,
|
|
account_numbers: (obj as { accountNumbers?: unknown }).accountNumbers,
|
|
details: { ...obj },
|
|
},
|
|
},
|
|
options
|
|
)
|
|
}
|
|
} else {
|
|
if (locale === 'en' && typeof obj.message_en === 'string' && obj.message_en.trim()) {
|
|
return obj.message_en
|
|
}
|
|
return obj.message
|
|
}
|
|
}
|
|
|
|
// Structured application error: { error: { code, message, message_en?, ... } }
|
|
if (typeof obj.error === 'object' && obj.error !== null) {
|
|
const structured = obj.error as {
|
|
code?: unknown
|
|
message?: unknown
|
|
message_en?: unknown
|
|
account_numbers?: unknown
|
|
details?: unknown
|
|
}
|
|
|
|
// Say what is missing for THIS invoice's currency: on a SEK invoice the
|
|
// registry's currency-neutral text read as a foreign-currency account
|
|
// when the gap was the company's bankgiro (#2126). Before the English
|
|
// registry shortcut on purpose: both locales get the specific text.
|
|
if (structured.code === 'INVOICE_SEND_PAYMENT_ACCOUNT_MISSING') {
|
|
// Own local name on purpose: the sek-labelled-amount guard keys
|
|
// currency reads by owner path, and `details` is also the owner of
|
|
// the SEK-only journal totals formatted further down.
|
|
const paymentDetails = structured.details as { currency?: unknown } | undefined
|
|
if (isInvoicePaymentAccountCurrency(paymentDetails?.currency)) {
|
|
return pick(describeMissingInvoicePaymentAccount(paymentDetails.currency), locale)
|
|
}
|
|
}
|
|
|
|
// For English UI, return the registry's English message for any known
|
|
// code instead of falling through to the Swedish branches below (which
|
|
// ignored locale: English users were shown Swedish prose). The Swedish
|
|
// path is left entirely unchanged; codes absent from the registry still
|
|
// fall through. The dynamic branches (amounts / lock date / reason) keep
|
|
// owning Swedish display.
|
|
if (locale === 'en' && typeof structured.code === 'string') {
|
|
const entry = getErrorEntry(structured.code)
|
|
if (entry?.message_en) return entry.message_en
|
|
}
|
|
|
|
if (structured.code === 'ACCOUNTS_NOT_IN_CHART' && Array.isArray(structured.account_numbers)) {
|
|
const numbers = structured.account_numbers as string[]
|
|
return `Följande konton behöver aktiveras: ${numbers.join(', ')}`
|
|
}
|
|
|
|
if (structured.code === 'JOURNAL_ENTRY_NOT_BALANCED') {
|
|
const details = structured.details as { totalDebit?: number; totalCredit?: number } | undefined
|
|
if (details && typeof details.totalDebit === 'number' && typeof details.totalCredit === 'number') {
|
|
return `Verifikationen balanserar inte (${formatCurrency(details.totalDebit)} debet vs ${formatCurrency(details.totalCredit)} kredit).`
|
|
}
|
|
return 'Verifikationen balanserar inte. Kontrollera att debet och kredit är lika stora.'
|
|
}
|
|
|
|
if (structured.code === 'JOURNAL_LINE_NEGATIVE_AMOUNT') {
|
|
return 'En verifikationsrad har ett negativt belopp. Boka beloppet på motsatt sida i stället.'
|
|
}
|
|
|
|
if (structured.code === 'FISCAL_PERIOD_NOT_FOUND') {
|
|
return 'Räkenskapsperioden kunde inte hittas.'
|
|
}
|
|
|
|
if (structured.code === 'ENTRY_DATE_OUTSIDE_FISCAL_PERIOD') {
|
|
return 'Datumet ligger utanför det valda räkenskapsåret.'
|
|
}
|
|
|
|
if (structured.code === 'JOURNAL_ENTRY_NOT_FOUND') {
|
|
return 'Verifikationen kunde inte hittas.'
|
|
}
|
|
|
|
if (structured.code === 'CANNOT_REVERSE_NON_POSTED') {
|
|
return 'Endast bokförda verifikationer kan stornas.'
|
|
}
|
|
|
|
if (structured.code === 'CANNOT_CORRECT_NON_POSTED') {
|
|
return 'Endast bokförda verifikationer kan rättas.'
|
|
}
|
|
|
|
if (structured.code === 'ENTRY_ALREADY_REVERSED') {
|
|
return 'Verifikationen har redan stornats av en annan användare. Ladda om sidan och försök igen.'
|
|
}
|
|
|
|
if (structured.code === 'CURRENCY_REVALUATION_ALREADY_EXISTS') {
|
|
return 'En valutaomvärdering finns redan för denna period.'
|
|
}
|
|
|
|
if (structured.code === 'FX_CLOSING_RATE_UNAVAILABLE') {
|
|
// Name the currency and the date: the user needs to know exactly which
|
|
// rate is missing to judge whether to wait or pick another closing
|
|
// date. Nothing was posted, so this is never a partial-state message.
|
|
const details = structured.details as { missingRates?: unknown } | undefined
|
|
const missing = Array.isArray(details?.missingRates)
|
|
? (details.missingRates as { currency?: unknown; date?: unknown }[])
|
|
.filter((m) => typeof m?.currency === 'string' && typeof m?.date === 'string')
|
|
.map((m) => `${m.currency as string} per ${m.date as string}`)
|
|
: []
|
|
const what = missing.length > 0 ? missing.join(', ') : 'balansdagen'
|
|
return `Ingen valutakurs från Riksbanken finns för ${what}. Valutaomvärderingen har inte bokförts: en uppskattad kurs får inte bokföras mot 3960/7960. Försök igen när kursen är publicerad.`
|
|
}
|
|
|
|
if (structured.code === 'INVALID_MAPPING_RESULT') {
|
|
return 'Kontering saknas för transaktionen. Kontrollera bokföringsreglerna.'
|
|
}
|
|
|
|
if (structured.code === 'DIMENSION_VALIDATION_FAILED') {
|
|
// Prefer reconstructing the per-code Swedish sentences from the
|
|
// machine-readable issue list (present on both the dashboard and the
|
|
// v1/registry error envelopes); fall back to the message, which the
|
|
// engine already emits in Swedish naming the offending codes.
|
|
const details = structured.details as { issues?: unknown } | undefined
|
|
const formatted = formatDimensionValidationIssues(details?.issues)
|
|
if (formatted) return formatted
|
|
if (typeof structured.message === 'string' && structured.message.trim()) {
|
|
return structured.message
|
|
}
|
|
return 'Ett angivet kostnadsställe/projekt finns inte i dimensionsregistret eller är arkiverat. Skapa värdet i registret först.'
|
|
}
|
|
|
|
if (structured.code === 'NO_OPEN_PERIOD_FOR_DATE') {
|
|
return 'Det finns ingen räkenskapsperiod som täcker det valda datumet. Skapa eller öppna räkenskapsåret först.'
|
|
}
|
|
|
|
if (structured.code === 'TARGET_PERIOD_CLOSED') {
|
|
return 'Räkenskapsåret för det valda datumet är stängt (bokslut) och kan inte återöppnas. Bokför rättelsen i innevarande period istället.'
|
|
}
|
|
|
|
if (structured.code === 'TARGET_PERIOD_LOCKED') {
|
|
const details = structured.details as { lockDate?: string } | undefined
|
|
return details?.lockDate
|
|
? `Räkenskapsperioden för det valda datumet är låst (t.o.m. ${details.lockDate}). Lås upp perioden för att flytta verifikationen dit.`
|
|
: 'Räkenskapsperioden för det valda datumet är låst. Lås upp perioden för att flytta verifikationen dit.'
|
|
}
|
|
|
|
if (structured.code === 'OB_COMPANY_LOCK_DATE') {
|
|
const details = structured.details as { lockDate?: string } | undefined
|
|
return details?.lockDate
|
|
? `Bokföringen är låst t.o.m. ${details.lockDate} och ingående balanser kan inte korrigeras. Ta bort eller flytta låsdatumet under Inställningar → Bokföring och försök igen.`
|
|
: 'Bokföringen är låst av företagets låsdatum och ingående balanser kan inte korrigeras. Ta bort eller flytta låsdatumet under Inställningar → Bokföring och försök igen.'
|
|
}
|
|
|
|
if (structured.code === 'MEANINGLESS_CORRECTION') {
|
|
const details = structured.details as { reason?: string } | undefined
|
|
if (details?.reason === 'no_date_change') {
|
|
return 'Det nya datumet är samma som det nuvarande: det finns inget att flytta.'
|
|
}
|
|
if (details?.reason === 'identical_to_original') {
|
|
return 'Rättelsen är identisk med originalverifikationen: inget har ändrats.'
|
|
}
|
|
return 'Rättelsen saknar ekonomisk innebörd: varje konto netto till noll. En rättelse måste beskriva en faktisk affärshändelse (BFL 5 kap. 5 §).'
|
|
}
|
|
|
|
if (structured.code === 'CORRECTION_CHAIN_TOO_DEEP') {
|
|
const details = structured.details as
|
|
| { depth?: number; chainRootVoucher?: string | null }
|
|
| undefined
|
|
const depthPart =
|
|
typeof details?.depth === 'number'
|
|
? `Kedjan är redan ${details.depth} nivåer djup`
|
|
: 'Rättelsekedjan är redan flera nivåer djup'
|
|
const rootPart = details?.chainRootVoucher
|
|
? ` (ursprungsverifikat ${details.chainRootVoucher})`
|
|
: ''
|
|
return `${depthPart}${rootPart}. Räkna ut nettoeffekten av hela kedjan och gör EN rättelse istället, eller skicka allow_deep_chain=true för att rätta ändå.`
|
|
}
|
|
|
|
if (structured.code === 'BOOKKEEPING_DATABASE_ERROR') {
|
|
// A DB-layer error may carry a user-relevant cause (e.g. period lock
|
|
// trigger). Try the known-pattern map before falling back to the
|
|
// generic "kunde inte sparas" message.
|
|
if (typeof structured.message === 'string') {
|
|
const matched = tryMatchKnownError(structured.message)
|
|
if (matched) return matched
|
|
}
|
|
return 'Verifikationen kunde inte sparas. Försök igen.'
|
|
}
|
|
|
|
if (locale === 'en' && typeof structured.message_en === 'string' && structured.message_en.trim()) {
|
|
return structured.message_en
|
|
}
|
|
if (typeof structured.message === 'string' && structured.message.trim()) {
|
|
// Known codes without a dynamic branch above (e.g. CANNOT_REVERSE_STORNO)
|
|
// carry raw English engine messages: prefer the registry's Swedish
|
|
// message so no typed code surfaces English in a Swedish UI.
|
|
// A code flagged thrown_message_sv composes its Swedish text at the
|
|
// throw site (a date, an amount): that text wins over the static entry.
|
|
if (locale === 'sv' && typeof structured.code === 'string' && !isSwedishUserMessage(structured.message)) {
|
|
const entry = getErrorEntry(structured.code)
|
|
if (entry?.message_sv && !entry.thrown_message_sv) return entry.message_sv
|
|
}
|
|
return structured.message
|
|
}
|
|
}
|
|
|
|
// Accumulated per-item validation list from routes that collect several
|
|
// problems before responding, e.g. the salary approve route:
|
|
// { error: 'Valideringsfel …', details: ['Tomas Tysén: Bankuppgifter saknas …', …] }
|
|
// Surface the specific reasons: otherwise this shape falls all the way
|
|
// through to the generic HTTP-400 message and the user learns nothing.
|
|
if (
|
|
Array.isArray(obj.details) &&
|
|
obj.details.length > 0 &&
|
|
obj.details.every((d) => typeof d === 'string' && d.trim() !== '')
|
|
) {
|
|
const items = (obj.details as string[]).map((d) => d.trim())
|
|
const shown = items.slice(0, 5).join(' • ')
|
|
const more = items.length > 5 ? ` (+${items.length - 5} till)` : ''
|
|
const lead = typeof obj.error === 'string' && obj.error.trim() ? `${obj.error.trim()}: ` : ''
|
|
return `${lead}${shown}${more}`
|
|
}
|
|
|
|
// Try Zod validation errors
|
|
const zodMessage = tryParseZodErrors(obj)
|
|
if (zodMessage) return zodMessage
|
|
|
|
// Try Postgres error code
|
|
if (typeof obj.code === 'string' && POSTGRES_ERROR_MAP[obj.code]) {
|
|
return pick(POSTGRES_ERROR_MAP[obj.code], locale)
|
|
}
|
|
|
|
// Try known error patterns (e.g. locked period triggers)
|
|
for (const field of ['error', 'message'] as const) {
|
|
if (typeof obj[field] === 'string' && obj[field].trim()) {
|
|
const knownError = tryMatchKnownError(obj[field])
|
|
if (knownError) return knownError
|
|
}
|
|
}
|
|
|
|
// Try error.message if it's already a good Swedish message
|
|
if (typeof obj.error === 'string' && obj.error.trim()) {
|
|
if (isSwedishUserMessage(obj.error)) return obj.error
|
|
}
|
|
|
|
if (typeof obj.message === 'string' && obj.message.trim()) {
|
|
if (isSwedishUserMessage(obj.message)) return obj.message
|
|
}
|
|
}
|
|
|
|
// 3. Error instance
|
|
if (error instanceof Error && error.message.trim()) {
|
|
const knownError = tryMatchKnownError(error.message)
|
|
if (knownError) return knownError
|
|
if (isSwedishUserMessage(error.message)) return error.message
|
|
}
|
|
|
|
// 4. HTTP status code map
|
|
if (statusCode && HTTP_STATUS_MAP[statusCode]) {
|
|
return pick(HTTP_STATUS_MAP[statusCode], locale)
|
|
}
|
|
|
|
// 5. Context-specific fallback
|
|
if (context && CONTEXT_FALLBACKS[context]) {
|
|
return pick(CONTEXT_FALLBACKS[context], locale)
|
|
}
|
|
|
|
// 6. Generic fallback
|
|
return pick(GENERIC_FALLBACK, locale)
|
|
}
|
|
|
|
// PSD2 bank-connection OAuth callback errors. The Enable Banking callback
|
|
// route redirects the browser back to /settings/banking with a user-facing
|
|
// message. The raw provider code/description used to be passed through
|
|
// verbatim ("server_error", "invalid_state"), which left a stuck user with
|
|
// nothing to act on and support with nothing to answer (issue #1716: the
|
|
// Handelsbanken corporate fullmakt failures). Known codes get a Swedish
|
|
// explanation; the raw provider description is appended in parentheses so
|
|
// the underlying error still reaches the user (and a screenshot to support).
|
|
const BANK_CONNECTION_ERROR_MAP: Record<string, string> = {
|
|
server_error:
|
|
'Banken kunde inte slutföra godkännandet på grund av ett fel på bankens sida. Försök igen om en stund. Gäller det företagskonton kan banken kräva en fullmakt innan kopplingen godkänns.',
|
|
temporarily_unavailable:
|
|
'Bankens anslutningstjänst är tillfälligt otillgänglig. Försök igen om en stund.',
|
|
invalid_request:
|
|
'Banken avvisade anslutningsförfrågan som ogiltig. Försök igen, och kontakta supporten om felet kvarstår.',
|
|
// Internal callback tokens (not from the bank) that were previously shown raw.
|
|
invalid_state:
|
|
'Anslutningsförsöket kunde inte matchas mot ett pågående försök. Det kan hända om försöket tog för lång tid eller om ett nytt försök startades under tiden. Starta bankkopplingen på nytt.',
|
|
missing_parameters:
|
|
'Banken skickade ett ofullständigt svar tillbaka. Starta bankkopplingen på nytt.',
|
|
invalid_code_format:
|
|
'Banken skickade ett ogiltigt svar tillbaka. Starta bankkopplingen på nytt.',
|
|
}
|
|
|
|
const BANK_CONNECTION_CANCELLED_MESSAGE =
|
|
'Anslutningen avbröts hos banken innan den slutfördes. Ingen bankkoppling skapades. Försök igen och slutför alla steg hos banken.'
|
|
|
|
const BANK_CONNECTION_SESSION_EXPIRED_MESSAGE =
|
|
'Bankens inloggningssession hann gå ut innan anslutningen slutfördes. Starta bankkopplingen på nytt och slutför alla steg hos banken direkt.'
|
|
|
|
const BANK_CONNECTION_FALLBACK_MESSAGE =
|
|
'Banken avvisade anslutningen. Försök igen, och kontakta supporten om felet kvarstår.'
|
|
|
|
// Same shape the callback route keys its expired-vs-error decision on.
|
|
const BANK_SESSION_EXPIRY_PATTERN =
|
|
/session.?expired|expired.?session|closed.?session|session.?closed|invalid.?session|session.?not.?found/i
|
|
|
|
/**
|
|
* Map a PSD2 authorization callback outcome (OAuth error code plus optional
|
|
* provider description) to a Swedish user message. Always Swedish: the bank
|
|
* redirect carries no locale, and bank-connection surfaces follow the
|
|
* user-facing-errors-are-Swedish rule.
|
|
*/
|
|
export function getBankConnectionErrorMessage(
|
|
errorCode: string,
|
|
errorDescription?: string | null
|
|
): string {
|
|
const code = errorCode.trim()
|
|
const description = errorDescription?.trim() || null
|
|
const combined = `${code} ${description ?? ''}`
|
|
|
|
// User cancelled at the bank: an expected outcome, keep it clean without
|
|
// echoing the provider text back.
|
|
if (code === 'access_denied' || /cancel/i.test(combined)) {
|
|
return BANK_CONNECTION_CANCELLED_MESSAGE
|
|
}
|
|
|
|
let base: string
|
|
if (BANK_SESSION_EXPIRY_PATTERN.test(combined)) {
|
|
base = BANK_CONNECTION_SESSION_EXPIRED_MESSAGE
|
|
} else {
|
|
base = BANK_CONNECTION_ERROR_MAP[code] ?? BANK_CONNECTION_FALLBACK_MESSAGE
|
|
}
|
|
|
|
// Surface the underlying provider error: without it the user (and support,
|
|
// via a screenshot) cannot tell one failure from another.
|
|
return description && description !== code ? `${base} (${description})` : base
|
|
}
|
|
|
|
const PROVIDER_REASON_PREFIX: Bilingual = {
|
|
sv: 'Leverantörens svar',
|
|
en: 'Provider response',
|
|
}
|
|
|
|
/**
|
|
* The provider refused ONE register while the grant itself keeps working: a
|
|
* Fortnox account without rights to leverantörsregistret, a Bokio token with a
|
|
* narrower scope. Never say "återanslut" here, the reconnect re-mints the same
|
|
* grant and hits the same 403.
|
|
*
|
|
* The base copy is the registry's PROVIDER_RESOURCE_FORBIDDEN entry, not a
|
|
* second copy of it: the same sentence has to reach the toast, the API
|
|
* envelope and the public error catalogue (lib/docs/content/errors.ts renders
|
|
* the registry verbatim). The entry's existence is locked by
|
|
* lib/errors/__tests__/structured-errors.test.ts.
|
|
*
|
|
* `reason` is the provider's own sentence (e.g. Fortnox'
|
|
* "Saknar behörighet för leverantörsregister."), appended verbatim because it
|
|
* is the only part that names the register. Omitted when the provider sent an
|
|
* opaque body, which Bokio does.
|
|
*/
|
|
export function getProviderResourceForbiddenMessage(
|
|
reason?: string | null,
|
|
locale: ErrorLocale = 'sv',
|
|
): string {
|
|
const entry = getErrorEntry('PROVIDER_RESOURCE_FORBIDDEN')!
|
|
const base = pick({ sv: entry.message_sv, en: entry.message_en }, locale)
|
|
const detail = reason?.trim()
|
|
return detail ? `${base} ${pick(PROVIDER_REASON_PREFIX, locale)}: "${detail}"` : base
|
|
}
|
|
|
|
/**
|
|
* Helper that parses a Response body and returns a user-friendly error message.
|
|
*/
|
|
export async function getResponseErrorMessage(
|
|
response: Response,
|
|
context?: ErrorContext,
|
|
locale?: ErrorLocale,
|
|
): Promise<string> {
|
|
try {
|
|
const body = await response.json()
|
|
return getErrorMessage(body, { context, statusCode: response.status, locale })
|
|
} catch {
|
|
return getErrorMessage(null, { context, statusCode: response.status, locale })
|
|
}
|
|
}
|