bjornbergenheim
f101bde6a8
The image is built once with sentinel values
(ENV NEXT_PUBLIC_SELF_HOSTED=__NEXT_PUBLIC_SELF_HOSTED__) that
docker-entrypoint.sh seds into .next at container start. Comparing a flag in
place defeats that: the bundler inlines the sentinel, the minifier folds
"__NEXT_PUBLIC_SELF_HOSTED__" === 'true' to false and eliminates the branch, so
both the variable name and the sentinel disappear and sed has nothing left to
replace. The flag is then permanently false whatever the operator configures.
Diagnosed against a running self-hosted instance: the compiled gate read
function r(){return"true"!==process.env.FORCE_PAYWALL
&&"true"===process.env.DISABLE_PAYWALL}
with the isSelfHosted() branch gone. The un-prefixed FORCE_PAYWALL /
DISABLE_PAYWALL survived precisely because they are never inlined, and
NODE_ENV === 'development' was folded away by the same mechanism. The one
place the flag still worked, getSessionTimeoutConfig(env = process.env), reads
it off a parameter the bundler cannot fold.
Consequence: every Docker self-host ran with the entitlement paywall live, so
ai, bank_sync, skatteverket and email_send went dark 30 days after company
creation when the seeded trial grants expired. Nothing surfaced it, because
dev and the Vercel build both have real env values and never reproduce it.
Analytics, forced MFA, BankID and the hosted upload ceiling read the same flag
and were wrong in the same direction.
Flags are now read as values through lib/env/public-flags, which keeps the
sentinel in the output as a live string literal and defers the comparison to
runtime. flagEnabled uses a Set lookup rather than ===, which a minifier could
fold if it ever inlined the helper.
Guarded twice, because the source fix alone would not have caught this:
- check:guards folded-public-flag fails any in-place NEXT_PUBLIC_* comparison
(AST, no baseline, verified to fire on a probe file);
- docker-publish asserts the sentinels survive the built image, which is the
only artifact where the failure is observable.
npm test 14999 passed, npm run lint 0 errors, npm run check:guards clean.
Signed-off-by: Bjorn Bergenheim <29535152+bjornbergenheim@users.noreply.github.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
51 lines
2.0 KiB
TypeScript
51 lines
2.0 KiB
TypeScript
/**
|
|
* PostHog analytics gate.
|
|
*
|
|
* Analytics is a HOSTED-ONLY feature. Self-hosted deployments never load
|
|
* PostHog: an AGPL operator running their own instance should not have their
|
|
* users' behaviour shipped to our project, and the token is not baked into
|
|
* the Docker image (no `__NEXT_PUBLIC_POSTHOG_PROJECT_TOKEN__` sentinel in
|
|
* Dockerfile / docker-entrypoint.sh, deliberately). Recapt achieved the same
|
|
* result only by accident, via that missing sentinel; here it is explicit.
|
|
*
|
|
* Mirrors the shape of `isBankIdEnabled()` in lib/auth/bankid.ts: self-hosted
|
|
* short-circuits first, then the feature's own env var decides.
|
|
*/
|
|
|
|
import { isSelfHosted } from '@/lib/env/public-flags'
|
|
|
|
export const POSTHOG_TOKEN_VAR = 'NEXT_PUBLIC_POSTHOG_PROJECT_TOKEN'
|
|
|
|
export function isAnalyticsEnabled(): boolean {
|
|
if (isSelfHosted()) return false
|
|
return Boolean(process.env.NEXT_PUBLIC_POSTHOG_PROJECT_TOKEN)
|
|
}
|
|
|
|
/**
|
|
* A missing token must never break the app, but it must not fail silently
|
|
* either: without it every capture is dropped and the integration looks
|
|
* healthy while zero events arrive (PostHog's own framework rule). So we warn
|
|
* loudly in development and stay a no-op in production.
|
|
*
|
|
* Returns true when the caller should proceed with initialisation.
|
|
*/
|
|
export function warnIfAnalyticsMisconfigured(): boolean {
|
|
if (isAnalyticsEnabled()) return true
|
|
|
|
// Self-hosted is a deliberate off, not a misconfiguration: stay quiet.
|
|
if (isSelfHosted()) return false
|
|
|
|
if (process.env.NODE_ENV === 'development') {
|
|
// console, not createLogger(): this runs in the browser from
|
|
// instrumentation-client.ts before anything else is wired, and the point
|
|
// is for a developer to see it in the devtools console immediately.
|
|
// eslint-disable-next-line no-console
|
|
console.warn(
|
|
`${POSTHOG_TOKEN_VAR} variable required by PostHog is missing or un-configured, ` +
|
|
`this causes events to be silently missed. This error stops appearing once ` +
|
|
`${POSTHOG_TOKEN_VAR} is configured`
|
|
)
|
|
}
|
|
return false
|
|
}
|