Files
Jakob Wennberg 287828a850 fix(payments): refuse to book a bank row that unlinked vouchers already explain (#2300)
* fix(payments): refuse to book a bank row that unlinked vouchers already explain

A bank feed can deliver several affarshandelser as one row (a Bankgirot
daily aggregate: two customers' invoices, one "BGGIRERING" row with no
payer). When each invoice was already marked paid by hand, nothing on the
account equals the row, the 1:1 duplicate check passes, and "Dela
betalning" books the money a second time against whatever open invoices
the user picks (the next period's identical ones, in the reported case).

- lib/reconciliation/covering-set.ts: exact ore subset sum over a capped
  candidate list, smallest set first, closest in date second.
- detectExplainingVoucherSet(+ForTransaction): the vouchers whose bank legs
  on the row's settlement account, in the row's direction, within 7 days,
  add up exactly to the row; linked through any of the three anchors drops
  a voucher, a payment row without a bank transaction keeps it.
- POST match-batch refuses with BATCH_TX_POSSIBLE_DUPLICATE and returns the
  set; force=true must echo expected_journal_entry_ids (same binding as the
  single door). Fails open on a detection error.
- GET duplicate-payment-check returns candidate_set next to candidate.
- MatchAllocationDialog: pre-flight panel with the vouchers, one click
  links the row to them through the existing 1:1 or 1:N bank link (no new
  voucher), "Bokfor anda" acknowledges the set; confirm is disabled until
  then. Invoices dated after the bank row get a hint badge.
- Mark-paid guard: aggregate sweep (row = this invoice + an exact subset of
  other open invoices, 7 days, kronor) when the name sweeps found nothing;
  PaymentBookingDialog shows the covered invoice numbers and points to the
  split under Transaktioner.

Follow-ups: #2293 (1:N proposals in the auto-matcher), #2294 (MCP staging
guard), #2299 (supplier-side text guard).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NyjeEi1U8vnuPT4QXgayXu

* test(invoices): account for the aggregate sweep in the mark-paid route queue

The sweep issues one more transactions query whenever the name probes come
back empty, so every queued-mock sequence that reaches it gains a slot. The
sweep itself now fails open on odd client shapes (a single object for a
list query) and on errors: an advisory guard must never block "Markera som
betald".

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NyjeEi1U8vnuPT4QXgayXu

* fix(payments): fail open on resolved query errors; aggregate sweep without a payer name

Review follow-ups on #2300. A PostgREST failure resolves with { data: null,
error } instead of throwing, so the set detector read a failed link lookup
as "no links" and a failed cash-account lookup as "scan every 19xx
account"; both now return null (the booking RPC keeps the last word). The
aggregate sweep never needed a customer name (a Bankgirot row names
nobody), so a nameless invoice goes straight to it instead of skipping the
guard. The already-booked panel is announced as a live region, and the
"also covers" string is plural-aware.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NyjeEi1U8vnuPT4QXgayXu

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-05 11:59:59 +02:00

820 lines
32 KiB
TypeScript

'use client'
import { useEffect, useMemo, useState } from 'react'
import { useTranslations } from 'next-intl'
import { createClient } from '@/lib/supabase/client'
import { useCompany } from '@/contexts/CompanyContext'
import {
Dialog,
DialogContent,
DialogDescription,
DialogFooter,
DialogHeader,
DialogTitle,
} from '@/components/ui/dialog'
import { Button } from '@/components/ui/button'
import { Input } from '@/components/ui/input'
import { Skeleton } from '@/components/ui/skeleton'
import { Badge } from '@/components/ui/badge'
import { useToast } from '@/components/ui/use-toast'
import { getErrorMessage } from '@/lib/errors/get-error-message'
import { formatCurrency, formatDate, cn, isValidExchangeRate } from '@/lib/utils'
import { Loader2, Search, X, Plus, Check, AlertTriangle, Link2 } from 'lucide-react'
import type { Invoice, Customer, SupplierInvoice, Supplier } from '@/types'
import type { TransactionWithInvoice } from './transaction-types'
interface MatchAllocationDialogProps {
open: boolean
onOpenChange: (open: boolean) => void
transaction: TransactionWithInvoice | null
onSuccess: () => void
}
/**
* Direction-aware allocation candidate. The dialog normalizes customer and
* supplier invoices to the same shape so the row renderer + tally math stay
* a single code path. The `kind` discriminator drives the underlying API
* payload at submit time.
*
* `remaining` is in the invoice's own `currency` (USD, EUR, etc.).
* `exchangeRate` is the invoice's SEK-per-foreign-unit at invoicing time:
* used to compute the default SEK amount for cross-currency rows so the
* user doesn't have to mental-math the FX (PR #607).
*/
interface AllocationCandidate {
kind: 'customer_invoice' | 'supplier_invoice'
id: string
label: string
counterpartyName: string
remaining: number
total: number
currency: string
exchangeRate: number | null
dueDate: string
/** Invoice date: an invoice issued AFTER the bank row cannot normally be what it paid. */
invoiceDate: string | null
}
/**
* Mirror of ExplainingVoucherSet (lib/invoices/duplicate-payment-detection.ts):
* the posted, unlinked vouchers whose bank legs add up exactly to this row.
* Served by GET /api/transactions/[id]/duplicate-payment-check and by the
* BATCH_TX_POSSIBLE_DUPLICATE refusal of POST match-batch.
*/
interface ExplainingVoucher {
journal_entry_id: string
voucher_label: string
entry_date: string
description: string | null
source_type: string | null
amount: number
bank_account_number: string
}
interface ExplainingSet {
vouchers: ExplainingVoucher[]
total: number
bank_account_number: string
same_date: boolean
}
function readExplainingSet(value: unknown): ExplainingSet | null {
if (!value || typeof value !== 'object') return null
const v = value as Partial<ExplainingSet>
if (!Array.isArray(v.vouchers) || v.vouchers.length === 0) return null
return {
vouchers: v.vouchers,
total: Number(v.total ?? 0),
bank_account_number: v.bank_account_number ?? v.vouchers[0].bank_account_number,
same_date: v.same_date === true,
}
}
type AllocationDraft = {
candidateId: string
amount: string
}
type CustomerInvoiceRow = Invoice & { customer?: Customer | null }
type SupplierInvoiceRow = SupplierInvoice & { supplier?: Supplier | null }
function parseAmount(s: string): number {
// Accept Swedish-style decimal comma + thousand spaces. Empty string → 0.
const cleaned = s.replace(/\s+/g, '').replace(',', '.')
const n = parseFloat(cleaned)
return Number.isFinite(n) ? n : 0
}
function round2(n: number): number {
return Math.round(n * 100) / 100
}
export default function MatchAllocationDialog({
open,
onOpenChange,
transaction,
onSuccess,
}: MatchAllocationDialogProps) {
const { toast } = useToast()
const { company } = useCompany()
const supabase = useMemo(() => createClient(), [])
const t = useTranslations('tx_match_allocation')
const kind: 'customer_invoice' | 'supplier_invoice' = useMemo(() => {
// Strict > 0 (was >= 0): a zero-amount tx would otherwise load customer
// candidates and the RPC would reject with BATCH_TX_ZERO_AMOUNT after
// the user has already filled in allocations. PR #603 review fix.
return transaction && transaction.amount > 0 ? 'customer_invoice' : 'supplier_invoice'
}, [transaction])
const [candidates, setCandidates] = useState<AllocationCandidate[]>([])
const [loading, setLoading] = useState(true)
const [search, setSearch] = useState('')
const [drafts, setDrafts] = useState<Record<string, AllocationDraft>>({})
const [submitting, setSubmitting] = useState(false)
// Already-explained guard: the vouchers that already book this row, if any.
// Set from the pre-flight on open, or from the route's 409 on submit. The
// user either links the row to them (no new voucher) or acknowledges the
// set, which is what lets the confirm through with force=true.
const [explaining, setExplaining] = useState<ExplainingSet | null>(null)
const [explainingAcknowledged, setExplainingAcknowledged] = useState(false)
const [linking, setLinking] = useState(false)
useEffect(() => {
if (!open || !transaction || !company) return
const companyId = company.id
let cancelled = false
async function load() {
setLoading(true)
try {
if (kind === 'customer_invoice') {
// Mirror InvoicePicker's filter: only true invoices (no proformas)
// in an open state with a positive remaining balance.
const { data } = await supabase
.from('invoices')
.select('*, customer:customers(id, name)')
.eq('company_id', companyId)
.eq('document_type', 'invoice')
.is('credited_invoice_id', null)
.in('status', ['sent', 'overdue', 'partially_paid'])
.gt('remaining_amount', 0)
.order('due_date', { ascending: true })
if (cancelled) return
const rows = (data ?? []) as CustomerInvoiceRow[]
setCandidates(
rows.map((r) => ({
kind: 'customer_invoice',
id: r.id,
label: r.invoice_number ?? r.id.slice(0, 8),
counterpartyName: r.customer?.name ?? t('unknown_customer'),
remaining: Number(r.remaining_amount ?? r.total ?? 0),
total: Number(r.total ?? 0),
currency: r.currency,
exchangeRate: r.exchange_rate != null ? Number(r.exchange_rate) : null,
dueDate: r.due_date,
invoiceDate: r.invoice_date ?? null,
})),
)
} else {
const { data } = await supabase
.from('supplier_invoices')
.select('*, supplier:suppliers(id, name)')
.eq('company_id', companyId)
.in('status', ['registered', 'approved', 'overdue', 'partially_paid'])
.gt('remaining_amount', 0)
.order('due_date', { ascending: true })
if (cancelled) return
const rows = (data ?? []) as SupplierInvoiceRow[]
setCandidates(
rows.map((r) => ({
kind: 'supplier_invoice',
id: r.id,
label: r.supplier_invoice_number ?? `LF-${r.arrival_number}`,
counterpartyName: r.supplier?.name ?? t('unknown_supplier'),
remaining: Number(r.remaining_amount ?? r.total ?? 0),
total: Number(r.total ?? 0),
currency: r.currency,
exchangeRate: r.exchange_rate != null ? Number(r.exchange_rate) : null,
dueDate: r.due_date,
invoiceDate: r.invoice_date ?? null,
})),
)
}
} finally {
if (!cancelled) setLoading(false)
}
}
load()
return () => {
cancelled = true
}
}, [open, transaction, company, kind, supabase, t])
// Pre-flight: does the ledger already explain this row? Same detector the
// route refuses with, so the panel shows before a doomed submit. Fail-open:
// a failed pre-flight only means the route's own check does the refusing.
useEffect(() => {
if (!open || !transaction) return
let cancelled = false
async function check() {
try {
const res = await fetch(`/api/transactions/${transaction!.id}/duplicate-payment-check`)
if (!res.ok) return
const json = (await res.json()) as { candidate_set?: unknown }
if (!cancelled) setExplaining(readExplainingSet(json.candidate_set))
} catch {
// Pre-flight is advisory; the POST guard still runs.
}
}
void check()
return () => {
cancelled = true
}
}, [open, transaction])
// Reset state every time the dialog re-opens for a new tx.
useEffect(() => {
if (!open) {
setDrafts({})
setSearch('')
setExplaining(null)
setExplainingAcknowledged(false)
}
}, [open])
const txAmountAbs = transaction ? Math.abs(transaction.amount) : 0
const txCurrency = transaction?.currency ?? 'SEK'
// The explaining set is stated in SEK and the 1:N link slices are stated in
// the row's currency, so the one-click link is only offered for kronor rows;
// a foreign row is pointed to the reconciliation view instead.
const explainingLinkable = !!explaining && txCurrency === 'SEK'
const explainingBlocks = !!explaining && !explainingAcknowledged
const explainingLabels = explaining ? explaining.vouchers.map((v) => v.voucher_label).join(' + ') : ''
// Each draft's `amount` is the allocation in TRANSACTION currency (SEK
// for a Swedish bank import). For cross-currency invoices the FX
// rounding lives inside per-row FX diff lines (Dr 7960 / Cr 3960): NOT
// in the tolerance. So the sum must equal tx_abs exactly: anything
// unallocated would leave the bank line on 1930 short of the actual
// bank receipt and break reconciliation. (PR #607 round-1 review.)
const allocated = useMemo(() => {
return Object.values(drafts).reduce((sum, d) => sum + parseAmount(d.amount), 0)
}, [drafts])
const leftover = round2(txAmountAbs - allocated)
// 0.005 SEK matches the RPC's BATCH_AMOUNT_EXCEEDS_TX guard so the
// "balanced ✓" indicator never lies to the user about what the server
// will accept.
const TOLERANCE = 0.005
const overshoot = leftover < -TOLERANCE
const balanced =
Math.abs(leftover) < TOLERANCE && Object.keys(drafts).length > 0
const undershoot = leftover > TOLERANCE
const filteredCandidates = useMemo(() => {
const selectedIds = new Set(Object.keys(drafts))
const sorted = [...candidates].sort((a, b) => {
const aSel = selectedIds.has(a.id)
const bSel = selectedIds.has(b.id)
if (aSel !== bSel) return aSel ? -1 : 1
return a.dueDate.localeCompare(b.dueDate)
})
if (!search.trim()) return sorted
const needle = search.trim().toLowerCase()
return sorted.filter((c) => {
const haystack = `${c.label} ${c.counterpartyName}`.toLowerCase()
return haystack.includes(needle)
})
}, [candidates, drafts, search])
function addAllocation(candidate: AllocationCandidate) {
setDrafts((prev) => {
if (prev[candidate.id]) return prev
const remainingTxBudget = Math.max(0, round2(txAmountAbs - allocated))
const sameCurrency = candidate.currency === txCurrency
// Same-currency: partial allowed, default to min(remaining, budget).
// Cross-currency: full-payment-only, default to booked SEK (rate
// sanity-checked). NOT capped to remainingTxBudget: the cross-
// currency RPC guard requires the amount to be within ±10% of
// booked_sek, so capping a USD invoice's default at the leftover
// budget would silently trigger BATCH_FX_DEVIATION_TOO_LARGE on
// submit. Instead, let the row default to the right amount and
// the user re-balances the other rows to fit. PR #607 review fix.
let defaultAmount: number
if (sameCurrency) {
defaultAmount = Math.min(candidate.remaining, remainingTxBudget)
} else if (isValidExchangeRate(candidate.exchangeRate)) {
defaultAmount = round2(candidate.remaining * candidate.exchangeRate)
} else {
// No (or out-of-range) FX rate. Leave the amount blank rather
// than guessing a misleading default; the user must enter the
// SEK amount the bank converted to manually. Blocked from
// confirm via the per-row warning below.
defaultAmount = 0
}
return {
...prev,
[candidate.id]: {
candidateId: candidate.id,
amount: defaultAmount > 0 ? defaultAmount.toFixed(2).replace('.', ',') : '',
},
}
})
}
function removeAllocation(candidateId: string) {
setDrafts((prev) => {
const next = { ...prev }
delete next[candidateId]
return next
})
}
function setDraftAmount(candidateId: string, amount: string) {
setDrafts((prev) => ({
...prev,
[candidateId]: { candidateId, amount },
}))
}
async function handleConfirm() {
if (!transaction) return
// PR #607 round-1 review: require balanced. Undershoot is no longer
// allowed because it leaves the bank line short of tx_abs and breaks
// reconciliation.
if (!balanced || overshoot) return
setSubmitting(true)
try {
const allocations = Object.values(drafts)
.map((d) => {
const cand = candidates.find((c) => c.id === d.candidateId)
if (!cand) return null
const amount = parseAmount(d.amount)
if (amount <= 0) return null
return cand.kind === 'customer_invoice'
? { kind: 'customer_invoice' as const, invoice_id: cand.id, amount }
: { kind: 'supplier_invoice' as const, supplier_invoice_id: cand.id, amount }
})
.filter((a): a is NonNullable<typeof a> => a !== null)
if (allocations.length === 0) {
toast({
title: t('error_no_allocations_title'),
description: t('error_no_allocations_description'),
variant: 'destructive',
})
setSubmitting(false)
return
}
const response = await fetch(`/api/transactions/${transaction.id}/match-batch`, {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({
allocations,
// Acknowledged set: echo its ids so the route can verify that what
// the user overrode is what it still detects.
...(explaining && explainingAcknowledged
? {
force: true,
expected_journal_entry_ids: explaining.vouchers.map((v) => v.journal_entry_id),
}
: {}),
}),
})
if (!response.ok) {
const body = await response.json().catch(() => null)
const code = (body as { error?: { code?: string; details?: unknown } } | null)?.error?.code
if (code === 'BATCH_TX_POSSIBLE_DUPLICATE') {
// The pre-flight missed it (or the set changed since): show the
// vouchers instead of an error toast and let the user decide.
const set = readExplainingSet(
(body as { error?: { details?: unknown } }).error?.details,
)
if (set) {
setExplaining(set)
setExplainingAcknowledged(false)
return
}
}
toast({
title: t('error_submit_title'),
description: getErrorMessage(body, {
context: kind === 'customer_invoice' ? 'invoice' : 'supplier_invoice',
statusCode: response.status,
}),
variant: 'destructive',
})
return
}
toast({
title: t('success_title'),
description: t('success_description', { count: allocations.length }),
variant: 'success',
})
onSuccess()
onOpenChange(false)
} catch (err) {
toast({
title: t('error_submit_title'),
description: getErrorMessage(err, {
context: kind === 'customer_invoice' ? 'invoice' : 'supplier_invoice',
}),
variant: 'destructive',
})
} finally {
setSubmitting(false)
}
}
/**
* Link the row to the vouchers that already book it. One voucher goes
* through the 1:1 link, several through the 1:N split
* (linkTransactionToVouchers): slices carry the row's sign and each
* voucher's SEK bank leg, which the engine checks against the voucher's
* line and against the row total. No new verifikat is created.
*/
async function handleLinkToExplaining() {
if (!transaction || !explaining || !explainingLinkable) return
setLinking(true)
try {
const sign = transaction.amount > 0 ? 1 : -1
const body =
explaining.vouchers.length === 1
? {
transaction_id: transaction.id,
journal_entry_id: explaining.vouchers[0].journal_entry_id,
account_number: explaining.bank_account_number,
}
: {
transaction_id: transaction.id,
account_number: explaining.bank_account_number,
allocations: explaining.vouchers.map((v) => ({
journal_entry_id: v.journal_entry_id,
amount: round2(sign * v.amount),
})),
}
const res = await fetch('/api/reconciliation/bank/link', {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify(body),
})
const json = await res.json().catch(() => null)
if (!res.ok || (json as { error?: unknown } | null)?.error) {
toast({
title: t('already_booked_link_failed'),
description: getErrorMessage(json, { context: 'transaction', statusCode: res.status }),
variant: 'destructive',
})
return
}
toast({
title: t('already_booked_link_success_title'),
description: t('already_booked_link_success_description', { labels: explainingLabels }),
variant: 'success',
})
onSuccess()
onOpenChange(false)
} catch (err) {
toast({
title: t('already_booked_link_failed'),
description: getErrorMessage(err, { context: 'transaction' }),
variant: 'destructive',
})
} finally {
setLinking(false)
}
}
if (!transaction) return null
return (
<Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent className="sm:max-w-[640px]">
<DialogHeader>
<DialogTitle>{t('title')}</DialogTitle>
<DialogDescription>
{kind === 'customer_invoice' ? t('description_customer') : t('description_supplier')}
</DialogDescription>
</DialogHeader>
<div className="space-y-4">
{/* Transaction summary */}
<div className="rounded-lg border bg-card p-3">
<p className="text-xs uppercase tracking-wider text-muted-foreground">
{t('transaction_label')}
</p>
<p className="mt-1 text-sm font-medium">{transaction.description}</p>
<div className="mt-1 flex items-center justify-between text-sm">
<span className="tabular-nums text-muted-foreground">
{formatDate(transaction.date)}
</span>
<span
className={cn(
'font-medium tabular-nums',
transaction.amount > 0 && 'text-success',
)}
>
{transaction.amount > 0 ? '+' : ''}
{formatCurrency(transaction.amount, transaction.currency)}
</span>
</div>
</div>
{/* Already-explained guard: the ledger already books this row.
Shown first, before any invoice can be picked: the mistake this
prevents is picking the next period's identical invoices for a
row whose payment was already booked by hand. */}
{explaining && (
<div
className={cn(
'rounded-lg border p-4 space-y-3',
explainingAcknowledged ? 'border-border bg-muted/20' : 'border-attn/40 bg-muted/30',
)}
data-testid="already-booked-panel"
role="status"
aria-live="polite"
>
<div className="flex items-start gap-2">
<AlertTriangle className="h-4 w-4 flex-shrink-0 mt-0.5 text-attn" />
<div className="min-w-0 flex-1 space-y-1 text-sm">
<p className="font-medium text-attn">
{explainingAcknowledged
? t('already_booked_acknowledged_title')
: t('already_booked_title')}
</p>
{!explainingAcknowledged && (
<p className="text-muted-foreground">
{t(
transaction.amount > 0 ? 'already_booked_body_in' : 'already_booked_body_out',
{
amount: formatCurrency(explaining.total, 'SEK'),
count: explaining.vouchers.length,
},
)}
</p>
)}
</div>
</div>
{!explainingAcknowledged && (
<ul className="space-y-1.5">
{explaining.vouchers.map((v) => (
<li
key={v.journal_entry_id}
className="flex items-center justify-between gap-3 rounded-sm border bg-card px-3 py-2 text-sm"
>
<div className="min-w-0 space-y-0.5">
<div className="flex items-center gap-2">
<span className="font-medium tabular-nums">{v.voucher_label}</span>
<span className="text-xs tabular-nums text-muted-foreground">
{formatDate(v.entry_date)}
</span>
</div>
{v.description && (
<p className="truncate text-xs text-muted-foreground">{v.description}</p>
)}
</div>
<span className="shrink-0 font-medium tabular-nums">
{formatCurrency(v.amount, 'SEK')}
</span>
</li>
))}
</ul>
)}
{!explainingAcknowledged && (
<div className="flex flex-col gap-2 sm:flex-row">
{explainingLinkable ? (
<Button
type="button"
size="sm"
onClick={handleLinkToExplaining}
disabled={linking || submitting}
className="sm:flex-1"
>
{linking ? (
<Loader2 className="mr-2 h-4 w-4 animate-spin" />
) : (
<Link2 className="mr-2 h-4 w-4" />
)}
{t('already_booked_link', { labels: explainingLabels })}
</Button>
) : (
<p className="text-xs text-muted-foreground sm:flex-1">
{t('already_booked_foreign_hint', { currency: txCurrency })}
</p>
)}
<Button
type="button"
size="sm"
variant="ghost"
onClick={() => setExplainingAcknowledged(true)}
disabled={linking || submitting}
className="text-muted-foreground"
>
{t('already_booked_book_anyway')}
</Button>
</div>
)}
{explainingAcknowledged && (
<p className="text-xs text-muted-foreground">
{t('already_booked_acknowledged_note', { labels: explainingLabels })}
</p>
)}
</div>
)}
{/* Search */}
<div className="relative">
<Search className="absolute left-3 top-1/2 h-4 w-4 -translate-y-1/2 text-muted-foreground" />
<Input
value={search}
onChange={(e) => setSearch(e.target.value)}
placeholder={t('search_placeholder')}
className="pl-9"
/>
</div>
{/* Candidate list */}
{loading ? (
<div className="space-y-2">
<Skeleton className="h-16 w-full" />
<Skeleton className="h-16 w-full" />
<Skeleton className="h-16 w-full" />
</div>
) : filteredCandidates.length === 0 ? (
<div className="rounded-lg border border-dashed bg-muted/30 p-6 text-center">
<p className="text-sm font-medium">{t('empty_title')}</p>
<p className="mt-1 text-xs text-muted-foreground">{t('empty_description')}</p>
</div>
) : (
<ul className="space-y-2 max-h-[320px] overflow-y-auto">
{filteredCandidates.map((c) => {
const draft = drafts[c.id]
const isSelected = !!draft
return (
<li
key={c.id}
className={cn(
'rounded-lg border bg-card p-3 transition-colors',
isSelected ? 'border-foreground' : 'border-border',
)}
>
<div className="flex items-start justify-between gap-3">
<div className="min-w-0 flex-1 space-y-1">
<div className="flex items-center gap-2">
<span className="text-sm font-medium tabular-nums">{c.label}</span>
{isSelected && (
<Badge variant="secondary" className="gap-1">
<Check className="h-3 w-3" />
{t('selected_badge')}
</Badge>
)}
</div>
<p className="truncate text-xs text-muted-foreground">
{c.counterpartyName}
</p>
<p className="text-xs text-muted-foreground tabular-nums">
{t('remaining_label', {
amount: formatCurrency(c.remaining, c.currency),
})}
</p>
{/* Money that arrived before the invoice existed rarely
paid it: the next period's identical invoice is the
classic wrong pick when the real one is already
settled. A hint, not a block: prepayments exist. */}
{c.invoiceDate && c.invoiceDate > transaction.date && (
<Badge variant="warning" className="gap-1">
<AlertTriangle className="h-3 w-3" />
{t('invoiced_after_payment_badge', { date: formatDate(c.invoiceDate) })}
</Badge>
)}
</div>
{isSelected ? (
<div className="flex flex-col items-end gap-1">
<div className="flex items-center gap-2">
<Input
type="text"
inputMode="decimal"
value={draft.amount}
onChange={(e) => setDraftAmount(c.id, e.target.value)}
className="h-9 w-28 font-mono text-right tabular-nums"
aria-label={t('amount_input_aria', { label: c.label })}
/>
<Button
type="button"
size="icon"
variant="ghost"
onClick={() => removeAllocation(c.id)}
aria-label={t('remove_aria', { label: c.label })}
>
<X className="h-4 w-4" />
</Button>
</div>
{/* FX hint: appears only for cross-currency rows
so the user can see what their tx-currency
input translates to in invoice currency.
When the rate is missing or out of range, we
warn instead of silently defaulting to a
misleading number. PR #607 round-1 review. */}
{c.currency !== txCurrency && (
isValidExchangeRate(c.exchangeRate) ? (
<p className="text-[11px] tabular-nums text-muted-foreground">
{formatCurrency(parseAmount(draft.amount) / c.exchangeRate, c.currency)}
</p>
) : (
<p className="text-[11px] tabular-nums text-attn">
{t('fx_rate_missing_warning', { currency: c.currency })}
</p>
)
)}
</div>
) : (
<Button
type="button"
size="sm"
variant="outline"
onClick={() => addAllocation(c)}
>
<Plus className="mr-1 h-3.5 w-3.5" />
{t('add_button')}
</Button>
)}
</div>
</li>
)
})}
</ul>
)}
{/* Tally */}
<div className="space-y-2 border-t pt-3">
<div className="flex items-center justify-between text-sm">
<span className="text-muted-foreground">{t('allocated_label')}</span>
<span
className={cn(
'font-mono tabular-nums',
overshoot && 'text-destructive',
balanced && 'text-success',
)}
>
{formatCurrency(allocated, transaction.currency)} /{' '}
{formatCurrency(txAmountAbs, transaction.currency)}
</span>
</div>
{overshoot ? (
<div className="flex items-center gap-2 rounded-lg bg-destructive/10 p-3 text-sm text-destructive">
<AlertTriangle className="h-4 w-4 flex-shrink-0" />
<p>
{t('overshoot_warning', {
excess: formatCurrency(Math.abs(leftover), transaction.currency),
})}
</p>
</div>
) : balanced ? (
<div className="flex items-center gap-2 rounded-lg bg-success/10 p-3 text-sm text-success">
<Check className="h-4 w-4 flex-shrink-0" />
<p>{t('balanced_message')}</p>
</div>
) : undershoot && Object.keys(drafts).length > 0 ? (
// Undershoot is now a blocking state: the JE's 1930 line
// must equal the bank's actual receipt or reconciliation
// breaks. The user must allocate the full amount or remove
// selections. PR #607 round-1 review fix.
<div className="flex items-start gap-2 rounded-lg bg-muted/30 p-3 text-sm text-attn">
<AlertTriangle className="h-4 w-4 flex-shrink-0 mt-0.5" />
<p>
{t('undershoot_warning', {
amount: formatCurrency(leftover, transaction.currency),
})}
</p>
</div>
) : null}
</div>
</div>
<DialogFooter>
<Button variant="outline" onClick={() => onOpenChange(false)} disabled={submitting}>
{t('cancel')}
</Button>
<Button
onClick={handleConfirm}
// Confirm requires sum == tx_abs exactly (within rounding).
// Anything else lets the JE diverge from the bank line and
// breaks reconciliation. PR #607 round-1 review fix.
disabled={submitting || linking || !balanced || overshoot || explainingBlocks}
>
{submitting && <Loader2 className="mr-2 h-4 w-4 animate-spin" />}
{t('confirm')}
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
)
}