Em dashes (—) and en dashes (–) had spread across comments, docs, tests,
and a few UI strings, reading as AI-generated boilerplate rather than
house style. Replaced each with punctuation matching its context: colon
for explanatory clauses, comma for asides, plain hyphen for numeric/legal
ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for
paired-dash asides. messages/en.json and messages/sv.json were fixed by
hand together to keep sv/en in sync.
Left untouched where the dash is the functional subject rather than
decorative punctuation: date-range-parser.ts's separator regex,
charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE
encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the
agent system-prompt files that already instruct against em dashes, and
a golden iXBRL test fixture compared byte-for-byte.
Also fixes two bugs surfaced along the way: an off-by-one in
ApiKeysPanel's scope-label split (a leftover from an earlier partial
pass), and a charset-repair test that had lost the literal en-dash it
exists to verify.
Regenerated the agent atom seed migration (skills:generate) since 27
SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes,
with an explicit carve-out for the functional-dash cases above.
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
* feat(bookkeeping): agent attribution into the immutable ledger layer
Close the three attribution gaps left after 20260618120001 (which made
commit_method record 'api_key' for MCP-relayed approvals):
- journal_entries gains nullable committed_actor_type/committed_actor_label,
stamped by commit_journal_entry in the same draft->posted UPDATE that
writes commit_method. The RPC gains p_actor_type/p_actor_label
(DEFAULT NULL; prior signature dropped first to avoid PostgREST overload
ambiguity, same technique as 20260421140000).
- write_audit_log now populates audit_log.actor_type/actor_label from
transaction-local gnubok.actor_* GUCs set by the RPC (the established
gnubok.allow_delete pattern). Unset GUCs COALESCE to 'user' — byte-
identical to the column's previous effective DEFAULT for every
pre-existing write path.
- commitPendingOperation accepts opts.actor and runs the entire executor
inside an AsyncLocalStorage runWithActor() scope read by commitEntry(),
so EVERY journal commit an operation makes is attributed — closing the
documented "commitMethod only reaches create_voucher" gap. MCP approve
passes the api_key actor + key label; web single/bulk approve pass the
user + email.
Known limitation (documented): reverseEntry posts reversal vouchers via
direct PostgREST writes, not the commit RPC — reversals keep NULL
attribution until that path is RPC-ified (follow-up).
pg-real coverage: lib/bookkeeping/__tests__/commit-actor.pg.test.ts
(RPC param stamping, audit GUC read, transaction-locality, CHECK
rejection, immutability of the new columns, single-signature guard).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(bookkeeping): split actor-context so client bundles never see node:async_hooks
CI core-only build failed: engine.ts is reachable from client component
bundles (invoices/[id] page), and the static node:async_hooks import in
actor-context.ts cannot be chunked for the browser. Split the module:
- actor-context.ts (isomorphic): CommitActor type + a storage registry +
getActor(). In a client bundle the registry stays empty and getActor()
returns undefined — identical to the server-side no-scope default.
- actor-context-node.ts (server-only): owns the AsyncLocalStorage, binds it
into the registry on import, exports runWithActor(). Imported only by the
approval paths (commit.ts), which are never client-reachable.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Jakob Wennberg