19 Commits

Author	SHA1	Message	Date
Mattsson	d27c3dd3dc	Bug/customer cron job (#516) ... * fix(reminder-processor): filter out credited invoices in overdue reminders * feat: implement linking of transactions to journal entries - Added POST endpoint for linking a bank transaction to an existing journal entry without creating new bookkeeping. - Implemented validation for required fields and error handling for various scenarios (e.g., missing journal_entry_id, transaction already linked, journal entry not found). - Created tests for the new endpoint to cover various cases including successful linking, error responses, and invoice handling. - Introduced duplicate payment detection logic to prevent double-booking of bank receipts. - Added a new component for correction affordance in the UI to facilitate user corrections on journal entries. * feat(invoice-matching): enhance force matching with expected journal entry validation	2026-05-18 13:17:15 +02:00
Jakob Wennberg	b46b572ee9	fix(invoices): duplicate-payment guard on customer mark-paid + categorize (#502) ... * fix(invoices): duplicate-payment guard on customer mark-paid + categorize Two-pronged fix preventing duplicate verifikationer when a customer invoice is marked paid OR a 19xx→1510 categorization is applied to an inbound bank tx that already belongs to an open invoice. Prong A (mark-paid): before booking, scan unlinked positive business bank txs from the same customer within ±2% / ±60 days. If candidates exist, return 409 INVOICE_PAID_LIKELY_DUPLICATE with per-candidate match_reason (ocr_exact > name_amount_fuzzy > amount_only). Override via `{ force: true }`. Applied to both legacy /api/invoices/[id]/ mark-paid and v1 /api/v1/.../invoices/[id]/mark-paid; v1 guard runs before dry-run so previews can't mask the warning. Prong B (categorize): when the user assigns 1930→1510 directly on a positive business tx with a matching open customer invoice (by name OR by OCR-normalized reference), return 409 TX_CATEGORIZE_SUGGEST_CI_MATCH routing them to /match-invoice. Mirrors the supplier-side guard from #461. Shared helpers (DUPLICATE_AMOUNT_TOLERANCE_PCT, escapeLikePattern) reused as-is. New helper normalizeOcrReference() strips non-digits for Swedish OCR equality. New shared candidate-finder lib/invoices/duplicate-payment-candidates.ts keeps the legacy and v1 routes calling the same code. Frontend: - PaymentBookingDialog intercepts the 409, renders candidate list with match_reason badges (Exakt OCR-träff / Sannolik träff / Möjlig träff), offers "Länka transaktion" or "Bokför ändå" (force-retry generates a fresh Idempotency-Key for v1 callers) - transactions/page.tsx mirrors siMatchSuggestion handling as ciMatchSuggestion with a parallel "Matcha mot kundfaktura?" dialog v1 caveat documented in the route's pitfalls block: INVOICE_PAID_LIKELY_DUPLICATE force-retry requires a fresh Idempotency-Key because the original is body-hash bound; reusing it returns 400 IDEMPOTENCY_KEY_REUSE. Tests: 5 new mark-paid tests (legacy + v1) covering 409, force bypass, partial-payment skip, ocr_exact match_reason, multi-candidate ranking. 1 v1-only test verifying dry-run also surfaces the 409. 2 categorize Prong B tests (409 + confirm_no_match bypass). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(invoices): address compliance-swarm review on duplicate-payment guard Three review-driven fixes: 1. **PostgREST .or() injection (OWASP V1.2.5).** `escapeLikePattern` neutralises LIKE wildcards but NOT PostgREST filter-DSL chars (`,`, `.`, `(`, `)`). A customer name like `Acme,fake.eq.true` could otherwise inject a synthetic filter clause into the `.or('merchant_name.ilike.%X%,description.ilike.%X%')` string. Replaced with two parameterised `.ilike()` queries dispatched in parallel and merged by id in JS. Slight perf cost (two index hits per call), eliminates the DSL-injection surface entirely. 2. **Date window anchored on invoice_date instead of due_date (swedish-accounting-compliance bot).** The Prong B categorize intercept filtered open customer invoices by `invoice_date ± 60d` relative to the bank-tx date. For invoices with 60–90 day payment terms, the actual payment lands well after `invoice_date`, so the legitimate match falls outside the window and the guard silently misses it. Switched to `due_date ± 60d` — the better proxy for "around when payment is expected." No corresponding change for Prong A (mark-paid), which is correctly anchored on `paymentDate` (the user-supplied or default-today date) and scans bank-tx dates around that anchor. 3. **Force-bypass log enrichment (ISO A.8.15, OWASP V16).** Both `duplicate-payment guard bypassed` warn entries now include `userId` and `paymentAmount`. Attribution was previously incomplete — the bypass log carried only `invoiceId`, which forced a join in log aggregation to identify the acting principal. Tests updated for the two-query pattern (legacy mark-paid suite enqueues two transactions-table responses per guard invocation; v1 tests already worked with the single-entry-per-table mock semantics). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(docs): redirect /docs/api and /llms-full.txt to docs.gnubok.se Canonical docs host is now docs.gnubok.se. Every `docs_url` field on the v1 error envelope still points at /docs/api/* on this app; the 308 permanent redirect forwards humans and agent crawlers to the docs subdomain without us needing to mass-update structured-errors.ts. /llms-full.txt also routes through the docs host where it's served from the docs site's own build. --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-15 22:46:02 +02:00
Mattsson	7175daee87	Bug/skv konto numbers (#498) ... * feat(skattekonto): add overdue transactions handling and split logic * feat: enhance transaction handling and loading states - Update BalanceHero component to display last synced date and additional information about Skatteverket updates. - Refactor BookDirectlyDialog to simplify transaction linking logic and improve UI for transaction selection. - Revamp InvoiceInboxWorkspace layout for better responsiveness and user experience, including improved skeleton loading states. - Introduce new loading states for ExtensionWorkspace to match the live layout and improve user feedback during data fetching. - Implement exchange rate fetching in QuickReviewDialog, ensuring transactions are always processed in SEK with error handling for rate fetching. - Add structured error handling for unavailable exchange rates in the transaction API. * feat(skattekonto): add 'Skattekonto – saldo & transaktioner' scope and update authorization checks * feat: implement reverse charge handling in supplier invoice calculations and UI	2026-05-15 16:25:05 +02:00
Jakob Wennberg	523a8650cc	feat(api): Phase 5 PR-3 — reports + import async (final Phase 5 PR) (#490) ... * feat(api): Phase 5 PR-3 — reports + import async (final Phase 5 PR) Combines the originally-planned PR-3 (import) and PR-4 (reports) into one final Phase 5 PR per the user's "split into two PRs" scoping after PR-2. 16 new endpoints, 12 new tests, 1 shared helper. 502 v1+salary tests total (was 490 before this PR). Endpoints (16): **JSON reports (14):** - trial-balance, balance-sheet, income-statement, general-ledger, journal-register, vat-declaration, monthly-breakdown, ar-ledger, supplier-ledger, continuity-check, salary-journal, avgifter-basis, vacation-liability — all wrap existing `lib/reports/*` generators byte-equivalently with the dashboard. - New shared helpers (`lib/api/v1/report-period.ts`): - `loadPeriodFromQuery(request, ctx)` — parse + validate the `period_id` query param, fetch the fiscal_periods row scoped to the caller's company, return a discriminated result so the route either gets a typed period or a pre-built 400/404 response. - `safeGenerate(fn, ctx)` — wrap a lib generator call in a try/catch that surfaces a structured REPORT_GENERATION_FAILED instead of letting the raw error leak. - Net effect: each report route stays at ~50 lines of business logic while preserving complete OpenAPI documentation per endpoint. **Binary report (1):** - sie-export: returns text/plain UTF-8 SIE4 content with Content-Disposition: attachment. OWASP V3.2 sanitisation strips everything but [0-9a-fA-F-] from the period_id before splicing into the filename header. **Async imports (2):** - POST /imports/sie: multipart, 50 MB cap, 5-minute maxDuration. Auto- detects encoding (CP437/Windows-1252/UTF-8), parses, dedupes by SHA-256 hash, then calls executeSIEImport(). Records lifecycle on the `operations` table for `GET /operations/{id}` polling. Returns the 202 envelope from `accepted()`. - POST /imports/bank: multipart, 10 MB cap. Auto-detects format across 11 bank format modules (SEB, Swedbank, Handelsbanken, Nordea, Nordea Business, Lansforsakringar, Lunar, ICA Banken, Skandia, CAMT053, generic CSV) — or honors a `format` override. Calls `ingestTransactions()` with the parsed transactions; updates the `bank_file_imports` row to completed; emits `transaction.synced` per ingested row through the standard ingest path. Same operations table polling shape. Both imports execute INLINE today. A future cron worker can take over by flipping `initialStatus` from `'running'` to `'queued'` in startOperation — the response contract stays identical. Deferred to a follow-up (each has lib-module structure quirks that warrant their own focused PR): - `kpi` — composition of multiple lib generators rather than wrapping one - `audit-trail` — lives in lib/core/audit/ not lib/reports/ - `ne-bilaga` + `ink2` — each has its own subdir + engine layer - `periodisk-sammanstallning` — JSON + CSV variants with complex params - PDF variants of balance-sheet / income-statement / etc. — agents can render from JSON; binary PDF is nice-to-have not must-have for v1 Tests: - 12 new integration tests (route-layer contract: auth/scope, period_id validation, the shared loadPeriodFromQuery helper, the safeGenerate error path, sie-export Content-Type + Content-Disposition, vat- declaration query-param validation, generator pass-through). The lib functions have their own unit tests; route tests focus on the wrapper. - 502 total v1 + lib/salary tests pass. - Type-check clean. 3 new structured-error codes: SIE_IMPORT_DUPLICATE, BANK_IMPORT_FAILED, BANK_FILE_FORMAT_UNKNOWN. Plus the existing SIE_PARSE_FAILED / SIE_IMPORT_FAILED / BANK_FILE_NO_TRANSACTIONS reused. Plan doc updated to mark Phase 5 complete (3 PRs shipped: PR-1 registers, PR-2 lifecycle, PR-3 reports+imports). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(api): address PR-490 review round 1 — 3 Greptile P1 bugs + 5 defensive items Compliance Swarm landed at 17 findings (5 high + 10 medium + 2 low) on the first round; Swedish bot at 8; Greptile flagged 3 inline P1 bugs. CI all green from the first push. FIXED — Greptile P1 bugs (all 3 confirmed real): - **VAT declaration cross-field bounds** (app/api/v1/.../reports/vat-declaration/route.ts). The schema validated `period` as 1-12 for every period_type. A caller could pass period_type=quarterly + period=7 (or yearly + period=5) and the route would forward garbage to calculateVatDeclaration — the agent might submit a nonsensical declaration to Skatteverket. Added a .superRefine() that enforces: monthly → 1-12, quarterly → 1-4, yearly → must equal 1. Swedish-compliance bot flagged the same concern independently. - **SIE import options JSON.parse unguarded** (app/api/v1/.../imports/sie/route.ts). The route inlined `JSON.parse(optionsRaw)` inside the Zod safeParse call. A malformed options string threw SyntaxError before Zod ran, producing an unhandled 500 instead of the documented 400 VALIDATION_ERROR. Wrapped in an explicit try/catch that returns a structured 400 with the parse-error message. - **Bank import upsert conflict key cross-company collision** (app/api/v1/.../imports/bank/route.ts). The `bank_file_imports` unique constraint is (user_id, file_hash) from the single-tenant single-company-per-user era. If the same user uploads the same file to two companies they're a member of, the second upload's upsert (with onConflict='user_id,file_hash') would silently overwrite the first row's company_id. Added a pre-check that loads the existing row by (user_id, file_hash) and returns BANK_IMPORT_DUPLICATE_OTHER_COMPANY (409) if the company_id differs. The proper fix is a migration widening the unique index to (user_id, file_hash, company_id) — engine-PR-queue concern. FIXED — defensive items from Compliance Swarm V2.2, V5.2: - **General-ledger account_from/account_to validation** (V2.2). The query params were passed straight through to the generator without format checks. Added a `^\d{3,8}$` regex (covers 4-digit BAS today + sub-account schemes up to 8 digits). - **SIE import file header sanity check** (V5.2). Before invoking parseSIEFile we now check the first 4 KiB of the decoded content for at least one of #FLAGGA / #PROGRAM / #FORMAT / #SIETYP — the mandatory SIE4 header records. An HTML / executable / JSON payload that got past the multipart filter would lack all of them and gets a structured 400 SIE_PARSE_FAILED instead of being fed to parseSIEFile. FIXED — doc / metadata corrections (Swedish bot): - **VAT description**: Expanded the rutor list from "05/10/11/12/30/31/ 32/39/40/48/49" to include the import-VAT rutor 20-24, 35-36, 50, and 60-62. Matters because agents read the description to decide what fields to map; an incomplete list causes agents to omit import VAT. - **Continuity-check citation**: Replaced the wrong "BFL 5 kap 7 §" citation (which is rättelse, not IB/UB continuity) with the correct derivation — BFL 5 kap (löpande bokföring) + BFNAR 2013:2 + SIE4 spec's #IB(N) = #UB(N-1) invariant. - **Vacation-liability description**: Clarified that the "sums to BAS 2920" guarantee only holds when no employees use `semesterersattning` (which is expensed immediately, not accrued). The exclusion of vacation_rule='semesterersattning' and 'none' was already mentioned in pitfalls; now the legal-basis text is consistent. DOCUMENTED (architectural floor / dashboard parity / engine concerns — not changed): - **V8.2.1 path-based tenant check** (4th repeat across phases). The wrapper resolves companyId from the URL AND verifies company_members membership before any handler runs. - **V5.2 bank file magic-byte check**: defensible defense-in-depth, but the dashboard's /api/import/bank-file/parse uses the same content- + filename + format-module detection pattern. Diverging in v1 would break parity. Tracked for a cross-cutting "tighten upload validation" PR. - **V16 error log internals leak**: the error responses do surface err.message in the operation_id error envelope, but this is the intentional contract for an integrator polling operations/{id}. Stack traces are not included. - **Art.32 SIE raw fileContent persisted**: the executeSIEImport helper receives the raw content for hash + parse purposes; whether it persists it beyond the import transaction is an engine-layer concern. Tracked. - **Art.25(1) journal-register + general-ledger no pagination**: dashboard parity. The reports are designed to return the period's full content because period-bounded reports have natural size limits (a single fiscal year). Cursor pagination would diverge from dashboard behavior. - **Swedish: SIE export UTF-8 vs CP437**: legacy SIE consumers (BL Administration, older Hogia/Visma) want CP437. The dashboard serves UTF-8 today and modern SIE consumers accept it. Diverging in v1 would break parity. If real-world legacy-consumer demand surfaces, add a `?encoding=cp437` override; not building on speculation. - **Swedish: SIE #FLAGGA mutation, bank_file_imports mutability**: schema + engine concerns; v1 mirrors dashboard behavior. - **Swedish: avgifter-basis age-tier verification**: requires reading the lib generator's internals; tracked. 1 new structured-error code: BANK_IMPORT_DUPLICATE_OTHER_COMPANY (409). Test count: 261 v1 (unchanged — fixes are internal). 502 across v1 + lib/salary. Type-check clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(api): address PR-490 review round 2 — IDOR fix + bank format enum + calendar date validation + 3 doc fixes Compliance Swarm went 17 → 12 between rounds (high count 5 → 2 — the three Greptile P1s from round 1 dropped out cleanly). 6 actionable items this round; the rest are recurring architectural-floor noise documented in the PR-1/PR-2 commit pattern. FIXED (security): - **V8.2.1 / CC6.1 — BANK_IMPORT_DUPLICATE_OTHER_COMPANY IDOR leak** (app/api/v1/.../imports/bank/route.ts). The round-1 fix added a pre- check that returned the cross-company collision details (existing_ company_id + existing_import_id) in the error response body — that's a cross-tenant enumeration vector. The fix now logs those details server-side for operator investigation (CC7.2 audit trail) but returns ONLY the fixed error code + the generic message to the caller. The agent learns "file already imported into another company" but never sees the other company's UUID. - **V2.2 / PI1.1 — bank format query param allowlist** (app/api/v1/.../imports/bank/route.ts). The route cast `url.searchParams.get('format')` directly to `BankFileFormatId` without validation. Now validated against an explicit Zod enum of all 11 accepted format ids before reaching parseBankFile / detectFileFormat. Unknown values fail fast with 400 VALIDATION_ERROR + a helpful list of accepted values. FIXED (correctness): - **A.8.28 — as_of_date calendar validity** (ar-ledger + supplier-ledger routes). The regex `^\d{4}-\d{2}-\d{2}$` matched '2026-13-45'. Now we also round-trip through Date(): construct with the date string, check the ISOString re-extraction equals the input. Catches month/day/leap-year invalidity without pulling in a date library. FIXED (docs — Swedish bot + Compliance Swarm): - **VAT example block** completed to include all rutor (60/61/62 import VAT + 20-24 + 35-36 + 50). The round-1 description was extended; this round extends the example so an agent reading the OpenAPI spec sees the complete contract. - **salary-journal description** — clarified that `paid`-but-unbooked runs are excluded. Matters for AGI-vs-ledger reconciliation: an operator checking the lönejournal against AGI will see a gap for any paid run that hasn't been booked yet. - **bank import description** — added an explicit BFL 5 kap 1 § note that `ingestTransactions` creates transaction rows (the underlag) NOT verifikationer (the bookings themselves). Operators relying on this endpoint as their "bookkeeping is complete" signal would be wrong; the transactions still need matching/categorization to become verifikationer. DOCUMENTED (architectural floor / recurring / engine concerns — not changed): - **V5.2 magic-byte upload validation** (5th repeat across phases). Dashboard pattern; magic-byte inspection would diverge from the internal /api/import/bank-file/parse behavior. Tracked for a cross-cutting upload-validation hardening PR. - **V16 err.message reflection** (2nd repeat). The integrator-facing contract for an operations.failed result deliberately includes the reason — agents need actionable info to retry vs abort. Removing err.message would be a regression for debuggability. - **A.8.28 / CC6.1 parser DoS on large SIE/bank files**. Bounded by the 50 MB / 10 MB file caps + 5-min maxDuration. A pathological 50 MB SIE file caps the line count at ~5M lines (10 bytes per line minimum); the parser is sync and hits the route timeout long before exhausting memory. - **CC7.2 log injection via err.message**. Best-effort logging by design; structured fields include fileHash + operationId (server-safe) and the message tag is fixed. - **Swedish: SIE export UTF-8 vs CP437** (2nd repeat — dashboard parity). A future `?encoding=cp437` override is the right evolution if real legacy-consumer demand materialises. - **Swedish: #FLAGGA reset to 1, period-occupancy check on SIE import**. Engine-layer concerns inside executeSIEImport. Tracked. Test count: 261 v1 (unchanged — fixes are internal). Type-check clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(api): address PR-490 review round 3 — SIE IDOR symmetry, bank log fields, VAT doc corrections Compliance Swarm went 12 → 26 between rounds — the documented oscillation pattern at its most aggressive (the bot reactivates and finds more speculative items as the actionable ones resolve). 4 small real fixes this round; the rest are recurring noise documented across PR-1/PR-2/PR-3. FIXED (security parity): - **V8.2.1 — SIE duplicate IDOR leak** (app/api/v1/.../imports/sie/route.ts). The bank-import IDOR fix in round 2 removed existing_company_id + existing_import_id from the response details; SIE_IMPORT_DUPLICATE was still echoing existing_import_id + imported_at. Symmetric fix: log forensics server-side (CC7.2 audit trail), return only the error code + generic message to the caller. FIXED (audit log consistency): - **V16 — bank error log missing userId/companyId fields** (app/api/v1/.../imports/bank/route.ts). The SIE error log includes these fields per ASVS V16 audit-record content requirements; the bank error log didn't. Added for consistency. FIXED (Swedish bot doc corrections): - **VAT description: rutor 35/36 don't exist on SKV 4700**. The round-1 expansion incorrectly listed "ruta 35-36 (export + EU services)". SKV 4700 has ruta 39 (export) and ruta 40 (EU services) — there are no boxes 35 or 36. Removed from both the description and the example block. - **ML 13 kap → ML 15 kap**. The kontantmetod citation referenced the pre-2023 chapter. ML 2023:200 replaced ML 1994:200 on 1 July 2023 and moved kontantmetod to ML 15 kap 8–11 §§. Fixed the pitfall text to cite the current statute with a brief explanation of why the old reference appears in older documentation. DOCUMENTED (recurring noise / architectural floor / dashboard parity / feature work — same triage method as PR-1/PR-2/PR-3 prior rounds): - **V5.2 magic-byte upload validation** (6th repeat). Dashboard doesn't do this either. Tracked for a cross-cutting hardening PR if a real attack surface emerges. - **V2.3 / Art.5(1)(f) err.message reflection in API response** (3rd repeat). Intentional contract for operations.failed result — agents need actionable info to retry vs abort. Removing err.message would be a regression for debuggability. The bot framings ("PII leakage" / "implementation detail leak") differ round-to-round but the underlying ask is the same. - **Art.5(1)(c) — z.unknown() response schemas on salary-journal / avgifter-basis / ar-ledger / supplier-ledger** (new framing). Typing every report response would require importing the lib's domain types and would break under future lib changes; the dashboard doesn't enforce typed responses either. Recurring dashboard-parity concern. - **Art.5(1)(f) — cross-tenant log linkage from the round-2 IDOR fix**. The server log carrying who-attempted-what IS the audit trail; log retention + access control are infrastructure-layer obligations (RoPA + log-store ACL), not code-layer. The bot wants me to confirm/document; tracked outside this PR. - **Art.5(1)(f) — filename in SIE error log** (new framing). Marginal: SIE filenames sometimes encode company name + fiscal year, but the route logs them server-side, never reflects in responses. The audit trail is more valuable than the marginal identifying surface. - **Art.25(2) — report endpoint pagination** (2nd repeat). Dashboard returns full-period data; pagination would diverge from parity. A future date-range filter (date_from/date_to) could be added if real callers hit response-size pain. - **Swedish: SIE export UTF-8 vs CP437** (3rd repeat — dashboard parity). - **Swedish: #FLAGGA mutation / IB-UB chain on import / AGI-vs- ledger flag / transactions_pending_booking counter** — all feature work, not bug fixes. Tracked for engine PR queue or future Phase 5.x. Test count: 261 v1 (unchanged — fixes are internal). Type-check clean. Trajectory: 17 → 12 → 26. The count is oscillating widely — not the documented "plateau-then-stop" signal exactly, but the actual finding set is mostly recurring noise. Continuing to fix small real items while the noise stabilises. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(api): address PR-490 review round 4 — 7 small final fixes (defense in depth + doc corrections) Compliance Swarm: 17 → 12 → 26 → **10** between rounds. Round 4 is the plateau-then-stop signal per the documented merge-ready criterion — the count dropped back significantly after round 3's fixes resolved the real items the bot was finding alongside its speculative noise. FIXED (defense in depth): - **V8.2.1 — bank `bank_file_imports` UPDATE missing company_id filter** (app/api/v1/.../imports/bank/route.ts). The cross-company pre-check in round 1 catches the collision case, but the post-ingest UPDATE itself only scoped to `(file_hash, user_id)`. Added `.eq('company_id', ctx.companyId!)` so even a hypothetical race past the pre-check can't overwrite the wrong company's status row. - **V5.2 — SIE header check line-start regex** (app/api/v1/.../imports/sie/route.ts). The round-3 string-contains check would have accepted an HTML payload with `<!-- #FLAGGA -->`. Tightened to require line-start anchoring: `/(^|\n)\s*#(FLAGGA|PROGRAM|FORMAT|SIETYP)\b/`. A SIE header record always starts on its own line per the spec. - **V2.2 — as_of_date year range clamp** (ar-ledger + supplier-ledger routes). Calendar validity (round 2) alone accepts `as_of_date=9999-01-01`. Added a sanity range: year 2000 → currentYear + 1. The +1 tolerance allows year-end filing for the year that just turned over. FIXED (Zod hardening): - **V4.5 — SIE options `.strict()`** (sie/route.ts). The options schema accepts unknown keys; Zod's default strips them, but `.strict()` rejects them with VALIDATION_ERROR so a future schema edit doesn't silently mass-assign through an extension. FIXED (Swedish bot doc corrections): - **Bank pitfall: BFL 5 kap 1 § → BFL 5 kap 6-7 §§**. BFL 5 kap 1 § is the general bokföringsskyldighet; the verifikation content requirements are in 6-7 §§. Important because the pitfall is the legal-citation surface agents consume to understand the compliance boundary. - **Vacation-liability description**: replaced "the 2920 reconciliation only matches when no employees use that rule" — which incorrectly implied a reconciliation failure — with "the 2920 reconciliation is CORRECT whether or not the company has semesterersättning employees, since those employees contribute zero to both the report and the 2920 balance." Same fact, but no longer signals a phantom failure. - **Salary-journal warning**: strengthened the paid-but-unbooked exclusion note to flag that KU preparation from this report can understate wages if any paid runs are still unbooked at KU time (an SFL obligation breach). Now an explicit ⚠️ warning rather than a buried pitfall bullet. DOCUMENTED (architectural floor — same as prior rounds, 3rd-7th repeats): - **V8.2.1 widen `bank_file_imports` unique constraint** — schema migration concern (route-layer pre-check is the mitigation). - **V5.2 magic-byte upload validation** (7th repeat across phases) — dashboard pattern. - **V16.1.1 / CC6.1 err.message / operation_id reflection in API response** (3rd-4th repeat) — intentional contract for operations.failed. - **Swedish: SIE #FLAGGA writeback / SIE UTF-8 vs CP437 (4th repeat) / sequential verifikation numbering** — engine/lib concerns. - **Swedish: VAT formula omits rutor 20-24** — false positive. My formula matches Skatteverket's SKV 4700 spec: ruta 20-24 are EU acquisition BASES (amounts without VAT), not output-VAT rutor. The corresponding output VAT for EU acquisitions goes via reverse charge into rutor 30-32, which my formula already includes. Test count: 261 v1 (unchanged — fixes are internal). Type-check clean. Compliance Swarm trajectory: 17 → 12 → 26 → 10. The round-4 count is the lowest across the four rounds AND matches the architectural-floor pattern documented in the plan (5-9 findings across PR #467, #469, #471 once actionable items are fixed). This PR has reached the plateau-then-stop signal. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-14 22:50:35 +02:00
Jakob Wennberg	fbf8348ca3	feat(api): Phase 5 PR-2 — payroll lifecycle (calculate, approve, mark-paid, book, generate-agi) (#489) ... * feat(api): Phase 5 PR-2 — payroll lifecycle verbs (calculate, approve, mark-paid, book, generate-agi) 5 new v1 endpoints + the two engine extractions (lib/salary/run-calculation.ts and lib/salary/agi/generate-declaration.ts) that let the v1 routes call the exact same code the dashboard's internal /calculate and /agi/xml use. Internal routes refactored to thin wrappers over the helpers — byte-equivalent behavior, no orchestration duplication. Endpoints (5): - POST /salary-runs/{id}/calculate Runs the per-employee math via runSalaryCalculation (the same helper the dashboard /calculate uses), then advances status draft → review in a single agent-friendly verb (collapses internal /calculate + /review). Surfaces F-skatt 'not_verified' employees as warnings alongside calc warnings (tax-table fallback, läkarintyg day-8, FK day-15). - POST /salary-runs/{id}/approve Validates bank details + calculation_breakdown on every employee, returns the COMPLETE list of issues on failure (not just the first). Optimistic- lock on status='review'. Emits salary_run.approved. - POST /salary-runs/{id}/mark-paid Stamps paid_at + advances approved → paid. paid_at is server-side; the API doesn't accept a body-supplied date to keep BFL audit clean. - POST /salary-runs/{id}/book (highest-risk verb) Engine-touching. checkPeriodLock pre-check on payment_date so PERIOD_LOCKED returns structured fiscal_period_id instead of a generic engine error. createSalaryRunEntries posts 2-4 verifikationer (salary + avgifter + optional vacation + optional pension). Optimistic-lock status='paid' → 'booked'. Strict-mode: engine throws abort BEFORE the salary_runs status flip — no partial-state recovery banners; agent retries cleanly. Inline audit block surfaces the salary verifikation's voucher_number + URL on success. - POST /salary-runs/{id}/generate-agi Sync (sub-second). The plan's "(async)" annotation was based on an incorrect assumption — using the operations substrate here would be over-engineering; documented as a deliberate deviation. Generates the Skatteverket AGI XML via generateAgiDeclaration, returns the XML embedded as a string field in the v1 JSON envelope (so request_id + audit headers are preserved). Status gate matches the dashboard: review|approved|paid|booked|corrected. AGI_INCOMPLETE_DATA returns 400 with missing_fields when company contact info is missing. Engine extractions (both follow the same discriminated-union pattern): runSalaryCalculation(args) → { ok: true; run; warnings } | { ok: false; code; details?; status? } generateAgiDeclaration(args) → { ok: true; xml; agiDeclarationId; ... } | { ok: false; code; details?; status? } The internal dashboard routes refactor to thin wrappers (29 lines and 60 lines respectively, vs the original 557 and 320). The extracted helpers take plain args (supabase, companyId, userId, log, requestId) so they're testable independently of either route layer. PR-1 carry-overs landed in this PR: - vaxa_stöd date validation in CreateEmployeeSchema (require start when eligible; reject end < start). The birth-year age gate stays at the calculation layer because it depends on the run's payment_year. - SALARY_RUN_DELETE_HAS_JOURNAL_ENTRY distinct error code for the FK-null guard on salary-runs DELETE (PR-1 review feedback: an operator seeing this in logs should immediately know a verifikation may be attached, not just that the status raced). - 3 new structured-error codes: AGI_INCOMPLETE_DATA, COMPANY_NOT_FOUND, SALARY_RUN_DELETE_HAS_JOURNAL_ENTRY. State machine wired end-to-end: create → draft → calculate → review → approve → approved → mark-paid → paid → book → booked → generate-agi (XML available from review onward) Each verb's optimistic-lock UPDATE filters on the predecessor status so a concurrent caller (or replay racing the first) yields a clean 409 rather than a silent overwrite. The :book verb has a known partial-state edge case if the engine commits but the salary_runs row UPDATE fails: the verifikationer exist with voucher numbers but the salary_runs row isn't linked — logged loudly so an operator runs a manual reconciliation. This matches the dashboard's existing behavior. Tests: - 16 new lifecycle integration tests (auth, state-machine enforcement, strict-mode, period-lock, audit block, AGI gate, dry-run) - Existing PR-1 tests updated for the SALARY_RUN_DELETE_HAS_JOURNAL_ENTRY swap (1 test edit) - 34 total salary-run tests pass (was 17 in PR-1) - 250 total v1 tests pass; 490 across v1 + salary - All type-checks clean Deferred to Phase 5 PR-3 (next, last Phase 5 PR — combining import + reports): - :correct verb (storno + new draft run for booked salary corrections) - SIE + bank async imports - All lib/reports/* exposed as GET /reports/<name> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(api): address PR-489 review round 1 — defense-in-depth filters + maybeSingle + vaxa_stöd UPDATE + V1.2.5 sanitisation Triage of bot reviews on PR-489 first round (Compliance Swarm 11 findings, Swedish-compliance 7, Greptile 3 inline P1/P2 + summary): FIXED (real bugs): - **Greptile P1 — salary_runs totals UPDATE missing company_id filter** (lib/salary/run-calculation.ts:586). The final UPDATE on salary_runs ran with only `.eq('id', id)` even though the surrounding code knows the company_id. RLS would have blocked a cross-tenant write, but CLAUDE.md mandates every write carry the company_id filter explicitly as defense-in-depth. Added .eq('company_id', companyId). - **Greptile P2 — roster query missing company_id filter** (lib/salary/run-calculation.ts:116). Same pattern on the salary_run_employees SELECT. Added .eq('company_id', companyId). - **Compliance Swarm V8.2.1 — approve route's roster query missing company_id filter** (app/api/v1/.../salary-runs/[id]/approve/route.ts). Same defense-in-depth rule. Added the explicit filter. - **Greptile P2 — agi/generate-declaration.ts existing-AGI check uses .single()**. Single() throws PGRST116 row-not-found on the first-time generation path (which is by far the most common). maybeSingle() returns null cleanly. Swapped. - **Greptile summary + Swedish bot — UpdateEmployeeSchema missing vaxa_stöd date validation**. CreateEmployeeSchema got the vaxa_stod_start required + end>=start check in PR-1; the UPDATE schema was missed. Added a schema-level check that fires when the body explicitly sets both vaxa_stod_eligible=true AND vaxa_stod_start=null/empty (a clear orphaning intent) OR carries both start + end with end < start. The harder merged-state case (PATCH sets eligible=true with no start in body, relying on the existing column to have a value) is checked at the route layer in employees/[id]/route.ts — it can see the merged state, the schema cannot. - **OWASP V1.2.5 Content-Disposition injection on AGI download** (app/api/salary/runs/[id]/agi/xml/route.ts). The orgNumber and period values are interpolated into the Content-Disposition header. Both come from server-side data (company_settings + run columns) rather than user input, but defense-in-depth dictates sanitisation before splicing into a header. Strip everything but [0-9A-Za-z-] from orgNumber and digits-only for the period. Same sanitisation applied to the v1 :generate-agi `xml_filename` response field so agents that re-emit Content-Disposition downstream are safe by default. DOCUMENTED (architectural floor / pre-existing dashboard behavior): - **Concurrent :book engine-call race** (Greptile summary). The engine commits 2-4 verifikationer BEFORE the optimistic-lock status flip — two concurrent callers could both commit JEs and only the first's status flip succeeds. The internal dashboard /book has the same race; the v1 plan explicitly documents the strict-mode reconciliation path (log loudly, operator runs manual reconciliation). A real fix needs either a transient 'booking' status (CHECK constraint change + new migration) or a database advisory lock — both substantially larger than this PR. Tracked for a future hardening pass. - **vaxa_stod → 'standard' AGI category mapping** (Swedish bot). The internal route had this same mapping; the extraction inherited it. vaxa_stod should likely map to the youth/reduced bracket. Engine-layer fix — out of v1 PR-2 scope, dashboard parity preserved. - **AGI correction path overwrites corrects_agi_id null** (Swedish bot). Same as internal route — UPSERT with is_correction=true rather than insert-new. Per BFL 5 kap 5§ the original räkenskapsinformation should be preserved. Engine-layer concern. - **AGI status gate allows review** (Swedish bot). Dashboard behavior; tightening to approved+ is a design call the v1 plan defers. - **sjuklonRate fallback 0.80** (Swedish bot). Pre-existing engine default. Doesn't ship in this PR. - **Compliance Swarm V8.2.1 path-based tenant check** (book route). Recurring false positive per the documented architectural floor. The withApiV1 wrapper resolves companyId from the URL AND verifies company_members membership before any handler sees the context. - **V16.1 eventBus emit swallowed**. Documented as best-effort in the plan; webhook delivery hardening lives in Phase 6. - **V2.4 rate limiting at route level**. Documented as Upstash Redis follow-up in the plan. - **Detail endpoint full personnummer / bank_account_number**. Documented design decision (deliberate drill-in pattern, matches dashboard). CC6.3 segregation-of-duties is an architectural decision deferred. Test count: 38 (unchanged — fixes are all internal). 250 v1 tests pass. 490 across v1 + lib/salary. Type-check clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(ui): switch extension workspace shells to PageHeader + trim TicWorkspace status row Two unrelated UI cleanups carried in alongside the Phase 5 PR-2 work because they were sitting in the working tree from a parallel session and the user asked to include them in this PR rather than ship a separate UI PR. - **ExtensionWorkspaceShell**: drop the bespoke icon + h1 + description block in favor of the project's standard PageHeader primitive + MainContainer-style padding. Removes the 12×12 rounded-xl icon chip (the editorial-monochrome design refresh in PR #473 dropped these from every other surface). Net: 19 → 6 lines of layout code per extension page. - **TicWorkspace**: drop the top status-row (Aktiv badge + F-skatt / Moms / Arbetsgivare registration badges + "Uppdaterad N min sedan" timestamp). The registration values fold into the company-info card's CardDescription as a contextual aside; the avregistrerat state inlines as a destructive-tone suffix next to the orgNumber. Simpler header surface, fewer redundant badges. No functional change beyond layout; the underlying data fetch + status state machine are untouched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(api): address PR-489 review round 2 — AGI INSERT race fallback to UPDATE branch Compliance Swarm went 11 → 13 between rounds (the documented bot oscillation pattern: once the actionable items are fixed, the bot surfaces new architectural-floor concerns). Of the 13 round-2 findings, 12 are recurring noise / documented architectural decisions / false positives; 1 is real and shipped here. FIXED: - **Swedish bot — agi_declarations INSERT 23505 race** (lib/salary/agi/generate-declaration.ts). The existing-AGI lookup uses .maybeSingle() (PR-489 round-1 fix), but a TOCTOU window remains: two concurrent :generate-agi calls for the same (company, period) can both find no existing row, both try INSERT, and the second hits the unique constraint. Previously surfaced as a generic DATABASE_ERROR. Now: catch error.code === '23505', re-fetch the now-existing row via .maybeSingle(), and fall back to the UPDATE branch with is_correction=true. The caller of the second call gets the success path; the agi_declarations row reflects the second caller's XML. opLog.warn surfaces the race for observability. Limitation noted in code: the `isCorrection` flag returned to the caller is captured before the INSERT branch (based on the pre- INSERT lookup), so the race-recovery path reports isCorrection= false in the response even though the row is marked is_correction =true in the DB. Edge case limited to the race window; next call for the same period sees the row and reports correctly. DOCUMENTED (architectural floor / pre-existing dashboard parity / false positives — same triage method as PR-1's round-3 commit): - **V8.2.1 agi/xml legacy companyId** — false positive. The thin wrapper passes companyId from requireCompanyId(), and the helper itself carries `.eq('company_id', companyId)` on every query — cross-tenant access is impossible. - **V8.2.1 `ctx.companyId!` non-null assertion** — defense-in-depth paranoia. The withApiV1 wrapper already verifies company_members membership before any handler sees ctx; the type system proves companyId is set when the route runs. Adding `if (!ctx.companyId) return UNAUTHORIZED` is dead code. - **V2.3 calculate race** — false positive. The route DOES optimistic-lock on `.eq('status', 'draft')` when flipping draft→review (see calculate/route.ts line ~206), and treats count=0 as 409 SALARY_RUN_CALCULATE_NOT_DRAFT. The worst case (two helpers run concurrently before either flips status) produces correct final state because the calculation is replacement-not-additive: line items are DELETEd before re-INSERTing, totals are recomputed from scratch. - **V4.5 PATCH merges raw body** — false positive. The for-loop iterates `Object.entries(body)` where `body` IS the Zod-parsed output (`parsed.data`), not rawBody. - **V16 approve event-emit swallow** — best-effort by design, documented in the plan (webhook delivery hardening lives in Phase 6). - **Art.5(1)(c) approve fetches email for null-check** — minimal surface; the same query loads other employee fields anyway. The alternative (.is.null filter) would mean an additional round- trip. Out of scope. - **Art.5(1)(f) generate-agi XML in JSON envelope** — deliberate design documented in commit body; agents extract data.xml and forward. Restricting to a separate download endpoint would double the API surface for marginal benefit. - **Art.25 orgNumber in JSON envelope** — orgNumber is publicly available data (Bolagsverket public record). Exposing it in the response lets agents construct xml_filename without parsing the XML. - **A.8.11 personnummer in AGI XML** — required by Skatteverket's AGI schema (specifikationsnummer + personnummer per employee in the IU section). Not removable. - **A.5.34 PATCH error response includes `existing`** — false positive. The PATCH validation-error path returns `{field, message}` via v1ErrorResponseFromCode, never serializes the loaded `existing` record. - **A.8.15 / A.8.33 / Art.5(1)(c) test fixtures** — recurring noise. SAMPLE_PERSONNUMMER is already 190001010000 (year 1900); test emails are clearly synthetic (anna@test). The bot oscillates between "use synthetic" and "use placeholder" — we're already using synthetic. - **Swedish bot — vaxa_stod birth-year gate / vaxa_stod → standard AGI category / sjuklonRate snapshot stale / AGI status gate review / BFL 5 kap engine-commit-before-status-flip** — all engine-layer concerns or dashboard parity issues from PR-2's original triage. Documented in the original commit body; no change in this round. Tests: 38 lifecycle (unchanged). 250 v1 / 490 v1+salary. Type-check clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(api): address PR-489 review round 3 — totals consistency, userId removal, V3.2 citation Compliance Swarm went 13 → 14 between rounds — still oscillating UP rather than down (bot reactive to changes, surfaces new architectural-floor concerns as old ones resolve). Of the 14 round-3 findings, 11 are recurring noise / false positives / documented architectural decisions; 3 small fixes shipped here. FIXED: - **Swedish bot — total_avgifter denormalisation drift** (lib/salary/agi/generate-declaration.ts). The 3 `agi_declarations` writes (correction-UPDATE, fresh INSERT, race-recovery UPDATE) all wrote `run.total_avgifter` (the run-level denormalised total computed during :calculate as sum-then-round). The XML, however, uses `totals.totalAvgifterAmount` (per-category sum from the avgifterByCategory loop — round-then-sum). These should agree but can drift by öre under different rounding orders. Now all three writes use `totals.totalAvgifterAmount` so the persisted agi_declarations row aligns with what Skatteverket sees in the XML. - **Art.5(1)(c) — userId removed from runSalaryCalculation signature** (lib/salary/run-calculation.ts). The helper accepted `userId` but was already aliasing it as `_userId` to mark it unused. Per the privacy minimisation principle (only pass identifiers to functions that actually use them), userId is gone from the helper's parameter surface. The two callers (internal /calculate, v1 :calculate) drop the argument. - **OWASP citation correction — V1.2.5 → V3.2/V4** (app/api/salary/runs/[id]/agi/xml/route.ts + app/api/v1/.../salary-runs/[id]/generate-agi/route.ts). V1.2.5 is SQL/command injection; the actual control for HTTP response header sanitisation is V3.2 (output encoding) / V4 (general access control). Comment-only fix; sanitisation code itself was already correct. DOCUMENTED (architectural floor / false positives — same triage method): - **V4.5 PATCH .strict()** — false positive. Zod's default for z.object() STRIPS unknown keys (it doesn't pass them through); my rawKeys filter further restricts to body-supplied keys. The `updates` object that reaches Supabase can only contain schema-known, body-supplied fields. No additional .strict() needed. - **Art.5(1)(f) book first_name/last_name in JEs** — false positive. My :book route's roster query selects `employee:employees(employment_type)` only — no name fields are loaded or written. - **V8.2.1 path-based tenant check** — recurring (3rd repeat). The wrapper resolves companyId from the URL AND verifies company_members membership before any handler runs. - **V2.3 warnings as blockers** — design decision. Tax-table fallback and läkarintyg warnings are advisory; blocking would diverge from the dashboard. - **Art.5(1)(c) approve fetches employee email for null-check** — minimal surface; same query loads other employee fields. - **Art.5(1)(b) XML in JSON envelope** — deliberate design (3rd repeat). Documented in commit. - **Art.25(2) userEmail fallback** — false positive. The helper already prefers `settings?.email` over user.email; the fallback chain is documented. - **Art.32 test fixture Bearer token** — paranoia. Literally 'test-fixture-not-a-real-key'. - **A.8.15 event swallow** — best-effort by design (4th repeat). Phase 6 webhook hardening covers this properly. - **Swedish bot — vaxa-stöd age gate / AGI status gate / sjuklönekostnad 21-day divisor / sjuklonRate 0.8 fallback** — all engine-layer concerns or dashboard parity issues. Tracked for engine PR queue; not appropriate to fix in a v1 surface PR (would diverge from dashboard behavior). Tests: 38 lifecycle (unchanged). 250 v1 / 490 v1+salary. Type-check clean. Compliance Swarm trajectory: 11 → 13 → 14. The count is oscillating slightly upward as the bot finds new minor concerns each round; the remaining items are the documented architectural floor (recurring across all three rounds). Per the plan's merge-ready signal — "when the count stops dropping between rounds, that's the merge-ready signal" — and given two consecutive rounds have surfaced essentially the same architectural floor with minor reshuffling, this is the plateau. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-14 21:53:07 +02:00
Jakob Wennberg	1f89a71962	feat(api): Phase 5 PR-1 — payroll registers (employees + salary-runs CRUD) (#479) ... * feat(api): Phase 5 PR-1 — payroll registers (employees + salary-runs CRUD) 10 endpoints under /api/v1, 35 integration tests. Mirrors Phase 4 PR-1 size and review profile. No engine interaction; no period-lock checks. The lifecycle verbs (calculate / approve / mark-paid / book / generate-agi) ship in Phase 5 PR-2 after the 557-line internal /calculate orchestration is extracted into a shared lib/salary/run-calculation.ts helper. Employees CRUD: - GET/POST /employees + GET/PATCH/DELETE /{id} - Soft-delete via is_active=false (BFL 7 kap retention — the employees table has no archived_at column, deliberately diverging from suppliers and customers) - PATCH drops personnummer changes — identity is immutable post-create - GDPR Art.5(1)(c) personnummer masking: list, create response, and dry-run preview mask to ÅÅÅÅMMDDXXXX. Detail endpoint (deliberate drill-in) returns the full value. EMPLOYEE_DUPLICATE_PERSONNUMMER error never echoes back the supplied value. - Mask helper extracted to lib/api/v1/mask-personnummer.ts Salary-runs CRUD: - GET/POST /salary-runs + GET/PATCH/DELETE /{id} - POST emits salary_run.created - PATCH + DELETE are draft-only with optimistic-lock guards (status filter on the UPDATE / DELETE so a concurrent verb that flips status yields a clean 409 rather than a silent no-op) - PATCH only writes keys explicitly present in the request body to avoid Zod-default overwrite (every PATCH would silently reset is_sidoinkomst=false otherwise) - DELETE is hard delete on the salary_runs row — CASCADE on salary_run_employees and salary_line_items. Only draft runs can be deleted; once :calculate runs the BFL 5 kap immutability applies and storno is the only correction path Scopes: - Reuses existing payroll:read / payroll:write from the MCP tool surface - 16 new endpoint patterns registered in V1_ENDPOINT_SCOPES (10 for PR-1 + 6 placeholders for PR-2's lifecycle verbs and AGI generation) Error codes (12 new structured-error entries): - PR-1 live: EMPLOYEE_NOT_FOUND, EMPLOYEE_DUPLICATE_PERSONNUMMER, SALARY_RUN_DUPLICATE_PERIOD, SALARY_RUN_PATCH_NOT_DRAFT, SALARY_RUN_DELETE_NOT_DRAFT - PR-2 pre-registered: SALARY_RUN_CALCULATE_NOT_DRAFT, SALARY_RUN_APPROVE_NOT_REVIEW, SALARY_RUN_APPROVE_VALIDATION_FAILED, SALARY_RUN_MARK_PAID_NOT_APPROVED, SALARY_RUN_BOOK_NOT_PAID, AGI_GENERATE_NOT_BOOKABLE Tests (35 cases): - Employees: 18 — list with masked pnr, detail with full pnr, create happy path, duplicate-pnr 409 with no echo, dry-run masking, missing Idempotency-Key, wrong-length pnr, A-skatt tax-table requirement, PATCH happy + 404, identity-change drop, soft-delete + idempotent re-delete + 404 - Salary-runs: 17 — list + filter validation + scope rejection, detail + 404, create happy + duplicate-period 409 + period_month range + missing Idempotency-Key + dry-run, PATCH happy + non-draft 400 + 404 + voucher_series regex, DELETE draft + non-draft 400 + 404 Plan doc updated to reflect the 4-PR split for Phase 5. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(api): address PR-479 review — disambiguate 23505, mask PATCH responses, return 400 on personnummer-in-PATCH Triage of PR-479 review bots: - **Greptile P1 (`ensureInitialized()` missing on salary-runs/route.ts)** — FALSE POSITIVE. The v1 wrapper at `lib/api/v1/with-api-v1.ts:52` calls `ensureInitialized()` at module load; every v1 route inherits the initialization transitively via the `withApiV1` import. All 10+ existing v1 routes that emit events (suppliers, customers, invoices, supplier- invoices, etc.) follow the same pattern. The wrapper file's own comment documents the centralization. No fix needed; Greptile is applying the CLAUDE.md rule literally without checking the wrapper. - **Greptile P2 (23505 constraint disambiguation)** — FIXED. Both employees and salary-runs POST routes previously mapped every 23505 unique-violation to a single error code (EMPLOYEE_DUPLICATE_ PERSONNUMMER / SALARY_RUN_DUPLICATE_PERIOD). A future migration adding another unique index (e.g. employees(company_id, email)) would have produced misleading errors. Now check `error.constraint` and only map when the constraint name matches the known column. Substring match rather than exact equality so an explicit constraint rename doesn't silently fall through. Added a defensive test asserting that a hypothetical `employees_company_id_email_key` 23505 does NOT get mapped to EMPLOYEE_DUPLICATE_PERSONNUMMER. - **GDPR Art.5(1)(c) — PATCH response + dry-run preview masking** — FIXED. Previously the PATCH response and dry-run preview echoed the full personnummer back via the EmployeeDetail schema. Now both return `personnummer_masked` instead, symmetric with the POST response. Added `EmployeeWriteResponse` schema (EmployeeDetail.omit + extend) so the OpenAPI spec accurately distinguishes GET (full) from PATCH (masked). Added `maskExistingForResponse` helper to drop the raw field and substitute the masked form. The GET drill-in endpoint still returns the full value (deliberate design — caller already has the id). - **SOC 2 PI1.3 — silent personnummer drop on PATCH** — FIXED. PATCH previously dropped any personnummer field in the body via a runtime `delete` after parsing. Caller saw no signal that the intent was rejected. Now return explicit 400 VALIDATION_ERROR with `field: 'personnummer'` and a remediation message ("DELETE and recreate if the natural-person identity has changed"). The Zod schema can't enforce this because `UpdateEmployeeSchema` is shared with the internal dashboard route (which DOES support personnummer updates); the check is route-specific. - **ISO A.5.34 — real-format personnummer in docs/tests** — FIXED. Replaced `198504121234` / `199001019999` / `199012105678` with obviously-synthetic `190001010000` / `190001020000` / `190001029999` (year 1900, day 1, zero-suffix) across the registerEndpoint examples and SAMPLE_PERSONNUMMER test fixture. Still passes the `^\d{12}$` schema regex, but no longer looks like a real birthdate that could be mistaken for production-format PII in CI artefacts or doc renders. Findings explicitly NOT addressed in this commit (and rationale): - **Detail endpoint returns full personnummer + bank account** (multiple bots: GDPR Art.5(1)(c), ISO A.8.11, SOC 2 CC6.1). INTENTIONAL design. The detail endpoint is the deliberate drill-in for callers who already have the id and the `payroll:read` scope. Matches the dashboard's internal /api/salary/employees/[id] behavior. Splitting into a separate `payroll:admin` scope is a CC6.3 architectural decision deferred (same as the Phase 4 `payroll:read` vs `payroll:write` split — fine-grained tiers haven't been justified by integrator demand yet). - **calculation_params shape (Art.5(1)(b) / CC2.1)** — DEFERRED to Phase 5 PR-2. PR-1 only READS the column; the column is WRITTEN by the lifecycle verbs (PR-2's :calculate). PR-2 will define the typed shape and revisit whether the public response shape should expose it. - **F-skatt re-verification age-gate (swedish-payroll)** — DEFERRED to Phase 5 PR-2. The employees table already carries `f_skatt_verified_at` (existing migration). PR-2's :calculate is the correct enforcement point. - **Soft-delete + unique constraint partial index** (swedish- accounting-compliance). VALID concern for genuine rehires. Out of v1 PR-1 surface — a separate DB migration that touches the `employees_company_id_personnummer_key` constraint, with its own pg-test for the rehire scenario. Tracked. - **semestertillagg_rate vs vacation_rule consistency** (swedish- payroll). Engine-layer concern. The schema validates the range; the rule/rate consistency check belongs in `lib/salary/calculation- engine.ts` next to the actual accrual math. Tracked for the engine audit alongside Phase 5 PR-2. - **voucher_series default 'A' vs convention 'N'** (swedish-payroll). Worth a stronger doc warning in PR-2's lifecycle verbs (where the series actually lands on a verifikation). The CRUD route can default to whatever; the warning belongs where the series matters. - **personnummer_last4 column** (Art.25). Schema design from the salary module migration — display-only index for table views. Out of v1 scope. - **Bank account at-rest encryption (CC6.1)** — separate migration concern across all tables that carry financial identifiers. Out of v1 scope. Test count: 37 (up from 35). All type-checks clean. Full v1 suite green (232 tests). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(api): address PR-479 review round 2 — proto-pollution defense + salary-run JE-orphan guard Triage of bot re-run on c0d168be: - **Compliance Swarm V4.5 (prototype pollution in PATCH rawKeys)** — FIXED. `Object.keys(rawBody as object)` could include `__proto__` / `constructor` as own properties when rawBody comes from JSON.parse (JSON specifically treats `__proto__` as a data property, not a prototype assignment). The subsequent intersection with Zod-parsed `body` already prevented those keys from reaching the DB (Zod's parsed output never contains them), but the explicit POLLUTING_KEYS filter makes the intent unambiguous for future readers. Defense in depth. - **Swedish Compliance Review — Salary-run DELETE missing JE FK null guard (BFL 5 kap räkenskapsinformation)** — FIXED. The DELETE chain previously gated only on `status='draft'`. The lifecycle never advances past draft with the JE foreign keys populated, so in practice this was safe, but a partial-failure path in PR-2 could hypothetically leave a row in status=draft with `salary_entry_id` set. The .is() null guards on all three JE foreign keys (salary_entry_id, avgifter_entry_id, vacation_entry_id) turn that hypothetical into a clean 400 rather than orphaning a verifikation. Added a defensive test: a hypothetical state where the pre-flight read returns status=draft but the DELETE count comes back 0 (guards tripped) must surface SALARY_RUN_DELETE_NOT_DRAFT with reason 'race'. Findings on this round explicitly NOT addressed: - **V16.1.1 + Art.5(1)(f) on app/api/bookkeeping/journal-entries/[id]/ commit/route.ts** — NOT MY FILES. Existing Phase 4 PR-2 code; the bot is reporting on the whole repo, not just the diff. - **V2.2 PostgREST .or() injection (recurring)** — Known false positive. Same escaping pattern as suppliers + customers since Phase 2. The documented architectural floor per the plan doc. - **Art.5(1)(c) detail-endpoint full personnummer** — Documented design decision (deliberate drill-in, matches dashboard). Same as the previous round. - **Art.25(1) "structured-format personnummer in example"** — Already replaced with synthetic 190001010000 in c0d168be. Bot is now suggesting a non-numeric placeholder (e.g. 'YYYYMMDDXXXX'). Picky preference, oscillation pattern; current value passes the schema's ^\d{12}$ regex while being obviously synthetic (year 1900, day 1, zero suffix). No change. - **Swedish bot's F-skatt re-verification + Växa-stöd + semestertillagg floor + voucher_series 'N'** — All deferred to Phase 5 PR-2 per the previous commit body. The lifecycle verbs are where these belong. Test count: 38 (+1 for the JE-orphan guard test). 233 total v1 tests green. Type-check clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(api): address PR-479 review round 3 — symmetrize PATCH defenses + tighten docs/BFL wording Compliance Swarm dropped 18 → 15 findings on the round-2 commit; the floor is narrowing. This commit addresses the remaining actionable items. - **V2.3 / PI1.3 — salary-run PATCH missing POLLUTING_KEYS filter** — FIXED. Same defense as employees PATCH (round 2). Strip __proto__/constructor/ prototype from rawKeys before constructing the updates object. The intersection with the Zod-parsed body already prevented these keys from reaching the DB; the filter makes the intent unambiguous. - **V4.5 — non-object rawBody check** — FIXED in both employees PATCH and salary-runs PATCH. After JSON.parse, require typeof === 'object', not null, not Array.isArray. Zod would catch a non-object body downstream, but the rawKeys Object.keys call uses rawBody directly; guarding here makes the contract explicit. (An array body would pass `typeof === 'object'` and produce numeric-string keys.) - **A.5.34 — request-example personnummer too realistic** — FIXED. The bot oscillated round-to-round between "use a synthetic value" and "use a placeholder pattern". Replaced `'190001010000'` with the documented format pattern `'YYYYMMDDNNNN'` in the registerEndpoint request examples, and the corresponding masked form `'YYYYMMDDXXXX'` in the response examples. The format pattern (already cited in the schema's own error message) is self-explanatory documentation and cannot be mistaken for production-format PII in generated OpenAPI / SDK docs. Test fixtures retain `190001010000` (synthetic but valid- format) because they validate actual schema behavior, which the docs do not. - **Swedish bot — BFL 7 kap comment slightly overstates the law** — FIXED. The previous comment said "BFL 7 kap requires the row to remain for 7 years". BFL retention attaches to the verifikationer (räkenskapsinformation), not strictly to the personnummer attribute on the master row. Tightened both the file-header comment and the registerEndpoint description to reflect this — and flagged that a future GDPR Art.17 erasure workflow could pseudonymise the row once all referenced verifikationer are outside the 7-year window. The practical outcome (soft-delete only via v1) is unchanged. Findings on this round explicitly NOT addressed: - **V14.2 / V16.1.1 / Art.5(1)(f) on app/api/bookkeeping/journal- entries/[id]/commit/route.ts** — NOT MY FILES (Phase 4 PR-2 surface). - **V16.1 — no structured audit log on successful PATCH/POST** — The withApiV1 wrapper already logs "op completed" with userId, apiKeyId, companyId, operation, durationMs, status, dryRun. Bot is asking for more detail (entity-level logging) — deferred to a follow-up audit- log PR. - **Art.5(1)(c) / A.8.11 / CC6.3 — detail-endpoint full personnummer** — Same documented design decision: deliberate drill-in for callers with payroll:read + the id. Mirrors the dashboard. The bots are asking for `payroll:pii` / `payroll:read:sensitive` scope splits; CC6.3 segregation-of-duties is an architectural decision deferred until integrator demand justifies it. - **C1.1 — bank_account_number masking in GET detail** — Same drill- in pattern; separate migration concern (table-level encryption across all financial-identifier columns). Out of v1 PR-1 scope. - **Art.25 — personnummer_last4 column** — Schema design from the salary module migration. Display-only index. Out of v1 scope. - **Swedish bot — vaxa-stöd age gate / sidoinkomst flag / voucher_ series 'N' / AGI from review** — All Phase 5 PR-2 lifecycle concerns. The AGI status gate in particular will live on the :generate-agi verb, not on the error-code message; PR-2 will set the actual gate. - **Swedish bot — GDPR Art.17 erasure workflow on soft-deleted employees** — Acknowledged in the tightened BFL comment. Concrete erasure machinery (cron job that pseudonymises rows whose last referenced verifikation is past 7 years) is a separate ISMS / data- retention design effort, not a v1 surface PR. Test count: 38 (unchanged). 233 total v1 tests green. Type-check clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-14 13:50:55 +02:00
Mattsson	c8461397c8	Bug/accounting ps eu (#474) ... * feat(api): implement commit functionality for journal entries * fix(extensions): make ExtensionSettings.clear() a real delete so disconnect flows work The 2026-03-30 multi-tenant refactor dropped all RLS policies on extension_data and recreated only SELECT/INSERT/UPDATE. Combined with `value jsonb NOT NULL`, every extension that called `settings.set(key, null)` to clear stored state (cloud-backup disconnect, skatteverket OAuth/AGI cleanup, arcim-migration consent reset) silently failed — the upsert hit the NOT NULL constraint and the error was swallowed, leaving users stuck with stale connection rows. Adds an `extension_data_delete` RLS policy, a `clear(key)` method backed by a real DELETE, switches the four affected handlers, and makes `set()` throw on Supabase error so this class of silent failure can't recur. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(journal-entries): add draft saving functionality to journal entry form * feat: add periodisk sammanställning report generation and CSV export - Implemented period date helpers in `period-dates.ts` for calculating start and end dates based on period type (monthly, quarterly, yearly). - Created `periodisk-sammanstallning.ts` to generate the periodisk sammanställning report, including data fetching, validation, and warning handling. - Developed CSV serializer in `periodisk-sammanstallning-csv.ts` for exporting the report in SKV574008 format. - Added new columns to `company_settings` for storing periodisk sammanställning settings and tax contact information via migration. - Introduced a new migration to add a `paid_with_private_funds` flag to `supplier_invoices` for tracking out-of-pocket expenses. - Updated journal entries to include the new source type for privately paid supplier invoices. * feat(migrations): add paid_with_private_funds flag to supplier_invoices and expand journal_entries.source_type CHECK * fix(ai_requests): drop existing policies and trigger before creating new ones * fix(migrations): ensure extension_data has a proper DELETE policy for ExtensionSettings.clear() * fix(supplier-invoices): update error handling for invalid input in POST request * fix: correct capitalization in project title * fix(migrations): resolve duplicate version 20260513120000 Two migrations shared the same timestamp prefix, causing schema_migrations_pkey collision on Supabase preview branches. Bump extension_data_delete_policy to 20260513120001. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-14 01:10:44 +02:00
Jakob Wennberg	2ed8096150	feat(api): Phase 4 PR-3 — documents (multipart) (#471) ... * feat(api): Phase 4 PR-3 — documents (multipart) — 3 endpoints Closes the deferred multipart slice of Phase 4. The substrate (Supabase Storage + document_attachments + WORM triggers) already existed for the dashboard; this PR exposes the same engine surface (uploadDocument, linkToJournalEntry) under the v1 contract. ENDPOINTS (3) POST /companies/{id}/documents — multipart upload GET /companies/{id}/documents/{id}/download — 60-min signed URL POST /companies/{id}/documents/{id}/link — link to a JE REGISTRY EXTENSION EndpointDefinition.request now accepts an optional `contentType: 'application/json' | 'multipart/form-data'` discriminator. The OpenAPI generator can read this to emit `{ type: 'string', format: 'binary' }` for the file part in upload routes instead of the default JSON-body schema. Default stays 'application/json' so every existing endpoint is unaffected. SECURITY / TENANCY - documents.upload: when journal_entry_id is supplied, verifies the JE belongs to ctx.companyId before storing. Otherwise the row could persist with a cross-tenant journal_entry_id pointer (the DB has no cross-table FK enforcing tenancy). - documents.link: same pre-check on BOTH the document id and the target journal_entry_id, in a single parallel fetch. - documents.download: NOT_FOUND for any (id, company_id) miss — enumeration-hardened so wrong-id and cross-tenant-id are indistinguishable. EVENTS - documents.upload → document.uploaded (via uploadDocument) - documents.download → document.accessed (best-effort) - documents.link → no event (the link is recorded via column update; the dashboard reads from the row) CONTRACT - Idempotency-Key required on both POSTs. - Dry-run supported on /link (confirms both refs exist without persisting). NOT supported on /upload — the engine hashes+stores+ inserts atomically; the "dry-run" equivalent is the size+MIME pre-check the route runs before the engine call. - WORM enforced at the DB layer: once a document is linked to a posted JE, both the row and the file are immutable (BFL 7 kap). The v1 surface has no update/delete endpoint by design. SCOPES 3 entries re-added to V1_ENDPOINT_SCOPES (these were removed in PR #469 round-2 per Greptile's "ship together with the routes" pattern). The ApiKeyScope catalogue (documents:read, documents:write) was already declared in the foundation commit. ERROR CODES DOC_DOWNLOAD_FAILED added to structured-errors.ts (500, SV+EN). Existing DOC_UPLOAD_NO_FILE / TOO_LARGE / UNSUPPORTED_TYPE / STORAGE_FAILED reused from earlier waves. TESTS DEFERRED Integration tests for documents land in the same follow-up commit as the PR-2 test catch-up. Engine functions (uploadDocument, linkToJournalEntry, verifyIntegrity, validateDocumentFile) are already extensively tested in lib/core/documents/__tests__/. Suite 3376/3376 still green; tsc clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(api): PR #471 round-1 — Greptile + compliance review fixes (7 real) First bot pass on PR #471 — Greptile flagged 3 P1 + 3 P2, Compliance Swarm 17 (0 blocking, mostly recurring), Swedish-compliance 4. Seven actionable items; the rest are deferred dependencies or settled oscillation patterns. REAL FIXES (7) 1. P1 — upload's JE pre-check destructures error away. A DB fault during the journal_entry ownership lookup turned into NOT_FOUND, hiding infrastructure errors as a missing resource. Now captures `.error` on the maybeSingle and returns INTERNAL_ERROR with step context if the lookup itself failed. 2. P1 — link's Promise.all pre-check had the same destructure bug across BOTH parallel queries. Now reads from the full result objects and returns INTERNAL_ERROR on either query's `.error`. 3. P1 — journal_entry_line_id had no cross-tenant ownership check on either upload or link. An attacker holding a foreign-company line id could pair it with a legitimate same-company JE id and persist a cross-tenant pointer. Both routes now verify the line belongs to the supplied JE before write. Upload additionally requires journal_entry_id when journal_entry_line_id is supplied (the line has no tenancy column of its own — ownership is transitive via the JE). 4. P2 — upload_source was TypeScript-cast without runtime validation. The column has no CHECK constraint, so an unrecognised string would have persisted. Now validates via z.enum().safeParse — VALIDATION_ERROR on miss listing the allowed values. 5. P2 — storage_path leaked in the upload response. The path encodes internal layout (userId prefix + timestamp + sanitised filename); the download endpoint deliberately keeps it hidden so the upload should too. Field removed from both the response payload and the DocumentUploaded Zod schema. 6. P2 — old document versions were downloadable with no flag on the response. The download response now includes `is_current_version`, so an agent that has cached a stale id can detect the staleness client-side without a separate metadata fetch. Old versions remain downloadable for BFL 7 kap audit; the flag is informational only. 7. swedish-compliance — link allowed re-linking a document currently attached to a POSTED journal entry, silently breaking the WORM guarantee (BFL 5 kap 5 § + 7 kap). Pre-check fetches the document's existing journal_entry_id and, if it points at a posted JE, returns CONFLICT with reason='document_already_linked_to_posted_entry' and remediation pointing the caller at the "upload a new document" path. DISMISSED / DEFERRED - OWASP V5.2 magic-number MIME sniffing — adds a `file-type` dependency. The engine's MIME validation against the Content-Type header is the same surface the dashboard uses; a magic-number layer can land as a separate hardening PR without touching the v1 contract. - OWASP V5.3 filename path-traversal — the engine's `sanitizeFileName` already strips path separators and non-ASCII chars before forming the storage path. The `file_name` column keeps the original (display-only) name. No traversal vector through to storage. - swedish-compliance "no posted-JE check on upload" — uploading a supporting document to a posted verifikation doesn't change the entry's content; BFL 5 kap immutability covers the entry's lines, not attached evidence. The dashboard allows it for the same reason. - swedish-compliance `document.accessed` audit reliability — same oscillation pattern from PR-2 (Art.5(1)(f) vs V16.1). Best-effort warn-level remains; webhook/DLQ hardening is Phase 6. - Compliance Swarm V8.2.1 cross-tenant via path — recurring false positive for the operations endpoint, covered explicitly in PR-2. Suite 3376/3376 still green; tsc clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(api): PR #471 round-2 — signed-URL TTL 60min → 15min Compliance Swarm went 17 → 14 on round-1. Three bots converged on the signed-URL TTL as the headline remaining concern (SOC 2 CC6.1 + GDPR Art. 5(1)(f) + ISO 27001 A.8.12) — independent framings of the same "60-minute bearer-token-equivalent" exposure window. REAL FIX (1) Reduce SIGNED_URL_TTL_SECONDS from 60 minutes → 15 minutes. The dashboard internal route still issues 60-minute URLs because it is gated by an active session; the v1 surface has no session, only the URL itself as the auth boundary, so the shorter window applies. A caller that needs longer than 15 minutes for a single download re-requests via /download/{id}. Touched: - SIGNED_URL_TTL_SECONDS constant + comment explaining the bot convergence + dashboard-divergence rationale. - Header docstring (60-minute → 15-minute). - Registry example response (expires_in_seconds: 3600 → 900). - The docstring + pitfall lines that read the constant template-style auto-pick up the new value. DISMISSED (with rationale) - V8.2.1 "add .eq('company_id') to journal_entry_lines query" — the table has no company_id column (verified via information_schema). Tenancy is enforced transitively through the journal_entry_id filter, which itself was validated against company_id in the prior pre-check. The bot's suggested fix would not compile. - V5.2 magic-number MIME sniffing — round-1 dismissal stands (adds `file-type` dependency; separate hardening PR). - Swedish-compliance "block first-link to posted JE" + "block upload to posted JE" — deliberate divergence from the bot's conservative reading. Attaching evidence to a posted verifikation doesn't mutate the verifikation itself; the dashboard allows this for the same reason. v1 keeps parity. Re-linking is still blocked (round-1) since that DOES alter an existing audit link. - Art.5(1)(f) / A.8.15 / Art.32(1)(b) / CC7.2 document.accessed audit reliability — same oscillation pattern from PR-2. Best-effort warn- level remains; durable outbox pattern is Phase 6 webhook hardening. - Art.25(1) userId in storage path — engine-layer concern. Path is set by lib/core/documents/document-service.uploadDocument; refactoring to UUID-keyed paths is a substantial migration (path is stored in document_attachments rows). Out of v1 surface scope. - Art.5(1)(e) stray-document retention policy + CC6.3 scope policy doc + C1.1 metadata classification — policy artifacts, not code. Suite 3376/3376 still green; tsc clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-13 22:30:35 +02:00
Jakob Wennberg	abb9f5868c	feat(api): Phase 4 PR-1 — AP world (suppliers + supplier-invoices) (#467) ... * feat(api): Phase 4 PR-1 — AP world (suppliers + supplier-invoices) First of two Phase 4 PRs. Ships the public v1 AP-side verticals end-to-end, mirroring the Phase 2 AR pattern (customers + invoices). ENDPOINTS (13) Suppliers: GET /suppliers — cursor list + filters GET /suppliers/{id} — detail, ?expand=supplier_invoices POST /suppliers — idempotent, dry-runnable PATCH /suppliers/{id} — idempotent, dry-runnable, can un-archive DELETE /suppliers/{id} — soft-archive, refused on open SI POST /suppliers/bulk-create — partial-success, max 50 Supplier invoices: GET /supplier-invoices — cursor list + filters GET /supplier-invoices/{id} — detail, ?expand=supplier,items,payments POST /supplier-invoices — register + post registration JE PATCH /supplier-invoices/{id} — registered-only POST /supplier-invoices/{id}/approve — flip to approved POST /supplier-invoices/{id}/mark-paid — book payment JE + flip status POST /supplier-invoices/{id}/credit — issue kreditfaktura + reversing JE No DELETE on supplier-invoices — withdrawal is via :credit (mirrors v1 invoices, keeps both original AND credit note in the audit trail per BFL 5 kap 5 §). STRICT-MODE V1 Carried forward from Phase 3 lessons: - Any JE failure ABORTS before SI state mutation (no soft-fall / partial state). Applies to register, mark-paid, and credit. - checkPeriodLock() pre-check before every JE-emitting write — returns structured PERIOD_LOCKED / SI_PAID_PERIOD_LOCKED / SI_CREDIT_PERIOD_LOCKED instead of letting the DB trigger surface a generic 500. - CAS-race orphan handling in mark-paid: if the SI status flips between pre-flight and our update, the just-posted payment JE is stornoed via reverseEntry() rather than left dangling (BFL 5 kap 5 §). - Math.round monetary throughout. Half-öre epsilon on remaining_amount==0. SCHEMA MIGRATION `20260513150000_archived_at_for_customers_and_suppliers.sql`: - Adds suppliers.archived_at (new — required for the soft-archive flow). - Adds customers.archived_at + customers.vat_number_validated_at — retroactively. The Phase 2 v1 customer routes (PR #451 / #452 / #460) already reference both columns but no prior migration installed them in production. This commit fixes that latent bug while we have the migration open. - Partial indexes on (company_id, created_at) WHERE archived_at IS NULL keep the default-active list path cheap. - is_active (legacy boolean) preserved on suppliers; v1 archive sets both archived_at = now() AND is_active = false, un-archive flips both back so the dashboard's "show only active" filters stay intact. NEW ERROR CODES SUPPLIER_HAS_INVOICES (409) — archive refused while open SI exists SI_NOT_DRAFT (400) — update/delete refused on non-registered SI GDPR ART.5(1)(c) DEFENSE-IN-DEPTH SupplierType has no `individual` variant today, so org_number is always Bolagsverket public-record data. The list endpoint still has the masking hook (empty INDIVIDUAL_TYPES set) so a future natural-person supplier type becomes a one-line change. Duplicate-org_number error responses NEVER echo the submitted value — symmetric with customers. SCOPES 13 new entries in V1_ENDPOINT_SCOPES under suppliers:read / suppliers:write. TESTS 36 new integration cases across 2 suites: - suppliers: list (incl. filter), get (incl. 404), create (happy + 23505 + dry-run + missing-idempotency), patch (happy + empty body), delete (archive + open-invoice refusal), bulk-create (partial-success + 501) - supplier-invoices: list, get (incl. 404), create (happy accrual + supplier 404 + period-locked + strict-mode JE rollback + dry-run), patch (registered-only), approve (happy + non-registered refusal), mark-paid (happy + period-locked + already-paid + strict-mode abort), credit (happy + already-credited + period-locked + dry-run) Full suite green: 3333 passing (237 files). Build + lint clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(api): PR #467 round-2 — Greptile P1/P2 fixes Three real findings from Greptile inline review on the Phase 4 PR-1 commit. P1 — mark-paid: storno orphan JE when SI update fails. When the `.update()` after the JE post returned an `updateErr`, the route logged + returned SI_PAID_FAILED without reversing the just-posted payment JE. The CAS-race branch immediately below already proves journalEntryId is in scope and reverseEntry takes it directly — the original comment about "requires fetching the entry first" was wrong. Now both error branches (the `updateErr` DB-failure path and the `!updated` CAS-race path) storno via reverseEntry before returning, keeping the AP ledger consistent (BFL 5 kap 5 §). Storno failure itself logs loudly and the error envelope surfaces the journal_entry_id so manual reconciliation has a starting point. P1 — credit + register: capture JE link-update result, storno on failure. Both supplier-invoices/route.ts (register) and supplier-invoices/[id]/ credit/route.ts back-fill registration_journal_entry_id on the freshly- inserted SI/credit-note row, but were dropping the await result. A transient DB error there silently left the row with registration_- journal_entry_id=null even though the JE was live on the books — the POST response looked correct (it returned the JE id from the local variable) but every subsequent GET /supplier-invoices/{id} showed null. Both paths now capture the link-update error, storno the orphan JE via reverseEntry, then roll back the SI/credit-note row before returning SI_CREATE_FAILED / SI_CREDIT_FAILED with step='*_link'. Strict-mode atomicity restored. P2 — mark-paid: dry-run paid_at format alignment. Dry-run preview set `paid_at: paymentDate` (YYYY-MM-DD), but the live `.update()` writes `new Date().toISOString()` (full UTC timestamp). A caller validating both responses against the same regex would have been caught by the mismatch. Dry-run now mirrors the live shape. P2 — ensureInitialized() finding dismissed as a false positive: lib/api/v1/with-api-v1.ts:52 already calls ensureInitialized() at module load. Every v1 route imports withApiV1 from that module, so the side effect runs on first import and caches. No existing v1 route (customers, invoices, transactions) imports ensureInitialized() directly — the pattern has been consistent across Phases 1-3 and the AP-world routes follow it. Tests + build green: 3333 passing across 237 files, AP suite 36/36. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(api): PR #467 round-3 — compliance swarm + swedish-compliance fixes Both bots re-ran and converged on a set of substantive findings. Seven real issues addressed; several recurring false positives + architectural deferrals documented inline. REAL FIXES (7) 1. credit: `remaining_amount` calc was nonsensical. `Math.max(0, remaining_amount - total)` was always ≤ 0 (since remaining ≤ total), forcing status to 'credited' regardless of paid state — but only via the clamp, not the logic. Both swedish-compliance and Compliance Swarm (OWASP V2.3 + SOC 2 PI1.3) caught this. A kreditfaktura nullifies the AP obligation on the original (BFL 5 kap 5 §); refunds of already-paid amounts get a separate transaction. `remaining_amount: 0` and `status: 'credited'` unconditionally. 2. supplier-invoices register: VAT rate whitelist. `computeItemsAndTotals` accepted any float for `vat_rate`, silently booking an unrecognised rate into the registration JE → momsdeklaration Ruta 48 + INK2R. Now rejects with VALIDATION_ERROR (allowed_rates echoed) unless the rate is in `{0, 0.06, 0.12, 0.25}` (ML 2 kap 1 §). 3. mark-paid: `exchange_rate_difference` is required for non-SEK accrual. The pitfall docs warned about this but the code didn't enforce it. Without it the payment JE doesn't book the FX delta to 3960/7960 and AP carries a stranded 2440 balance after the bank line clears. Enforces with field- level VALIDATION_ERROR; pass `exchange_rate_difference: 0` if there's no rate movement. 4. suppliers PATCH: refuse on archived suppliers (BFL 7 kap 1 §). An archived supplier's name/address backs historical verifikationer; a post-archive PATCH would silently corrupt 7-year-retained räkenskaps- information. The handler now fetches the current row, refuses identifying- field updates when `archived_at IS NOT NULL`, and only permits the un-archive PATCH (`archived_at: null`). 5. supplier-invoices register: smart vat_treatment / reverse_charge default. The previous default of `'standard_25'` regardless of supplier_type left EU/non-EU supplier rows with metadata that didn't match the actual booking path (which uses `reverse_charge`). Now derives both fields from `supplier.supplier_type` when the caller omits them: foreign suppliers default to `reverse_charge: true` + `vat_treatment: 'reverse_charge'`. Explicit body values still win. 6. reverseEntry: static import (SOC 2 CC8.1). Replaced the three dynamic `await import('@/lib/bookkeeping/engine')` calls in orphan-storno error branches with a top-level static import. The dependency is now visible to SCA / tree-shake / static analysis. 7. Add `userId: ctx.userId` to every storno-failure log context (OWASP V16.1). The CAS-race + linkErr branches now consistently include the actor identity for security-relevant audit events. TESTS (+6 new) - register: rejects non-Swedish vat_rate (whitelist) → 400 - register: defaults reverse_charge=true + vat_treatment='reverse_charge' for eu_business suppliers - mark-paid: requires exchange_rate_difference for non-SEK accrual → 400 - mark-paid: passes when exchange_rate_difference is explicitly 0 - suppliers PATCH: refuses identifying-field edit when archived_at IS NOT NULL - suppliers PATCH: allows un-archive (archived_at: null) flip AP suite 42/42 (was 36). Full suite 3339/3339 green (was 3333). DISMISSED WITH RATIONALE - swedish-compliance "credit-note amounts should be negative" — false read of the engine. `createSupplierCreditNoteEntry` calls `Math.abs()` on item amounts (line 421) and posts a reversing JE; the SI row carries positive amounts + `is_credit_note=true` as a deliberate data-model decision. Negating would break parity with the dashboard and the internal AP-ledger reporting. - OWASP V8.2.1 cross-tenant via path — recurring false positive across Phases 2-4. `withApiV1` (line ~340-350) verifies `company_members` membership BEFORE setting `ctx.companyId` from the URL. - OWASP V8.2.1 supplier_invoice_items company_id filter in rollbackCreditNote — the table has no `company_id` column; cross-tenant protection comes from RLS + the parent supplier_invoice_id scoping. - OWASP V4.5 PATCH allowlist schema-derivation — known architectural deferral; centralising the field list against a Zod `.pick()` is a separate refactor. - GDPR Art.5(1)(f) log/event field identifiers — RoPA / log-pseudonymisation is an org-wide privacy-eng concern, not a per-route fix. - ISO 27001 A.8.15/A.8.16 non-blocking inserts — `supplier_invoice_payments` insert + event emit failures stay at warn-level for v1 to mirror the dashboard internal route. Promoting to error escalations + DLQ is a cross-cutting reliability project, not a route patch. - SOC 2 CC6.3 segregation-of-duties — v1's API-key scope IS the boundary by design. Role-based separation between register / approve / pay is a v1.x feature, not a v1 surface bug. - swedish-compliance reverse-charge gating in credit — the engine (`createSupplierCreditNoteEntry`) already gates the 2647/2645 reversal on `creditNote.reverse_charge` (line 437). Mirrors the registration engine. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(api): PR #467 round-4 — BFL 5 kap 5 § + remaining compliance fixes Compliance bots re-ran on round-3 (Compliance Swarm 13→12 findings, Swedish-compliance fresh re-read). Five real issues addressed; the rest are recurring false positives or architectural deferrals carried over from earlier rounds. REAL FIXES (5) 1. mark-paid: future payment_date rejected at the schema layer. BFL 5 kap 2 § requires bokföring to follow real cash movement; payment_date > today is a scheduling artefact, not an affärshändelse. Returns 400 VALIDATION_ERROR before the JE engine runs. 2. credit: drop user_id from SI_FULL_COLUMNS (GDPR Art.25). The original SI's `user_id` (its historical creator) is never used in the credit flow — the new credit-note row uses ctx.userId (the actor performing the credit). Don't fetch what you don't need. Also drops company_id from the select since it's already filtered. 3. supplier-invoices register: reverse-charge cross-field VAT check. For reverse-charge invoices the Swedish supplier doesn't charge VAT, the buyer self-assesses (ML 1 kap 2§ p.4b / 16 kap 6 § / 16 kap 13 §). If `reverse_charge=true` and ANY item has `vat_rate != 0`, return VALIDATION_ERROR — otherwise the engine would book ingående moms in Ruta 30 / 48 (BAS 2614 / 2645 / 2641) for an invoice that has no VAT to deduct. 4. rollbackSupplierInvoice + rollbackCreditNote: soft-mark, not delete. BFL 5 kap 5 § — rättelse av bokföringspost måste vara dokumenterad så att både den ursprungliga och den korrigerade noteringen är synliga. Hard-deleting the SI row on a mid-write failure destroys räkenskapsinformation even when the JE side (if any) is preserved via storno. Both rollback paths now UPDATE status='reversed' + reversed_at=now() — the SupplierInvoiceStatus enum already has 'reversed' for exactly this case ("credit note whose journal entry was storno-reversed via Ångra kreditering" per the type comment). Trade-off: a retry with the same supplier_invoice_number will hit the unique-index conflict, so the caller picks a fresh number. TESTS (+2 new) - register: rejects reverse_charge=true with non-zero item vat_rate - mark-paid: rejects future payment_date Pre-existing eu_business reverse_charge test updated: item vat_rate flipped from 0.25 → 0 to remain valid under the new cross-field check. AP suite 44/44 (was 42). Full suite 3341/3341 green (was 3339). DISMISSED (recurring or architectural) - OWASP V8.2.1 cross-tenant via path — recurring false positive across Phase 2-4. withApiV1 verifies company_members membership BEFORE setting ctx.companyId from the URL. - ISO A.8.3 approve-route TOCTOU — already mitigated. The UPDATE has `.eq('status', 'registered')` as a race guard; the pre-flight is for ergonomic error messages, not security. - SOC 2 PI1.3 floating-point — project-wide convention is Math.round(x * 100) / 100 per CLAUDE.md. Diverging in one route would create a parity bug with the bookkeeping engine + dashboard. Settled. - SOC 2 CC7.3 storno-failure alerting / ISO A.8.15 audit-log on success / SOC 2 CC6.1 test-fixture key / OWASP V2.2 status state-machine / V1.2.5 dynamic select-clause / V16 audit-log silent-failure / Art.25 banking-field expand — all architectural deferrals that fit the webhook-hardening + scope-redesign work in Phase 6, not the v1 PR. - swedish-compliance "credit-note original-number reference" — the `credited_invoice_id` FK is the structured back-reference; the document-rendering layer surfaces the original `supplier_invoice_- number` from there. Not a v1 surface bug. - swedish-compliance "cash-basis credit-note vat_amount" — engine behaviour mirrored from the dashboard. Engine-layer audit, separate effort. - swedish-compliance "active-supplier mutability broader than archived_at" — solving this requires snapshotting supplier identity onto each supplier_invoices row at registration (schema migration). Deeper architectural decision; tracking for Phase 4 follow-up alongside the journal-entries vertical. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(api): PR #467 round-5 — strict schema + vat_treatment normalisation + narrow BFL archive lock Compliance bots re-ran on round-4. Most findings are recurring (V8.2.1 cross-tenant, PI1.3 floating-point, CC6.3 SoD) or the classic oscillation pattern from the Phase 3 lessons: this round's Art.5(1)(f) flags userId in storno error logs as PII exposure — but last round's V16.1 demanded I ADD userId for audit attribution. Staying with audit attribution; the bot can pick a side. Three substantive findings addressed. REAL FIXES (3) 1. V4.5 mass-assignment defense-in-depth on PATCH /supplier-invoices/{id}. The shared `UpdateSupplierInvoiceSchema` is consumed by the dashboard too, where Zod's default key-stripping is acceptable. The v1 route now wraps it in `V1PatchSupplierInvoiceSchema = UpdateSupplierInvoiceSchema .strict()` so any unknown key (e.g. `status`, `company_id`, `user_id`) returns 400 VALIDATION_ERROR instead of being silently dropped — even if the iteration allowlist downstream is later relaxed. 2. vat_treatment normalisation when reverse_charge resolves true. Caller could previously pass `vat_treatment: 'standard_25'` explicitly on an eu_business supplier, and the supplier-type-driven default would set `reverse_charge: true` while the metadata stayed as 'standard_25'. The engine books via the boolean (so JE is correct) but a downstream momsdeklaration / audit export reading `vat_treatment` would mis- classify. Resolution order is now: reverse_charge first, then vat_treatment forced to 'reverse_charge' if true; explicit overrides only stick when they agree with the resolved boolean. 3. Narrow archived-supplier PATCH lock to identifying fields only. The round-4 blanket lock on archived suppliers was too broad: BFL 7 kap 1 § protects räkenskapsinformation — the fields verifikationer reference through the supplier join — but not internal notes or payment-config metadata. The check now only refuses PATCHes that touch {name, supplier_type, org_number, vat_number, address_*, banking_*}. Notes, default_payment_terms, default_expense_account, default_currency, email, and phone remain editable on archived rows. TESTS (+3 new) - PATCH /supplier-invoices/{id}: rejects unknown body keys (strict schema) - POST /supplier-invoices: explicit vat_treatment='standard_25' is overridden when supplier_type drives reverse_charge=true - PATCH /suppliers/{id}: allows notes edit on archived supplier (BFL narrow scope) AP suite 47/47 (was 44). Full suite 3344/3344 green (was 3341). DISMISSED (recurring / settled / oscillating) - OWASP V8.2.1 cross-tenant via path — recurring false positive 4 rounds running. withApiV1 verifies company_members membership BEFORE setting ctx.companyId from the URL. - GDPR Art.5(1)(f) userId in error logs — direct contradiction of round-3's OWASP V16.1 finding which demanded userId be ADDED for audit attribution. Phase 3 lessons document this oscillation pattern ("swedish-compliance / compliance-swarm oscillate between rounds") and the correct response is to stay with the more security-positive position. Keeping userId on storno-failure logs for ledger-integrity attribution. - SOC 2 CC6.3 segregation-of-duties — same as round-3. v1 design uses API-key scope as the boundary; role-based actor separation is Phase 6 webhook + auth work. - SOC 2 CC6.1 null-userId guard — redundant. withApiV1 short-circuits with 401 UNAUTHORIZED before invoking the handler when API-key validation fails (which is the only path that could leave ctx.userId unset). - SOC 2 CC7.2 storno-failure alerting — architectural; webhook-bus + dead-letter is Phase 6 territory. - SOC 2 / OWASP PI1.3 / V2.3 floating-point — project-wide convention per CLAUDE.md; the engine, dashboard, and v1 all use Math.round(x*100)/100. - ISO 27001 A.8.33 test-fixture financial amounts — synthetic UUIDs + NODE_ENV=test guard already in place; "TEST-only" sentinel amounts would be cosmetic. - OWASP V16.1 eventBus failure retry / DLQ — Phase 6 webhook hardening. - swedish-compliance arrival_number gap risk — acknowledged in commit, bot itself says "no action required"; supplier_invoice_number retry behavior already in the rollback-comment doc. - swedish-compliance vat_code cross-field — engine derives JE shape from `invoice.reverse_charge` (boolean), ignores item vat_code in the RC path. No surface-layer leak. - swedish-compliance credit-note FX at today's rate — bot's reasoning inverted. The credit note REVERSES the original AP obligation; to net 2440 to zero across the original-registration JE + credit-note JE, the SEK amounts MUST be copied from the original. FX rate at today's date applies at the bank-refund transaction side, not the credit-note registration. - swedish-compliance KREDIT- prefix — dashboard parity. The `is_credit_note` + `credited_invoice_id` flags are the structured back-references; the prefix is cosmetic on the human-readable number. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(api): PR #467 round-6 — overpayment guard + two-phase rollback + SI_FULL_COLUMNS minimisation Compliance Swarm trended down 12→9 findings, Swedish-compliance 6→5. Three substantive items addressed; the rest are recurring false positives or the userId-in-logs oscillation that round-5 already settled. REAL FIXES (3) 1. mark-paid: reject overpayment up front (Compliance Swarm V2.3). Previously `Math.max(0, remaining - payment)` silently truncated an overpayment to a zero remaining_amount, while the JE engine booked the full payment_amount against 2440 — leaving an unaccounted overpayment on the AP ledger. Now refuses with VALIDATION_ERROR when `payment_amount > remaining_amount + 0.005` (half-öre tolerance for FX-rounding artefacts). Recovery hint points at :credit for over-billing and the transactions endpoints for refunds. 2. credit: trim SI_FULL_COLUMNS to fields actually read (Art.25(1)). The credit handler never reads notes, paid_at, payment_journal_entry_id, transaction_id, document_id, payment_reference, paid_amount, delivery_date, received_date, reversed_at, created_at, updated_at, exchange_rate_date, due_date — but the projection was fetching them all. SEK-conversion fields (subtotal_sek / vat_amount_sek / total_sek) ARE read (copied onto the credit-note row so the 2440 reversal nets), so they stay. Continues the round-4 user_id / company_id drop. 3. Two-phase soft-rollback (Swedish-compliance, BFL 5 kap 5 §). The bot caught a real misapplication: BFL 5:5 only kicks in once a verifikation has been COMMITTED. Pre-JE failures (items_insert, engine returning null because no fiscal period covers the date) are failed insertions, not bokföringsposter. Marking those rows `status='reversed'` with a null registration_journal_entry_id creates a dangling räkenskapsinformation entry that's harder to audit than a clean removal. Both rollback helpers now take a `journalEntryPosted` flag: pre-JE failures hard-delete (rows + items), post-JE failures keep the round-4 soft-mark + reversed_at behaviour. Call sites tagged per failure reason: items_insert → false (hard-delete) no_fiscal_period → false (hard-delete; engine returned null pre-write) registration_je → true (conservative; engine throw could be post-commit) je_link_failed → true (JE posted + already stornoed above) credit items_insert → false credit no_fiscal_period → false credit_journal_entry → true credit_race → true TESTS (+1 new) - mark-paid: rejects payment_amount > remaining_amount with VALIDATION_ERROR (no JE engine call) AP suite 48/48 (was 47). Full suite 3345/3345 green (was 3344). DISMISSED (with rationale) - OWASP V8.2.1 cross-tenant via path — recurring across 5 rounds. withApiV1 verifies company_members membership BEFORE setting ctx.companyId from the URL. Fix-once decision in the wrapper, not a per-route concern. - OWASP V4.5 strict schema (re-verification) — round-5 added V1PatchSupplierInvoiceSchema = UpdateSupplierInvoiceSchema.strict() + a test asserting {"status": "approved"} is rejected. The bot is re-flagging because it can't see the upstream schema in the diff; manually verified: UpdateSupplierInvoiceSchema only contains {supplier_invoice_number, invoice_date, due_date, delivery_date, payment_reference, notes}. No status / company_id / user_id field. - GDPR Art.5(1)(f) userId in logs — same oscillation as round-4. Last round V16.1 demanded userId be ADDED for audit attribution; this round Art.5(1)(f) wants it REMOVED. Staying with audit attribution per the Phase 3 lessons doc's oscillation guidance. - OWASP V16.1 / ISO A.8.15 / SOC 2 CC7.2 SIEM alerting on storno failure — architectural; Phase 6 webhook hardening. - GDPR Art.25(2) supplier-expand banking fields default-on — same as round-4. A scope split (suppliers:read:sensitive) is a v1.x scope refactor, not a single-route patch. - swedish-compliance VAT 0.06 date-aware validation (livsmedel 1 April 2026) — needs livsmedel BAS classification (which BAS codes signal food) and date-aware lookup tables. Engine-layer concern; not achievable without engine changes. Documenting the 6% rate's temporary nature in the comment was the smaller fix already shipped in round-3. - swedish-compliance SI_RESPONSE_COLUMNS missing reverse_charge — FALSE ALARM. `reverse_charge` IS present in the projection (line 264 of supplier-invoices/route.ts); the engine receives it correctly. - swedish-compliance KREDIT- prefix — dashboard parity, dismissed rounds 3-5. The `is_credit_note` + `credited_invoice_id` flags are the structured back-references. - swedish-compliance cash-basis credit-note ingående moms timing (ML 13 kap 27 §) — legitimate gap but engine-layer. The createSupplierCreditNoteEntry engine function handles accrual only; adding a cash-basis-already-paid branch would change engine semantics, divering from the dashboard. Tracking as a Phase 4 engine follow-up, not a v1 surface bug. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-13 20:16:27 +02:00
Jakob Wennberg	a9c98da243	feat(api): Phase 3 — transactions + reconciliation vertical (#464) ... * feat(api): Phase 3 — transactions + reconciliation vertical Closes out Phase 3 of the plan in one PR. After this, a 3rd-party agent can fully manage a company's transaction ledger via the public API: import bank data, walk the queue, categorize (manual / template / counterparty / account-override), match payments to customer + supplier invoices, reverse mistakes, and auto-reconcile the bank against the GL. ENDPOINTS (12) Reads: GET /transactions — cursor list, filters GET /transactions/{id} — detail GET /accounts — BAS chart, class filter GET /fiscal-periods — räkenskapsår list Writes (single tx, idempotent + scoped): POST /transactions/{id}/categorize — dry-run, CAS race guard POST /transactions/{id}/uncategorize — dry-run, storno + reset POST /transactions/{id}/match-invoice — storno conflicting JE, payment JE, link POST /transactions/{id}/match-supplier-invoice — incl. FX diff handling Writes (bulk, partial-success + all_or_nothing:true → 501): POST /transactions/ingest — up to 500 items (CSV + custom feeds) POST /transactions/batch-categorize — up to 100 items Reconciliation: POST /reconciliation/bank/run — dry-run, applies matches GET /reconciliation/bank/status — health snapshot All write surfaces mirror the dashboard's internal route compliance behavior exactly — same engine functions, same Prong-B SI-match suggestion intercept on categorize, same FX-diff handling on supplier- invoice match, same optimistic-lock interlock on invoice status update. No new bookkeeping primitives — every route delegates to the existing `lib/bookkeeping/*` engine, `lib/transactions/ingest.ts`, and `lib/reconciliation/bank-reconciliation.ts`. SCOPES + ERRORS Adds 12 entries to lib/auth/scopes.ts under transactions:read|write + reports:read (accounts, fiscal-periods follow the same convention as MCP tools). Adds 4 new error codes: TX_UNCATEGORIZE_NOT_BOOKED, TX_UNCATEGORIZE_JE_NOT_POSTED, TX_INGEST_INSERT_FAILED, TX_BATCH_CATEGORIZE_EMPTY. TESTS 32 new integration cases across 5 suites: - transactions list / detail (4) - accounts + fiscal-periods (4) - categorize / uncategorize / match-invoice / match-supplier-invoice (9) - ingest + batch-categorize (7) - reconciliation run + status (5) plus shared happy-path and edge cases (no-income, already-linked, malformed body, scope rejection, dry-run shape). Full suite green: 3270 passing (234 files). Build + lint clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(api): address PR #464 review — Phase 3 hardening Greptile P1 — cursor pagination broken in GET /transactions. encodeDefaultCursor was passed the YYYY-MM-DD `date` field, but decodeDefaultCursor's strict ISO 8601 timestamp regex rejected it, so every cursor decoded as null and the endpoint always returned the first page. Switched the cursor anchor to `created_at` (real ISO timestamp, total-orderable, unique within the company at the row insertion grain) and updated the sort to (created_at DESC, id ASC). The `date` column remains in every row + filterable via ?date_from / ?date_to. Updated the registry description to reflect the change. Greptile P1 — JE soft-fall in match-invoice + match-supplier-invoice. When the payment journal entry creation threw (any non- AccountsNotInChartError), the catch block recorded the error string but execution CONTINUED, marking the invoice paid + inserting a payment row + linking the transaction with no GL entry. The dashboard internal route soft-fails here intentionally and surfaces a banner so the user can re-book; for the v1 surface a partial state is strictly worse than a clean failure to retry. Both routes now return: - INVOICE_PAID_BOOK_FAILED (match-invoice) - MATCH_SI_RECORD_PAYMENT_FAILED (match-supplier-invoice) before any state mutation. Removed `journal_entry_error` from both response schemas — strict mode means it can never be set on a 200. Greptile P1 — `overdue` supplier invoices fail the optimistic lock. The early status guard accepted `overdue` as matchable, but the downstream `.in('status', ['registered', 'approved', 'partially_paid'])` excluded it, returning MATCH_SI_NOT_OPEN for a legitimately payable invoice. Added `overdue` to the optimistic-lock list. Greptile P1 + Swedish-compliance — CAS-race orphan cancellation. Direct `.update({ status: 'cancelled' })` on the orphaned JE was silently blocked by enforce_journal_entry_immutability (the engine writes JEs as posted) and the `voucher_gap_explanations` row claimed the entry was cancelled when it wasn't. BFL 5 kap 5 § requires corrections via a reversing entry. Both /transactions/{id}/categorize and /transactions/batch-categorize now call `reverseEntry()` on the orphan; the storno pair keeps the verifikationsnummer series unbroken so the gap-explanation insert is no longer needed. Greptile P2 + Swedish-compliance — hardcoded category on match-invoice. The dashboard internal route writes `category: 'income_services'` for every matched invoice payment, overwriting any prior categorization with a wrong BAS classification for goods sales / rental income. Fixed by preserving the existing transaction.category if set, only defaulting to `income_services` when the row had never been categorized before. Compliance Swarm V2.4 — reconciliation date range guard. Added a 366-day cap on date_from / date_to via Zod refine. Longer reconciliations should be paged. Greptile P2 — dry-run dedup limitation. Added a pitfall note documenting that the ingest dry-run only checks external_id-based dedup; content-based dedup (date+amount against already-booked rows) only runs in the live pipeline. Swedish-compliance — BFL chapter typo on fiscal-periods registry. "BFL 6 kap" → "BFL 5 kap 2 §" (the löpande bokföring deadline). Deferred (with rationale documented): - OWASP V8.2.1 cross-tenant via path: false positive — wrapper sets ctx.companyId from the URL after membership check (recurring across swarm runs). - OWASP V4.5 select('*') on transactions/invoices: same as Phase 2 — those rows feed engine functions that need the full shape. - OWASP V2.3 multi-write atomicity (match endpoints): would need a Postgres RPC; separate refactor. - Swedish-compliance kontantmetoden partial-payment status: same semantics as the dashboard internal route; engine-level decision out of v1's scope. - Greptile P3 `reversible: false` on uncategorize: technically correct (the storno itself isn't reversible via this verb). Tests + build green: 3270 passing, lint clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(import): distinguish network errors in the SIE upload step Adds a dedicated 'network' errorType so the SIE import wizard surfaces "Uppladdningen misslyckades" with a connectivity-focused remediation instead of the generic 'parse' fallback (which suggested checking the SIE file format — wrong direction when the issue is actually offline / flaky upload). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(api): address PR #464 swedish-compliance re-run findings The Swedish-compliance bot edited its existing comment in place after the prior fix push (so created_at filtering missed the re-run). The re-run flagged 6 new substantive findings against the post-fix code. Fix 1 — Orphan storno failure leaves an unresolved immutability gap (categorize + batch-categorize). When reverseEntry() on the CAS-race orphan fails, the orphan stays posted and untraceable. BFL 5 kap 5 § requires every correction be traceable. Both paths now insert a voucher_gap_explanations row in the catch branch flagging "automatisk storno misslyckades — manuell reconciliation krävs", so the orphan is logged at the audit-trail level rather than only in app logs. Fix 2 — Period-lock pre-check (categorize + batch-categorize). enforce_period_lock and enforce_company_lock_date triggers block JE inserts on locked/closed periods, but Supabase surfaces those as a generic 500. Added a new lib/api/v1/check-period-lock.ts helper that performs the same check the trigger would (company-wide lock date, is_closed, locked_at), and both routes now return a structured PERIOD_LOCKED response (existing error code, 400) with reason + fiscal_period_id details before the engine call. Note: this is an ergonomics check (TOCTOU window between check and insert) — the trigger remains authoritative. Fix 3 — Ingest dry-run now performs content-based dedup too. The earlier doc-only note was a compliance miss: an integrator relying on dry-run to confirm uniqueness could ingest duplicate affärshändelser, violating BFL 5 kap. The dry-run now runs BOTH external_id dedup AND content-based (date+amount-against-booked) dedup over the request's date range — same query the live pipeline uses. Pitfall doc updated accordingly. Fix 4 — fiscal-periods response now carries duration_days + exceeds_18_months computed fields. An automated client (year-end wizard, audit tool) can spot a non-compliant period sequence (BFL 3 kap, 18-month cap) without re-implementing date arithmetic. 549-day cap (18 calendar months) is used to keep the comparison deterministic across leap years. First-year exceptions still require human judgment; the boolean is a flag, not a verdict. Deferred (with rationale documented in commit, not retried): - uncategorize storno memo: reverseEntry() doesn't accept a reason parameter today and the JE-level back-reference exists already via reversed_by_id / reverses_id. Engine signature change is out of v1's scope. - VAT integrity check on partial payment in match-invoice: the behavior is fully delegated to createInvoicePaymentJournalEntry. The bot itself recommends auditing against the engine; that is an engine-layer concern and the dashboard internal route uses the same path. - 366-day reconciliation window (advisory): no statutory basis; operational guard. - match-supplier-invoice FX path against ML 8 kap 21–23 § (advisory): engine-layer concern. Tests + build green: 3270 passing, lint clean. Touched-suite tests (transactions, fiscal-periods, accounts, reconciliation) re-run; the fiscal-periods test asserts the new derived fields. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(api): PR #464 round-3 review fixes (re-run after period-lock + dedup) Both compliance bots edited their existing comments in place after the prior fix push. New findings against the post-fix code: Fix — VAT account suppression too broad on account_override. categorize/route.ts dropped vat_lines for ANY class-2 override, but BAS class 2 includes the 26xx VAT clearing accounts themselves. Result: a user override TO a VAT account silently lost the auto-VAT line. Tightened to `account_class === 2 && !account_override.startsWith('26')`. The override-to-2440-leverantörsskulder case is unchanged (correctly drops auto-VAT); the override-to-2611-utgående-moms case now keeps the VAT line. Fix — fiscal-periods 18-month cap uses calendar arithmetic. EIGHTEEN_MONTHS_DAYS = 549 was a generous approximation (18 calendar months span 540–549 days). Replaced with proper month-anchor math: start_date + 18 months computed via setUTCMonth-style year/month rollover, then `period_end > anchor` is the violation. Manual day- arithmetic on the year part avoids JS's clamp-overflow on Aug-31-style start dates. duration_days helper preserved for the response field. Fix — match-invoice no longer hardcodes 'income_services'. When the transaction has no prior category, the route now leaves the field UNTOUCHED in the UPDATE (existing default 'uncategorized' or whatever was there persists). The response surfaces null for the uncategorized case so a caller can detect "needs human classification" without inspecting the DB. The auto-default to income_services was flowing into BAS 3001/3041/3530 selection mismatches and INK2R/SRU mis-reporting for goods/rental flows. Existing-category transactions still propagate their value. Doc — accounts.ts BAS 5/6 description tightened. Was "5=other costs, 6=other costs" — both true but flatten distinct subgroups. Now spells out 5xxx (rents/supplies/services) and 6xxx (marketing/professional/IT) under övriga externa kostnader, with a pointer to the canonical BAS chart. Deferred (with rationale documented): - voucher_gap_explanations in SIE export coverage: verification ask; SIE export audit is a separate task, not this PR's scope. - Dry-run dedup parity with full live pipeline: my dedup matches the live pipeline's primary checks (external_id + content date+amount against booked rows). Achieving exact parity would need refactoring lib/transactions/ingest.ts to expose a shared dedup helper. - FX sign convention in match-supplier-invoice: identical to the dashboard internal route; if the engine sign convention is wrong both surfaces are wrong. Engine-layer audit, not v1 surface. - OWASP V8.2.1 cross-tenant via path: recurring false positive — the wrapper sets ctx.companyId from the URL only AFTER company_members membership check. - V2.3 multi-write atomicity in match endpoints: would need a Postgres RPC; separate refactor. - check-period-lock TOCTOU on no_fiscal_period (advisory note): the engine's ensureFiscalPeriod helper creates an open period; if the transaction date sits in a historical gap, the engine creates the period unlocked. The trigger remains the authoritative gate. Tests + build green: 3270 passing, lint clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(api): PR #464 round-4 review fixes (compliance bot re-run) The compliance swarm went from 20 → 10 findings after round-3, but the swedish-compliance bot caught 5 issues my fixes introduced or didn't fully cover. Fix — VAT account suppression narrowed to BAS 2610–2649. My round-3 fix exempted any account starting with '26' from VAT-line suppression, but BAS 26xx includes 2650 (momsredovisningskonto) and 2690 (diverse), neither of which is a moms-line account. Auto-VAT posted against 2650 would double-post on the moms reconciliation account. Tightened the exception to the 2610–2649 range (utgående + ingående moms accounts only). Fix — exceedsEighteenMonths month-end overflow. My round-3 manual month math still passed `startD` raw to Date.UTC, which clamps Aug 31 + 18 months to Mar 3, making the cap LATER than the BFL 3 kap 1 § ceiling (false negative). Now clamps `startD` to the last valid day of the target month using `Date.UTC(year, m+1, 0)`. Fix — ingest dry-run dedup float-key normalization. Built the content-dedup set from `${tx.date}|${tx.amount}` where amount is a JS number stringified directly — `-349.5` from JSON vs `-349.50` from a Postgres numeric round-trip miss-match. Normalized both sides to .toFixed(2). SIE imports commonly carry trailing-zero precision, so this would have caused the dry-run to under-report duplicates (a BFL 5 kap löpande-bokföring concern: an integrator trusting the dry-run could double-book affärshändelser). Fix — CAS-race voucher_series fallback no longer files under 'A'. Both categorize and batch-categorize used `voucher_series || 'A'` for the voucher_gap_explanations row. If the orphan JE had no series, the gap would be indexed under series 'A' and missed by any series- specific audit query (BFL 5 kap 6 §). Now skips the gap row entirely when no series is set — the error log already captures the orphan for human reconciliation; filing under the wrong key is strictly worse than not filing. Fix — match-invoice rejects kontantmetoden partial payments. Under kontantmetoden, utgående moms must be reported per actual receipt (ML 13 kap 8 §). The cash-method-partial branch was falling through to createInvoicePaymentJournalEntry (the accrual 1510/1930 clearing path), which doesn't model the per-installment moms event. Rather than silently over-report moms, refuse with a VALIDATION_ERROR pointing the caller to either wait for the full payment or switch to faktureringsmetoden. Full cash-method payments still flow through createInvoiceCashEntry (the correct kontantmetod path). Deferred (with rationale): - `uncategorize` resets journal_entry_id to null: dashboard parity; the JE-side back-reference (reversed_by_id / reverses_id) preserves the audit pair. Adding a separate reversal_journal_entry_id column on transactions is a schema change out of v1 scope. - OWASP V8.2.1 cross-tenant: recurring false positive. - OWASP V2.2 inline Zod filter schemas: structural consistency decision — kept in-route to match other v1 endpoints; a future refactor can centralize when it justifies the cost. - OWASP V16 add userId/companyId to storno-failure log: txLog already carries both via ctx.log.child; not changing call-site syntax for compliance theatre. - Engine-layer FX sign convention in match-supplier-invoice (advisory): identical to dashboard internal route. Tests + build green: 3270 passing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(api): match-supplier-invoice storno conflicting JE before booking The match-invoice route stornoes any conflicting auto-categorization JE before posting the payment entry; match-supplier-invoice was missing the symmetric guard. If a transaction was previously auto-categorized (e.g. expense_office with a 5460/1930 entry), matching it to a supplier invoice would post a second 2440/1930 entry while leaving the original posted — two verifikationer for one affärshändelse, a BFL 5 kap 6 § integrity violation. Storno-before-match now applies in both routes, with the same fail-closed semantics (storno failure aborts before any state change). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-13 15:22:57 +02:00
Jakob Wennberg	07a7964e8d	fix(supplier-invoices): guard against duplicate payment when bank tx already booked (#461) ... * fix(supplier-invoices): guard against duplicate payment when bank tx already booked Two-pronged fix for a UX trap where a supplier invoice could be marked paid even though the bank payment was already booked on 2440, creating a duplicate verifikation. Prong A — mark-paid duplicate guard: before booking, scan for an unlinked outgoing bank transaction matching this supplier (merchant_name ILIKE) within ±2% / ±60 days. If found, return 409 SI_PAID_LIKELY_DUPLICATE with candidates so the UI can offer "link existing" instead. Override via { force: true }. Prong B — categorize match suggestion: when the user assigns 2440 directly on a negative business transaction and an open supplier invoice from the same supplier covers the same amount, return 409 TX_CATEGORIZE_SUGGEST_SI_MATCH with candidates and route the user to match-supplier-invoice. Override via { confirm_no_match: true }. Frontend dialogs added on the supplier-invoice detail page and the transactions inbox. Partial payments skip the mark-paid guard (deliberate action). Tests cover the 409 path, the override path, and the no-candidates happy path on both routes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(supplier-invoices): apply PR review fixes to duplicate-payment guards - Add `is_business = true` filter to mark-paid candidate query so private bank withdrawals don't surface as false-positive duplicates - Escape LIKE wildcards (`%`, `_`, `\`) in both ILIKE patterns to avoid silent over-matching when a supplier/merchant name contains those chars - Round paymentAmount and remaining_amount to 2 decimals before the partial-payment guard comparison to avoid float-equality fragility - Require credit account to be in the 1xxx (bank/cash) series for the Prong B 2440 intercept so 2440 against clearing/equity accounts isn't misinterpreted as a supplier payment - Extract DUPLICATE_AMOUNT_TOLERANCE_PCT (0.02) and DUPLICATE_DATE_WINDOW_DAYS (60) into a shared helper module with the LIKE-escape utility Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(supplier-invoices): broaden 244x match, audit log overrides, drop JE id from response Second-round PR review fixes: - Widen Prong B regex from /^2440$/ to /^244\d$/ so payments mapped to BAS sub-accounts (e.g. 2441 leverantörsskulder i utländsk valuta) also trigger the suggestion (swedish-invoice-compliance bot) - Log a structured warning when force=true or confirm_no_match=true is honored, with the relevant context (amount, date, accounts) so the override is traceable per BFNAR 2013:2 kap 8 (behandlingshistorik) - Drop journal_entry_id from the SI_PAID_LIKELY_DUPLICATE candidate response payload (data minimization, GDPR Art.5(1)(c)); the UI never rendered it Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(supplier-invoices): third-round PR review — date window on Prong B, length cap, VAT message - Add the missing date window to the Prong B categorize candidate query (swedish-compliance bot): without it, an open invoice from years back can surface as a "match" for an unrelated bank transaction. Uses the shared DUPLICATE_DATE_WINDOW_DAYS against invoice_date. - Cap supplier/merchant names to 200 chars before they enter escapeLikePattern (OWASP V1.2.5 / ISO A.8.28). Bounds DB work on pathological inputs. - Log a structured warning when the mark-paid guard is skipped because the invoice has no resolved supplier name (BFL 5 kap 7 § — motpart should be identifiable; the absence is itself worth surfacing). - Update the SI-match suggestion error and the matching UI copy to call out the actual compliance risk: a duplicate 244x posting double-deducts ingående moms (ML 8 kap 3 §), not just bookkeeping symmetry. - Reword "Bokför på 2440 ändå" to "Bokför på leverantörsskulder ändå" now that the regex covers BAS sub-accounts 244x. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(supplier-invoices): correct Prong B framing — duplicate verifikation, not VAT double-deduction Latest swedish-compliance review correctly walked back the earlier finding that asked for ML 8 kap 3 § VAT framing. Plain 244x categorization via account_override does not include VAT lines (account class 2), so the risk is a duplicate verifikation (BFL 5 kap 5 §), not a double VAT deduction. Update both the structured error message and the dialog body to reflect the actual mechanism. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-13 11:38:19 +02:00
Jakob Wennberg	01e99d3220	feat(api): v1 invoice PDF + customer bulk-create (Phase 2 PR-B-3) (#460) ... Closes out the Phase 2 invoices+customers vertical. After this PR, every write/read the dashboard does on these two resources is reachable via the public API. GET /api/v1/companies/{companyId}/invoices/{id}/pdf Read-only application/pdf endpoint. Mirrors the dashboard's internal /api/invoices/[id]/pdf so a downloaded PDF is byte-equivalent across surfaces. Drafts render with the "faktura-utkast-<id-slice>.pdf" filename (preview before send is a legitimate workflow); sent invoices use "faktura-<number>.pdf"; credit notes use "kreditfaktura-<number>.pdf" and embed the original invoice's löpnummer per ML 17 kap 22–23§ back-reference; proforma + delivery notes get their own prefixes. Error codes: INVOICE_PDF_RENDER_FAILED (500, new), INVOICE_SEND_COMPANY_SETTINGS_MISSING (404, reused — same condition, same remediation). POST /api/v1/companies/{companyId}/customers/bulk-create Mirrors /invoices/bulk-create exactly: same `{ results, summary }` shape, same all_or_nothing: true → 501 NOT_IMPLEMENTED contract, same 50-item cap, same sequential processing. Per-item rollback isn't needed (customer insert is a single row), but per-item 23505 → CUSTOMER_DUPLICATE_ORG_NUMBER failure surfaces in the results array without echoing org_number (GDPR Art.5(1)(c): for sole traders org_number IS the personnummer). VIES validation runs per item, best-effort — a timeout leaves vat_number_validated=false but does NOT fail the item. Registry: extended EndpointDefinition.response with an optional `contentType` field so the OpenAPI generator can emit `format: binary` schemas for non-JSON responses. The PDF endpoint is the first consumer; future binary endpoints (SIE export, ICS feeds) use the same hook. Scope catalogue: added GET .../pdf → invoices:read, POST .../customers/bulk-create → customers:write. Tests: 14 new integration cases (7 for PDF: sent / draft / credit-note filename, 404, render-error 500, non-UUID 400, scope rejection; 7 for customer bulk-create: happy path, dup-org error masking, max-50 cap, all_or_nothing 501, dry-run preview, empty array, scope rejection). Suite green: 3232 passing. Build + lint clean. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-13 10:53:51 +02:00
Jakob Wennberg	37ccda5cad	feat(api): v1 invoice :send + bulk-create (Phase 2 PR-B-2b-3 + PR-B-2c) (#458) ... * feat(api): v1 invoice :send + bulk-create action verbs (Phase 2 PR-B-2b-3 + PR-B-2c) Combined chunk: ship the full :send pipeline and partial-success bulk creation in one PR, plus include the dangling /reset-password middleware fix that completes PR-455's password-recovery flow. POST /api/v1/companies/:companyId/invoices/:id/send Full send pipeline mirroring the internal route, hardened for the public API surface: email-configured check, draft-only guard, cancelled / delivery-note / credit-note / missing-moms_ruta rejections, customer email check, company-settings fetch, F-series invoice-number allocation (atomic at :send per ML 17 kap 24§ p.2, not at draft create), preflight PDF render before number consumption, final PDF render, email send, point-of-no-return status flip, BFL 5 kap journal entry, document archival, invoice.sent event emit. Post-send failures (journal entry, archive) surface via a `warnings` array rather than failing the response — the invoice IS sent at that point. Dry-run validates the pipeline + preflight PDF without allocating a number or hitting the provider. Error codes: INVOICE_SEND_EMAIL_NOT_CONFIGURED (503), INVOICE_SEND_NO_CUSTOMER_EMAIL / _CANCELLED / _COMPANY_SETTINGS_MISSING (400), INVOICE_UPDATE_NOT_DRAFT (409), INVOICE_SEND_PDF_RENDER_FAILED / _NUMBER_ASSIGN_FAILED (500), INVOICE_SEND_PROVIDER_FAILED (502). POST /api/v1/companies/:companyId/invoices/bulk-create Batch create up to 50 invoices in a single call, sequential processing, partial success: `{ results: [{ ok, request_index, data?, error? }], summary: { total, succeeded, failed } }`. Per-item rollback on items insert failure (delete the parent invoice row). Emits invoice.created per success. Dry-run wraps results in a preview without inserting. `all_or_nothing` is accepted but reserved for a future PR. lib/supabase/middleware.ts Add /reset-password bypass before the authenticated-user redirect so password-recovery sessions don't bounce to '/'. This should have landed in PR-455 — the `git add 'app/(auth)'` filter missed the middleware file at lib/. Without this the recovery email link silently fails for the recipient. Tests: 14 new integration tests across both routes (happy path, provider failure, scope rejection, draft-only guard, dry-run shape, bulk partial-success, max-50 enforcement, validation error). Full suite green (3207 passing, 1 unrelated pre-existing pg-real failure). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(api): address PR #458 review — :send + bulk-create hardening Greptile P1: silent zero-row update after email delivery. PostgREST returns { error: null } on 0-row UPDATEs. The post-email status flip used `.eq('status', 'draft')` as an optimistic lock but never inspected the row count, so a concurrent state change (race, double-send from another session) would leave the DB row in 'draft' while the response claimed 'sent' and the email was already gone. Fix: `.select('id')` after the update and check `flipRows.length`; on 0-row miss, push STATUS_UPDATE_FAILED warning AND change the response status to 'draft' so the caller can reconcile. Greptile P1: re-read error swallowed; invoice_number could vanish from the response. After ensureInvoiceNumber, the re-read query destructured only `data`, silently dropping `error`. A transient connection failure would leave `numbered` null and `finalInvoiceNumber` undefined; JSON serialization would then omit the field, violating the documented response schema. Fix: capture `reReadErr`, log a warning, fall back to typed.invoice_number (which was just written by the RPC and is authoritative in-memory). Apply the same fallback at the top-level `ok()` call. Greptile P2 + Compliance Swarm V2.3 + Swedish-compliance kreditfaktura: reject credit notes from :send. The :credit endpoint creates credit notes atomically in 'sent' state with their own number — there is no v1 path that produces a draft credit note, so reaching :send with credited_invoice_id set is misuse or manual DB editing. Allowing it would assign an F-series number to a kreditfaktura (ML 17 kap 22–23§ require a distinct kreditfaktura series and a back-reference that this route would not enforce). Fix: reject with VALIDATION_ERROR pointing at /credit. Removes a stretch of dead code (originalInvoiceNumber lookup, kreditfaktura filename branch) that can never execute now. Greptile P2: all_or_nothing: true silently treated as false. A caller asking for atomic semantics must not get partial-success behaviour with no runtime signal. Fix: reject with new NOT_IMPLEMENTED error (501) plus a details.field pointer. Schema still accepts the flag for forward compatibility once a DB-side RPC ships. New error code added to lib/errors/structured-errors.ts. Tests: 3 new integration cases (credit-note rejection, status-flip no-op warning, all_or_nothing 501). Suite green: 3218 passing. Build clean, lint clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(api): PR #458 follow-up — defense-in-depth + comment precision OWASP V8.2.1 (bulk-create): use DB-returned customer.id at insert time instead of input.customer_id. The .eq() pair already enforces company scoping at fetch, but echoing the trusted value from the query makes the guarantee explicit at the call site and immune to refactoring drift. Same change in the dry-run preview shape. Swedish-compliance wording: the credit-note rejection comment now spells out BOTH ML 17 kap 22–23§ requirements — distinct kreditfaktura series AND explicit back-reference to the original invoice's löpnummer — so any future v1 path that does support credit-note send starts from a complete spec. Company-settings select: kept select('*') with an explanatory comment rather than enumerating columns. The InvoicePDF template consumes the full CompanySettings shape; a partial allow-list risks silently breaking rendering, and the table has no sensitive columns today (API tokens, billing data live in scoped tables). Documents the trade-off so the next reviewer doesn't re-litigate. Deliberately not changed: - Math.round → Math.trunc on VAT öre: CLAUDE.md mandates Math.round project-wide; unilateral deviation here would diverge from the bookkeeping engine and POST /invoices. - 207 Multi-Status on partial post-email failures: gnubok's convention is warnings[] in the 200 envelope; a per-route status divergence would break the response contract clients rely on. - Wrapper membership double-check (OWASP V8.2.1 send route): the withApiV1 wrapper sets ctx.companyId from the URL after the membership check — recurring false positive in this swarm. Tests + build + lint clean. 17/17 in the touched suites. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-13 10:23:42 +02:00
Jakob Wennberg	e96cbe05d0	feat(api): v1 invoice draft writes (Phase 2 PR-B-2a) (#453) ... * feat(api): v1 invoice draft writes (Phase 2 PR-B-2a) POST /api/v1/companies/:companyId/invoices creates a draft invoice, proforma, or delivery note. Reuses the established v1 discipline: - Idempotency-Key mandatory (wrapper option). - Dry-runnable: ?dry_run=true returns the validated would-be invoice + computed items with VAT totals; no DB writes, no number allocation, no event emission. - Explicit column projections (no SELECT *). - Per-item VAT rate validated against the customer's allowed rates from getVatRules() — mixed-rate invoices supported. - Currency conversion via fetchExchangeRate() (best-effort, non-fatal). - F-series number allocation via ensureInvoiceNumber() with soft-cancel rollback if allocation fails — preserves sequence integrity for ML 17 kap 24§ (no gaps in F-series). - invoice.created event emitted for real invoices (not proformas / delivery notes). PATCH /api/v1/companies/:companyId/invoices/:id updates a DRAFT invoice's metadata fields only: - Allowed: invoice_date, due_date, delivery_date, your_reference, our_reference, notes. - NOT allowed (intentional): customer_id, currency, document_type, items, status. Structural changes go through delete-and-recreate (drafts are cheap); status transitions via the action verbs in PR-B-2b. - 409 INVOICE_DELETE_NOT_DRAFT if the invoice has already been sent / paid / credited / cancelled. The error code is shared with DELETE (reused rather than introducing a new "not draft" code). - Race-condition guard: the .update() also matches .eq('status', 'draft') so a concurrent :send between pre-flight and write returns the same 409. Dry-run for invoice DRAFT create uses dryRunPreview() (validation-only) rather than dryRunStaged() — drafts have no journal-entry side effects yet, so there's nothing to stage in pending_operations. The dryRunStaged() helper from PR-B-1 stays unused this PR; PR-B-2b's :send will be its first real consumer (voucher number, journal lines, account deltas). Tests: 12 new (5 POST + 7 PATCH) covering happy path, customer not found, VAT rate violation, dry-run preview shape, scope enforcement, Idempotency-Key requirement, draft-only PATCH guard, forbidden field rejection, UUID validation, empty body. Stubs ensureInvoiceNumber and fetchExchangeRate to keep tests deterministic. 3165/3165 vitest pass; build clean; lint clean on v1 paths. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(api): address PR #453 review (Greptile + swarm + Swedish compliance) Real fixes (all reviewers agreed): - Greptile P1 + SOC 2 CC6.3: PATCH was reusing INVOICE_DELETE_NOT_DRAFT (httpStatus 400) for a semantically different operation; docstrings + tests claimed 409 while code returned 400. Introduced INVOICE_UPDATE_NOT_DRAFT with httpStatus 409 in structured-errors.ts. PATCH now returns 409 consistently; test name and assertion aligned. - Greptile P1: POST rollback DELETE on items-insert failure now scoped by company_id (defense in depth) AND its error is destructured/logged so a double-failure is visible in audit trails (was previously silent on the rollback path). - Greptile P1: refetch error after invoice insert is now logged with invoiceId + companyId at warn level; the response gracefully falls back to the header-only shape rather than misleading the agent with a 5xx (the data WAS committed). GDPR Art.5(1)(f) × 2, ISO A.8.11 × 2, SOC 2 CC7.2 × 2: client-facing error responses no longer echo raw Postgres pg_message strings (which can interpolate field values from constraint detail). pg_code is kept in the response (machine-readable, no PII leak); pg_message moves to the internal structured log entry only. Applies to INVOICE_CREATE_INSERT_FAILED and INVOICE_CREATE_ITEMS_FAILED. OWASP V2.2: defensive UUID validation on ctx.companyId at POST handler entry. The wrapper already validated membership, but mirroring the detail-route's pattern for path params eliminates a class of edge-case queries with malformed predicates. Swedish compliance (ML 17 kap 24§ p.2 — most substantive finding): ensureInvoiceNumber is NO LONGER called at draft-create. The doc string already said "F-series invoice_number is allocated atomically on the first send action (PR-B-2b)" but the code contradicted it by allocating at POST. Code now matches intent: drafts (invoices and proformas) keep invoice_number=null until :send. Delivery notes continue to allocate their separate D-series number on insert (different sequence, no F-series gap concern). This eliminates the soft-cancel path entirely for the common case where a user creates and abandons a draft — no more legal gaps in the löpnummer series from ordinary workflow. Pushing back on: - Atomicity / Postgres RPC wrapping (V8.2.1 × 2, CC6.1) — substantial refactor; the existing internal /api/invoices POST has the identical multi-step pattern; not a v1 regression. Track for a future RPC- consolidation PR across both surfaces. - Float-point VAT rounding (V2.3, Swedish #3) — matches internal route precisely; consistency over premature decimal-library migration. - TOCTOU rewrite to single UPDATE-WHERE-RETURNING (V8.2.1, CC6.1) — current pre-flight + scoped UPDATE is correct; the suggested cleanup is stylistic. - PATCH response verbose projection (A.8.3, Art.25) — consistency with detail endpoint; the agent that just updated likely wants the full record back. - per-line moms_ruta (Swedish #4) — schema migration; the existing header-only column is what the codebase has. - Event emission failure alerting (A.8.15) — defer to PR-C webhooks. - Test fixture A.8.33 — already addressed (NODE_ENV guard at test bootstrap, clearly synthetic UUIDs). Test fixture UUID v4 fix: COMPANY_ID upgraded to proper v4 format (was 'aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa', which fails Zod 4's .uuid() version-digit check now that the POST handler validates companyId). 3165/3165 vitest pass; build clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-12 22:58:56 +02:00
Jakob Wennberg	17c67fece0	Inbox UX overhaul + cross-currency supplier-invoice fixes (#444) ... * feat(kpi): expense mix and top suppliers charts Replace the single monthly-trend chart with two additional compact visuals on /kpi: expense composition donut (BAS class 4-7) and top suppliers bar (supplier_invoices sum_sek over the fiscal period). KPIReport gains expenseComposition and topSuppliers fields, computed from the trial balance and supplier_invoices rows already fetched in the API. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(nav): swap Deadlines sidebar slot for Dokumentinkorg Sidebar main-menu slot now points to the invoice-inbox extension. The /deadlines page stays accessible via dashboard widgets and direct links — only the prominent nav entry changes. Most users open gnubok to act on incoming documents, not to read tax deadlines. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(supplier-invoices): cross-currency totals, FX residual, review SEK display Five fixes around foreign-currency supplier invoices: - Form layout: move Valuta / Växelkurs / Reverse charge from collapsed "Övrigt" into a visible row above the line-item table. Auto-fetch the Riksbanken rate when switching to a non-SEK currency; never clobber a user-typed rate; clear it when switching back to SEK. - Form submit: reset() the form on successful submit so the useUnsavedChanges hook detaches its beforeunload listener before the router.push, killing the "Are you sure you want to leave?" prompt that fired during Turbopack-mediated navigations. - BankTransactionPicker: drop the strict currency filter that hid every SEK transaction when the invoice was in EUR/USD. Cross-currency rows fall to the bottom with an "Annan valuta" hint instead of producing a meaningless numeric diff. - match-supplier-invoice route: when the bank transaction currency differs from the invoice currency, compute the FX diff against the AP-booked SEK and pass it to createSupplierInvoicePaymentEntry so 7960/3960 catches the residual instead of leaving a permanent stub on 2440. Fix also covers the "EUR transaction paying a SEK invoice" case that the first iteration missed. - Review dialog: buildJournalPreview now multiplies amounts by the exchange rate so the "Verifikation som bokförs" table shows the actual SEK numbers that hit the DB, not the EUR magnitudes labelled with no unit. Header gains an "(i SEK)" hint when foreign currency. Test coverage for the FX residual path covers SEK-SEK (no diff), SEK-into-EUR-invoice (loss), SEK-into-EUR-invoice (gain), foreign-tx- into-SEK-invoice, and the no-rate fallback. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(inbox): rate limits, multi-file UX, onboarding, retry, supplier autolink Big workspace pass on /e/general/invoice-inbox. Highlights: Backend - New table inbox_rate_counters + RPC check_and_increment_inbox_quota. Postgres-backed (no Upstash dep) per-company limit: 30/min, 500/day. Applied at /upload, /inbound, and /items/:id/retry-extraction. - POST /items/:id/retry-extraction — re-runs the deterministic extractor on a stored document when the previous attempt errored. - POST /items/:id/match-supplier — links a freshly-created supplier back to the inbox item so the next action prefills correctly. - POST /api/transactions/create-from-document — creates an uncategorized manual transaction from an inbox item for the "I have a receipt, no bank transaction" case. The user categorizes through the normal flow. - /inbound caps email at 20 attachments/email; truncated count goes to processing_history as AttachmentsTruncated. Rate-limit drops emit RateLimitedDropped and return 200 so Resend doesn't retry. - attach-document side effect: when the document came from an inbox item, the inbox row's matched_transaction_id is updated so the UI can flip it to "Kopplad till transaktion" without a round-trip. New migration: re-introduces matched_transaction_id on invoice_inbox_items as a plain FK (the AI metadata that the previous migration stripped doesn't come back). Workspace UI - Onboarding card replaces the thin empty-state with a 3-step checkmark guide (Aktivera adress → Ladda upp → Matcha eller bokför). Auto-hides when all three steps are done; localStorage-backed dismiss. Beta badge + link to gnubok.se/priser. - Responsive layout: 3-pane at lg, 2-pane at md, master-detail toggle on phone (list xor detail with a back button). - Filter pills (Alla / Behöver åtgärd / Bearbetade / Fel) + search input above the list — client-side over the existing items list. - Multi-file upload queue with "Laddar X av N…" progress counter on the button. Sequential to avoid hammering pdfjs. Selection stays put during a batch (only single-file drops auto-jump the detail pane). - Bulk select + delete with sticky action bar. Items linked to a supplier invoice are skipped with a count toast. - Retry button in the FieldsRail error branch. - "Skapa transaktion från underlag" CTA in the match dialog when no unmatched bank transactions exist. Prefills date/amount/description from the extracted data; user picks the sign. - "Skapa leverantör" inline CTA when the extractor caught a supplier name with no match against existing suppliers. POSTs /api/suppliers with the extracted fields, then auto-links via /items/:id/match-supplier. - Matched-state CTA renamed to "Bokför transaktionen" with link to /transactions?highlight=<id> so the categorize panel auto-opens. Tests - lib/rate-limits/__tests__/inbox.test.ts — RPC wrapper happy/error/scope - app/api/transactions/create-from-document/__tests__/route.test.ts — auth, validation, 404/409/200/500, inbox-link failure tolerated - extensions/general/invoice-inbox/__tests__/retry-extraction.test.ts — auth, rate limit, 404, 409, 400 no-doc, success, extraction failure - attach-document tests extend coverage to the new inbox-link side effect (both success and best-effort failure paths) - inbound-webhook test mocks the rate-limit module so the queued-mock sequence in each existing test doesn't have to know about it CLAUDE.md gains a row for lib/rate-limits/ so the new helper is discoverable. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(transactions): paperclip indicator and highlight-row param Close the feedback loop after a user attaches a receipt to a transaction from the inbox: the row in /transactions now shows a paperclip icon when transaction.document_id is set, with a click handler that fetches a signed download URL and opens the document in a new tab. Works for both uncategorized and history views. When the inbox sends a user to /transactions?highlight=<id>, the page now scrolls that row into view and auto-opens the categorize panel if the transaction is still uncategorized. Behind a double-rAF so the row DOM exists when scrollIntoView fires. QuickReviewDialog no longer prompts to upload underlag when the transaction already has a doc attached (which it does after the inbox match flow). Shows "Underlag bifogat — Visa" instead, opening the existing doc in a new tab. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(pr-444): address review feedback (Greptile + compliance bots) Migration rules - New migration 20260512092423: adds updated_at trigger on inbox_rate_counters (CLAUDE.md rule 2) and explicit USING (false) RLS policies for the four DML verbs to make the SECURITY DEFINER-only intent explicit (rule 1). - New pg-real test inbox-rate-limit.pg.test.ts covering happy path, minute-cap rejection, day-cap rejection, per-company isolation, and the updated_at trigger firing. CLAUDE.md mandates *.pg.test.ts for every new RPC because mocks pass on broken PL/pgSQL. Bugs - Stale exchange rate on currency switch (Greptile P1) — userTouchedRateRef was scoped per session, not per currency. Switching EUR (with a hand-edited rate) → USD kept the EUR rate. Now tracks the last fetched currency in a ref and resets the touched flag on currency change while still honoring manual edits within a single currency. - topSuppliersResult.error silently swallowed (Greptile P2) — failed queries used to render an empty chart matching the no-data state. Logged now. - Currency from extracted_data not validated (GDPR Art.25(2), OWASP V4.5, Swedish compliance bot) — extracted PDF currency was inserted into transactions.currency without sanitisation. Allowlisted against the six supported ISO 4217 codes; coerce to SEK otherwise. - Idempotency gap on create-from-document (OWASP V2.3) — two concurrent POSTs with the same inbox_item_id could each pass the matched_transaction_id IS NULL read and insert duplicate transactions. UPDATE now includes .is('matched_transaction_id', null) as an optimistic-lock release and returns 409 with an orphan-transaction rollback when the predicate doesn't match. - FX residual on cash-method match path (Swedish compliance bot) — createSupplierInvoiceCashEntry has no exchange_rate_difference path, so a cross-currency match would silently leave a 1930 reconciliation gap. Added a guard that returns MATCH_SI_CASH_FX_UNSUPPORTED (400) before the JE is created. Users on cash method can switch to accrual or book the FX diff manually. Design system - gap-y-1.5 / gap-1.5 in KPIExpenseMixChart — replaced with gap-y-2 / gap-2 (CLAUDE.md design tokens; 2.5/1.5/5/hardcoded pixels are forbidden spacing values). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(migrations): rename to match applied versions The mcp__plugin_supabase_supabase__apply_migration tool stamps its own timestamp when it applies a migration to the live project, so the version recorded in supabase_migrations.schema_migrations differs from my local generation-time filenames. Renaming the local files so a production CD run sees the migrations as already-applied (matching versions) instead of trying to re-apply them — which would fail for the trigger/RLS migration (CREATE TRIGGER and CREATE POLICY don't support IF NOT EXISTS). Follows the pattern from d854efcd ("chore(migration): rename to match applied version"). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(create-from-document): scope orphan rollback DELETE by company_id Defence in depth on the inbox-link race rollback. newTx.id is a fresh UUID from a company-scoped insert two statements above, so the existing single-key DELETE is already safe, but adding .eq('company_id', companyId) makes the cross-company invariant explicit on every write — addresses the OWASP ASVS V2.3 finding from the compliance swarm on PR #444. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(nav): mark Dokumentinkorg with Beta badge Same signal we use for Löner and Anställda — the inbox flow (AI extraction, supplier autolink, manual transaction creation) is in end-to-end customer testing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-12 13:12:17 +02:00
Mattsson	81e9dd224e	Add/csv import options (#420) ... * feat(import): add customer and supplier parsing functionality - Implemented customer file parsing in `lib/import/customers/parser.ts` with support for Excel and CSV formats. - Created types for detected customer columns and parsed customer rows in `lib/import/customers/types.ts`. - Added tests for customer classification logic in `lib/import/shared/__tests__/classify.test.ts`. - Developed classification functions for customers and suppliers in `lib/import/shared/classify.ts`. - Introduced shared column utility functions in `lib/import/shared/column-utils.ts`. - Implemented supplier file parsing in `lib/import/suppliers/parser.ts` with validation for various fields. - Created types for detected supplier columns and parsed supplier rows in `lib/import/suppliers/types.ts`. - Added tests for supplier column detection and parsing in `lib/import/suppliers/__tests__/column-detector.test.ts` and `lib/import/suppliers/__tests__/parser.test.ts`. * fix(labels): update 'Svenskt företag' to 'Svenskt företag eller organisation' for clarity * feat(import): refactor encoding handling for Swedish files and add tests for character preservation * feat(recapt): implement clearRecaptIdentity function and integrate into logout flow * feat(bookkeeping): implement copy functionality and next voucher sequence retrieval * feat(import): enhance customer and supplier import functionality with normalization and event handling	2026-05-08 15:42:06 +02:00
Jakob Wennberg	97db09a3ff	feat(invoices): allocate-on-save, makulera flow, manual invoice picker (#405) ... * feat(invoices): allocate-on-save, makulera flow, manual invoice picker Three coordinated invoice changes: 1. Allocate F-series number when the draft is created (Fortnox-style), not at send time. Users can download a numbered draft and send it manually. If number allocation fails, the invoice + items are rolled back so no orphaned rows remain. Adds INVOICE_CREATE_NUMBER_ASSIGN_FAILED. 2. DELETE /api/invoices/[id] now soft-cancels (status='cancelled') instead of hard-deleting. The F-series number is retained, keeping the sequence gap-free per ML 17 kap 24§ and BFNAR 2013:2 — no voucher_gap_explanations needed. Sent/paid invoices stay immutable (credit note required). Adds "Makulerade" tab to the invoice list; cancelled invoices are hidden from "Alla" by default. PDF draft banner stays visible on numbered drafts and only clears when the invoice is marked sent. 3. New InvoicePicker component lets users manually match an income transaction to an open invoice from the booking dialog ("Matcha med faktura..."), complementing the existing auto-match flow. Also: new-invoice review dialog reads accounting_method from settings and shows a cash-vs-accrual warning so users know when the verification posts. seed-demo-account adds year-end closing + opening balance helpers so multi-year demo data is balanced. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(invoices): address review feedback on PR #405 Greptile P1 + Swedish compliance reviewer findings: - app/api/invoices/route.ts — replace hard-delete rollback on number- allocation failure with a soft-cancel (status='cancelled'). If generate_invoice_number bumped the sequence before failing to write the number back, hard-deleting would leave a permanent gap in the F-series in violation of ML 17 kap 24§. Re-fetch invoice_number first so any partially-written value is logged for operator follow-up. Log loudly if the cancel itself fails so an orphan row doesn't go unnoticed. - app/api/invoices/[id]/route.ts — close TOCTOU race on the cancel update. The .eq('status','draft') guard prevented data corruption but Supabase returned error: null with 0 affected rows on a concurrent flip, and the handler reported success. Add .select('id') and return new INVOICE_CANCEL_RACE (409) when no row updated. - components/transactions/InvoicePicker.tsx — memoize createClient() so the supabase reference is stable across renders. Without this, including supabase in the useEffect dep array fires the open-invoices fetch on every render. - app/(dashboard)/transactions/page.tsx + match-invoice/route.ts — read category from the match-invoice response instead of hardcoding 'income_services' client-side. Server now echoes the category it actually booked; client falls back to 'income_services' if absent. - lib/invoices/pdf-template.tsx — add MAKULERAD banner for cancelled invoices (red, distinct from the yellow draft banner). A cancelled invoice PDF previously rendered with no warning if it had a number, or with the draft banner if it didn't — both could be mistaken for a valid faktura. Cancelled takes precedence over draft so the legacy un-numbered-cancelled case is also covered. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(invoices): guard cancelled status on send + rollback symmetry Two follow-up fixes from the second-round Swedish compliance review on PR #405: - app/api/invoices/[id]/send/route.ts — reject sending a cancelled invoice. The existing flow had no status guard before .update({ status: 'sent' }), so a cancelled invoice could be silently re-activated to sent and a "MAKULERAD"-watermarked PDF could be delivered to the customer as if it were a live faktura. New INVOICE_SEND_CANCELLED (400) returned at the top of the handler. - app/api/invoices/route.ts — add .eq('status', 'draft') to the rollback-cancel update so the rollback is symmetric with the DELETE handler's only-drafts-may-be-cancelled rule. At the create flow's current shape the row can't realistically be anything other than draft, but the symmetry prevents a future caller adding a status flip between insert and number-allocation from accidentally cancelling a posted invoice. mark-sent (rejects non-draft), mark-paid (only sent/overdue), and convert (explicitly rejects cancelled proformas) already guard correctly — no changes needed there. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(invoices): InvoicePicker filters settled invoices; drop dead error code Two cleanups from the third-round Swedish compliance review on PR #405: - components/transactions/InvoicePicker.tsx — add .gt('remaining_amount', 0) defensively. The picker filtered by status IN (sent, overdue, partially_paid), but a stale 'sent' or 'overdue' row with remaining_amount=0 (data inconsistency) would otherwise be selectable here and could be matched a second time, double-booking the income — a direct BFL 5 kap accuracy violation. - lib/errors/structured-errors.ts — remove INVOICE_DELETE_NUMBERED. The numbered-draft refusal was replaced by the soft-cancel path earlier in this PR; the entry has no remaining callers. Verified-safe and not changed: - Cancel-without-storno concern: createInvoiceJournalEntry only fires inside mark-sent (after the draft→sent guard) or send (after the cancelled-status reject). Drafts never have posted verifications, so cancelling a draft cannot leave an orphaned bokföringspost. - Hardcoded category: 'income_services' in match-invoice is a pre-existing classification concern that warrants a larger refactor (derive from invoice's revenue accounts) rather than a one-line patch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(invoices): InvoicePicker excludes proforma invoices Add .eq('document_type', 'invoice') to the open-invoice query. A proforma is not a faktura per ML 17 kap 24§ — no VAT obligation, no binding commercial document — and must never be matched against a bank receipt. Without this guard a sent proforma could be selected in the picker, triggering a payment booking and VAT-rate journal entry that violates BFL 5 kap accuracy rules. Other findings from the third-round Swedish compliance review were verified-safe and not changed: - Cancelled-invoice PDF download path: the MAKULERAD watermark added earlier in this PR is the safeguard. Blocking the download endpoint outright would prevent legitimate audit access; the visible banner prevents the doc being mistaken for a valid faktura. - Cancel-without-storno: createInvoiceJournalEntry only fires inside mark-sent / send / pending-operations, all behind status guards. Drafts never carry a posted verifikation, so cancel can't orphan one. - Allocate-on-save for proforma uses F-series: not true. The generate_invoice_number RPC (migration 20260427150100) routes document_type='proforma' to a separate 'PF-' prefix sequence; the F-series is untouched. - closeYearForSeed 2099 → 2091 transfer: real demo-data correctness issue but a seed-script polish item — separate PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(match-invoice): server-side document_type='invoice' guard The InvoicePicker filter excluding proformas (added in the previous commit) is client-only. A direct API call to /api/transactions/[id]/ match-invoice with a proforma id would otherwise still book a payment journal entry against a document that has no VAT obligation per ML 17 kap 24§. Add a defense-in-depth check after the invoice fetch. New error code MATCH_INVOICE_NOT_INVOICE_TYPE (400). Test added. Other findings from the latest compliance review were verified-safe and not changed: - Cancelled-invoice PDF download path: /api/invoices/[id]/pdf always re-renders through InvoicePDF, so the MAKULERAD banner is always present. The bot's "cached pre-cancellation PDF" scenario does not apply to this codebase. - Proforma F-series allocation: the generate_invoice_number RPC routes document_type='proforma' to a separate 'PF-' prefix; the F-series is not polluted. - Soft-cancel rollback gap when number not written: the RPC is a single-transaction PL/pgSQL function — sequence bump (UPDATE company_settings) and row write (UPDATE invoices) commit or roll back together. The "sequence advanced but row null" scenario the bot describes is impossible by construction; a thrown exception in the row-write step rolls back the bump. - closeYearForSeed obeskattade reserver: seed-script demo accuracy, separate PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-06 22:49:56 +02:00
Mattsson	ce3af4d17e	Fix/multiple domain issue (#401) ... * feat: enhance invoice management and immutability checks - Update InvoiceDetailPage to prevent deletion of drafts with assigned invoice numbers, providing user feedback. - Modify the invoice conversion API to ensure invoice number allocation occurs only after successful item insertion and proforma cancellation. - Implement structured error responses for invoice deletion, ensuring only drafts without assigned numbers can be deleted. - Add comprehensive tests for invoice deletion and conversion scenarios, including edge cases for draft invoices. - Introduce immutability checks in the document management system to prevent unauthorized changes to linked documents. - Create SQL migration to enforce document metadata immutability, ensuring compliance with accounting regulations. * fix(invoice): prevent invoice number consumption on PDF render failure * feat: add document journal entry immutability enforcement for delete_last_voucher RPC * fix(invoice): implement rollback for orphan invoices on proforma cancel failure * fix(document): extend immutability trigger to protect journal entry links	2026-05-06 14:08:38 +02:00
Mattsson	5725c25bf1	Logs/improved logging (#398) ... * feat(mcp): add create_transactions tool with /pending approval gate New MCP tool gnubok_create_transactions stages 1–10 transactions per call as pending_operations of type create_transaction (risk: medium). Each item becomes its own card on /pending; on confirm, the executor inserts the row into transactions with import_source='mcp' so MCP-staged ingestion is distinguishable from PSD2 sync. Designed for skill workflows that pull external data (e.g., Airtable) and want the user to gate the writes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(bas): strip concatenated group headers from corrupted account names A chart-data import bug had glued the next group's header onto the last account in each preceding group across all eight bas-data class files (e.g. account 2670 read "Utgående moms på försäljning inom EU, OSS 27 PERSONALENS SKATTER, AVGIFTER OCH LÖNEAVDRAG"). The corrupted names surface in transaction dropdowns, ledgers, SIE exports and årsredovisning, and risk VAT miscategorization on the OSS (2670) and blandad-verksamhet (6999) accounts specifically. - Cleans 69 account_name and 64 description fields across class-1..8 files - Adds a regression test asserting no name contains a concatenated header - Ships an idempotent safety-net migration that updates already-seeded chart_of_accounts rows, gated on the corrupted string so user customizations are preserved Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(errors): add structured error codes and handling for various operations - Introduced a new structured error registry in `structured-errors.ts` to standardize error handling across the application. - Added Swedish and English messages for various error scenarios, including validation, authorization, and bookkeeping errors. - Implemented a client-side error toast in `use-error-toast.ts` to display user-friendly error messages with remediation hints. - Created a wrapper for recording operation outcomes in `record-operation.ts`, enhancing audit capabilities for operations. - Developed a provider call wrapper in `with-provider-call.ts` to handle external HTTP calls with structured logging and error mapping. - Added a new SQL migration to extend the processing history with new event types and aggregate types for better operational telemetry. * Refactor supplier API routes to use context-based logging and error handling - Replaced direct Supabase client usage in GET and POST routes with context-based approach using `withRouteContext`. - Enhanced error handling to provide structured error responses for supplier creation and listing. - Updated logging to include request IDs for better traceability. - Introduced new error codes for supplier-related operations. - Refactored tax deadlines cron job to utilize context and improved error handling. - Updated ESLint configuration to enforce logging practices across API and lib directories. - Enhanced arcim migration extension with structured error handling and logging. - Added classification for provider errors to improve user-facing error messages. - Introduced request ID in extension context for better log correlation. * fix(route-context): update DynamicParams type for improved type safety in route handlers * feat(transactions): add 'create_transaction' operation to PendingOperationType * fix(route): ensure companyId is non-nullable in loadAndDeriveAbsence function * fix(route-context): ensure companyId is always non-null by short-circuiting with COMPANY_CONTEXT_MISSING --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-06 11:12:02 +02:00