Em dashes (—) and en dashes (–) had spread across comments, docs, tests,
and a few UI strings, reading as AI-generated boilerplate rather than
house style. Replaced each with punctuation matching its context: colon
for explanatory clauses, comma for asides, plain hyphen for numeric/legal
ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for
paired-dash asides. messages/en.json and messages/sv.json were fixed by
hand together to keep sv/en in sync.
Left untouched where the dash is the functional subject rather than
decorative punctuation: date-range-parser.ts's separator regex,
charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE
encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the
agent system-prompt files that already instruct against em dashes, and
a golden iXBRL test fixture compared byte-for-byte.
Also fixes two bugs surfaced along the way: an off-by-one in
ApiKeysPanel's scope-label split (a leftover from an earlier partial
pass), and a charset-repair test that had lost the literal en-dash it
exists to verify.
Regenerated the agent atom seed migration (skills:generate) since 27
SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes,
with an explicit carve-out for the functional-dash cases above.
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
The dual-write window ends (dev_docs/dimensions_implementation_plan.md PR9):
journal_entry_lines.cost_center/project are now GENERATED ALWAYS AS
(NULLIF(dimensions->>'1'/'6','')) STORED — divergence from the bag is
impossible by construction instead of by convention.
- migration 20260702230000: drift pre-flight (refuses cutover on
inconsistent data; prod verified 0 drift across 593k rows), column swap
(DROP metadata-only + one-rewrite ADD pair), and atomic redefinition of
the two SQL writers — retag_line_dimensions (SET dimensions only) and
bulk_book_transactions (INSERT names the bag only)
- TS writers stripped of the mirror spread: engine buildLineInserts
(covers create/update/reversal), storno-service (reversal + correction),
SIE import bulk insert, sandbox seed
- lineDimensionColumns() removed from dimension-resolver — nothing derives
mirrors in TypeScript anymore; normalizeLineDimensions + the deprecated
cost_center/project INPUT aliases stay (API contract, they normalize
into the bag); JournalEntryLine ROW type keeps the fields (generated
columns still SELECT)
- immutability carve-out unchanged BY DESIGN: its whole-row diff already
subtracts dimensions/cost_center/project on both sides, which is exactly
what makes it correct with generated columns (BEFORE-trigger NEW carries
not-yet-recomputed mirror values)
- audited every reader (v1 journal-entries, MCP query_journal filters +
group_by, rc-basis-gaps) — reads are untouched; no index, view, or
constraint referenced the TEXT columns, so DROP COLUMN cascades nothing
- new pg suite: generated derivation, explicit-mirror-write rejection,
draft-update recompute; existing retag/substrate/bulk-book suites
updated to bag-only writes (their mirror assertions now exercise the
generation expression)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Jakob Wennberg