- SIE round-trip fixture: vouchers in ascending verno order (A1, A2, A3)
per SIE4 core invariant 5 — the custom-dim voucher was spliced out of
order
- commitEntry: note that source_type is a HEADER column repeated by the
join — reading lines[0] IS reading the entry header, lines cannot mix
source types (a reviewer misread this as per-line logic)
- dimension-rules: sharpen the credit-note exemption rationale — credit
notes copy the original's bags, so enforcement is either a no-op or
would force the exact asymmetric-tag P&L skew the feature prevents
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
SIE import books three system entries through the engine (opening
balances, IB resynk, the omföring adjustment for excluded vouchers) —
after PR10 those passed through the rules layer, so a required rule
could block an import and default/fixed rules could inject dimensions
into derived historical entries. Year-end, currency revaluation and
credit instruments had the same exposure.
Policy now governs NEW business events only: source types in
DIMENSION_RULE_EXEMPT_SOURCE_TYPES (opening_balance, import, year_end,
storno, correction, credit_note, supplier_credit_note,
currency_revaluation, system) skip both the draft-time apply and the
commit-time assert — imported history lands verbatim (BFL 5 kap),
bokslut can never be blocked by a dimension rule, and crediting an
entry that pre-dates a rule always works. Operational sources (manual,
bank_transaction, invoice_*, supplier_* registrations/payments,
salary_payment) stay enforced.
The SIE round-trip test now also covers a PR10-created custom dimension
(#DIM 20) with a custom child (#UNDERDIM 25 ... 20) and a tagged line —
proving user-created dims survive export → parse structurally.
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* feat(dimensions): PR10 advanced — custom dimensions, hierarchy, account rules, commit enforcement
The final rung of the dimensions ladder
(dev_docs/dimensions_implementation_plan.md §7 row 10):
- custom dimensions: POST /api/dimensions creates registry dims (next free
SIE number >= 20 when omitted; explicit numbers allowed — SIE import
already mints reserved ones); register gets a 'Ny dimension' dialog with
a quiet Avancerat disclosure for the #UNDERDIM parent; GET now carries
parent_sie_dim_no (the column + SIE round-trip existed since PR1/PR5 —
this exposes it)
- account_dimension_rules (migration 20260703120000): one rule per
(account, dimension) — required / default / fixed, per-rule is_active,
company-scoped RLS, composite FK to the registry, value-presence CHECK
- enforcement, opt-in BY CONSTRUCTION (zero rules = engine byte-identical;
deliberately NO settings toggle — a rule that exists but is ignored is
worse than either extreme): default/fixed apply onto line bags at draft
creation (fixed overwrites, default fills); required asserts at
commitEntry with a Swedish MANDATORY_DIMENSION_MISSING naming every
account + dimension; the bulk-book route runs the same policy before its
RPC; storno/correction paths never pass through commitEntry so history
always reverses regardless of policy; rule fetches fail open incl.
thrown exceptions
- chart of accounts: per-account Dimensionsregler section in
EditAccountDialog (Krävs/Förval/Låst, value picker, pause switch),
gated on the existing dimensions toggle, quiet when empty
- pickers: LineDimensionFields is registry-driven (one combobox per active
dimension, cached fetch, hardcoded 1/6 fallback) — every existing mount
lights up custom dims with zero changes
- agent briefing: per-dimension required_on_accounts/default_on_accounts
so agents self-correct instead of bouncing off the policy error
- rules CRUD API with existence/active/company validation and qualified
DTO ids; firm_id FK deferred until the firms table lands (per plan)
39 new tests (pure-fn rules, engine enforcement, both new API surfaces,
pg-real RLS/CHECK/cascade suite); full suite 6,791 green; migration
replayed on a fresh container.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix: renumber migration to 20260703200000 — version collision with prod
The concurrent session shipped pending_operations_add_link_document_to_voucher
as 20260703120000 today; the Supabase preview branch (cloned from prod)
rejected the duplicate version key.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix: review round — auto-pick retry on collision, fail-open warnings, query schema
- POST /api/dimensions retries once past a concurrent number claim when the
number was auto-picked (explicit choices still 409)
- every fail-open skip of the dimension-rules policy now logs a structured
warning (engine draft/commit paths + bulk-book) — deliberate fail-open,
but observable
- GET /api/dimensions/rules validates its query through
ListDimensionRulesQuerySchema instead of an inline regex
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Jakob Wennberg