Em dashes (—) and en dashes (–) had spread across comments, docs, tests,
and a few UI strings, reading as AI-generated boilerplate rather than
house style. Replaced each with punctuation matching its context: colon
for explanatory clauses, comma for asides, plain hyphen for numeric/legal
ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for
paired-dash asides. messages/en.json and messages/sv.json were fixed by
hand together to keep sv/en in sync.
Left untouched where the dash is the functional subject rather than
decorative punctuation: date-range-parser.ts's separator regex,
charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE
encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the
agent system-prompt files that already instruct against em dashes, and
a golden iXBRL test fixture compared byte-for-byte.
Also fixes two bugs surfaced along the way: an off-by-one in
ApiKeysPanel's scope-label split (a leftover from an earlier partial
pass), and a charset-repair test that had lost the literal en-dash it
exists to verify.
Regenerated the agent atom seed migration (skills:generate) since 27
SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes,
with an explicit carve-out for the functional-dash cases above.
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
* feat: invoicing & account-security polish bundle
Five independent improvements bundled to ship together:
- BankID/password lockout fix: BankID-only users could enroll MFA and
brick themselves (Supabase requires AAL2 to change password or unenroll
MFA, and AAL2 needs a password sign-in). New app_metadata.has_password
flag tracks this; middleware gates /mfa/enroll behind it, /account/set-
password is the unlock path, SecuritySettings shows a banner, and
/api/account/password is the single write path that flips the flag.
Backfill script for existing users.
- Swish invoice payment method: company_settings.swish + invoice_show_swish
columns, validation in lib/api/schemas.ts (accepts 123XXXXXXX företag or
07XXXXXXXX mobile, strips whitespace/hyphens), rendered on invoice PDFs.
- Send-reminders kill switch: per-company company_settings.send_invoice_
reminders toggle in PdfPrintSettings/Automatisering. Reminder processor
also tightened: positive status allowlist (sent + overdue) so terminal
statuses can never match; skip when customer already responded via
reminder link; race-window re-check before send.
- First-invoice logo prompt: one-shot dialog when creating the first
invoice without a logo (issue #520). Self-limits via head-only count.
- SIE export opening-balance fallback: route IB through getOpeningBalances
so the compute_prior_opening_balances RPC supplies #IB after multi-year
imports where opening_balance_entry_id is intentionally NULL. Previously
#IB silently went to zero and #UB collapsed to current-period movements.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(account-polish): address PR review feedback
- BankID-link path (extensions/general/tic/index.ts): read-merge-write
app_metadata instead of passing { bankid_linked: true } alone.
updateUserById REPLACES app_metadata wholesale, so the previous code
would have wiped has_password for any user who later linked BankID,
causing the set-password banner to (incorrectly) reappear and blocking
the standard MFA enrollment button. The comment is now corrected.
- Middleware (lib/supabase/middleware.ts): thread inner returnTo through
the /mfa/enroll → /account/set-password redirect so the user lands on
their original destination after the full chain completes, not on /.
- safeReturnTo helper (lib/auth/safe-return-to.ts): replace the
starts-with-/-but-not-// guard on mfa/enroll and set-password pages.
The previous guard let /\evil.com and /@evil.com through. The new
helper parses against a synthetic base origin and verifies it matches.
- set-password page (app/(auth)/account/set-password/page.tsx): remove
CLAUDE.md design system violations — bg-gradient-to-b on page bg,
inline shadow-md style on the card, space-y-5, font-medium on the h1,
rounded-xl on the card. Flat surface, hairline border, font-display
h1 per the design tokens.
- Swish dedup (lib/payments/swish.ts): extract normaliseSwish() and
isValidSwish() helpers and use them in lib/api/schemas.ts,
components/settings/BankDetailsForm.tsx, and the invoicing settings
page. Single source of truth for the regex.
- Password route (app/api/account/password/route.ts): emit a structured
success log so the audit pipeline can detect password-set events, not
just failures.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Jakob Wennberg